Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-08-16 Thread Guodong Xu
On 16 August 2016 at 20:33, Marcel Holtmann wrote: > > Hi Guodong, > > >>> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO > >>> packets available in tx or rx, the LEDs will blink. > >>> > >>> For each hci registration, two triggers are added into LED subsystem: > >>> [hde

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-08-16 Thread Guodong Xu
Hi, Marcel On 16 August 2016 at 14:03, Marcel Holtmann wrote: > Hi Guodong, > >> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO >> packets available in tx or rx, the LEDs will blink. >> >> For each hci registration, two triggers are added into LED subsystem: >> [hdev->na

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-08-15 Thread Guodong Xu
Ping. :) Would you give me some review opinions on this? In this revision, I chose to limit LED blinking to tx/rx traffic packets only. For other types of over-the-air packets, like scanning, it's not covered. Thank you. -Guodong On 31 July 2016 at 12:24, Guodong Xu wrote: >

[PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-30 Thread Guodong Xu
on HiKey 96boards, which uses HiSilicon hi6220 SoC and TI WL1835 WiFi/BT combo chip. Signed-off-by: Guodong Xu --- include/net/bluetooth/hci_core.h | 1 + net/bluetooth/hci_core.c | 6 ++ net/bluetooth/leds.c | 17 + net/bluetooth/leds.h |

Re: [PATCH 1/2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-15 Thread Guodong Xu
erified on HiKey, 96boards. It uses hi6220 SoC and TI WL1835 combo >>>> chip. >>>> >>>> Signed-off-by: Guodong Xu >>>> --- >>>> include/net/bluetooth/hci_core.h | 1 + >>>> net/bluetooth/hci_core.c | 3 +++ &g

Re: [PATCH 1/2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-14 Thread Guodong Xu
6220 SoC and TI WL1835 combo >> chip. >> >> Signed-off-by: Guodong Xu >> --- >> include/net/bluetooth/hci_core.h | 1 + >> net/bluetooth/hci_core.c | 3 +++ >> net/bluetooth/leds.c | 15 +++ >> net/bluetooth/leds.h

Re: [PATCH 1/2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-14 Thread Guodong Xu
6220 SoC and TI WL1835 combo >> chip. >> >> Signed-off-by: Guodong Xu >> --- >> include/net/bluetooth/hci_core.h | 1 + >> net/bluetooth/hci_core.c | 3 +++ >> net/bluetooth/leds.c | 15 +++ >> net/bluetooth/leds.h

Re: [PATCH 1/2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-07-11 Thread Guodong Xu
Dear maintainers, Would you have a review on this? -Guodong On 23 June 2016 at 12:58, Guodong Xu wrote: > Two LED triggers are defined: tx_led and rx_led. Upon frames > available in HCI core layer, for tx or for rx, the combined LED > can blink. > > Verified on HiKey, 96boards.

[PATCH 1/2] Bluetooth: Add LED triggers for HCI frames tx and rx

2016-06-22 Thread Guodong Xu
Two LED triggers are defined: tx_led and rx_led. Upon frames available in HCI core layer, for tx or for rx, the combined LED can blink. Verified on HiKey, 96boards. It uses hi6220 SoC and TI WL1835 combo chip. Signed-off-by: Guodong Xu --- include/net/bluetooth/hci_core.h | 1 + net/bluetooth

[PATCH 2/2] arm64: dts: hikey: set bluetooth led trigger

2016-06-22 Thread Guodong Xu
Set bluetooth led trigger to hci0-rx, and so LED blinks on hci frame receiving. Signed-off-by: Guodong Xu --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-05 Thread Guodong Xu
On 5 May 2016 at 16:11, Dean Jenkins wrote: > On 05/05/16 00:45, John Stultz wrote: >> >> On Tue, May 3, 2016 at 3:54 AM, Dean Jenkins >> wrote: >>> >>> On 03/05/16 11:04, Guodong Xu wrote: >>>> >>>> did you test on ARM 64-bit

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Guodong Xu
On 3 May 2016 at 17:23, Dean Jenkins wrote: > On 03/05/16 05:55, John Stultz wrote: >> >> In testing with HiKey, we found that since commit 3f30b158eba5c60 >> (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of >> noise during network transfers: >> >> [ 239.027993] asix 1-1.1:1

[PATCH] wlcore: align reg_ch_conf_last[] to 64bit

2015-09-18 Thread Guodong Xu
000 [ 10.720239] PC is at set_bit+0x14/0x30 [ 10.724002] LR is at wlcore_set_pending_regdomain_ch+0x40/0x4c Signed-off-by: Guodong Xu --- drivers/net/wireless/ti/wlcore/wlcore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/wlcore.h b/drivers/