Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-26 Thread Guilherme Piccoli
On Wed, Jun 26, 2019 at 5:25 AM Sudarsana Reddy Kalluru wrote: > > Sudarsana, let me ask you something: why does the register is reading value > > 0x0 always in the TX timestamp routine if the RX filter is set to None? > > This is > > the main cause of the thread reschedule thing. > > The registe

Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-25 Thread Guilherme Piccoli
Sudarsana, let me ask you something: why does the register is reading value 0x0 always in the TX timestamp routine if the RX filter is set to None? This is the main cause of the thread reschedule thing. Of course this thread thing is important to fix, but I was discussing with my leader here and w

Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-25 Thread Guilherme Piccoli
On Tue, Jun 25, 2019 at 1:02 AM Sudarsana Reddy Kalluru wrote: > > Thanks for your changes and time on this. In general time-latching happens in > couple or more milliseconds (even in some 100s of usec) under the normal > traffic conditions. With this approach, there's a possibility that every

Re: [EXT] [PATCH] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-24 Thread Guilherme Piccoli
V2 submitted here: https://marc.info/?l=linux-netdev&m=156141504615972 Cheers, Guilherme

Re: [EXT] [PATCH] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-23 Thread Guilherme Piccoli
On Sun, Jun 23, 2019 at 2:13 AM Sudarsana Reddy Kalluru wrote: > > Thanks for uncovering this issue, and the fix. > With the proposed fix, if HW latches the timestamp after 3 iterations then it > would lead to erroneous PTP functionality. When driver receives the next PTP > packet, driver sees t