On 28/06/2019 02:22, Sudarsana Reddy Kalluru wrote:
> [...]
> Thanks for the changes.
>
> Acked-by: Sudarsana Reddy Kalluru
>
Thanks a lot Sudarsana!
David, do you think it's still possible to get this merged as a fix in
5.2 cycle, or it's gonna go in 5.3?
Thanks,
Guilherme
skipped
TX timestamp packets and it reduces the priority of timestamping
error messages to prevent log flooding. The code was tested using
both linuxptp and chrony.
Reported-and-tested-by: Przemyslaw Hausman
Suggested-by: Sudarsana Reddy Kalluru
Signed-off-by: Guilherme G. Piccoli
---
Thanks a
Thanks again Sudarsana for the good review and advice. I'll send V4 soon.
Discussions about your points are in-line below:
On 27/06/2019 07:09, Sudarsana Reddy Kalluru wrote:
>
>> [...]
>> if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {
>> if (!(bp->flags & TX_TIME
skipped
TX timestamp packets and it reduces the priority of timestamping
error messages to prevent log flooding. The code was tested using
both linuxptp and chrony.
Reported-and-tested-by: Przemyslaw Hausman
Suggested-by: Sudarsana Reddy Kalluru
Signed-off-by: Guilherme G. Piccoli
---
Sudarsa
skipped
TX timestamp packets and it reduces the priority of timestamping
error messages to prevent log flooding. The code was tested using
both linuxptp and chrony.
Reported-and-tested-by: Przemyslaw Hausman
Suggested-by: Sudarsana Reddy Kalluru
Signed-off-by: Guilherme G. Piccoli
---
Sudar
he error path for TX timestamping. It was tested using both
linuxptp and chrony.
Reported-and-tested-by: Przemyslaw Hausman
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h| 1 +
.../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c| 1 +
.../net/ethernet/broadco
multiple
PCI errors in a row are not expected to lead to a functional
adapter anyway), and by,
* preventing access to adapter FW when MCP is failed (we mark it as
failed when shmem cannot get initialized properly).
Reported-by: Abdul Haleem
Signed-off-by: Guilherme G. Piccoli
---
drivers/net
h of ULD on
cxgb4 driver, by properly freeing and disabling interrupts on PCI
remove handler too.
Fixes: 0fbc81b3ad51 ("Allocate resources dynamically for all cxgb4 ULD's")
Reported-by: Harsha Thyagaraja
Signed-off-by: Guilherme G. Piccoli
---
It might be important to add
the recovery steps is a mistake that could prevent the
recovery path to complete successfully.
Reported-by: Harsha Thyagaraja
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 21 +
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 9
I forgot to attach a perhaps important file, the output of lspci.
Here it goes.
Thanks,
Guilherme
0002:01:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller
X710/X557-AT 10GBASE-T [8086:1589] (rev 02)
Subsystem: Super Micro Computer Inc Device [15d9:]
Con
Guilherme
>From 1a49e453816dbab747788b87f9d03edc978cb50b Mon Sep 17 00:00:00 2001
From: "Guilherme G. Piccoli"
Date: Tue, 7 Feb 2017 17:38:04 -0200
Subject: [PATCH] i40: force global reset on adapter probe
Device might experience a bad state on probe time, making impossible
to
On 11/10/2016 04:46 PM, Guilherme G. Piccoli wrote:
> Whenever the igb driver detects the result of a read operation returns
> a value composed only by F's (like 0x), it will detach the
> net_device, clear the hw_addr pointer and warn to the user that adapter's
> link
Thyagaraja
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/intel/igb/igb_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index edc9a6a..136ee9e 100644
--- a/drivers/net/ethernet/i
On 11/09/2016 03:12 PM, Alexander Duyck wrote:
> On Mon, Oct 31, 2016 at 1:12 PM, Guilherme G. Piccoli
> wrote:
>> Whenever the igb driver detects the result of a read operation returns
>> a value composed only by F's (like 0x), it will detach the
>> net_devi
a call to netif_carrier_off() on ehea's net device
open callback.
Reported-by: Xiong Zhou
Reference-ID: IBM bz #137702, Red Hat bz #1089134
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/et
h that
path.
Reported-by: Anthony H. Thai
Reported-by: Harsha Thyagaraja
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/intel/igb/igb_main.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb
ed by Michael Chan].
Fixes: 0486a063b1ff ("tg3: prevent ifup/ifdown during PCI error recovery")
Fixes: dfc8f370316b ("net/tg3: Release IRQs on permanent error")
Tested-by: Guilherme G. Piccoli
Signed-off-by: Milton Miller
Signed-off-by: Guilherme G. Piccoli
---
* v2 cha
On 09/27/2016 11:43 PM, David Miller wrote:
> From: "Guilherme G. Piccoli"
> Date: Tue, 27 Sep 2016 15:33:54 -0300
>
>> The bnx2x driver prints multiple error messages during register dump,
>> with "ethtool -d" for example. The driver even warn that
On 09/27/2016 07:41 PM, Keller, Jacob E wrote:
> On Tue, 2016-09-27 at 18:14 -0300, Guilherme G. Piccoli wrote:
>> Although rare, it's possible to hit PCI error early on device
>> probe, meaning possibly some structs are not entirely initialized,
>> and some might even b
On 09/27/2016 05:58 PM, Michael Chan wrote:
On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli
wrote:
From: Milton Miller
While the driver is probing the adapter, an error may occur before the
netdev structure is allocated and attached to pci_dev. In this case,
not only netdev isn&#
e. Also, driver
started to flood console with those ARQ event messages.
This patch will prevent these issues by allowing error recovery
mechanism to remove the failed device from the system instead of
trying to recover from early PCI errors during device probe.
Signed-off-by: Guilherme G. Pi
r recovery")
Fixes: dfc8f370316b ("net/tg3: Release IRQs on permanent error")
Tested-by: Guilherme G. Piccoli
Signed-off-by: Milton Miller
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/broadcom/tg3.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
e messages were supressed - in our
tests we saw 78 more "LATCHED attention" and "GRC time-out" messages,
supressed here.
This patch avoid these messages to be printed on register dump instead
of just warn they are harmless.
Signed-off-by: Guilherme G. Piccoli
---
* Thi
+0x88/0xc0
Also, we noticed that without this patch, if we modprobe the module without
enough MSI-X interrupts (triggering the above warning), unload the module
and re-load it again, we got a crash on the system.
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/intel/i40e/i40e_main.
ted-by: Harsha Thyagaraja
Signed-off-by: Guilherme G. Piccoli
---
v2: Removed the unlikely attribute on bnx2x_fw_dump_lvl() if block.
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/br
On 08/10/2016 10:28 AM, Guilherme G. Piccoli wrote:
On 08/10/2016 04:59 AM, Yuval Mintz wrote:
Why would the published resume() from pci_error_handlers be called
in this
scenario?
It isn't. That's why I specifically commented on commit message:
"There are two
cases though th
On 08/10/2016 04:59 AM, Yuval Mintz wrote:
Why would the published resume() from pci_error_handlers be called in this
scenario?
It isn't. That's why I specifically commented on commit message: "There are two
cases though that another path is taken on the code".
The code path reach bnx2x_chip_
On 08/09/2016 09:14 AM, Yuval Mintz wrote:
When PCI error is detected, in some architectures (like PowerPC) a slot reset is
performed - the driver's error handlers are in charge of "disable"
device before the reset, and re-enable it after a successful slot reset.
There are two cases though that
eing removed because of a permanent failure, the HW chip reset is
not expected to work fine neither is necessary.
Also, we avoid the MCP information dump in case of non-recoverable PCI
error (when adapter is about to be removed), since it will certainly fail.
Reported-by: Harsha Thyagaraja
Signed-off
en if interface is down.
No functional changes were introduced.
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/emulex/benet/be_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/
On 07/26/2016 05:26 AM, Sathya Perla wrote:
-Original Message-
From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
On 07/25/2016 07:48 AM, Sathya Perla wrote:
-Original Message-
From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
Temperature values on
On 07/25/2016 07:48 AM, Sathya Perla wrote:
-Original Message-
From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
Temperature values on be2net driver are made available to userspace via
hwmon abstraction, so tools like lm-
sensors can present them to the user.
The driver
e for temperature information.
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
index 9f44a00..0e23ab2 1
ons of the adapter, instead of only setting the temperature of the
function passed to be_worker().
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/emulex/benet/be.h | 1 +
drivers/net/ethernet/emulex/benet/be_cmds.c | 13 +++---
drivers/net/ethernet/emulex/benet/be_m
On 06/27/2016 12:16 PM, Guilherme G. Piccoli wrote:
Currently, the q_vector initialization routine sets the affinity_mask
of a q_vector based on v_idx value. Meaning a loop iterates on v_idx,
which is an incremental value, and the cpumask is created based on
this value.
This is a problem in
index from the cpu_online_mask instead of
just using the v_idx incremental value.
No functional changes were introduced.
Signed-off-by: Guilherme G. Piccoli
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/driver
36 matches
Mail list logo
