Re: fib6_del_route has redundant code

2007-12-28 Thread Gui Jianfeng
> From: Gui Jianfeng <[EMAIL PROTECTED]> > Date: Fri, 28 Dec 2007 13:58:21 +0800 > >>>> I think the following code in fib6_del_route in the latest kernel is >>>> useless. >>>> 1125 if (fn->leaf == NULL && fn->fn_flags&

[PATCH] remove useless code from fib6_del_route

2007-12-27 Thread Gui Jianfeng
Hi Dave, There are useless codes in fib6_del_route(). The following patch has been tested, every thing looks fine, as usual. Signed-off-by: Gui Jianfeng<[EMAIL PROTECTED]> --- net/ipv6/ip6_fib.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_fib.c

Re: fib6_del_route has redundant code

2007-12-27 Thread Gui Jianfeng
fn->leaf becomes NULL when last route has been deleted, the radix tree should be expunged. > But I am not completely convinced that all of these lines > of code can be removed :-) > > -- Regards Gui Jianfeng -- Gui Jianfeng

fib6_del_route has redundant code

2007-12-26 Thread Gui Jianfeng
Hi all, I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) 1126 fn->leaf = &ip6_null_entry; ip6_null_entry will never be unlinked from fn->leaf now, that is, fn->leaf == NULL will never meet.

Re: [PATCH 2.4.35.3] Fix the "InAddrErrors" increasing problem

2007-10-22 Thread Gui Jianfeng
Krishna Kumar2 写道: > Gui Jianfeng wrote on 10/22/2007 11:37:07 AM: > >> @@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s >> * how the packet travels inside Linux networking. >> */ >> if (skb->dst == NULL) { >> - if (ip_route

Re: [PATCH 2.4.35.3] Fix the "InAddrErrors" increasing problem

2007-10-21 Thread Gui Jianfeng
Krishna Kumar2 写道: > Gui Jianfeng wrote on 10/22/2007 11:37:07 AM: > >> @@ -310,8 +310,12 @@ static inline int ip_rcv_finish(struct s >> * how the packet travels inside Linux networking. >> */ >> if (skb->dst == NULL) { >> - if (ip_route

[PATCH 2.4.35.3] Fix the "InAddrErrors" increasing problem

2007-10-21 Thread Gui Jianfeng
Hi, When kernel receives a package with a wrong destination ipv4 address, it can't increase "InAddrErrors" number correctly. InAddrErrors is located in /proc/net/snmp. This is a patch for fixing this problem. Signed-off-by: Gui Jianfeng <[EMAIL PROTECTED]> --- diff -Nar