56b16ad ("virtio-net: page_to_skb() use build_skb when there's
> sufficient tailroom")
> Signed-off-by: Eric Dumazet
> Reported-by: Guenter Roeck
> Cc: Xuan Zhuo
> Cc: Jason Wang
> Cc: "Michael S. Tsirkin"
> Cc: virtualizat...@lists.linux-foundation.org
Tested-by: Guenter Roeck
on alpha, sh4 (little endian).
Thanks!
Guenter
On 4/20/21 9:31 AM, Eric Dumazet wrote:
> On Tue, Apr 20, 2021 at 5:42 PM Guenter Roeck wrote:
>>
>> On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote:
>>> On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote:
>>>>
>>
On Tue, Apr 20, 2021 at 04:00:07PM +0200, Eric Dumazet wrote:
> On Tue, Apr 20, 2021 at 3:48 PM Guenter Roeck wrote:
> >
> > On 4/20/21 2:43 AM, Eric Dumazet wrote:
>
> > >
> >
> > Unfortunately that doesn't fix the problem for me. With this patch appl
gt; common_interrupt+0xa4/0xd0 arch/x86/kernel/irq.c:240
>
> Fixes: fb32856b16ad ("virtio-net: page_to_skb() use build_skb when there's
> sufficient tailroom")
> Signed-off-by: Eric Dumazet
> Reported-by: syzbot
> Reported-by: Guenter Roeck
> Reported-by: Mat Marti
[] __sys_sendto+0xa4/0x170
[] sys_sendto+0x24/0x40
[] sys_bind+0x20/0x40
[] entSys+0xa4/0xc0
Bisect log attached.
Guenter
---
# bad: [50b8b1d699ac313c0a07a3c185ffb23aecab8abb] Add linux-next specific files
for 20210419
# good: [bf05bf16c76bb44ab5156223e1e58e26dfe30a88] Linux 5.12-rc8
git bisect
attr && setup_max_cpus > (uintptr_t)attr->data) {
This is wrong. We can not make the decision below without having access
to attr. The function may wrongly return false if soc_device_match()
returns an error.
Guenter
> dev_info(dev, "Watchdog blacklisted on %s %s\n", attr->soc_id,
>attr->revision);
> return true;
>
On 4/13/21 5:41 AM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> After commit 0f6925b3e8da ("virtio_net: Do not pull payload in skb->head")
> Guenter Roeck reported one failure in his tests using sh architecture.
>
> After much debugging, we have been able to spot
the failing system call
isn't always clock_gettime().
Guenter
On 4/12/21 9:31 AM, Eric Dumazet wrote:
> On Mon, Apr 12, 2021 at 6:28 PM Linus Torvalds
> wrote:
>>
>> On Sun, Apr 11, 2021 at 10:14 PM Guenter Roeck wrote:
>>>
>>> Qemu test results:
>>> total: 460 pass: 459 fail: 1
>>> Failed
strace so that we have an idea of time
> delays just in case.
>
The exact command as executed is:
strace -tt -o /tmp/STRACE -f -s 1000 udhcpc -n -q
Log is below. This is the complete log: nothing was truncated, neither
at the beginning nor at the end. The log ends with sendto().
Hope
On 4/11/21 2:43 PM, Eric Dumazet wrote:
> On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote:
>>
>> On 4/11/21 2:23 PM, Eric Dumazet wrote:
>>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote:
>>>>
>>>> On 4/11/21 8:06 AM, Eric Dumazet wrot
On 4/11/21 2:43 PM, Eric Dumazet wrote:
> On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote:
>>
>> On 4/11/21 2:23 PM, Eric Dumazet wrote:
>>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote:
>>>>
>>>> On 4/11/21 8:06 AM, Eric Dumazet wrot
On 4/11/21 2:23 PM, Eric Dumazet wrote:
> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote:
>>
>> On 4/11/21 8:06 AM, Eric Dumazet wrote:
>>> On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote:
>>>
>>>> This patch causes a virtio-net interface
On 4/11/21 8:06 AM, Eric Dumazet wrote:
> On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote:
>
>> This patch causes a virtio-net interface failure when booting sh4 images
>> in qemu. The test case is nothing special: Just try to get an IP address
>> using udhcpc. If
eth0 Link encap:Ethernet HWaddr 52:54:00:12:34:56
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:1 errors:0 dropped:0 overruns:0 frame:0
TX packets:1 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX byte
ude/linux/compiler_types.h:320:38: error:
call to '__compiletime_assert_177' declared with attribute error:
FIELD_GET: type of reg too small for mask
and lots of similar errors.
Guenter
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> arch/arm64/Kconfig.platforms
0x-0x001f]
...
pcnet32: card has no PCI IO resources, aborting
Use pci_resouce_len() instead.
Signed-off-by: Guenter Roeck
---
drivers/net/ethernet/amd/pcnet32.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/amd/pcnet32.c
b/drivers
On Thu, Mar 25, 2021 at 03:23:07AM -0700, Guenter Roeck wrote:
> On Tue, Mar 23, 2021 at 04:02:29PM +0800, Yangbo Lu wrote:
> > Current calculation for diff of TMR_ADD register value may have
> > 64-bit overflow in this code line, when long type scaled_ppm is
> > large.
>
odconfig build) fails with:
ERROR: modpost: "mul_u64_u64_div_u64" [drivers/ptp/ptp-qoriq.ko] undefined!
or a similar error.
Guenter
cvmsg functions:
>
> static int packet_recvmsg(struct socket *sock, struct msghdr *msg,
> size_t len,
> int flags)
>
> If MSG_CMSG_COMPAT is set in 'flags', it's value will be negative.
> Once it perform bit o
to bisect
a compat related network problem will fail at this commit.
Guenter
> ---
> include/linux/socket.h | 71 ++
> 1 file changed, 37 insertions(+), 34 deletions(-)
>
> diff --git a/include/linux/socket.h b/include/linux/socket.h
> ind
Christophe Leroy
Reviewed-by: Guenter Roeck
> ---
> drivers/watchdog/Kconfig | 4 -
> drivers/watchdog/Makefile | 1 -
> drivers/watchdog/mv64x60_wdt.c | 324 -
> include/linux/mv643xx.h| 8 -
> 4 files changed, 337 de
I would suggest to consult with Dave on that. While much of the conversion
could be handled automatically with coccinelle, it touches a lot of files.
I don't think that is worth the effort (or risk).
Guenter
That is needed because of the %d. Without the (u32), the expression is
promoted to unsigned long and the compiler wants to see %ld.
Guenter
On Wed, Mar 17, 2021 at 01:02:51AM +0200, Andy Shevchenko wrote:
> On Wednesday, March 17, 2021, Guenter Roeck wrote:
>
> > Hi,
> >
> > On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com wrote:
> > > From: Menglong Dong
> > >
> >
On 3/16/21 4:02 PM, Andy Shevchenko wrote:
>
>
> On Wednesday, March 17, 2021, Guenter Roeck <mailto:li...@roeck-us.net>> wrote:
>
> Hi,
>
> On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com
> <mailto:menglong8.d...@gmail.com
is patch fixes the problem.
Guenter
---
bisect log:
# bad: [0f4b0bb396f6f424a7b074d00cb71f5966edcb8a] Add linux-next specific files
for 20210316
# good: [1e28eed17697bcf343c6743f0028cc3b5dd88bf0] Linux 5.12-rc3
git bisect start 'HEAD' 'v5.12-rc3'
# bad: [edd84c42baeffe66740143a04
ivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:24:29: error: field
'match_level' has incomplete type
Bisect log attached.
Guenter
---
# bad: [a4bfd8d46ac357c12529e4eebb6c89502b03ecc9] Add linux-next specific files
for 20210209
# good: [92bf22614b21a2706f4993b278017e437f7785b
lse);
>
> + if ((hw->wiphy->flags & WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART) &&
> + !reconfig_due_to_wowlan) {
> + list_for_each_entry(sdata, &local->interfaces, list) {
> + if (!ieee80211_sdata_running
rs/misc/mei/bus.c | 5 ++---
> drivers/misc/mei/hdcp/mei_hdcp.c | 7 +--
> drivers/nfc/microread/mei.c | 4 +---
> drivers/nfc/pn544/mei.c | 4 +---
> drivers/watchdog/mei_wdt.c | 4 +---
Acked-by: Guenter Roeck
> include/linux/mei_cl_bus.h
gt; dev_get_platdata(&fep->pdev->dev);
> |^
>
> Fix this by moving the variable declarations inside the existing #ifdef
> blocks.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> drivers/net/eth
fined an enum of arrays. While a valid
> schema, it is simpler as a whole to only define scalar constraints.
>
> Cc: Jean Delvare
> Cc: Guenter Roeck
> Cc: Jonathan Cameron
> Cc: Lars-Peter Clausen
> Cc: Alexandre Torgue
> Cc: Dmitry Torokhov
> Cc: Ulf Hansson
>
| 2 +-
Acked-by: Guenter Roeck
Guenter
called from modules,
but it is not exported, resulting in build errors such as the following.
arm64:allmodconfig:
ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!
Guenter
> ---
> include/linux/irqdesc.h | 17 +
>
fs/binfmt_em86.c: In function 'load_em86':
fs/binfmt_em86.c:66:2: error: ignoring return value of 'remove_arg_zero'
declared with attribute 'warn_unused_result'
With a change like this, I'd have expected that there is a coccinelle
script or similar to ensure that claims made in the commit message
are true.
Guenter
ma
> identifiers and incorrectly allows JSON pointers to begin without a '/'.
> Let's fix this before it becomes a problem when jsonschema module is
> fixed.
>
> Converted with:
> perl -p -i -e 's/yaml#definitions/yaml#\/definitions/g' `find
> Documentation/de
On 12/12/20 9:04 PM, Miguel Ojeda wrote:
> On Sat, Dec 12, 2020 at 5:18 PM Guenter Roeck wrote:
>>
>> This patch results in:
>>
>> arch/sh/kernel/cpu/sh4a/smp-shx3.c: In function 'shx3_prepare_cpus':
>> arch/sh/kernel/cpu/sh4a/smp-shx3.c:76:3: error
uilding sh:defconfig. Checking for calls to request_irq()
suggests that there will be other similar errors in various builds.
Reverting the patch fixes the problem.
Guenter
On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote:
> On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote:
> > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote:
> > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote:
>
reason it includes everyone in the XDP
maintainer list. If anyone has an idea how that happens, please
let me know - we'll want to get this fixed to avoid the same problem
in the future.
Guenter
+ MAX127_SENSOR_DEVICE_ATTR(5),
> + MAX127_SENSOR_DEVICE_ATTR(6),
> + MAX127_SENSOR_DEVICE_ATTR(7),
> + NULL,
> +};
> +
> +ATTRIBUTE_GROUPS(max127);
> +
> +static const struct attribute_group max127_attr_groups = {
> + .attrs = max127_attrs,
&
from all pmbus drivers.
>
> Signed-off-by: Bartosz Golaszewski
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/adm1266.c | 1 -
> drivers/hwmon/pmbus/adm1275.c | 1 -
> drivers/hwmon/pmbus/bel-pfe.c | 1 -
> drivers/hwmon/pmbus/ibm-cffps.c| 1 -
&
o
> Cc: Bjorn Andersson
> Cc: Baolin Wang
> Cc: Guenter Roeck
> Cc: Jonathan Cameron
> Cc: Mauro Carvalho Chehab
> Cc: Laurent Pinchart
> Cc: Lee Jones
> Cc: Ulf Hansson
> Cc: "David S. Miller"
> Cc: Bjorn Helgaas
> Cc: Vinod Koul
> Cc: Liam Gird
possibly skb->data may not be
initialized correctly ?
Thanks,
Guenter
---
[1] https://www.spinics.net/lists/linux-wireless/msg200403.html
voytov
> Cc: Igor Russkikh
> Signed-off-by: Sebastian Andrzej Siewior
Fixes: 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature")
Acked-by: Guenter Roeck
As in: This patch does not cause any additional trouble and will fix the
observed compile failure. However, t
gt; design-param. Fix both by checking for 0 and for a granularity bigger
> than our min-size; if the granularity <= EFX_MIN_DMAQ_SIZE then it fits
> in 32 bits, so we can cast it to u32 for the divide.
>
> Reported-by: kernel test robot
> Signed-off-by: Edward Cree
Reviewed-by
a power of 2, you could also use
the knowledge that a 2^n value can only be divided by a smaller 2^n value,
meaning that reader->value must have exactly one bit set. This would also
avoid divide-by-0 issues if reader->value can be 0.
if (reader->value > EFX_MIN_DMAQ_SIZE || hweight64(reader->value) != 1)
Guenter
On Mon, Aug 10, 2020 at 09:15:20AM +0100, Edward Cree wrote:
> On 09/08/2020 01:29, Guenter Roeck wrote:
> > On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:
> >> + if (EFX_MIN_DMAQ_SIZE % reader->value) {
> > This is a 64-bit operation (value i
ult on 32-bit builds:
ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined!
Guenter
On Wed, Jul 15, 2020 at 12:09:06PM +0100, Lad Prabhakar wrote:
> RZ/G2H (a.k.a. R8A774E1) watchdog implementation is compatible
> with R-Car Gen3, therefore add the relevant documentation.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Geert Uytterhoeven
Reviewed-by
On Thu, Jul 09, 2020 at 11:59:09AM -0700, Cong Wang wrote:
> On Thu, Jul 9, 2020 at 11:51 AM Cong Wang wrote:
> >
> > On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote:
> > >
> > > Something seems fishy with the use of skcd->val on big endian sy
On Thu, Jul 09, 2020 at 11:59:09AM -0700, Cong Wang wrote:
> On Thu, Jul 9, 2020 at 11:51 AM Cong Wang wrote:
> >
> > On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote:
> > >
> > > Something seems fishy with the use of skcd->val on big endian sy
On 7/9/20 11:51 AM, Cong Wang wrote:
> On Thu, Jul 9, 2020 at 10:10 AM Guenter Roeck wrote:
>>
>> Something seems fishy with the use of skcd->val on big endian systems.
>>
>> Some debug output:
>>
>> [ 22.643703] sock: # sk_alloc(sk=
On 7/8/20 12:32 PM, Cong Wang wrote:
> On Wed, Jul 8, 2020 at 12:07 PM Guenter Roeck wrote:
>>
>> On 7/8/20 11:34 AM, Cong Wang wrote:
>>> Hi,
>>>
>>> On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote:
>>>> This patch causes all my s390 bo
On 7/8/20 12:32 PM, Cong Wang wrote:
> On Wed, Jul 8, 2020 at 12:07 PM Guenter Roeck wrote:
>>
>> On 7/8/20 11:34 AM, Cong Wang wrote:
>>> Hi,
>>>
>>> On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote:
>>>> This patch causes all my s390 bo
On 7/8/20 11:34 AM, Cong Wang wrote:
> Hi,
>
> On Wed, Jul 8, 2020 at 8:33 AM Guenter Roeck wrote:
>> This patch causes all my s390 boot tests to crash. Reverting it fixes
>> the problem. Please see bisect results and and crash log below.
>>
> ...
>> Crash lo
atch causes all my s390 boot tests to crash. Reverting it fixes
the problem. Please see bisect results and and crash log below.
Guenter
---
bisect results (from pending-fixes branch) in -next repository):
# bad: [1432f824c2db44ef35b26caa9f81dd05211a75fc] Merge remote-tracking branch
'drm
for IR35221")
>
> Cc: Samuel Mendoza-Jonas
> Signed-off-by: Tao Ren
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
>
the mode from struct tzd.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Guenter Roeck
> ---
> drivers/acpi/thermal.c| 9 --
> .../ethernet/mellanox/mlxsw/core_thermal.c| 19
> drivers/platform/x86/acerhdf.c
On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz wrote:
> Prepare for eliminating get_mode().
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Guenter Roeck
> ---
> drivers/acpi/thermal.c| 18 ++--
> .../ether
On 6/1/20 4:16 AM, Andrzej Pietrasiewicz wrote:
> Hi Guenter,
>
> W dniu 29.05.2020 o 17:52, Guenter Roeck pisze:
>> On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote:
>>> Prepare for making the drivers not access tzd's private members.
&
the mode from struct tzd.
>
> Signed-off-by: Andrzej Pietrasiewicz
Based on separate feedback/dscussion:
Reviewed-by: Guenter Roeck
Guenter
> ---
> drivers/acpi/thermal.c| 9 --
> .../ethernet/mellanox/mlxsw/core_thermal.c| 19 --
On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz wrote:
> Prepare for eliminating get_mode().
>
> Signed-off-by: Andrzej Pietrasiewicz
Based on discussion:
Reviewed-by: Guenter Roeck
Guenter
> ---
> drivers/acpi/thermal.c
On 5/29/20 10:21 AM, Andrzej Pietrasiewicz wrote:
> Hi again,
>
> W dniu 29.05.2020 o 18:08, Andrzej Pietrasiewicz pisze:
>> Hi Guenter,
>>
>> W dniu 29.05.2020 o 17:42, Guenter Roeck pisze:
>>> On Thu, May 28, 2020 at 09:20:44PM +0200, Andrzej Pietrasiewicz
On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote:
> Prepare for making the drivers not access tzd's private members.
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/thermal/thermal_core.c | 53 ++
> include/linux/thermal.h| 13
on. Now the global value for mode is returned, but I am not sure
if it matches the local value.
Guenter
> ---
> drivers/acpi/thermal.c| 9 --
> .../ethernet/mellanox/mlxsw/core_thermal.c| 19
> drivers/platform/x86/acerhdf.c|
27; branch,
there are still local instances of thermal_device_mode in
drivers/thermal/st/stm_thermal.c
drivers/thermal/ti-soc-thermal/ti-thermal-common.c
If there is a reason not to replace those, it might make sense to explain
it here.
Thanks,
Guenter
> 8 files changed, 44 insertions(+
On 5/29/20 8:13 AM, Andrzej Pietrasiewicz wrote:
> Hi Guenter,
>
> W dniu 29.05.2020 o 16:48, Guenter Roeck pisze:
>> On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote:
>>> Prepare for storing mode in struct thermal_zone_device.
>>>
>>
On 5/29/20 8:08 AM, Andrzej Pietrasiewicz wrote:
> W dniu 29.05.2020 o 17:05, Guenter Roeck pisze:
>> On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote:
>>> Prepare for storing mode in struct thermal_zone_device.
>>>
>>> Signed-off-by: Andr
nor on top of linux-next.
Thanks,
Guenter
tzd. The
> get_mode() methods will become redundant.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Guenter Roeck
> ---
> include/linux/thermal.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> ind
On Thu, May 28, 2020 at 09:20:41PM +0200, Andrzej Pietrasiewicz wrote:
> The acpi_thermal_register_thermal_zone() is missing any error handling.
> This needs to be fixed.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Guenter Roeck
> ---
> drivers/a
On Thu, May 28, 2020 at 09:20:42PM +0200, Andrzej Pietrasiewicz wrote:
> Prepare for storing mode in struct thermal_zone_device.
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/acpi/thermal.c| 27 +--
> drivers/platform/x86/acerhdf.c
m Sang
> Reviewed-by: Geert Uytterhoeven
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/watchdog/renesas,wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.txt
> b/Documentation/de
On Sun, Sep 01, 2019 at 11:06:05AM +0300, Kalle Valo wrote:
> Guenter Roeck writes:
>
> > Hi,
> >
> > On Sat, Aug 03, 2019 at 08:31:01PM -0400, Hui Peng wrote:
> >> The `ar_usb` field of `ath10k_usb_pipe_usb_pipe` objects
> >> are initialized to p
rising.
What I don't understand is how this can work in the first place.
The modified entry in realtek_drvs[] doesn't have read_page/write_page
functions defined, yet rtl8211e_config_init() depends on it.
What am I missing here ?
Thanks,
Guenter
On Fri, Mar 01, 2019 at 02:17:40PM -0800, Eric Dumazet wrote:
>
>
> On 03/01/2019 02:03 PM, Guenter Roeck wrote:
> > Hi,
> >
> > On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote:
> >> JITed BPF programs are indistinguishable from kernel fu
manually.
I suspect that
prog->aux->stats = alloc_percpu_gfp(struct bpf_prog_stats, gfp_flags);
...
u64_stats_init(&prog->aux->stats->syncp);
may be wrong. At the very least it looks odd, and I don't find a similar use
of u64_stats_init() anywhere else
uild error fixed by commit ae40832e53c3
("bpfilter: fix a build err").
Apology for the breakage, and thanks to Guenter for reporting this.
Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for
bpfilter_umh")
Reported-by: Guenter Roeck
Signed-off-by: Masahiro Yama
On Fri, Feb 22, 2019 at 12:54:47AM +0900, Masahiro Yamada wrote:
> On Thu, Feb 21, 2019 at 11:46 PM Guenter Roeck wrote:
> >
> > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote:
> > > Currently, the header search paths -Itools/include and
> > >
blem last fixed with commit ae40832e53c3
("bpfilter: fix a build err"). Seen (at least) with gcc 7.4.0, 8.2.0.
binutils version is 2.31.1. Reverting this patch fixes the problem.
Guenter
> Signed-off-by: Masahiro Yamada
> Signed-off-by: David S. Miller
> ---
> net/bpfilter/M
On 2/13/19 11:06 PM, Vadim Pasternak wrote:
-Original Message-
From: Guenter Roeck On Behalf Of Guenter Roeck
Sent: Wednesday, February 13, 2019 5:03 PM
To: Andrew Lunn ; Ido Schimmel
Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko
; mlxsw ; Vadim Pasternak
Subject: Re
view
if/when that is done.
Guenter
On Fri, Jan 04, 2019 at 09:57:35AM -0500, Richard Guy Briggs wrote:
> On 2019-01-03 18:50, Guenter Roeck wrote:
> > Hi Richard,
> >
> > On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote:
> > > The audit-related parameters in struct task_struct sho
gned-off-by: Richard Guy Briggs
Overall I am not sure if keeping task_struct a bit smaller is worth
the added complexity, but I guess that is just me.
Anyway, couple of nitpicks. Please feel free to ignore, and my apologies
if some of all of the comments are duplicates.
Hi Richard,
On Thu, Jan 03, 2019 at 12:36:13PM -0500, Richard Guy Briggs wrote:
> On 2019-01-03 08:15, Guenter Roeck wrote:
> > Hi,
> >
> > On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote:
> > > Implement kernel audit container identifier.
&g
Hi,
On Tue, Jul 31, 2018 at 04:07:35PM -0400, Richard Guy Briggs wrote:
> Implement kernel audit container identifier.
>
I don't see a follow-up submission of this patch series. Has it been abandoned,
or do I use the wrong search terms ?
Thanks,
Guenter
> This patchset is a f
On Fri, Dec 21, 2018 at 09:57:26PM +0100, Florian Westphal wrote:
> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds. Use helper instead to reset the secpath.
>
> Not even compile tested.
>
It does fix the build error.
Tested-b
On Thu, Sep 27, 2018 at 07:58:24PM -0300, Flavio Leitner wrote:
> On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote:
> > Hi Flavio,
> >
> > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote:
> > > Netfilter assumes that if the socket is pre
b->sk;
>
> + if (!net_eq(xt_net(par), sock_net(sk)))
> + sk = NULL;
> +
Same here.
> if (!sk)
> sk = nf_sk_lookup_slow_v6(xt_net(par), skb, xt_in(par));
> +
> if (sk) {
> bool wildcard;
> bool transparent = true;
Thanks,
Guenter
bpf: make use of reallocarray") added
reallocarray use to libbpf, make perf also perform the reallocarray
feature check.
Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
Reported-by: Guenter Roeck
Signed-off-by: Jakub Kicinski
Tested-by: Guenter Roeck
---
tools/b
On 07/13/2018 05:07 PM, Jakub Kicinski wrote:
On Fri, 13 Jul 2018 16:53:05 -0700, Guenter Roeck wrote:
Hi,
On Tue, Jul 10, 2018 at 02:43:05PM -0700, Jakub Kicinski wrote:
reallocarray() is a safer variant of realloc which checks for
multiplication overflow in case of array allocation. Since
> add a static inline implementation when needed. Use feature
> detection to probe for existence of reallocarray.
>
This probe doesn't work on my system (Ubuntu 16.04).
libbpf.c: In function ‘bpf_object__add_program’:
libbpf.c:326:10: error: implicit declaration of function ‘reallocarray’
bisect points to this patch.
Guenter
've discussed to switch to something like klibc and keep it
> as part of the kernel to avoid relying on glibc and cc-can-link.sh.
>
At the very least it fixes the build issue when building i386 images
on x86_64 systems.
(Build-)Tested-by: Guenter Roeck
> net/bpfilter/Makefile
On Tue, Jun 26, 2018 at 04:47:05PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Guenter Roeck [mailto:li...@roeck-us.net]
> > Sent: Tuesday, June 26, 2018 7:33 PM
> > To: Vadim Pasternak
> > Cc: Andrew Lunn ; da...@davemloft.net
> This is possibly the first board with so many sensors. However, i
> doubt it is totally unique. Other big Ethernet switches with lots of
> SFP modules may be added later. Also, 10G copper PHYs often have
> temperature sensors, so this is not limited to just boards with
> optical ports. So having a generic solution would be good.
Agreed.
Thanks,
Guenter
>
> What do the Linux PM exports say about this?
>
> Thanks
> Andrew
On Tue, Jun 26, 2018 at 02:47:01PM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Andrew Lunn [mailto:and...@lunn.ch]
> > Sent: Tuesday, June 26, 2018 5:29 PM
> > To: Vadim Pasternak
> > Cc: da...@davemloft.net; netdev@vger.kernel.org; li...@roeck-us.net;
> > rui.zh..
On Thu, Jun 21, 2018 at 08:34:40PM +0200, Andrew Lunn wrote:
> > Hi Andrew,
>
> Adding Guenter Roeck, the HWMON maintainer.
>
> > The temperature of each individual module can be obtained
> > through ethtool.
>
> You mean via --module-info?
>
> FYI: I
On 05/29/2018 08:01 PM, Michael S. Tsirkin wrote:
On Tue, May 29, 2018 at 03:19:08PM -0700, Guenter Roeck wrote:
On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote:
The struct vhost_msg within struct vhost_msg_node is copied to userspace,
so it should be allocated with kzalloc() to
5/driver.h: In function ‘mlx5_get_vector_affinity_hint’:
> include/linux/mlx5/driver.h:1299:13: error:
> ‘struct irq_desc’ has no member named ‘affinity_hint’
>
> Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function")
> Signed-off-by: Saeed Mahameed
> CC: Randy Dunlap
&
1 - 100 of 252 matches
Mail list logo
