Re: net: macb: fail when there's no PHY

2020-12-04 Thread Grant Edwards
On 2020-12-04, Florian Fainelli wrote: > On 12/2/2020 7:54 PM, Grant Edwards wrote: >> On 2020-12-03, Florian Fainelli wrote: >> >>> You would have to have a local hack that intercepts the macb_ioctl() >>> and instead of calling phylink_mii_ioctl() it would hav

Re: net: macb: fail when there's no PHY

2020-12-03 Thread Grant Edwards
On 2020-12-03, Andrew Lunn wrote: >> I don't think there's any way I could justify using a kernel that >> doesn't have long-term support. > > 5.10 is LTS. Well, it will be, once it is actually released! Convincing people to ship an unreleased kernel would be a whole 'nother bucket of worms. It's

Re: net: macb: fail when there's no PHY

2020-12-03 Thread Grant Edwards
On 2020-12-03, Andrew Lunn wrote: > On Thu, Dec 03, 2020 at 03:07:58PM -0000, Grant Edwards wrote: > >> I don't think I can justify the additional effort to devlope and >> maintain a custom kern-space driver. > > Why custom? You should contribute it. I can't

Re: net: macb: fail when there's no PHY

2020-12-03 Thread Grant Edwards
On 2020-12-03, Andrew Lunn wrote: >> So I can avoid my local hack to macb_main.c by doing a doing a local >> hack to macb_main.c? > > User space drivers were never supported in any meaningful way. The > IOCTL call is basically there for mii-tool, and nothing much more. I probably wouldn't call a

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
On 2020-12-03, Florian Fainelli wrote: > You would have to have a local hack that intercepts the macb_ioctl() > and instead of calling phylink_mii_ioctl() it would have to > implement a custom ioctl() that does what > drivers/net/phy/phy.c::phy_mii_ioctl does except the mdiobus should > be pointe

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
On 2020-12-02, Andrew Lunn wrote: >>> So it will access the MDIO bus of the PHY that is attached to the >>> MAC. >> >> If that's the case, wouldn't the ioctl() calls "just work" even when >> only the fixed-phy mdio bus and fake PHY are declared in the device >> tree? > > The fixed-link PHY is con

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
On 2020-12-02, Andrew Lunn wrote: >> > So it will access the MDIO bus of the PHY that is attached to the >> > MAC. >> >> If that's the case, wouldn't the ioctl() calls "just work" even when >> only the fixed-phy mdio bus and fake PHY are declared in the device >> tree? > > The fixed-link PHY is c

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
On 2020-12-02, Andrew Lunn wrote: >> When using the SIOC[SG]MIIREG ioctl() call, how does one control >> whether the fake fixed-link bus is accessed or the real macb-mdio bus >> is accessed? > > As far as i remember, that ioctl is based on the interface name. Right. > So it will access the MDIO

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
[Sorry for sending my previous message twice, it was rejected by the list server the first time because it contained both plaintext and HTML alternatives]. On Wed, Dec 02, 2020 at 10:10:37AM -0800, Florian Fainelli wrote: > On 12/2/2020 9:50 AM, Grant Edwards wrote: > > > I know this

Re: net: macb: fail when there's no PHY

2020-12-02 Thread Grant Edwards
On Thu, Sep 21, 2017 at 01:05:57PM -0700, Florian Fainelli wrote: > On 09/21/2017 12:59 PM, Grant Edwards wrote: > > Several years back (circa 2.6.33) I had to hack up macb.c to work on > > an at91 board that didn't have a PHY connected to the macb controller. > > [...]

Re: net: macb: fail when there's no PHY

2017-09-21 Thread Grant Edwards
On Thu, Sep 21, 2017 at 01:05:57PM -0700, Florian Fainelli wrote: >> It looks like the macb driver still can't handle boards that don't >> have a PHY. Is that correct? > > Not since: > > dacdbb4dfc1a1a1378df8ebc914d4fe82259ed46 ("net: macb: add fixed-link > node support") Yep, it's obvious now

net: macb: fail when there's no PHY

2017-09-21 Thread Grant Edwards
with the situation, so I never bothered to submit a patch. -- Grant Edwards grant.b.edwa...@gmail.com