Re: [PATCH] [PATCH net, stable 4.19.y, 1/1] net: hns: Fix WARNING when hns modules installed

2019-04-25 Thread Graeme Gregory
On Tue, Apr 23, 2019 at 12:48:57AM +0800, xiaoj...@hisilicon.com wrote: > From: Jun Xiao > > Commit dfdf26babc98 upstream > > this patch need merge to 4.19.y stable kernel > > Fix Conflict:already fixed the confilct dfdf26babc98 with Yonglong Liu > > stable candidate:user cannot connect to the

Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support

2018-01-18 Thread graeme . gregory
/Armada70x0/Dsdt.asl#L131 > > I will appreciate any comments or remarks. > Nice work, this looks pretty neat to me, for series. Reviewed-by: Graeme Gregory Thanks Graeme > Best regards, > Marcin > > Changelog: > v2 -> v3: > * 1/7, 2/7 > - Add Rafael's A

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-09 Thread Graeme Gregory
On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > Hi Andrew, > > > > 2018-01-08 16:42 GMT+01:00 Andrew Lunn : > > w> I am not familiar with MDIO, but if its similar or a specific > >> implementation of a serial bus that does sound sane! > > > > Thanks for digging, I will check if

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Mon, Jan 08, 2018 at 03:53:12PM +0100, Andrew Lunn wrote: > On Mon, Jan 08, 2018 at 02:45:48PM +0000, Graeme Gregory wrote: > > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > > > I already agreed with 'reg' being awkward in the later email

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-08 Thread Graeme Gregory
On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote: > > > I already agreed with 'reg' being awkward in the later emails. > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > > > > Ah it is an actual address, then yes _ADR is probably more appropriate. > > Newbi

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-04 Thread Graeme Gregory
On Wed, Jan 03, 2018 at 12:12:06PM +0100, Marcin Wojtas wrote: > Hi Graeme, > > 2018-01-03 12:00 GMT+01:00 Graeme Gregory : > > On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: > >> On 18 December 2017 at 10:17, Marcin Wojtas wrote: > >>

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-03 Thread graeme . gregory
On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: > > * Modify way of obtaining interrupts - with ACPI they are resources > > bound to struct platform_device and it's not possible to obtain > > them directly from the child node. Hence a formula is used, depending > > on the port_id

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 Thread Graeme Gregory
On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: > On 18 December 2017 at 10:17, Marcin Wojtas wrote: > > Hi, > > > > This patchset introduces ACPI support in mvpp2 and mvmdio drivers. > > First three patches introduce fwnode helpers for obtaining PHY > > information from nodes and

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
On Thu, Aug 13, 2015 at 10:01:17AM +0100, Lorenzo Pieralisi wrote: > On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: > > On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: > > > Add ACPI bindings for the smsc911x driver. Convert the DT speci

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
on ARM Juno. > > Signed-off-by: Jeremy Linton The code looks fine to me. Currently the compulsary DT properties seem to match the "approved" ACPI NIC properties from here http://www.uefi.org/sites/default/files/resources/nic-request-v2.pdf Reviewed-by: Graeme Gregory Thanks &

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

2015-08-07 Thread Graeme Gregory
On Thu, Aug 06, 2015 at 05:33:10PM -0700, David Daney wrote: > From: David Daney > > Find out which PHYs belong to which BGX instance in the ACPI way. > > Set the MAC address of the device as provided by ACPI tables. This is > similar to the implementation for devicetree in > of_get_mac_address(