[PATCH net] mpls: fix warning with multi-label encap

2019-06-07 Thread George Wilkie
he type of MPLS_IPTUNNEL_DST to fixed size NLA_U32. Change it to a minimum size. nla_get_labels() does the remaining validation. Signed-off-by: George Wilkie --- net/mpls/mpls_iptunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunn

Re: [PATCH net-next] vrf: local route leaking

2019-05-31 Thread George Wilkie
On Thu, May 30, 2019 at 03:50:09PM -0600, David Ahern wrote: > On 5/30/19 2:52 PM, George Wilkie wrote: > > This doesn't work for me (again, not using namespaces). > > For traffic coming in on vrf-b to a destination on 10.200.2.0, > > I see ARPs going out for the destin

Re: [PATCH net-next] vrf: local route leaking

2019-05-30 Thread George Wilkie
On Wed, May 29, 2019 at 09:29:22PM -0600, David Ahern wrote: > you are correct that use of loopback here for default VRF does not work > -- the lookup code gets confused because it is a forward path (as > opposed to MPLS which is a local input). I found a couple of solutions > that work for default

Re: [PATCH net-next] vrf: local route leaking

2019-05-27 Thread George Wilkie
On Sat, May 25, 2019 at 09:13:13AM -0600, David Ahern wrote: > > Using a loopback doesn't work, e.g. if 10.1.1.0/24 was on a global > > interface: > >ip ro add vrf vrf-a 10.1.1.0/24 dev lo > > That works for MPLS when you exit the LSP and deliver locally, so it > should work here as well. I'l

Re: [PATCH net-next] vrf: local route leaking

2019-05-25 Thread George Wilkie
On Fri, May 24, 2019 at 02:19:45PM -0600, David Ahern wrote: > I think this codifies the use case: > ip li add vrf-a up type vrf table 1 > ip route add vrf vrf-a unreachable default > ip li add vrf-b up type vrf table 2 > ip route add vrf vrf-b unreachable default > ip ru add pref 32765 f

[PATCH net-next] vrf: local route leaking

2019-05-24 Thread George Wilkie
ff-by: George Wilkie --- drivers/net/vrf.c| 43 +++ include/net/l3mdev.h | 41 + net/ipv4/route.c | 2 ++ net/ipv6/ip6_input.c | 1 + 4 files changed, 87 insertions(+) diff --git a/drivers/net/vrf.c b/driver

Re: [PATCH net] team: use operstate consistently for linkup

2019-02-20 Thread George Wilkie
On Tue, Feb 19, 2019 at 02:18:30PM -0800, David Miller wrote: > From: George Wilkie > Date: Tue, 19 Feb 2019 15:57:15 + > > > Fixes: f1d22a1e0595 ("team: account for oper state") > > > > Signed-off-by: George Wilkie > > Please do not put an em

[PATCH net v2] team: use operstate consistently for linkup

2019-02-20 Thread George Wilkie
rather than netif_carrier_ok. Fixes: f1d22a1e0595 ("team: account for oper state") Signed-off-by: George Wilkie --- drivers/net/team/team.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 958f1cf67282..6ce3f666d

[PATCH net] team: use operstate consistently for linkup

2019-02-19 Thread George Wilkie
rather than netif_carrier_ok. Fixes: f1d22a1e0595 ("team: account for oper state") Signed-off-by: George Wilkie --- drivers/net/team/team.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 958f1cf67282..6ce3f666d

[PATCH net-next v3] team: account for oper state

2018-04-19 Thread George Wilkie
Account for operational state when determining port linkup state, as per Documentation/networking/operstates.txt. Signed-off-by: George Wilkie --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index

Re: [PATCH net-next v2] team: account for oper state

2018-04-19 Thread George Wilkie
On Thu, Apr 19, 2018 at 11:24:15AM +0100, George Wilkie wrote: > Account for operational state when determining port linkup state, > as per Documentation/networking/operstates.txt. > > Signed-off-by: George Wilkie > --- > drivers/net/team/team.c | 2 +- > 1 file chang

[PATCH net-next v2] team: account for oper state

2018-04-19 Thread George Wilkie
Account for operational state when determining port linkup state, as per Documentation/networking/operstates.txt. Signed-off-by: George Wilkie --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index

Re: [PATCH net-next] team: account for oper state

2018-04-19 Thread George Wilkie
;We are using tun/tap interfaces for the team ports with the physical > >interfaces > >under the control of a user process. > > > >> How is this handle in other drivers like bond, openvswitch, bridge, etc? > > > >It looks like bridge is using it, looking at br_po

[PATCH net-next] team: account for oper state

2018-04-18 Thread George Wilkie
Account for operational state when determining port linkup state, as per Documentation/networking/operstates.txt. Signed-off-by: George Wilkie --- drivers/net/team/team.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c

Re: [PATCH net-next] team: account for oper state

2018-04-18 Thread George Wilkie
On Wed, Apr 18, 2018 at 04:33:12PM +0100, George Wilkie wrote: > On Wed, Apr 18, 2018 at 04:58:22PM +0200, Jiri Pirko wrote: > > Wed, Apr 18, 2018 at 03:35:49PM CEST, gwil...@vyatta.att-mail.com wrote: > > >On Wed, Apr 18, 2018 at 02:56:44PM +0200, Jiri Pirko wrote: > > &g

Re: [PATCH net-next] team: account for oper state

2018-04-18 Thread George Wilkie
trol of a user process. > How is this handle in other drivers like bond, openvswitch, bridge, etc? It looks like bridge is using it, looking at br_port_carrier_check() and br_add_if(). Cheers. > > > > >Cheers. > > > >> > >> > > >> >Signed-off-by: George Wilkie &g

Re: [PATCH net-next] team: account for oper state

2018-04-18 Thread George Wilkie
ally usable or not (as opposed to just admin up). Cheers. > > > > >Signed-off-by: George Wilkie > >--- > > drivers/net/team/team.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >diff --git a/drivers/net/team/team.c b/drivers/net/team/t