Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property

2020-05-23 Thread Fuzzey, Martin
> - gpr: phandle of SoC general purpose register mode. Required for wake on LAN > - on some SoCs > + on some SoCs. Register bits of stop mode control, the format is > + <&gpr req_gpr req_bit>. > +gpr is the phandle to general purpose register node. > +req_gpr is the gpr reg

Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-23 Thread Fuzzey, Martin
Hi Andy, > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT configuration) Just a nitpick maybe but I don't really think this need as Fixes: tag. That commit didn't actually *break* anything AFAIK. It added WoL support for *some* SoCs that didn't have any in mainline and didn't hurt the

Re: [EXT] Re: [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format

2020-05-22 Thread Fuzzey, Martin
Hi Andy, On Fri, 22 May 2020, 03:01 Andy Duan, wrote: > > Andrew, many customers require the wol feature, NXP NPI release always support > the wol feature to match customers requirement. > > And some customers' board only design one ethernet instance based on > imx6sx/imx7d/ > Imx8 serial, but w