Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-22 Thread Frans Klaver
lse, rather than NULL. It's not a pointer (here). >> >> >>> And also in funciton init_prb_bdqc there is no usage of tx_ring. >> >>s,funciton,function, > > Thanks for feedback , please check below changelog if it looks ok, > Then i will share updated patch:-

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Frans Klaver
ring. s,funciton,function, > Thus removing tx_ring from init_prb_bdqc. > > Signed-off-by: Maninder Singh > Suggested-by: Frans Klaver > --- > net/packet/af_packet.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/net/packet/af_pa

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-17 Thread Frans Klaver
On Wed, Jun 17, 2015 at 10:26 AM, Alexander Drozdov wrote: > On Wed, 17 Jun 2015 09:36:11 +0200, Frans Klaver wrote: >> >> On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh >> wrote: >>> >>> Use BUG_ON(condition) instead of if(condition)/BUG() . >>>

Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

2015-06-17 Thread Frans Klaver
On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh wrote: > Use BUG_ON(condition) instead of if(condition)/BUG() . > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar > --- > net/packet/af_packet.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/net/pack

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Frans Klaver
[cc: Willy Tarreau] On Mon, Jun 1, 2015 at 3:26 AM, wrote: > Hello, > > Apoligies if I have submitted to the wrong lists. > > Encountered a regression in > 2.6.32.66 relative to 2.6.32.65. > > Crash eight minutes after boot. > > Will responded with additional details > if the OOPS is not suffice