[PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value

2019-07-05 Thread Frank de Brabander
If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1). The current if-statement incorrectly tests if *ring is NULL. Signed-off-by: Frank de Brabander --- tools/testing/selftests/net/txring_overwrite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

Re: bug: tpacket_snd can cause data corruption

2019-07-05 Thread Frank de Brabander
On 05-07-19 00:59, Willem de Bruijn wrote: Can you reproduce the issue when running the modified test in a network namespace (./in_netns.sh ./txring_overwrite)? But even when running the test with ./in_netns.sh it shows "wrong pattern", this time without length mismatches: wrong pattern: 0x62

Re: bug: tpacket_snd can cause data corruption

2019-07-04 Thread Frank de Brabander
On 03-07-19 18:07, Willem de Bruijn wrote: On Wed, Jul 3, 2019 at 7:08 AM Frank de Brabander wrote: In commit 5cd8d46e a fix was applied for data corruption in tpacket_snd. A selftest was added in commit 358be656 which validates this fix. Unfortunately this bug still persists, although since

bug: tpacket_snd can cause data corruption

2019-07-03 Thread Frank de Brabander
bug is still unclear. Signed-off-by: Frank de Brabander --- tools/testing/selftests/net/txring_overwrite.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/net/txring_overwrite.c b/tools/testing/selftests/net/txring_overwrite.c index

[PATCH] phy/marvell: prevent unneeded page switching

2019-02-18 Thread Frank de Brabander
register a link down & up event. Signed-off-by: Frank de Brabander --- drivers/net/phy/marvell.c | 59 ++- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index abb7876..31de2db 10