Hello Éric,
+ if (memcmp(lladdr, neigh->ha, neigh->dev->addr_len) != 0)
Where do you check that lladdr contains exactly neigh->dev->addr_len bytes ?
True, I do not check. I had some doubt about the best implementation,
since we could do:
* exact matching
* prefix matching (with a
aa:11:22:bb:ee:ff
Signed-off-by: Florent Fourcot
---
net/core/neighbour.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 8e39e28b0a8d..4b32bf49a005 100644
--- a/net/core/neighbour.c
+++ b/net/core
"how" was used as a boolean. Change the type to bool, and improve
variable name
Signed-off-by: Florent Fourcot
---
net/ipv6/addrconf.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 86
Second parameter of addrconf_ifdown "how" is used as a boolean
internally. It does not make sense to call it with something different
of 0 or 1.
This value is set to 2 in all git history.
Signed-off-by: Florent Fourcot
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+),
By default, all devices are listed, not only the default group.
Signed-off-by: Florent Fourcot
Signed-off-by: Romain Bellan
---
man/man8/ip-link.8.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index a8ae72d2..31051c52 100644
--- a/man/man8
signed int, but a correct definition from the beginning is probably
better.
In the same time, 'giants' structure member is unused since years, so
update the comment to mark it unused.
Signed-off-by: Florent Fourcot
---
include/uapi/linux/pkt_sched.h | 6 +++---
1 file changed, 3
Since introduction of htb module, this variable has never been used.
Signed-off-by: Florent Fourcot
---
tc/q_htb.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/tc/q_htb.c b/tc/q_htb.c
index b93d31d4..c8b2941d 100644
--- a/tc/q_htb.c
+++ b/tc/q_htb.c
@@ -109,7 +109,6 @@ static int
Eric Dumazet wrote:
I am a bit unsure why we need to add yet another field in TCP timewait
structure, since :
1) flowlabel can vary during a TCP flow lifetime.
2) flowlabel is different unde synflood (each syncookie gets a random
flowlabel), and if 3rd packet comes back from the client to finish
: fix flowlabel value in ACK messages")
Reported-by: Eric Dumazet
Signed-off-by: Florent Fourcot
---
net/ipv4/tcp_minisocks.c | 2 +-
net/ipv6/tcp_ipv6.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index ebe2ab2..
