Hi,
On Fri, Mar 19, 2021 at 04:43:07PM -0400, Aaron Conole wrote:
> When a user instructs a flow pipeline to perform connection tracking,
> there is an implicit L3 operation that occurs - namely the IP fragments
> are reassembled and then processed as a single unit. After this, new
> fragments
It is not unusual to have the bridge port down. Sometimes
it has the old MTU, which is fine since it's not being used.
However, the kernel spams the log with a warning message
when a packet is going to be sent over such port. Fix that
by warning only if the interface is UP.
Signed-off-by: F
dler() function.
>
> Reported-by: Flavio Leitner
> Signed-off-by: Eelco Chaudron
> ---
Acked-by: Flavio Leitner
---
LGTM
Acked-by: Flavio Leitner
e original problem is removed.
Then 44d6e2f27328 ("net: Replace NF_CT_ASSERT() with WARN_ON().")
replaced a debug assert with a WARN_ON() which is trigged now.
Signed-off-by: Flavio Leitner
---
net/openvswitch/conntrack.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --g
On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote:
> Hi Flavio,
>
> On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote:
> > Netfilter assumes that if the socket is present in the skb, then
> > it can be used because that reference is cleaned up
On Tue, May 15, 2018 at 02:08:09PM -0700, Eric Dumazet wrote:
>
>
> On 05/15/2018 12:31 PM, Flavio Leitner wrote:
> > Hi,
> >
> > There is a significant throughput issue (~50% drop) for a single TCP
> > stream when the skb is scrubbed and XPS is enabled.
> &
Hi,
There is a significant throughput issue (~50% drop) for a single TCP
stream when the skb is scrubbed and XPS is enabled.
If I turn CONFIG_XPS off, then the issue never happens and the test
reaches line rate. The same happens if I echo 0 to tx-*/xps_cpus.
It looks like that when the skb is s
On Mon, 6 Nov 2017 16:16:20 +0100
Jiri Benc wrote:
> On Mon, 6 Nov 2017 15:04:54 +, Colin King wrote:
> > The size for IFLA_IF_NETNSID is missing from the size calculation
> > because the proceeding semicolon was not removed. Fix this by removing
> > the semicolon.
>
> Acked-by: Jiri Benc
From: Jiri Benc
This patch allows reliable identification of netdevice interfaces connected
to openvswitch bridges. In particular, user space queries the netdev
interfaces belonging to the ports for statistics, up/down state, etc.
Datapath dump needs to provide enough information for the user spa
From: Jiri Benc
Currently, when an application gets netnsid from the kernel (for example as
the result of RTM_GETLINK call on one end of the veth pair), it's not much
useful. There's no reliable way to get to the netns fd from the netnsid, nor
does any kernel API accept netnsid.
Extend the RTM_G
From: Jiri Benc
It will be used by openvswitch.
Signed-off-by: Jiri Benc
---
net/core/net_namespace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 6cfdc7c84c48..b797832565d3 100644
--- a/net/core/net_namespace.c
+++ b/net/core/ne
Today Open vSwitch users are moving internal ports to other namespaces and
although packets are flowing OK, the userspace daemon can't find out basic
information like if the port is UP or DOWN, for instance.
This patchset extends openvswitch API to retrieve the current netnsid of
a port. It will b
On Thu, Jun 08, 2017 at 10:31:53AM +0200, Nicolas Dichtel wrote:
> Le 07/06/2017 à 21:14, Flavio Leitner a écrit :
> > Let's say the app is restarted, or another monitoring app is executed
> > with enough perms. How will it identify the error condition?
> Your app wants
On Mon, Jun 05, 2017 at 10:40:24AM +0200, Nicolas Dichtel wrote:
> > Let me ask this instead: How do you think userspace should behave when
> > netnsid allocation fails?
> >
> There is two ways to assign a nsid:
> - manually with netlink ('ip netns set'). In this case, the error is reported
>
On Thu, Jun 01, 2017 at 10:42:13PM +0200, Nicolas Dichtel wrote:
> Le 01/06/2017 à 19:02, Flavio Leitner a écrit :
> > On Thu, Jun 01, 2017 at 10:00:07AM +0200, Nicolas Dichtel wrote:
> >> The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a
> >> n
> checked only for netns that are different from the socket netns. Thus, if
> no nsid is assigned to the socket netns, NETNSA_NSID_NOT_ASSIGNED is
> reported to the userland. This value is confusing and useless.
> After this patch, only valid nsid are sent to userland.
>
>
On Wed, May 31, 2017 at 03:48:06PM +0200, Nicolas Dichtel wrote:
> Le 31/05/2017 à 14:28, Flavio Leitner a écrit :
> > On Wed, May 31, 2017 at 10:38:21AM +0200, Nicolas Dichtel wrote:
> >> Le 30/05/2017 à 23:33, Flavio Leitner a écrit :
> >>> Don't include ne
On Wed, May 31, 2017 at 10:38:21AM +0200, Nicolas Dichtel wrote:
> Le 30/05/2017 à 23:33, Flavio Leitner a écrit :
> > Don't include netns id for notifications broadcasts when the
> > socket and the skb are in the same netns because it will be
> > an error which can'
Don't include netns id for notifications broadcasts when the
socket and the skb are in the same netns because it will be
an error which can't be distinguished from a peer netns failing
to allocate an id.
Signed-off-by: Flavio Leitner
---
net/netlink/af_netlink.c | 6 --
1 file
On Tue, 26 Jan 2016 18:30:41 +0100
Jiri Pirko wrote:
> Tue, Jan 26, 2016 at 06:26:30PM CET, f...@sysclose.org wrote:
> >
> >Hi,
> >
> >After the commit[1] below, we can't set ageing on a Linux bridge
> >device to zero. It seems rocker needs the minimum value, but we
> >can't break an old and val
Hi,
After the commit[1] below, we can't set ageing on a Linux bridge device
to zero. It seems rocker needs the minimum value, but we can't break
an old and valid Linux bridge behavior.
[1] commit c62987bbd8a1a1664f99e89e3959339350a6131e
Author: Scott Feldman
Date: Thu Oct 8 19:23:19 2015 -0
vice device")
> Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of
> vport")
> Fixes: 6b001e682e90 ("openvswitch: Use Geneve device.")
> Signed-off-by: Paolo Abeni
> ---
LGTM and fixes the issue in my env.
Acked-by: Flavio Leitner
--
To un
On Tue, Sep 29, 2015 at 09:54:35PM -0700, David Miller wrote:
> From: Florian Westphal
> Date: Wed, 30 Sep 2015 02:45:07 +0200
>
> > Flavio Leitner wrote:
> >> Remove __nf_conntrack_find() from headers.
> >> Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: rem
Remove __nf_conntrack_find() from headers.
Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code"
Signed-off-by: Flavio Leitner
---
include/net/netfilter/nf_conntrack.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/net/netfilter/nf_conntrack.h
b/include/net
On Sun, Aug 16, 2015 at 04:42:25PM +0300, Victor Kaplansky wrote:
> Sometimes it is essential for libvirt to be able to configure MTU
> on guest's NICs to a value different from 1500.
>
> The change adds a new field to configuration area of network
> devices. It will be used to pass initial MTU fr
It seems patch 01 didn't make it to ovs dev mailing list,
but it is available on netdev mailing list.
fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> in the user space, do the same as bridging does and call dev_disable_lro in
> the kernel.
>
> Signed-off-by: Jiri Benc
> ---
LGTM
Acked-by: Flavio Leitner
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger
On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote:
> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote:
> > OVS interface for generic networking device operation looks odd. have
> > you considered adding new device ioctl to do this?
>
> New ioctls for networking configuration are gen
the range for the
> sockets with strong requirements (not using SO_REUSEADDR)
>
> Note this patch does not add a new sysctl, and only changes
> the way we try to pick port number.
>
> Signed-off-by: Eric Dumazet
> Cc: Marcelo Ricardo Leitner
> Cc: Flavio Leitner
> ---
Th
patch removes overhead of maintaining this counter and
> double inet_csk_get_port() calls under pressure.
>
> Signed-off-by: Eric Dumazet
> Cc: Marcelo Ricardo Leitner
> Cc: Flavio Leitner
> ---
The patch looks good to me.
Acked-by: Flavio Leitner
--
To unsubscribe from this list
RSHIP to handle only connectionless
Fix IP[V6]_ADD_MEMBERSHIP and IP[V6]_DROP_MEMBERSHIP to
return -EPROTO for connection oriented sockets.
Signed-off-by: Flavio Leitner <[EMAIL PROTECTED]>
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index 4d54457..6b420ae 100644
--- a
sets mc_list of cloned socket to NULL.
Signed-off-by: Flavio Leitner <[EMAIL PROTECTED]>
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index fbe7714..8ee0f54 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -506,6
33 matches
Mail list logo
