Re: [PATCH net 3/4] tcp: add tcp_tx_skb_cache sysctl

Hi Eric, On Fri, Jun 14, 2019 at 04:22:20PM -0700, Eric Dumazet wrote: > Feng Tang reported a performance regression after introduction > of per TCP socket tx/rx caches, for TCP over loopback (netperf) > > There is high chance the regression is caused by a change on > how wel

Re: [PATCH net 2/4] tcp: add tcp_rx_skb_cache sysctl

s of sockets. Thanks for the effort! Acked-by: Feng Tang > > Signed-off-by: Eric Dumazet > --- > Documentation/networking/ip-sysctl.txt | 8 > include/net/sock.h | 6 ++ > net/ipv4/sysctl_net_ipv4.c | 9 + > 3 files chang

[RESEND PATCH] intel-ethernet: warn when fatal read failure happens

hat we can get the necessary information about where and how it happens, and use it for root causing and fixing this "PCIe link lost issue" This affects igb, igc. Signed-off-by: Feng Tang Tested-by: Aaron Brown Acked-by: Sasha Neftin --- drivers/net/ethernet/intel/igb/igb_main.c | 1 +

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

Hi Alexander, On Mon, Jan 21, 2019 at 06:29:51PM -0800, Alexander Duyck wrote: > On Mon, Jan 21, 2019 at 5:39 PM Feng Tang wrote: > > > > Hi Duyck, > > > > Thanks for your review! > > > > On Mon, Jan 21, 2019 at 02:50:08PM -0800, Alexander Duyck wrote: >

Re: [Intel-wired-lan] [PATCH] igb: Make driver init async

Hi Duyck, Thanks for your review! On Mon, Jan 21, 2019 at 02:50:08PM -0800, Alexander Duyck wrote: > On Mon, Jan 21, 2019 at 12:36 AM Feng Tang wrote: > > > > When optimizing boot time for a platform with igb module, we found the > > igb driver probe will take about

[PATCH] igb: Make driver init async

e1000, but we don't have HW to verify that. Signed-off-by: Feng Tang --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 7137e7f..d477253 100644 --- a/dr

[PATCH] intel-ethernet: warn when fatal read failure happens

we can get the necessary information about where and how it happens, and use it for root causing and fixing this "PCIe link lost issue" This affects igb, igc. Signed-off-by: Feng Tang --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + drivers/net/ethernet/intel/igc/igc_main.c | 1 +

Backported alx driver fix for stable 4.4 kernel and older

o I backport it as follows. Could you help to add it to your stable queue. Let me know if I break any netdev+stable patch rule, thanks - Feng >From 9c9caee22400c7ed3a514b1ee5e017e5e5b6b812 Mon Sep 17 00:00:00 2001 From: Feng Tang Date: Fri, 24 Jun 2016 15:26:05 +0800 Subject: [PAT

[PATCH] net: alx: Work around the DMA RX overflow issue

overflow can be avoided. In theory this method should also apply to atl1c driver, which I can't find anyone who can help to test on real devices. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761 Signed-off-by: Feng Tang Suggested-by: Eric Dumazet Tested-by: Ole Lukoie --- driver

Re: [PATCH v2] net: alx: use custom skb allocator

Hi Eric, On Thu, May 26, 2016 at 06:08:22AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-26 at 16:41 +0800, Feng Tang wrote: > > On Wed, May 25, 2016 at 07:53:41PM -0400, David Miller wrote: > > > > > > > But now that we have at least two instances of this code

Re: [PATCH v2] net: alx: use custom skb allocator

On Wed, May 25, 2016 at 07:53:41PM -0400, David Miller wrote: > From: Feng Tang > Date: Wed, 25 May 2016 14:49:54 +0800 > > > This patch follows Eric Dumazet's commit 7b70176421 for Atheros > > atl1c driver to fix one exactly same bug in alx driver, that the > >

[PATCH v2] net: alx: use custom skb allocator

80 address cause the silicon to behave abnormally. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761 Cc: Eric Dumazet Cc: Johannes Berg Cc: Jarod Wilson Signed-off-by: Feng Tang Tested-by: Ole Lukoie --- drivers/net/ethernet/atheros/alx/alx.h | 4 +++ drivers/net/ethe

Re: [PATCH] net: alx: use custom skb allocator

Hi Jarod, On Fri, May 20, 2016 at 02:26:57PM -0400, Jarod Wilson wrote: > On Fri, May 20, 2016 at 03:56:23PM +0800, Feng Tang wrote: > > Hi, > > > > Please ignore this patch. > > > > I found the problem and made the patch with kernel 4.4 with Ubuntu 12.04 &g

Re: [PATCH] net: alx: use custom skb allocator

=70761 that had a fix from Jarod Wilson which get merged in v4.5 (commit c406700cd) Per my test, the new 4.6.0 kernel works fine with Jarod's patch. Thanks, Feng On Fri, May 20, 2016 at 01:41:03PM +0800, Feng Tang wrote: > This patch follows Eric Dumazet's commit 7b70176421 to fix

[PATCH] net: alx: use custom skb allocator

t device(PCI ID 1969:1091), with this patch the ethernet dev works just fine Signed-off-by: Feng Tang --- drivers/net/ethernet/atheros/alx/alx.h | 4 +++ drivers/net/ethernet/atheros/alx/main.c | 48 - 2 files changed, 51 insertions(+), 1 deletion(-) diff