[PATCH v2] can: m_can: Set device to software init mode before closing

2020-08-24 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- changes since v1: Rebased to latest mainline drivers/net/can/m_can/m_can.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 02c5795b7393..d0c458f7f6e1 100644 --- a/drivers/net/can/m_can

Re: [PATCH] can: m_can: Set device to software init mode before closing

2020-07-27 Thread Faiz Abbas
Hi, On 16/07/20 9:53 am, Faiz Abbas wrote: > There might be some requests pending in the buffer when the > interface close sequence occurs. In some devices, these > pending requests might lead to the module not shutting down > properly when m_can_clk_stop() is called. > > T

[PATCH] can: m_can: Set device to software init mode before closing

2020-07-15 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 02c5795b7393..d0c458f7f6e1 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-06-25 Thread Faiz Abbas
gger > Signed-off-by: Dan Murphy Acked-by: Faiz Abbas Thanks, Faiz

Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

2019-01-09 Thread Rizvi, Mohammad Faiz Abbas
Hi Dan, Wolfgang, On 1/10/2019 1:14 PM, Wolfgang Grandegger wrote: Hello Dan, sorry for my late response on that topic... Am 09.01.19 um 21:58 schrieb Dan Murphy: Wolfgang On 11/3/18 5:45 AM, Wolfgang Grandegger wrote: Hello Dan, Am 31.10.2018 um 21:15 schrieb Dan Murphy: Wolfgang Thanks

[PATCH v8 1/5] dt-bindings: can: m_can: Document new can transceiver binding

2018-01-16 Thread Faiz Abbas
: Rob Herring Signed-off-by: Faiz Abbas --- Documentation/devicetree/bindings/net/can/m_can.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt index 63e9042..ed61438 100644 --- a

[PATCH v8 3/5] can: m_can: Move allocation of net device to probe

2018-01-16 Thread Faiz Abbas
With the version no longer required to allocate the net device, it can be moved to probe and the alloc_m_can_dev() function can be simplified. Therefore, move the allocation of net device to probe and change alloc_m_can_dev() to setup_m_can_dev(). Signed-off-by: Faiz Abbas --- drivers/net/can

[PATCH v8 0/5] Add MCAN Support for Dra76 platform

2018-01-16 Thread Faiz Abbas
clock using pm_runtime calls must still provide a hclk in the clocks property. Support higher speed CAN-FD bitrate: The community decided that data sampling point be used for the secondary sampling point here https://patchwork.kernel.org/patch/9909845/ Faiz Abbas (2): can: m_can: Move allocation

[PATCH v8 5/5] can: m_can: Support higher speed CAN-FD bitrates

2018-01-16 Thread Faiz Abbas
2013 indicates that this TDC mode is only needed for data bit rates above 2.5 Mbps. Therefore, only enable this mode when the data bit rate is above 2.5 Mbps. Signed-off-by: Franklin S Cooper Jr Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- d

[PATCH v8 4/5] can: m_can: Add PM Support

2018-01-16 Thread Faiz Abbas
SoCs that have the MCAN IP to work with this driver. Signed-off-by: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 100 ++ 1 file changed, 62 insertions(+), 38 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index

[PATCH v8 2/5] dt-bindings: can: can-transceiver: Document new binding

2018-01-16 Thread Faiz Abbas
: Faiz Abbas --- .../bindings/net/can/can-transceiver.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/can-transceiver.txt diff --git a/Documentation/devicetree/bindings/net/can/can-transceiver.txt b

Re: [PATCH v7 5/8] can: m_can: Add PM Support

2018-01-16 Thread Faiz Abbas
Hi, On Monday 15 January 2018 07:25 PM, Marc Kleine-Budde wrote: > On 01/10/2018 11:55 AM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Add support for CONFIG_PM which is the new way to handle managing clocks. >> >> Move the clock management to pm_runtim

Re: [PATCH v7 4/8] can: m_can: Move allocation of net device to probe

2018-01-16 Thread Faiz Abbas
Hi, On Monday 15 January 2018 07:22 PM, Marc Kleine-Budde wrote: > On 01/10/2018 11:55 AM, Faiz Abbas wrote: >> With the version no longer required to allocate the net device, it can >> be moved to probe and the alloc_m_can_dev() function can be simplified. >> >> Theref

Re: [PATCH v7 7/8] dt-bindings: can: m_can: Document new can transceiver binding

2018-01-11 Thread Faiz Abbas
Hi Rob, On Friday 12 January 2018 01:50 AM, Rob Herring wrote: > On Wed, Jan 10, 2018 at 4:55 AM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Add information regarding can-transceiver binding. This is especially >> important for MCAN since the I

[PATCH v7 2/8] can: m_can: Add call to of_can_transceiver

2018-01-10 Thread Faiz Abbas
: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index f4947a7..f72116e 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1649,6 +1649,8 @@ static int

[PATCH v7 1/8] can: dev: Add support for limiting configured bitrate

2018-01-10 Thread Faiz Abbas
reading bitrate_max via the netlink interface. Reviewed-by: Suman Anna Signed-off-by: Franklin S Cooper Jr [nsek...@ti.com: fix build error with !CONFIG_OF] Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- drivers/net/can/dev.c| 45

[PATCH v7 0/8] Add MCAN Support for Dra76 platform

2018-01-10 Thread Faiz Abbas
. Drivers which enable hclk as the interface clock using pm_runtime calls must still provide a hclk in the clocks property. Support higher speed CAN-FD bitrate: The community decided that data sampling point be used for the secondary sampling point here https://patchwork.kernel.org/patch/9909845/ Faiz

[PATCH v7 3/8] can: m_can: Remove check for version when allocating m_can net device

2018-01-10 Thread Faiz Abbas
allocating the net device. Signed-off-by: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index f72116e..893edbb 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers

[PATCH v7 4/8] can: m_can: Move allocation of net device to probe

2018-01-10 Thread Faiz Abbas
With the version no longer required to allocate the net device, it can be moved to probe and the alloc_m_can_dev() function can be simplified. Therefore, move the allocation of net device to probe and change alloc_m_can_dev() to setup_m_can_dev(). Signed-off-by: Faiz Abbas --- drivers/net/can

[PATCH v7 5/8] can: m_can: Add PM Support

2018-01-10 Thread Faiz Abbas
allows future Texas Instruments SoCs that have the MCAN IP to work with this driver. Reviewed-by: Suman Anna Signed-off-by: Franklin S Cooper Jr [nsek...@ti.com: handle pm_runtime_get_sync() failure, fix some bugs] Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- drivers/net/can/m_can

[PATCH v7 8/8] dt-bindings: can: can-transceiver: Document new binding

2018-01-10 Thread Faiz Abbas
From: Franklin S Cooper Jr Add documentation to describe usage of the new can-transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas

[PATCH v7 6/8] can: m_can: Support higher speed CAN-FD bitrates

2018-01-10 Thread Faiz Abbas
2013 indicates that this TDC mode is only needed for data bit rates above 2.5 Mbps. Therefore, only enable this mode when the data bit rate is above 2.5 Mbps. Signed-off-by: Franklin S Cooper Jr Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- d

[PATCH v7 7/8] dt-bindings: can: m_can: Document new can transceiver binding

2018-01-10 Thread Faiz Abbas
-by: Faiz Abbas --- Documentation/devicetree/bindings/net/can/m_can.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt index 63e9042..ed61438 100644 --- a/Documentation

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-04 Thread Faiz Abbas
Hi, On Wednesday 03 January 2018 08:47 PM, Marc Kleine-Budde wrote: > On 01/03/2018 04:06 PM, Faiz Abbas wrote: >> Hi, >> >> On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: >>> On 01/03/2018 01:39 PM, Faiz Abbas wrote: >>>> On Tuesday 0

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-03 Thread Faiz Abbas
Hi, On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: > On 01/03/2018 01:39 PM, Faiz Abbas wrote: >> On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >>> On 12/22/2017 02:31 PM, Faiz Abbas wrote: >>>> From: Franklin S Cooper Jr >&g

Re: [PATCH v6 4/6] can: m_can: Support higher speed CAN-FD bitrates

2018-01-03 Thread Faiz Abbas
Hi, On Tuesday 02 January 2018 07:05 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> During test transmitting using CAN-FD at high bitrates (> 2 Mbps) >> would fail. Scoping the signals I noticed that

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-03 Thread Faiz Abbas
Hi, On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Add support for PM Runtime which is the new way to handle managing clocks. >> However, to avoid breaking SoCs not using P

Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

2018-01-03 Thread Faiz Abbas
Hi, On Tuesday 02 January 2018 09:45 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is connected to. Thi

Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

2018-01-03 Thread Faiz Abbas
Hi Marc, On Tuesday 02 January 2018 06:30 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is con

[PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

2017-12-22 Thread Faiz Abbas
Cooper Jr [nsek...@ti.com: fix build error with !CONFIG_OF] Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- v6 changes: fix build error with !CONFIG_OF drivers/net/can/dev.c | 39 +++ include/linux/can/dev.h | 8 2 files changed, 47

[PATCH v6 6/6] dt-bindings: can: can-transceiver: Document new binding

2017-12-22 Thread Faiz Abbas
: Faiz Abbas --- .../bindings/net/can/can-transceiver.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/can-transceiver.txt diff --git a/Documentation/devicetree/bindings/net/can/can-transceiver.txt b

[PATCH v6 0/6] Add M_CAN Support for Dra76 platform

2017-12-22 Thread Faiz Abbas
This patch series adds support for M_CAN on the TI Dra76 platform. Device tree patches will be sent separately. A bunch of patches were sent before by Franklin Cooper . I have clubbed the series together and rebased to the latest kernel. v6 changes: Dropped the patches to make hclk optional. Drive

[PATCH v6 4/6] can: m_can: Support higher speed CAN-FD bitrates

2017-12-22 Thread Faiz Abbas
2013 indicates that this TDC mode is only needed for data bit rates above 2.5 Mbps. Therefore, only enable this mode when the data bit rate is above 2.5 Mbps. Signed-off-by: Franklin S Cooper Jr Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- d

[PATCH v6 5/6] dt-bindings: can: m_can: Document new can transceiver binding

2017-12-22 Thread Faiz Abbas
: Rob Herring Signed-off-by: Faiz Abbas --- Documentation/devicetree/bindings/net/can/m_can.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt index 63e9042..ed61438 100644 --- a

[PATCH v6 2/6] can: m_can: Add call to of_can_transceiver

2017-12-22 Thread Faiz Abbas
: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index f4947a7..f72116e 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1649,6 +1649,8 @@ static int

[PATCH v6 3/6] can: m_can: Add PM Runtime

2017-12-22 Thread Faiz Abbas
allows future Texas Instruments SoCs that have the MCAN IP to work with this driver. Signed-off-by: Franklin S Cooper Jr [nsek...@ti.com: handle pm_runtime_get_sync() failure, fix some bugs] Signed-off-by: Sekhar Nori Signed-off-by: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 38