Hi Andrew,
On Tue, Mar 30, 2021 at 11:30 AM Andrew Lunn wrote:
> Hi Fabio
>
> I think it should be merged, and we fixup anything which does break.
> We are probably at the point where more is broken by not merging it
> than merging it.
Thanks for your feedback. I agree.
Shawn wants to collect
ity to break old dtb's.
Reviewed-by: Fabio Estevam
Andrew, what do you think?
Thanks
Hi Sasha,
On Wed, Feb 24, 2021 at 10:35 PM Sasha Levin wrote:
>
> From: Joakim Zhang
>
> [ Upstream commit 812f0116c66a3ebaf0b6062226aa85574dd79f67 ]
>
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
>
i-ref";
> ...
> };
>
> The board which was referred in the initial patch is already fixed.
> See: arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
>
> Signed-off-by: Oleksij Rempel
Reviewed-by: Fabio Estevam
On Thu, Nov 12, 2020 at 8:56 AM Kegl Rohit wrote:
> Not so easily possible because there are custom drivers and some
> kernel modifications in the mix.
imx6 is a well supported SoC in mainline.
You should try a mainline kernel, otherwise we cannot help you.
On Wed, Nov 11, 2020 at 11:27 AM Kegl Rohit wrote:
>
> Hello!
>
> We are using a imx6q platform.
> The fec interface is used to receive a continuous stream of custom /
> raw ethernet packets. The packet size is fixed ~132 bytes and they get
> sent every 250µs.
>
> While testing I observed spontane
Hi David,
On Wed, Nov 11, 2020 at 2:52 PM David Laight wrote:
> I've seen a 'fec' ethernet block in a freescale DSP.
> IIRC it is a fairly simple block - won't be doing out-of-order writes.
>
> The imx6q seems to be arm based.
This is correct.
> I'm guessing that means it doesn't do cache cohe
Hi Oleksij,
On Tue, Oct 6, 2020 at 5:05 AM Oleksij Rempel wrote:
>
> Hello PHY experts,
>
> Short version:
> what is the proper way to handle the PHY reset before identifying PHY?
>
> Long version:
> I stumbled over following issue:
> If PHY reset is registered within PHY node. Then, sometimes,
Hi Bruno,
On Tue, Jul 28, 2020 at 6:02 AM Bruno Thomsen wrote:
>
> The current reset logic only has a delay during assert.
> This reuses the delay value as deassert delay to ensure
> PHYs are ready for commands. Delays are typically needed
> when external hardware slows down reset release with a
Hi Bruno,
Adding netdev and the Ethernet PHY folks.
On Fri, Jul 17, 2020 at 12:48 PM Bruno Thomsen wrote:
>
> Hi
>
> I have been having issues with Ethernet PHY type ID
> auto-detection when changing from the deprecated fec
> phy-reset-{gpios,duration,post-delay} properties to the
> modern mdio
DP83869 is an Ethernet PHY, not a charger, so fix the documentation
accordingly.
Fixes: 4d66c56f7efe ("dt-bindings: net: dp83869: Add TI dp83869 phy")
Signed-off-by: Fabio Estevam
---
Documentation/devicetree/bindings/net/ti,dp83869.yaml | 2 +-
1 file changed, 1 insertion(+),
DP83867 is an Ethernet PHY, not a charger, so fix the documentation
accordingly.
Fixes: 74ac28f16486 ("dt-bindings: dp83867: Convert DP83867 to yaml")
Signed-off-by: Fabio Estevam
---
Documentation/devicetree/bindings/net/ti,dp83867.yaml | 2 +-
1 file changed, 1 insertion(+),
On Mon, Jul 6, 2020 at 2:30 AM Andy Duan wrote:
>
> From: Sven Van Asbroeck Sent: Sunday, July 5, 2020
> 11:34 PM
> >
> > ext phy-| \
> > | |
> > enet_ref-o--|M |pad--| \
> >| |_/ | |
> >|
Hi Sven,
On Thu, Jul 2, 2020 at 2:53 PM Sven Van Asbroeck wrote:
> + /*
> +* On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to
> +* be the PTP clock source, instead of having to be routed through
> +* pads.
> +*/
> + if (of_machine_is_
Hi Russell,
On Sun, Aug 11, 2019 at 10:37 AM Russell King - ARM Linux admin
wrote:
>
> Hi Fabio,
>
> When I woke up this morning, I found that one of the Hummingboards
> had gone offline (as in, lost network link) during the night.
> Investigating, I find that the system had gone into OOM, and at
On Thu, Jul 18, 2019 at 1:49 PM Lucas Stach wrote:
>
> Am Donnerstag, den 18.07.2019, 10:34 -0400 schrieb Sven Van Asbroeck:
> > Allowing the fec to reset its PHY via the phy-reset-gpios
> > devicetree property is deprecated. To improve developer
> > awareness, generate a warning whenever the depr
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam
---
Changes since v2:
- Use dev_err() instead of netdev_err() - Andy
drivers/net/ethernet/freescale/fec_main.c | 9 +
1 file changed, 5 insertions(+), 4
board.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 848defa33d3a..2ee72452ca76 100644
--- a/drivers
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam
Acked-by: Fugang Duan
---
Changes since v2:
- Made it a standalone patch
- Collected Andy's Ack
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
1 file chang
netdev_err() is more appropriate for printing error messages inside
network drivers, so switch to netdev_err().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Split the changes from fec_main and fec_ptp in two different patches
drivers/net/ethernet/freescale/fec_main.c | 8
1
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Use dev_err() instead of netdev_err() - Andy
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
netdev_err() is more appropriate for printing error messages inside
network drivers, so switch to netdev_err().
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_main.c | 8
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
2 files changed, 5 insertions(+), 5
Hi Ioana,
On Mon, May 27, 2019 at 6:47 PM Ioana Ciornei wrote:
>
> From: Vladimir Oltean
>
> This is a cosmetic patch that wraps the operation of creating sysfs
> links between the netdev->phydev and the phydev->attached_dev.
>
> This is needed to keep the indentation level in check in a follow-
The correct form is "can be probed", so fix the typo.
Signed-off-by: Fabio Estevam
---
Documentation/devicetree/bindings/net/dsa/dsa.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt
b/Documentation/devicetree/bi
From: Fabio Estevam
When platform_device_register_simple() fails we can return
the error immediately instead of jumping to the 'err_pdev'
label.
This makes the error path a bit simpler.
Signed-off-by: Fabio Estevam
---
drivers/net/phy/fixed_phy.c | 7 ++-
1 file changed, 2
From: Fabio Estevam
Currently there is no license information in the header of
this file.
The MODULE_LICENSE field contains ("GPL"), which means
GNU Public License v2 or later, so add a corresponding
SPDX license identifier.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet
From: Fabio Estevam
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_ptp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/freescale
From: Fabio Estevam
If the example binding is used on a real dts file, the following DTC
warning is seen with W=1:
arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size):
/mdio-gpio/switch@0: unnecessary #address-cells/#size-cells without "ranges" or
Hi Andrew,
On Sun, Mar 25, 2018 at 5:56 PM, Andrew Lunn wrote:
> By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING
> we override the trigger mode provided in device tree. And the
> interrupt is actually active low, which is what all the current device
> tree descriptions use.
>
.
>
> Signed-off-by: Yangbo Lu
> ---
> Changes for v2:
> - explained why spinlock was needed in commit message.
Thanks for improving the commit log:
Reviewed-by: Fabio Estevam
On Mon, Jan 8, 2018 at 8:13 AM, Yangbo Lu wrote:
> set_fipers() calling should be protected by spinlock.
> This patch is to move set_fipers() to spinlock protecting
> area in ptp_gianfar_adjtime() function.
It would be nice to explay why.
Thanks
Hi Andy,
On Tue, Jan 2, 2018 at 7:57 AM, Fugang Duan wrote:
> @@ -3576,6 +3580,7 @@ static int fec_enet_get_irq_cnt(struct platform_device
> *pdev)
> of_node_put(phy_node);
> failed_ioremap:
> free_netdev(ndev);
> + dev_id--;
This seems to be a different fix and should b
From: Fabio Estevam
The GPIO polarity passed to phy-reset-gpio is ignored by the FEC
driver and it is assumed to be active low.
It can be active high only when the 'phy-reset-active-high' property
is present.
The current examples pass active high polarity and work fine, but
in order
Hi Andrew,
On Tue, Jul 18, 2017 at 10:32 AM, Andrew Lunn wrote:
> http://elixir.free-electrons.com/linux/latest/source/include/linux/gpio/consumer.h#L345
> static inline void gpiod_set_value_cansleep(struct gpio_desc *desc, int value)
> {
> /* GPIO can never have been requested */
>
On Tue, Jul 18, 2017 at 10:02 AM, Sergei Shtylyov
wrote:
>No, it does -- devm_gpiod_get_optinal() will return NULL in that case,
> bus->reset_gpio will remanin NULL, and you're removing the NULL checks
> around the gpiod_set_value_cansleep() calls. Perhaps it's the problem in the
> GPIO suppo
On Tue, Jul 18, 2017 at 9:48 AM, Sergei Shtylyov
wrote:
> On 07/18/2017 03:39 PM, Fabio Estevam wrote:
>
>>>Won't this result in kernel WARNING when GPIO is disabled?
>
>
>GPIO support, I was going to type...
>
>> Not sure if I understood your point,
On Tue, Jul 18, 2017 at 6:56 AM, Sergei Shtylyov
wrote:
>Won't this result in kernel WARNING when GPIO is disabled?
Not sure if I understood your point, but gpiod_set_value_cansleep() is
a no-op when the gpiod is NULL.
From: Fabio Estevam
The gpiod API checks for NULL descriptors, so there is no need to
duplicate the check in the driver.
Signed-off-by: Fabio Estevam
---
drivers/net/phy/mdio_bus.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers
On Wed, Jul 12, 2017 at 6:09 PM, Dave Hansen
wrote:
>
> From: Dave Hansen
>
> I'm seeing warnings on kernel configurations where CONFIG_PM is
> disabled. It happens in 4.12, at least:
>
> drivers/ethernet/intel/igb/igb_main.c:7988:13: warning:
> 'igb_deliver_wake_packet' defined but not used [-
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote:
> A previous commit inserted a dependency on DMA API that requires
> HAS_DMA to be added in Kconfig.
It would be nice to specify the commit that caused this.
On Sat, Jun 10, 2017 at 5:16 PM, David Miller wrote:
> From: Fabio Estevam
> Date: Fri, 9 Jun 2017 22:37:22 -0300
>
>> From: Fabio Estevam
>>
>> Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
>> introduced fec_enet_clea
From: Fabio Estevam
Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.
Add the missing empty stub to fix the bui
From: Fabio Estevam
Commit 2b30842b23b9 ("net: fec: Clear and enable MIB counters on imx51")
introduced fec_enet_clear_ethtool_stats(), but missed to add a stub
for the CONFIG_M5272=y case, causing build failure for the
m5272c3_defconfig.
Add the missing empty stub to fix the bui
Hi Paul,
On Fri, Jun 9, 2017 at 10:01 PM, Paul Gortmaker
wrote:
> Seems to break one of the automated linux-next builds:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/13057702/
>
> A mindless automated bisect reports:
>
> 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633 is the first bad commit
> c
t;
> Signed-off-by: Andrew Lunn
Thanks for the fix:
Reviewed-by: Fabio Estevam
>
> Signed-off-by: Leonard Crestez
Reviewed-by: Fabio Estevam
Hi Leonard,
On Tue, May 30, 2017 at 2:34 PM, Leonard Crestez
wrote:
> These bits seem to be lost after a suspend/resume cycle so just set them
> again.
>
> This patch fixes ethernet suspend/resume on imx6ul-14x14-evk boards.
>
> Signed-off-by: Leonard Crestez
When you send a v2 addressing Flori
On Sat, Apr 22, 2017 at 1:56 PM, Maksim Salau wrote:
> Allocate buffer on HEAP instead of STACK for a local structure
> that is to be sent using usb_control_msg().
>
> Signed-off-by: Maksim Salau
> ---
> drivers/net/can/usb/gs_usb.c | 17 -
> 1 file changed, 12 insertions(+), 5 d
Hi Tim,
On Wed, Apr 12, 2017 at 1:15 PM, Tim Harvey wrote:
>
> Andrew,
>
> Thanks for the reply. Your talking about suspend/resume power
> management right? The users reporting this were not using
> suspend/resume.
>
> With regards to clock are you talking about the IPG clock? Is there
> any othe
On Fri, Feb 10, 2017 at 3:54 AM, Andy Duan wrote:
> Fix hardware setup of multicast address hash:
> - Never clear the hardware hash (to avoid packet loss)
> - Construct the hash register values in software and then write once
> to hardware
>
> Signed-off-by: Fugang Duan
> Signed-off-by: Rui Sousa
: phy: Fix lack of reference count on PHY driver")
> Signed-off-by: Florian Fainelli
This fixes the kernel crash:
Tested-by: Fabio Estevam
On Wed, Feb 8, 2017 at 12:40 PM, Andrew Lunn wrote:
> And i guess you don't have a specific PHY driver for you PHYs. You are
> using the generic PHY driver?
Yes, I am:
Generic PHY 63fec000.ethernet-1:00: attached PHY driver [Generic PHY]
(mii_bus:phy_addr=63fec000.ethernet-1:00, irq=-1)
>
> Cou
Hi Andrew,
On Wed, Feb 8, 2017 at 12:28 PM, Andrew Lunn wrote:
> Hi Fabio
>
> Could you try reverting:
>
> commit cafe8df8b9bc9aa3dffa827c1a6757c6cd36f657
> Author: Mao Wenan
> Date: Tue Jan 31 18:46:43 2017 -0800
>
> net: phy: Fix lack of reference count on PHY driver
>
> There is cu
Hi,
I am getting the following kernel crash with linux-next 20170208
running on a imx53-qsb board.
Any ideas?
Thanks
Unable to handle kernel NULL pointer dereference at virtual address 0008
pgd = c0004000
[0008] *pgd=
Internal error: Oops: 5 [#1] SMP ARM
Modules linked in:
tions do not exist, which results into build errors.
>
> Fix that by adding explicit handling of !defined(CONFIG_M5272) case.
>
> Fixes: 4dfb80d18d05 ("net: fec: cache statistics while device is down")
> Signed-off-by: Nikita Yushchenko
Looks better now:
Reviewed-by: Fabio Estevam
Add a definition for PHY ID mask for improving code readability.
Signed-off-by: Fabio Estevam
---
drivers/net/phy/at803x.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index f279a89..dd47b69 100644
--- a
Hi Eric,
On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson wrote:
> Reading the i.MX28 reference manual, it appears that this SoC doesn't
> have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag.
On MX28 the register is called HW_ENET_MAC_IPACCRXCONF.
I sent a patch that fixes the
From: Fabio Estevam
Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks
networking on mx28.
There is an erratum on mx28 (ENGR121613 - ENET big endian mode
not compatible with ARM little endian) that requires an additional
byte-swap operation to workaround this problem
Hi Henri,
2016-10-21 7:19 GMT-02:00 Henri Roosen :
> Hi,
>
> Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in
> hardware" breaks networking on an iMX28 system.
>
> The commit seems valid for iMX6, where it is tested okay and solves the
> unaligned accesses.
>
> On iMX28 I still see
Hi Albert,
On Mon, Sep 26, 2016 at 4:11 PM, Albert ARIBAUD (3ADEV)
wrote:
> If the MDIO enf-of-transfer wait loop does not time out,
> 0 should be returned to the caller through ret, but ret
> was not reset to 0 after receiving the return value of
> pm_runtime_get_sync(). Reset ret when no time o
clk_prepare_enable() may fail, so we should better check its return
value and propagate it in the case of failure
While at it, replace __lpc_eth_clock_enable() with a plain
clk_prepare_enable/clk_disable_unprepare() call in order to
simplify the code.
Signed-off-by: Fabio Estevam
Acked-by
From: Fabio Estevam
clk_prepare_enable() may fail, so we should better check its return
value and propagate it in the case of failure
While at it, replace __lpc_eth_clock_enable() with a plain
clk_prepare_enable/clk_disable_unprepare() call in order to
simplify the code.
Signed-off-by: Fabio
From: Fabio Estevam
clk_prepare_enable() may fail, so we should better check its return
value and propagate it in the case of failure.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/nxp/lpc_eth.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff
Since commit f786f3564c4f02d5026 ("net: ethernet: lpc_eth: use phydev
from struct net_device") the 'pldat' variable became unused, so
just remove it.
Reported-by: Olof's autobuilder
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/nxp/lpc_eth.c | 1 -
1 file cha
On Tue, May 31, 2016 at 2:17 PM, George G. Davis
wrote:
> Convert the i.MX FEC driver and DT files to use the GPIOD API
> which automatically handles GPIO polarity.
>
> Signed-off-by: George G. Davis
In order to avoid breaking old dtb's a property called
'phy-reset-active-high' has been introduc
9.371540] Unable to handle kernel paging request at virtual address
001c
[9.371540] pc = d0320926, ra = 903209d1
[9.375358] Oops: sig: 11 [#1]
This reverts commit da47b4572056487fd7941c26f73b3e8815ff712a.
Reported-by: Guenter Roeck
Signed-off-by: Fabio Estevam
---
Documentation/
From: Fabio Estevam
Replace the hardcoded mask 0x00f0 with MICREL_PHY_ID_MASK for
better readability.
Suggested-by: Andrew Lunn
Signed-off-by: Fabio Estevam
---
drivers/net/phy/micrel.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git
and new u64_stats_update_begin_raw()
> and u64_stats_update_end_raw methods.
>
> Fixes: c10d9310edf5 ("tcp: do not assume TCP code is non preemptible")
> Reported-by: Fabio Estevam
> Diagnosed-by: Francois Romieu
> Signed-off-by: Eric Dumazet
Thanks for the fix, Eric and Francois! This allows me to do NFS boot again:
Tested-by: Fabio Estevam
Hi Chuck,
On Sun, May 1, 2016 at 4:52 PM, Chuck Lever wrote:
> Hi Fabio-
>
>> On Apr 29, 2016, at 7:18 PM, Fabio Estevam wrote:
>>
>> Hi,
>>
>> NFS is not working on a imx6q-sabresd board running linux-next 20160429:
>>
>> [ 15.753317] #0:
Hi,
NFS is not working on a imx6q-sabresd board running linux-next 20160429:
[ 15.753317] #0: wm8962-audio
[ 15.759437] Root-NFS: no NFS server address
[ 15.763649] VFS: Unable to mount root fs via NFS, trying floppy.
[ 15.774223] VFS: Cannot open root device "nfs" or
unknown-block(2,0)
From: Fabio Estevam
Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error
messages") introduces a write to a register that does not exist in
Coldfire.
Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block,
so that we guarantee i
Hi Greg,
On Wed, Mar 30, 2016 at 10:17 PM, Greg Ungerer wrote:
> Yes, that fixes it. Will you carry this change?
Thanks for confirming.
Yes, I will submit it later today;
Hi Andy,
On Wed, Mar 30, 2016 at 10:41 PM, Fugang Duan wrote:
>
> Fabio, we cannot do it like this that may cause confused for the quirk flag
> "FEC_QUIRK_HAS_RACC".
We can treat FEC_QUIRK_HAS_RACC flag as "this is a non-Coldfire SoC".
>
>
> Hi, Greg,
>
> The header file fec.h define the FEC_F
Hi Greg,
On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer wrote:
> Hi Troy,
>
> Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error
> messages') adds a write to a register that is not present in all
> implementations of the FEC hardware module. None of the ColdFire
> SoC parts with the
On Mon, Mar 7, 2016 at 3:23 PM, Fabio Estevam wrote:
> Hi,
>
> Not able to NFS mount on a mx6sx-sdb board running linux-next 20160307:
Ops, I was using the wrong device tree. Sorry for the noise.
Hi,
Not able to NFS mount on a mx6sx-sdb board running linux-next 20160307:
[6.618638] devtmpfs: mounted
[6.623340] Freeing unused kernel memory: 1024K (c0c0 - c0d0)
[6.899625] Unable to handle kernel NULL pointer dereference at
virtual address 0001
[6.907828] Unable t
On Wed, Mar 2, 2016 at 5:05 PM, Bernhard Walle wrote:
> Indeed, you're correct.
>
> Should I send a new patch or a patch that corrects my first patch?
> Because it already is in linux-next.
As your patch is already in linux-next you should send an incremental
patch then. Thanks
t a try it would be great.
>
> For reference, the patch is here : https://lkml.org/lkml/2015/11/30/768
I finally got access to a mx53ard board, applied your patch and
managed to NFS boot without issues:
[1.739281] smsc911x f400.lan9220 eth0: SMSC911x/921x
identified at 0xe0a8, IRQ: 207
Tested-by: Fabio Estevam
On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote:
> Signed-off-by: Diego Viola
You should write a commit log.
On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber
wrote:
> +static int marvell_config_init(struct phy_device *phydev)
> +{
> + int err;
> +
> + /* Set registers from marvell,reg-init DT property */
> + err = marvell_of_reg_init(phydev);
> + if (err < 0)
> + ret
On Fri, Feb 12, 2016 at 1:20 PM, Rob Herring wrote:
> This is what the gpio flags are for. Why can't you use that?
This has already been discussed in v1:
https://lkml.org/lkml/2016/2/8/867
Hi Bernhard,
On Tue, Feb 9, 2016 at 6:01 PM, Bernhard Walle wrote:
> We need that for a custom hardware that needs the reverse reset
> sequence.
>
> Signed-off-by: Bernhard Walle
Looks good:
Reviewed-by: Fabio Estevam
On Wed, Dec 9, 2015 at 6:09 PM, Timur Tabi wrote:
>> +/* set MAC address */
>> +void emac_mac_addr_clear(struct emac_adapter *adpt, u8 *addr)
>> +{
>> + u32 sta;
>> +
>> + /* for example: 00-A0-C6-11-22-33
>> +* 0<-->C6112233, 1<-->00A0.
>> +*/
>
> /*
> * Multi-line c
On Mon, Dec 7, 2015 at 10:56 AM, Krzysztof Hałasa wrote:
> Gateworks Ventana boards seem to need "RGMII-ID" (internal delay)
> PHY mode, instead of simple "RGMII", for their Marvell 88E1510
> transceiver. Otherwise, the Ethernet MAC doesn't work with Marvell PHY
> driver (TX doesn't seem to work c
On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann
wrote:
> - gpio_set_value_cansleep(phy_reset, 1);
> + gpiod_set_value_cansleep(phy_reset, 1);
This will break some existing DTBs.
Currently the fec driver does not care whether 'phy-reset-gpios' is
active low or active high. (Yes, it
On Wed, Oct 28, 2015 at 10:36 AM, David Jander wrote:
> I can search further down, but 4.1 is also broken.
> Are there specific changes or versions you are suspicious of?
I was just trying to understand if this was a regression or if it has
always been broken.
--
To unsubscribe from this list: s
On Wed, Oct 28, 2015 at 9:19 AM, David Jander wrote:
> Sorry, I somehow assumed it was obvious I'd report against latest mainline...
> I'm on 4.3-rc7.
Are you able to find out a previous kernel version that does not
exhibit this failure?
--
To unsubscribe from this list: send the line "unsubscri
From: Fabio Estevam
We are in a context where we can sleep, and the FEC PHY reset gpio
may be on an I2C expander. Use the cansleep() variant when
setting the GPIO value.
Based on a patch from Russell King for pci-mvebu.c.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale
On Wed, Sep 30, 2015 at 5:21 AM, Neil Armstrong wrote:
> To simplify and prevent memory leakage when unbinding, use
> the devm_ memory allocation calls.
>
> Signed-off-by: Neil Armstrong
> ---
> net/dsa/dsa.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/dsa/
ta.
Does this patch help?
https://patchwork.ozlabs.org/patch/523632/
It was suggested in the following thread:
https://lkml.org/lkml/2015/9/29/258
and it seems to have fixed the performance issue.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Fabio Estevam
There is no need to have FEATURES_NEED_QUIESCE defined as we
can simply use NETIF_F_RXCSUM instead as done in other parts
of the driver.
Signed-off-by: Fabio Estevam
---
drivers/net/ethernet/freescale/fec_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Sergey Senozhatsky
> Reported-by: Richard Alpe
> Reported-by: Fabio Estevam
> Signed-off-by: David Ahern
Thanks, David. I am able to NFS boot again:
Tested-by: Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message t
On Wed, Sep 16, 2015 at 6:24 AM, Sergey Senozhatsky
wrote:
> added by b7503e0cdb5dbec5d201aa69dc14679b5ae8
>
> net: Add FIB table id to rtable
>
> Add the FIB table id to rtable to make the information available for
> IPv4 as it is for IPv6.
I see the same issue here when booting
From: Fabio Estevam
Commit a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
added a new argument to fixed_phy_register(), but missed to update bgmac
driver, causing the following build failure:
drivers/net/ethernet/broadcom/bgmac.c:1450:2: error: too few ar
From: Fabio Estevam
There is no need to use the IS_ERR_VALUE() macro for checking
the return value from pm_runtime_* functions.
Just do a simple negative test instead.
The semantic patch that makes this change is available
in scripts/coccinelle/api/pm_runtime.cocci.
Signed-off-by: Fabio
On Mon, Aug 10, 2015 at 6:39 PM, Dan Carpenter wrote:
> If register_netdev() fails we return success but we should return an
> error code instead.
>
> Reported-by: RUC_Soft_Sec
> Signed-off-by: Dan Carpenter
I have also sent a similar one:
https://patchwork.ozlabs.org/patch/505758/
--
To unsubs
If register_netdev() fails we are not propagating the error and
we return success because ax_open() succeeded previously.
Fix this by checking the return value of ax_open() and
register_netdev() and propagate the error in case of failure.
Reported-by: RUC_Soft_Sec
Signed-off-by: Fabio Estevam
Use '%zx' to print size_t format in order to fix the following build warning:
drivers/net/ethernet/mellanox/mlxsw/item.h:65:3: warning: format '%lx' expects
argument of type 'long unsigned int', but argument 6 has type 'size_t'
[-Wformat=]
Signed
fa6cd672011c755c3cd85c9ffd4e2d10a6f.
>
> Same tests was made with different versions of the Barebox bootloader and
> cable detection works flawless.
>
> Please, help to resolve issue with Linux drivers.
I tried linux-next on a imx51-babbage and could not reproduce the problem here.
st time, please do
> test and send a Tested-by:
With this version I can boot via NFS on a mx6 board:
Tested-by: Fabio Estevam
Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 104 matches
Mail list logo
