[PATCH 7/9 net-next] xfrm: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- net/xfrm/xfrm_interface.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c index eb8181987620d..8f8631eafe784 100644 --- a/net/xfrm

[PATCH 8/9 net-next] net: openvswitch: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- net/openvswitch/vport-internal_dev.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index 58a7b8312c289

[PATCH 9/9 net-next] ipv4: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- net/ipv4/ip_tunnel.c | 8 +--- net/ipv4/ip_vti.c| 9 + 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index 0c1f364044715..8b04d1dcfec4e 100644

[PATCH 6/9 net-next] ipv6: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- net/ipv6/ip6_vti.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index fac01b80a1040..5f9c4fdc120d6 100644 --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6

[PATCH 5/9 net-next] gtp: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- drivers/net/gtp.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index c09fe18c6c52d..030a1a5afe05a 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c

[PATCH 4/9 net-next] bareudp: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- drivers/net/bareudp.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 841910f1db655..ff0bea1554f9b 100644 --- a/drivers/net/bareudp.c

[PATCH 3/9 net-next] geneve: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- drivers/net/geneve.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 974a244f45ba0..d07008a818df6 100644 --- a/drivers/net/geneve.c +++ b

[PATCH 2/9 net-next] vxlan: use dev_sw_netstats_rx_add()

use new helper for netstats settings Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index be3bf233a809e..1a557aeba32b4 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net

[PATCH 1/9 net-next] net: netdevice.h: sw_netstats_rx_add helper

some drivers/network protocols update rx bytes/packets under u64_stats_update_begin/end sequence. Add a specific helper like dev_lstats_add() Signed-off-by: Fabian Frederick --- include/linux/netdevice.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/netdevice.h

[PATCH 0/9 net-next] drivers/net: add sw_netstats_rx_add helper

This small patchset creates netstats addition dev_sw_netstats_rx_add() based on dev_lstats_add() and replaces some open coding in both drivers/net and net branches. Fabian Frederick (9): net: netdevice.h: sw_netstats_rx_add helper vxlan: use dev_sw_netstats_rx_add() geneve: use

Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

> On 30/09/2020 18:29 Jakub Kicinski wrote: > > > On Wed, 30 Sep 2020 18:20:05 +0200 (CEST) Fabian Frederick wrote: > > Thanks a lot for explanations Jakub. udp_tunnel_nic.sh is a nice > > tool. Maybe it could also be used for remcsum testing ? I'd like

Re: [PATCH net-next] Revert "vxlan: move encapsulation warning"

> On 26/09/2020 03:56 Jakub Kicinski wrote: > > > This reverts commit 546c044c9651e81a16833806feff6b369bb5de33. > > Nothing prevents user from sending frames to "external" VxLAN devices. > In fact kernel itself may generate icmp chatter. > > This is fine, such frames should be dropped. > >

[PATCH V2 5/5 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH V2 2/5 net-next] vxlan: add unlikely to vxlan_remcsum check

small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/dr

[PATCH V2 4/5 net-next] vxlan: check rtnl_configure_link return code correctly

rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH V2 3/5 net-next] vxlan: move encapsulation warning

vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH V2 1/5 net-next] vxlan: don't collect metadata if remote checksum is wrong

call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH V2 0/5 net-next] vxlan: clean-up

This small patchet does some clean-up on vxlan. Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by Michal and David I hope to have some feedback/ACK from vxlan developers. Fabian Frederick (5): vxlan: don't collect metadata if remote checksum is wrong vxlan

[PATCH 1/1 nf] selftests: netfilter: add time counter check

Check packets are correctly placed in current year. Also do a NULL check for another one. Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_meta.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/netfilter

[PATCH 2/3 nf] selftests: netfilter: fix nft_meta.sh error reporting

net filter ^ Error is now correctly rendered: FAIL: oskuidcounter, want "packets 2", got table inet filter { counter oskuidcounter { packets 1 bytes 84 } } Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_meta.sh | 2 +- 1 file

[PATCH 3/3 nf] selftests: netfilter: remove unused cnt and simplify command testing

cnt was not used in nft_meta.sh This patch also fixes 2 shellcheck SC2181 warnings: "check exit code directly with e.g. 'if mycmd;', not indirectly with $?." Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_meta.sh | 6 ++ 1 file changed

[PATCH 1/3 nf] selftests: netfilter: add cpu counter check

run task on first CPU with netfilter counters reset and check cpu meta after another ping Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_meta.sh | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/testing/selftests/netfilter/nft_meta.sh b/tools

[PATCH 1/1 net-next] selftests/net: replace obsolete NFT_CHAIN configuration

Replace old parameters with global NFT_NAT from commit db8ab38880e0 ("netfilter: nf_tables: merge ipv4 and ipv6 nat chain types") Signed-off-by: Fabian Frederick --- tools/testing/selftests/net/config | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing

[PATCH 7/7 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH 6/7 net-next] vxlan: merge VXLAN_NL2FLAG use in vxlan_nl2conf()

Sort flag assignment to add readability. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e9b561b9d23e1..1501a5633a97e 100644 --- a/drivers

[PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

Replace common flag assignment with a macro. This could yet be simplified with changelink/supported but it would remove clarity Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 113 +--- include/net/vxlan.h | 10 2 files changed, 23

[PATCH 4/7 net-next] vxlan: check rtnl_configure_link return code correctly

rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH 3/7 net-next] vxlan: move encapsulation warning

vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH 2/7 net-next] vxlan: add unlikely to vxlan_remcsum check

small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/dr

[PATCH 1/7 net-next] vxlan: don't collect metadata if remote checksum is wrong

call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH V2 4/5 nf] selftests: netfilter: simplify command testing

Fix some shellcheck SC2181 warnings: "Check exit code directly with e.g. 'if mycmd;', not indirectly with $?." as suggested by Stefano Brivio. Signed-off-by: Fabian Frederick --- V2: new patch .../selftests/netfilter/nft_flowtable.sh | 34 ++- 1 file ch

[PATCH V2 5/5 nf] selftests: netfilter: add command usage

Avoid bad command arguments. Based on tools/power/cpupower/bench/cpufreq-bench_plot.sh Signed-off-by: Fabian Frederick --- V2: new patch tools/testing/selftests/netfilter/nft_flowtable.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/testing/selftests/netfilter

[PATCH V2 3/5 nf] selftests: netfilter: remove unused variable in make_file()

'who' variable was not used in make_file() Problem found using Shellcheck Signed-off-by: Fabian Frederick --- V2: new patch tools/testing/selftests/netfilter/nft_flowtable.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests

[PATCH V2 2/5 nf] selftests: netfilter: exit on invalid parameters

exit script with comments when parameters are wrong during address addition. No need for a message when trying to change MTU with lower values: output is self-explanatory. Use short testing sequence to avoid shellcheck warnings (suggested by Stefano Brivio). Signed-off-by: Fabian Frederick

[PATCH V2 1/5 nf] selftests: netfilter: fix header example

nft_flowtable.sh is made for bash not sh. Also give values which not return "RTNETLINK answers: Invalid argument" Signed-off-by: Fabian Frederick --- V2 = V1 tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/too

Re: [PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters

> On 18/08/2020 02:39 Stefano Brivio wrote: > > > Hi Fabian, > > On Fri, 14 Aug 2020 20:55:44 +0200 > Fabian Frederick wrote: > > > exit script with comments when parameters are wrong during address > > addition. No need for a message when trying

[PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters

exit script with comments when parameters are wrong during address addition. No need for a message when trying to change MTU with lower values: output is self-explanatory Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 13 + 1 file changed

[PATCH 1/2 nf] selftests: netfilter: fix header example

nft_flowtable.sh is made for bash not sh. Also give values which not return "RTNETLINK answers: Invalid argument" Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing

[PATCH 3/3 linux-next] selftests: netfilter: kill running process only

Avoid noise like the following: nft_flowtable.sh: line 250: kill: (4691) - No such process Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/netfilter

[PATCH 2/3 linux-next] selftests: netfilter: add MTU arguments to flowtables

Add some documentation, default values defined in original script and Originator/Link/Responder arguments using getopts like in tools/power/cpupower/bench/cpufreq-bench_plot.sh Signed-off-by: Fabian Frederick --- .../selftests/netfilter/nft_flowtable.sh | 30 +++ 1 file

[PATCH 1/3 linux-next] selftests: netfilter: add checktool function

avoid repeating the same test for different toolcheck Signed-off-by: Fabian Frederick --- .../selftests/netfilter/nft_flowtable.sh | 33 +++ 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing

[PATCH 1/1 linux-next] net: hns: fix typo in g_gmac_stats_string[]

s/gamc/gmac/ Signed-off-by: Fabian Frederick --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c index 1235c7f..1e1eb92

[PATCH V2 net-next] drivers/net: fix eisa_driver probe section mismatch

Some eisa_driver structures used __init probe functions which generates a warning and could crash if function is called after being deleted. Signed-off-by: Fabian Frederick --- V2: -Remove scsi occurence for net-next(suggested by David S. Miller) -Fix checkpatch warnings(space

[RFC 1/1] drivers/net: fix eisa_driver probe section mismatch

() sim710_eisa_probe() de4x5_eisa_probe() __maybe_unused: dfx_dev_register() default: advansys_eisa_probe() aic7770_probe() aha1740_probe() Signed-off-by: Fabian Frederick --- drivers/net/ethernet/3com/3c509.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 2 +- drivers/net/ethernet/dec/tulip/de4x5.c | 2

[PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

Don't opencode sg_init_one() Signed-off-by: Fabian Frederick --- net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c index b5408e8..fee3c15 100644

[PATCH V2 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick --- This is untested. V2: reorder variables (suggested by David S. Miller) net/rds/ib.h | 22 ++ 1 file

[PATCH 1/1 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick --- This is untested. net/rds/ib.h | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a

Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

> On 10 June 2015 at 22:29 Julia Lawall wrote: > > > > > On Wed, 10 Jun 2015, Fabian Frederick wrote: > > > > > > > > On 10 June 2015 at 21:52 Joe Perches wrote: > > > > > > > > > On Wed, 2015-06-10 at 18:33

Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

> On 10 June 2015 at 21:52 Joe Perches wrote: > > > On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote: > > Use kernel.h macro definition. > > > > Thanks to Julia Lawall for Coccinelle scripting support. > [] > > diff --git a/drivers/net/wir

[PATCH 1/1 linux-next] net/mlx4_core: use swap() in mlx4_make_profile()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/mellanox/mlx4/profile.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/profile.c b

[PATCH 1/1 linux-next] net/ibm/emac: use swap() in emac_make_bootlist()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/ibm/emac/core.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net

[PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet

[PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/wireless/ath/ath5k/phy.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net

[PATCH 1/1 linux-next] vxge: use swap() in vxge_hw_channel_dtr_alloc()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/neterion/vxge/vxge-traffic.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/neterion/vxge/vxge

[PATCH 1/1 linux-next] net/mlx4: use swap() in mlx4_init_qp_table()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/mellanox/mlx4/qp.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers