Re: [RFC net-next 3/3] drivers/vdpa: add NFP devices vDPA driver

2024-08-07 Thread Eugenio Perez Martin
On Fri, Aug 2, 2024 at 12:00 PM Louis Peens wrote: > > From: Kyle Xu > > Add a new kernel module ‘nfp_vdpa’ for the NFP vDPA networking driver. > > The vDPA driver initializes the necessary resources on the VF and the > data path will be offloaded. It also implements the ‘vdpa_config_ops’ > and t

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-30 Thread Eugenio Perez Martin
On Mon, Jul 29, 2024 at 2:48 PM Heng Qi wrote: > > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send v

Re: [PATCH 21/21] vdpasim: control virtqueue support

2021-01-22 Thread Eugenio Perez Martin
On Tue, Jan 12, 2021 at 4:12 AM Jason Wang wrote: > > > On 2021/1/11 下午8:26, Eli Cohen wrote: > > On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote: > >> This patch introduces the control virtqueue support for vDPA > >> simulator. This is a requirement for supporting advanced features lik

Re: [RFC PATCH 13/24] vhost-vdpa: introduce ASID based IOTLB

2020-09-29 Thread Eugenio Perez Martin
On Thu, Sep 24, 2020 at 5:24 AM Jason Wang wrote: > > This patch introduces the support of ASID based IOTLB by tagging IOTLB > with a unique ASID. This is a must for supporting ASID based vhost > IOTLB API by the following patches. > > IOTLB were stored in a hlist and new IOTLB will be allocated w

Re: [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API

2020-09-28 Thread Eugenio Perez Martin
On Thu, Sep 24, 2020 at 5:25 AM Jason Wang wrote: > > This patch extends the vhost-vdpa to support ASID based IOTLB API. The > vhost-vdpa device will allocated multple IOTLBs for vDPA device that > supports multiple address spaces. The IOTLBs and vDPA device memory > mappings is determined and mai

Re: [RFC PATCH 08/24] vdpa: introduce virtqueue groups

2020-09-28 Thread Eugenio Perez Martin
On Thu, Sep 24, 2020 at 5:23 AM Jason Wang wrote: > > This patch introduces virtqueue groups to vDPA device. The virtqueue > group is the minimal set of virtqueues that must share an address > space. And the adddress space identifier could only be attached to > a specific virtqueue group. > > A ne

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-29 Thread Eugenio Perez Martin
On Tue, Jul 21, 2020 at 4:55 AM Jason Wang wrote: > > > On 2020/7/20 下午7:16, Eugenio Pérez wrote: > > On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > >> On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > >>> On Fri, Jul 10

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-20 Thread Eugenio Perez Martin
On Mon, Jul 20, 2020 at 10:55 AM Jason Wang wrote: > > > On 2020/7/17 上午1:16, Eugenio Perez Martin wrote: > > On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > >> On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > >>>>> H

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-16 Thread Eugenio Perez Martin
On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > > On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > > > How about playing with the batch size? Make it a mod parameter instead > > > > of the hard coded 64, and

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-09 Thread Eugenio Perez Martin
On Fri, Jul 10, 2020 at 5:56 AM Jason Wang wrote: > > > On 2020/7/10 上午1:37, Michael S. Tsirkin wrote: > > On Thu, Jul 09, 2020 at 06:46:13PM +0200, Eugenio Perez Martin wrote: > >> On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > >>> > >>>

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-09 Thread Eugenio Perez Martin
On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > > > On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: > > On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > >> > >> On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: > >>> On Tue, Jun 23, 2020 at 6:15 PM

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-01 Thread Eugenio Perez Martin
On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > > > On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > > wrote: > >> On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > >>> On Mon, Jun 2

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-01 Thread Eugenio Perez Martin
On Wed, Jul 1, 2020 at 1:12 PM Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 12:43:09PM +0200, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirk

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-01 Thread Eugenio Perez Martin
On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin wrote: > > On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin > >

Re: [RFC v9 02/11] vhost: use batched get_vq_desc version

2020-06-23 Thread Eugenio Perez Martin
On Tue, Jun 23, 2020 at 4:42 PM Michael S. Tsirkin wrote: > > On Fri, Jun 19, 2020 at 08:22:53PM +0200, Eugenio Pérez wrote: > > From: "Michael S. Tsirkin" > > > > As testing shows no performance change, switch to that now. > > > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Eugenio PÃ

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-23 Thread Eugenio Perez Martin
On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > > On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Mar

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-23 Thread Eugenio Perez Martin
On Tue, Jun 23, 2020 at 10:25 AM Michael S. Tsirkin wrote: > > On Tue, Jun 23, 2020 at 09:00:57AM +0200, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > > > > > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-23 Thread Eugenio Perez Martin
On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: > >> On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: > >>>static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > >>>

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-22 Thread Eugenio Perez Martin
On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > wrote: > > > > > > On Thu, Jun 11, 2020 at 5:22 P

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-22 Thread Eugenio Perez Martin
On Mon, Jun 22, 2020 at 11:07 AM Jason Wang wrote: > > > On 2020/6/20 上午2:07, Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > wrote: > >> On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > >> wrote: > &g

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-19 Thread Eugenio Perez Martin
On Fri, Jun 19, 2020 at 8:07 PM Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > wrote: > > > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > > wrote: > > > > > > On Thu, Jun 11, 2020 at 07:34:19A

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-19 Thread Eugenio Perez Martin
On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin wrote: > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > wrote: > > > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > > As testing shows no performance change, switch to

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-19 Thread Eugenio Perez Martin
On Wed, Jun 17, 2020 at 5:19 AM Jason Wang wrote: > > > On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: > > static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > > { > > kfree(vq->descs); > > @@ -394,6 +400,9 @@ static long vhost_dev_alloc_iovecs(struct vhost_dev > > *dev) > >

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-16 Thread Eugenio Perez Martin
On Mon, Jun 15, 2020 at 6:05 PM Eugenio Pérez wrote: > > On Thu, 2020-06-11 at 07:30 -0400, Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 06:18:32PM +0200, Eugenio Perez Martin wrote: > > > On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin > > > wrote: &

Re: [PATCH RFC v8 05/11] vhost: format-independent API for used buffers

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > Add a new API that doesn't assume used ring, heads, etc. > For now, we keep the old APIs around to make it easier > to convert drivers. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 73 +

Re: [PATCH RFC v8 03/11] vhost/net: pass net specific struct pointer

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > In preparation for further cleanup, pass net specific pointer > to ubuf callbacks so we can move net specific fields > out to net structures. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/net.c | 14 +++--- > 1 f

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-15 Thread Eugenio Perez Martin
On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk wrote: > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > What kind of testing? 100GiB? Low latency? > Hi Konrad. I tested this version of the patch: htt

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:13 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 02:37:50PM +0200, Eugenio Perez Martin wrote: > > > +/* This function returns a value > 0 if a descriptor was found, or 0 if > > > none were found. > > > + *

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 5:08 PM Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2020 at 04:29:29PM +0200, Eugenio Pérez wrote: > > On Wed, 2020-06-10 at 07:36 -0400, Michael S. Tsirkin wrote: > > > As testing shows no performance change, switch to that now. > > > > > > Signed-off-by: Michael S. Tsi

Re: [PATCH RFC v7 03/14] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Wed, Jun 10, 2020 at 1:36 PM Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com > Signed-off-by: Michael S. T

Re: [PATCH RFC v6 02/11] vhost: use batched get_vq_desc version

2020-06-10 Thread Eugenio Perez Martin
On Mon, Jun 8, 2020 at 2:53 PM Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Eugenio Pérez > Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com > Signed-off-by: Michael S. Ts