Re: [PATCH] sctp: set the value of flowi6_oif to sk_bound_dev_if to make sctp_v6_get_dst to find the correct route entry.

2017-07-06 Thread Ethan Zhao
Zheng, On Thu, Jul 6, 2017 at 3:00 PM, Zheng Li wrote: > From: Zheng Li > > if there are several same route entries with different outgoing net device, > application's socket specifies the oif through setsockopt with > SO_BINDTODEVICE, sctpv6 should choose the route entry whose outgoing net > de

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva wrote: > Check return value from call

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-17 Thread ethan zhao
Alexander, On 2016/5/17 0:09, Alexander Duyck wrote: On Sun, May 15, 2016 at 7:59 PM, ethan zhao wrote: Alexander, On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Thanks for your reviewing. Ethan On 2016/5/13 20:52, Sergei Shtylyov wrote: Hello. On 5/13/2016 8:56 AM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less Performance. CPUs were assigned. especially when DCB is enabled, so we should

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-15 Thread ethan zhao
Alexander, On 2016/5/14 0:46, Alexander Duyck wrote: On Thu, May 12, 2016 at 10:56 PM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top limit, and aslo to

[PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-12 Thread Ethan Zhao
d-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 7df3fe2..1f9769c 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_m

Re: Hit regression with TCP_TW REUSE/RECYCLE

2015-11-19 Thread Ethan Zhao
Eric, On Tue, Nov 17, 2015 at 8:07 PM, Eric Dumazet wrote: > On Tue, 2015-11-17 at 14:35 +0800, Ethan Zhao wrote: >> Tested the same case with 4.4-RC1, it was fixed in 4.4-RC1. >> But don't know which commit fixed it. >> >> # echo 1024 65535 > /proc/sys/net

Re: Hit regression with TCP_TW REUSE/RECYCLE

2015-11-16 Thread Ethan Zhao
15:04:18 KST 2015 x86_64 x86_64 x86_64 GNU/Linux Thanks, Ethan On Sun, Nov 15, 2015 at 12:14 PM, Ethan Zhao wrote: > Hi, > >When we tested network with following case, found there is > regression with stable 4.1 kernel, connect() returns EADDRNOTAVAIL, > while a pretty old k

Hit regression with TCP_TW REUSE/RECYCLE

2015-11-14 Thread Ethan Zhao
Hi, When we tested network with following case, found there is regression with stable 4.1 kernel, connect() returns EADDRNOTAVAIL, while a pretty old kernel 3.8 doesn't. anybody knows about this issue and if it was fixed later ? (I am looking for devices and will do a test with the last stable