Re: some question about "/sys/class/net//operstate"

2020-11-11 Thread Erik Kline
On Wed, Nov 11, 2020 at 11:55 AM Stephen Hemminger wrote: > > On Wed, 11 Nov 2020 11:02:14 -0800 > Cong Wang wrote: > > > On Tue, Nov 10, 2020 at 8:32 PM 杜英杰 wrote: > > > > > > I want to use inotify to monitor /sys/class/net//operstate to detect > > > status of a iface in real time. > > > when

Re: [PATCH net] ipv6: set all.accept_dad to 0 by default

2017-11-13 Thread Erik Kline
avior. > > Fixes: a2d3f3e33853 ("ipv6: fix net.ipv6.conf.all.accept_dad behaviour for > real") > CC: Stefano Brivio > CC: Matteo Croce > CC: Erik Kline > Signed-off-by: Nicolas Dichtel > --- > net/ipv6/addrconf.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class

2017-11-07 Thread Erik Kline
Thanks. Signed-off-by: Erik Kline On 7 November 2017 at 16:59, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Add a per-device sysctl to specify the default traffic class to use for > kernel originated IPv6 Neighbour Discovery packets. > > Currently this includ

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-28 Thread Erik Kline
On 28 September 2017 at 13:47, Erik Kline wrote: >> Erik, please review. > > I apologize for the delay. I see that you've already applied this, and > it's mostly LGTM except I have one thing I'm not seeing clearly. > > The documentation accept_dad now claims:

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-27 Thread Erik Kline
> Erik, please review. I apologize for the delay. I see that you've already applied this, and it's mostly LGTM except I have one thing I'm not seeing clearly. The documentation accept_dad now claims: DAD operation and mode on a given interface will be selected according to the maximum v

Re: [PATCH] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-29 Thread Erik Kline
Passes my local unittest for this behaviour. Acked-by: Erik Kline

Re: [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

2016-09-29 Thread Erik Kline
Seems fine to me. Acked-by: Erik Kline

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-26 Thread Erik Kline
On 27 September 2016 at 11:23, Maciej Żenczykowski wrote: >> Given that some of this patch checks for == -1, and some of it checks >> for != 0... is it possible that setting the value to something >> unexpected like -3 will cause any issues to the stack? (Other than >> just rendering IPv6 unusable

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-26 Thread Erik Kline
ies, > }, > { > + .procname = "router_solicitation_max_interval", > + .data = &ipv6_devconf.rtr_solicit_max_interval, > + .maxlen = sizeof(int), > + .mode = 0644, > +

Re: [PATCH v4 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-26 Thread Erik Kline
On 25 September 2016 at 20:03, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This allows setting /proc/sys/net/ipv6/conf/*/router_solicitations > to -1 meaning an unlimited number of retransmits. > > Signed-off-by: Maciej Żenczykowski > --- > net/ipv6/addrconf.c | 10 ++ >

Re: [PATCH v4 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

2016-09-26 Thread Erik Kline
On 25 September 2016 at 20:03, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > replace with extra1/2 magic > > Signed-off-by: Maciej Żenczykowski > --- > net/ipv6/addrconf.c | 21 ++--- > 1 file changed, 6 insertions(+), 15 deletions(-) > > diff --git a/net/ipv6/addrc

Re: [PATCH v4 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

2016-09-26 Thread Erik Kline
} > } > > snprintf(path, sizeof(path), "net/ipv6/conf/%s", dev_name); > -- > 2.8.0.rc3.226.g39d4020 > Acked-by: Erik Kline

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-09 Thread Erik Kline
On 9 August 2016 at 14:20, David Miller wrote: > From: Lorenzo Colitti > Date: Tue, 9 Aug 2016 10:00:25 +0900 > >> Note that pretty much every sendmsg codepath allows other data to take >> precedence over sk_bound_dev_if: >> >> - udpv6_sendmsg: if sin6_scope_id specified on a scoped address >> -

Re: Add a SOCK_DESTROY operation to close sockets from userspace

2015-11-17 Thread Erik Kline
On 18 November 2015 at 12:34, Erik Kline wrote: > > > On 18 November 2015 at 12:27, Stephen Hemminger > wrote: >> >> On Wed, 18 Nov 2015 10:43:40 +0900 >> Lorenzo Colitti wrote: >> >> > This patch series adds the ability for a privileged proce

[PATCH net-next v5] ipv6: sysctl to restrict candidate source addresses

2015-07-22 Thread Erik Kline
nable this behaviour. Signed-off-by: Erik Kline --- Documentation/networking/ip-sysctl.txt | 7 +++ include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c| 22 +++--- 4 files changed, 28 insertions(+),

Re: [PATCH net-next v4] ipv6: sysctl to restrict candidate source addresses

2015-07-20 Thread Erik Kline
I thought perhaps "use_oif_addr_only" was a slightly clearer sysctl name. (Maybe it should be plural, "use_oif_addrs_only"?) On 20 July 2015 at 16:04, Erik Kline wrote: > Per RFC 6724, section 4, "Candidate Source Addresses": > > It is RECOMMENDED tha

[PATCH net-next v4] ipv6: sysctl to restrict candidate source addresses

2015-07-20 Thread Erik Kline
nable this behaviour. Signed-off-by: Erik Kline --- Documentation/networking/ip-sysctl.txt | 7 +++ include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c| 22 +++--- 4 files changed, 28 insertions(+),

[PATCH net-next v3] ipv6: sysctl to restrict candidate source addresses

2015-07-16 Thread Erik Kline
nable this behaviour. Signed-off-by: Erik Kline --- Documentation/networking/ip-sysctl.txt | 7 +++ include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c| 22 +++--- 4 files changed, 28 insertions(+),

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-15 Thread Erik Kline
And I now have a use_oif_addr sysctl patch that, on top if this one, passes all my tests. On 15 July 2015 at 18:15, Erik Kline wrote: > All my tests pass with this applied to net-next/master. > > Many thanks! > > Acked-by: Erik Kline > > On 13 July 2015 at 23:28, YOSHIFUJI

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-15 Thread Erik Kline
All my tests pass with this applied to net-next/master. Many thanks! Acked-by: Erik Kline On 13 July 2015 at 23:28, YOSHIFUJI Hideaki/吉藤英明 wrote: > Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when > finding source address on specific interface.") did not proper

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-13 Thread Erik Kline
On 13 July 2015 at 15:32, YOSHIFUJI Hideaki wrote: > Hi, > > Erik Kline wrote: >> Hmm, when I run a UML linux with this patch (which, I'm ashamed to >> say, I failed to do before) I get these kinds of errors: >> >> unregister_netdevice: waiting f

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-11 Thread Erik Kline
enough to iterate >> over that given interface only. >> >> Signed-off-by: YOSHIFUJI Hideaki >> Acked-by: Erik Kline > > Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-10 Thread Erik Kline
* are sorted by their scope > -* values. > -*/ > - goto try_nextdev; > - } > -

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-08 Thread Erik Kline
> I really would like to come up with a sane works-always behavior for > this, but besides doing a retry on the complete source address selection > algorithm I currently cannot come up with an idea. > > Maybe we can tweak saddr_eval a bit. I think it all comes down to this: source address selectio

Re: [PATCH net-next] ipv6: sysctl to restrict candidate source addresses

2015-07-05 Thread Erik Kline
Reworked with "use_oif_addr". Thanks, -Erik On 3 July 2015 at 16:03, YOSHIFUJI Hideaki wrote: > Hi, > > Erik Kline wrote: >> Per RFC 6724, section 4, "Candidate Source Addresses": >> >> It is RECOMMENDED that the candidate source addresses be

[PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-05 Thread Erik Kline
nable this behaviour. Signed-off-by: Erik Kline --- Documentation/networking/ip-sysctl.txt | 7 +++ include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c| 30 +- 4 files changed, 34 insert

[PATCH net-next] ipv6: sysctl to restrict candidate source addresses

2015-07-02 Thread Erik Kline
nable this behaviour. Signed-off-by: Erik Kline --- Documentation/networking/ip-sysctl.txt | 12 include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf.c| 30 +- 4 files changed,

Re: [PATCH net-next] Better handling of transition to NUD_PROBE state

2015-05-21 Thread Erik Kline
> Please, in the future, put a proper subsystem prefix in the Subject > line of your patch submissions. In this particular case "neigh: " > would have been appropriate and is what I added when applying your > patch. My apologies. > Applied, thanks. Appreciated. -ek -- To unsubscribe from this l