Re: [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()

2021-02-23 Thread Enrico Weigelt, metux IT consult
On 17.02.21 14:50, Andy Shevchenko wrote: On Wed, Feb 17, 2021 at 01:15:43PM +0100, Enrico Weigelt, metux IT consult wrote: Under rare circumstances it may happen that a device node's name is NULL (most likely kernel bug in some other place). What circumstances? How can I reproduce

Re: [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()

2021-02-23 Thread Enrico Weigelt, metux IT consult
em anyway. And it is better to avoid recursion in this path. thx, going to use it in v2. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux I

[PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()

2021-02-17 Thread Enrico Weigelt, metux IT consult
t out an extra warning. Signed-off-by: Enrico Weigelt, metux IT consult --- lib/vsprintf.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 3b53c73580c5..050a60b88073 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -2013,6 +2013,10 @@

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-08 Thread Enrico Weigelt, metux IT consult
I'll rebase my patch queue when this patch went through. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Li

[PATCH] net: 8021q: vlan: reduce noise in driver initialization

2020-12-08 Thread Enrico Weigelt, metux IT consult
If drivers work properly, they should be silent. Thus remove the unncessary noise von initialization. Signed-off-by: Enrico Weigelt, metux IT consult --- net/8021q/vlan.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..9f4b1b9a37e4

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-07 Thread Enrico Weigelt, metux IT consult
- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

[PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters. And the code has received lots of changes, without the version ever been touched (remained constant since landing in the mainline tree), so it doesn't seem to have any prac

[PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code received lots of changes, but module version remained constant, since the driver landed in mainline. So, this version doesn't seem have any practical meaning anymore

[PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The drivers have received lots of changes, without the module version (or the underlying DRV_VERSION macro) ever changed, since the code landed in the kernel tree. So, it do

[PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any pratical purpose. The code received lots of huge changes, but module version remained constant, since it landed in mainline tree, back 11 years go. Unmaintained version numbers aren't actually useful. For in-tree drivers, the kernel version re

[PATCH 08/11] drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters most. The driver received lots of changes, while module version remained constant, since it landed in mainline, back 7 years ago. Signed-off-by: Enrico Weigelt --- driver

[PATCH 06/11] drivers: staging: qlge: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version really matters. The module version doesn't seem to be maintained and having much practical meaning anymore. Signed-off-by: Enrico Weigelt --- drivers/staging/qlge/qlge_main.c | 1 -

[PATCH 09/11] drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose: the driver has received lots of changes, while the module version remained constant. Unmaintained version numbers aren't actually useful. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1

[PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose. For in-kernel drivers, the kernel version matters. The driver received lots of changes, but version number has remained the same since it's introducing into mainline, seven years ago. So, it doesn't seem to have much practi

[PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. The driver received lots of changes, but module remained constant since it landed in mainline, several years ago. Signed-off-by: Enrico Weigelt --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 del

[PATCH 07/11] drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose. For in-tree drivers, the kernel version really matters. OTOH, the module version doesn't seem to be actively maintained - the code received changes while the version remained constant. Signed-off-by: Enrico Weigelt --- dr

[PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call

2020-12-03 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code has received lots of changes, w/o the versions being actively maintained, so it doesn't seem to have much practical meaning. Signed-off-by: Enrico Weigelt --- dri

[PATCH v2 1/2] x86: make VMware support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from VMware support, for minimized kernels that never will be run under Vmware (eg. high-density virtualization or embedded systems). Average distro kernel will leave it on, therefore default to y. Signed-off-by: Enrico Weigelt --- arch/x86/Kconfig |

[PATCH v2 2/2] x86: make Hyper-V support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from Hyper-V support, for minimized kernels that never will by run under Hyper-V. (eg. high-density virtualization or embedded systems) Average distro kernel will leave it on, therefore default to y. Signed-off-by: Enrico Weigelt --- arch/x86/Kconfig

Re: [PATCH 1/2] x86: make vmware support optional

2020-12-02 Thread Enrico Weigelt, metux IT consult
On 17.11.20 21:31, Borislav Petkov wrote: > On Tue, Nov 17, 2020 at 09:23:07PM +0100, Enrico Weigelt, metux IT consult > wrote: >> Make it possible to opt-out from vmware support > > Why? Reducing the kernel size. Think of very high density virtualization (w/ specially strip

[PATCH 6/7] net: vmw_vsock: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/vmw_vsock/af_vsock.c | 1 - net/vmw_vsock/hyperv_transport.c | 1 - net/vmw_vsock/vmci_transport.c | 1 - 3 files chang

[PATCH 3/7] net: ipv4: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt --- net/ipv4/tcp_cubic.c| 1 - net/ipv4/tcp_illinois.c | 1 - net/ipv4/tcp_nv.c | 1 - 3 files changed, 3 deletions(-) diff --git a/net/ipv4/tcp_cubic

[PATCH 5/7] net: bridge: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bridge/br.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/br.c b/net/bridge/br.c index 401eeb9142eb..2502fdc

[PATCH 7/7] net: tipc: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/tipc/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/core.c b/net/tipc/core.c index c2ff42900b53..8c0c453

[PATCH 4/7] net: bluetooth: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bluetooth/6lowpan.c | 3 --- net/bluetooth/af_bluetooth.c | 1 - net/bluetooth/bnep/core.c| 1 - net/bluetooth/cmtp/c

[PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/batman-adv/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 70fee9b

[PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/8021q/vlan.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c

[PATCH] net: 8021q: use netdev_info() instead of pr_info()

2020-12-02 Thread Enrico Weigelt, metux IT consult
Use netdev_info() instead of pr_info() for more consistent log output. Signed-off-by: Enrico Weigelt --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..d3a6f4ffdaef 100644 --- a/net/8021q/vlan.c +++

[PATCH 2/2] x86: make hyperv support optional

2020-11-17 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from hyperv support. Signed-off-by: Enrico Weigelt, metux IT consult --- arch/x86/Kconfig | 7 +++ arch/x86/kernel/cpu/Makefile | 4 ++-- arch/x86/kernel/cpu/hypervisor.c | 2 ++ drivers/hv/Kconfig | 2 +- 4 files changed, 12

[PATCH 1/2] x86: make vmware support optional

2020-11-17 Thread Enrico Weigelt, metux IT consult
Make it possible to opt-out from vmware support Signed-off-by: Enrico Weigelt, metux IT consult --- arch/x86/Kconfig | 7 +++ arch/x86/kernel/cpu/Makefile | 4 +++- arch/x86/kernel/cpu/hypervisor.c | 2 ++ drivers/input/mouse/Kconfig | 2 +- drivers/misc/Kconfig

[PATCH 2/2] x86: make hyperv support optional

2020-11-17 Thread Enrico Weigelt, metux IT consult
--- arch/x86/Kconfig | 7 +++ arch/x86/kernel/cpu/Makefile | 4 ++-- arch/x86/kernel/cpu/hypervisor.c | 2 ++ drivers/hv/Kconfig | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index c227c1fa0091..60a

[PATCH 1/2] x86: make vmware support optional

2020-11-17 Thread Enrico Weigelt, metux IT consult
--- arch/x86/Kconfig | 7 +++ arch/x86/kernel/cpu/Makefile | 4 +++- arch/x86/kernel/cpu/hypervisor.c | 2 ++ drivers/input/mouse/Kconfig | 2 +- drivers/misc/Kconfig | 2 +- drivers/ptp/Kconfig | 2 +- 6 files changed, 15 insertions(+), 4 dele

[PATCH] lib: compile memcat_p only when needed

2020-11-17 Thread Enrico Weigelt, metux IT consult
The library function memcat_p() is currently used only once. (drivers/hwtracing/stm). So, often completely unused. Reducing the kernel size by about 4k by compiling it conditionally, only when needed. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/hwtracing/stm/Kconfig | 1 + lib