On 17/11/2015 15:57, Eric Dumazet wrote:
> Instead of having to implement complex ndo_busy_poll() method,
> drivers can simply rely on NAPI poll logic.
I really like where you are going with this series.
...
> We could go one step further, and make busy polling
> available for all NAPI drivers,
> > Doesn't this mean that ethtool -p will hold the RTNL lock forever?
> > Is this a good idea?
> >
> > For example on the Red Hat machine I have here if you do:
> >
> > ethtool -p eth2 10 &
> > reboot
> >
> > Various things the shutdown scripts try to do will fail because of the
> > held RT
[BNX2X]: update version
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index 2db0427..6db4805 100644
--- a/drivers/net/bnx2x.c
+++ b/drivers/net/b
[BNX2X]: HW attention and error handling - many fixes, sometimes improperly
acked HW attentions could cause lockup.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 229 +--
1 files changed, 150 insertions(
[BNX2X]: fix stats - rx errors were summed improperly, some were missing
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 164 +--
drivers/net/bnx2x.h |4 +-
2 files changed, 83 insertions(+), 85 deletions(-)
[BNX2X]: correct rx filtering (client-config)
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 165 ---
drivers/net/bnx2x.h |5 +-
2 files changed, 92 insertions(+), 78 deletions(-)
diff --git a/drivers/net/bnx
Dave,
Here are just the bug fixes out of the previous update.
Please apply to 2.6.25
1 Spelling fixes
2 Fix bnx2x_init_one() - was printing wrong PCI-E info, failed to release
netdev in one case.
3 Link mgmt and BC bugs - many link cfg fixes
The move to boot code 4.2.0 is mandatory sinc
[BNX2X]: fix bnx2x_init_one() - was printing wrong PCI-E info, failed to
release netdev in one case.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 41 ++---
drivers/net/bnx2x.h |5 +
2 files changed, 31 insertions(
[BNX2X]: add bnx2x to MAINTAINERS
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36c7bc6..38f5744 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -982,6 +982,1
[BNX2X]: fixed slowpath races - fixed up/down racing with timer and fastpath.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 213 ---
drivers/net/bnx2x.h |3 -
2 files changed, 116 insertions(+), 100 del
[BNX2X]: Tx fixes - fix several bugs in start_xmit
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 12 +++-
drivers/net/bnx2x.h |3 +++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index d
[BNX2X]: workaround PCI queue overflow - limit traffic through an internal
queue to prevent overflow.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_in
[BNX2X]: MSI-X / INT#A errata - workaround for a HW bug when moving from MSI-X
to INT#A without a reboot
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/net/b
[BNX2X]: Spelling fixes
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 119 +++---
drivers/net/bnx2x.h |2 +-
2 files changed, 56 insertions(+), 65 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/b
> > This patch-set updates several sections of the bnx2x driver.
>
> It is not appropriate to be adding features at this time
> to the 2.6.25 tree.
>
> Please wait for the opportunity to submit 2.6.26 bound
> patches for new features.
>
> I encourage you to split out just the bug fixes from thi
On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Fri, 22 Feb 2008 11:16:42 -0800
>
> > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
> > > When asked to blink LEDs the tg3 driver behaves when using:
> > > ethtool -p ethX
> >
> > This patch-set updates several sections of the bnx2x driver.
>
> It is not appropriate to be adding features at this time
> to the 2.6.25 tree.
>
> Please wait for the opportunity to submit 2.6.26 bound
> patches for new features.
>
> I encourage you to split out just the bug fixes from this
[BNX2X]: fix spelling, some fashion policework, report PCI link
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 272 ++-
drivers/net/bnx2x.h |7 +-
2 files changed, 121 insertions(+), 158 deletions(-)
diff -
[BNX2X]: Fix FW client config and assert printing
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 308 +++---
drivers/net/bnx2x.h | 11 +-
2 files changed, 170 insertions(+), 149 deletions(-)
diff --git a/drive
[BNX2X]: rework slowpath and hw attentions
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 466 +++
drivers/net/bnx2x.h |3 -
drivers/net/bnx2x_fw_defs.h |7 +-
3 files changed, 294 insertions(+
[BNX2X]: Xmit rework, add TSO6 and CSUM_HW support
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 307 +++---
drivers/net/bnx2x.h | 18 +++
2 files changed, 208 insertions(+), 117 deletions(-)
diff --git a/drive
[BNX2X]: add to MAINTAINERS
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6680ec4..da69429 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -982,6 +982,12 @@ M:
[BNX2X]: update version to 1.42.2
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index a213d67..fe96605 100644
--- a/drivers/net/bnx2x.c
+++ b/d
Hello All,
This patch-set updates several sections of the bnx2x driver.
Patches 2-4 are a set that should not be applied partially.
1: fix spelling, some fashion policework, report PCI link
Spelling corrections, style fixes and properly report the PCI link speed
Many Thanks to Stephen Hemminger
[BNX2X]: workaround for a PCI core bug
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h
index 04f93bf..dcaecc5 100644
ned-off-by: Lee Schermerhorn <[EMAIL PROTECTED]>
Acked-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 5bafb30..b9d7f5b 100644
--- a/drivers/net/Kco
I will resend it in a moment.
Thanks,
Eliezer
On Wed, 2007-12-05 at 05:44 -0800, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Wed, 05 Dec 2007 15:40:15 +0200
>
> > Dave,
> >
> > Lee Schermerhorn sent this patch while yo
IB_INFLATE has not been selected manually
or by building another module that automatically selects it.
Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2
and others. This seems to fix it.
Signed-off-by: Lee Schermerhorn <[EMAIL PROTECTED]>
Acked-by: Eliezer Tamir <[EMAI
selected manually
> or by building another module that automatically selects it.
>
> Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2
> and others. This seems to fix it.
>
> Signed-off-by: Lee Schermerhorn <[EMAIL PROTECTED]>
You are right.
My mi
Stephen,
Thank you for taking the time to go over this.
Stephen Hemminger wrote:
1. Please use dev_err() to help user figure out which board has problem:
OK
2. Use new MAC_ADDR() rather than
OK
3. The reset task logic needs more cleanup/protection.
OK
4. Rather than hard coding mac add
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
* Based on code from Michael Chan's bnx2 driver
*/
#ifndef BNX2X_H
#define BNX2X_H
/* error/debug prints */
#define DRV_MODULE_NAME "bnx2x"
#define PFX DRV_MODULE_NAME ": "
/* for
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
*/
#ifndef BNX2X_INIT_H
#define BNX2X_INIT_H
#define COMMON 0x1
#define PORT0 0x2
#define PORT1 0x4
#define INIT_EMULATION
Dave,
Here is the latest version for bnx2x.
Please consider applying to 2.6.25.
This patch also applies cleanly to net-2.6 for anyone that would like to
test it.
Major changes from last post.
* parts of the slowpath have been re-factored.
* slowpath task now runs in work queue context,
which
posting individual files for comments.
---
/* bnx2x_fw_defs.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Fr
On Fri, 2007-11-02 at 16:35 -0700, Max Asbock wrote:
> I built the newest bnx2x code against the net-2.6 kernel and ran a
> number of stress tests with netperf and pktgen. I did not encounter
> any
> errors.
>
> Max
>
>
Thanks,
Eliezer
-
To unsubscribe from this list: send the line "unsubscri
On Thu, 2007-11-01 at 02:56 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Thu, 01 Nov 2007 11:56:17 +0200
>
> > posting individual files for comments.
> >
> > ---
> > #ifndef __BNX2X_NEW_INIT_H__
> > #define
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
*/
#ifndef EVEREST_INIT_FUNCTIONS_H
#define EVEREST_INIT_FUNCTIONS_H
#define COMMON 0x1
#define PORT0 0x2
#define PORT1 0x4
#
posting individual files for comments.
---
/* bnx2x_fw_defs.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Fr
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
* Based on code from Michael Chan's bnx2 driver
*/
#ifndef BNX2X_H
#define BNX2X_H
/* error/debug prints */
#define DRV_MODULE_NAME "bnx2x"
#define PFX DRV_MODULE_NAME ": "
/* for
On Thu, 2007-11-01 at 02:28 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Thu, 01 Nov 2007 11:28:25 +0200
>
> > Here is the version with added register comments.
> > Please consider applying.
>
> The 2.6.24 merge w
Dave,
Here is the version with added register comments.
Please consider applying.
ftp link:
ftp://[EMAIL PROTECTED]/0001-bnx2x-0.4.12-with-reg-remarks.txt
gzipped:
ftp://[EMAIL PROTECTED]/0001-bnx2x-0.4.12-with-reg-remarks.txt.gz
(I will also post each individual file for review as a reply to t
(Sorry It took so long to answer, I've had to go over a lot of stuff to
make sure I'm giving you accurate answers.)
On Mon, 2007-10-29 at 01:39 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Sun, 28 Oct 2007 22:21:14 +0200
>
Dave,
Please take a look and tell me if this is better than the last attempt.
Main changes:
* Rewrite of the init code:
1. Full rewrite of the generated code into something easier to read.
2. Removed zeroes by adding a zero command.
3. Big chucks of data are read by the
On Tue, 2007-10-16 at 16:49 -0700, David Miller wrote:
> From: Max Asbock <[EMAIL PROTECTED]>
> Date: Tue, 16 Oct 2007 16:34:40 -0700
>
> > I tested the bnx2x driver (0001-BNX2X-0.40.10a-net-2.6.24.patch)
> with
> > netdev-2.6.24 git tree and found that I can reproducibly panic the
> > system when
On Mon, 2007-10-15 at 12:38 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Mon, 15 Oct 2007 17:27:29 +0200
>
> > Unfortunately, the firmware code is different for LE and BE machines.
> > We had issues with the BE firmware that
On Mon, 2007-10-15 at 18:05 +0200, Andi Kleen wrote:
> > This is not a driver issue.
> > Unfortunately, the firmware code is different for LE and BE machines.
> > We had issues with the BE firmware that appear to be resolved.
> > Hopefully, the next version will have both.
>
> If the firmware is b
On Fri, 2007-10-12 at 15:03 -0700, David Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Fri, 12 Oct 2007 16:47:28 +0200
>
> > "Eliezer Tamir" <[EMAIL PROTECTED]> writes:
> >
> >
> > > * For now depend on x86 or x86_64, wil
On Wed, 2007-10-10 at 17:59 -0700, David Miller wrote:
...
> I was going to add this to the tree for 2.6.24 but there is simply
> too much super-ugly stuff in this driver for me to do so.
We will rewrite bnx2x_hsi.h bnx2x_init.h and bnx2x_init_vlaues.h.
Does bnx2x_asm.h look OK?
> Look, there
On Wed, 2007-10-10 at 18:54 -0700, Stephen Hemminger wrote:
> Please fix these...
>
Thanks,
All that code is going to be rewritten, as per Dave's request,
but I will make sure to test the new code with sparse.
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
[added Andy Whitcroft, who is listed as a CHECKPATCH maintainer]
Stephen Hemminger wrote:
Minor formatting nits reported by checkpatch.pl script:
Thanks, I Will fix them.
...
WARNING: no space between function name and open parenthesis '('
#777: FILE: drivers/net/bnx2x.c:722:
+ case
Eliezer Tamir wrote:
The full patch is available at:
[EMAIL PROTECTED]://ftp1.broadcom.com/0001-BNX2X-0.40.10a-net-2.6.24.patch
Just when I thought I have beaten the line beast.
(or maybe it's just too much work and not enough sleep.)
the right links are of course:
ftp://[EMAIL PROT
On Mon, 2007-10-08 at 21:29 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Tue, 09 Oct 2007 06:13:23 +0200
>
> > Due to the size of the patch I can not post it to the list.
>
> Understood
>
> > Here is an FTP link.
David Miller wrote:
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:15:17 +0200
Add bnx2x to Kconfig and Makefile
In a patch submission, the tree should build on every step along the
way in applying your patches, with any given configuration.
Here, the us
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> On Mon, 08 Oct 2007 20:34:41 +0200
> "Eliezer" <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote:
> >
> > >
> > > Looks good. Some minor stuff:
> > > * You can use network device stats in net
Here are FTP links.
All the parts in a zipped tar.
ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24.tgz
One big patch.
ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24-one.patch.txt
I noticed that the big microcode files did not seem to get through to netdev,
so here they are:
ftp://[EMAIL PROT
bnx2x_init.h - code that does chip init
From 8ef995a3102800d70b677aefb6e769c0d36e178c Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:17 +0200
Subject: [PATCH 5/8] add bnx2x_init.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
bnx2x.h - main .h file
From c32bf79956add229de2e4b81a848fad0e503d3d0 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:14 +0200
Subject: [PATCH 3/8] add bnx2x.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bn
[sorry for the mess. resubmitting, this time using attachments, if this
does not work I'm going to go nuts.]
This is an initial version of the BNX2X, the Linux driver for the
BCM5771X 10Gb Ethernet controller family.
Although the chip is very different from the 5706-8 family we based the
driver
Add bnx2x to Kconfig and Makefile
From 94bf385550356534e6dd41ce61879608a63ed972 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:48:10 +0200
Subject: [PATCH 1/8] add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL
bnx2x_self_test.h - machine generated self test, plus the code that
reports HW/FW/BC asserts
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_self_test.h | 1387
+
1 files changed, 1387 insertions(+), 0 deletions(-)
diff -
bnx2x_init.h - code that does chip init
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 555
++
1 files changed, 555 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init
bnx2x.h - main .h file
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.h | 997
+++
1 files changed, 997 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h
new file mode 100644
Add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |9 +
drivers/net/Makefile |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9c635a2..1d44a5e 100644
[resubmitting, this time without line breaks, sorry]
This is an initial version of the BNX2X, the Linux driver for the
BCM5771X 10Gb Ethernet controller family.
Although the chip is very different from the 5706-8 family we based the
driver code on the BNX2 driver.
Since the hardware is supposed
Matti Aarnio wrote:
Your patch-posting procedure is yet in a bit problem state..
+{
+static const u32 EVST_TSEM_FAST_MEMORY_COMMON_MEMORY_INIT_EMULATION_7[] = {
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x
bnx2x_self_test.h
This file contains a self-test derived from HW specs, and the code that
prints HW/FW/BC assert codes.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x_self_test.h | 1387
++
bnx2x_init.h - Various bits of init code.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x_init.h | 555
++
1 files changed, 555 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bn
bnx2x.h - main .h file
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x.h | 997
+++
1 files changed, 997 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x.h b/drivers/net
Add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |9 +
drivers/net/Makefile |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 467532c..fbb69ac 100644
This is an initial version of the BNX2X, the Linux driver for the
BCM5771X 10Gb Ethernet controller family.
Although the chip is very different from the 5706-8 family we based the
driver code on the BNX2 driver.
Since the hardware is supposed to be generally available soon I have
posted an initi
Jeff, Roland,
Thanks for taking a look.
Jeff Garzik wrote:
Roland Dreier wrote:
> > +{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710,
> > +PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 },
FWIW, this could be neater as
{ PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 }
OK
Michal,
Thanks for going over the code.
My responses are inline.
Eliezer
Michael Buesch wrote:
On Wednesday 01 August 2007 10:31:17 Michael Chan wrote:
+typedef struct {
+ u8 reserved[64];
+} license_key_t;
No typedef.
What is a "license key" used for, anyway?
This will be removed.
72 matches
Mail list logo