poll.
On another note, any thoughts about unifying poll_controller with
regular poll?
cheers,
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Doesn't this mean that ethtool -p will hold the RTNL lock forever?
> > Is this a good idea?
> >
> > For example on the Red Hat machine I have here if you do:
> >
> > ethtool -p eth2 10 &
> > reboot
> >
> > Various things the shutdown scripts try to do will fail because of the
> > held RT
[BNX2X]: update version
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index 2db0427..6db4805 100644
--- a/drivers/net/bnx2x.c
+++ b/drivers/net/b
[BNX2X]: HW attention and error handling - many fixes, sometimes improperly
acked HW attentions could cause lockup.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 229 +--
1 files changed, 150 insertions(
[BNX2X]: fix stats - rx errors were summed improperly, some were missing
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 164 +--
drivers/net/bnx2x.h |4 +-
2 files changed, 83 insertions(+), 85 deletions(-)
[BNX2X]: correct rx filtering (client-config)
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 165 ---
drivers/net/bnx2x.h |5 +-
2 files changed, 92 insertions(+), 78 deletions(-)
diff --git a/drivers/net/bnx
- fixed up/down racing with timer and fastpath.
9 Tx fixes - fix several bugs in start_xmit (the shiny new rewrite will wait
for 2.6.26)
10 Update version
11 Add bnx2x to MAINTAINERS
Thanks
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
[BNX2X]: fix bnx2x_init_one() - was printing wrong PCI-E info, failed to
release netdev in one case.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 41 ++---
drivers/net/bnx2x.h |5 +
2 files changed, 31 insertions(
[BNX2X]: add bnx2x to MAINTAINERS
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 36c7bc6..38f5744 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -982,6 +982,1
[BNX2X]: fixed slowpath races - fixed up/down racing with timer and fastpath.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 213 ---
drivers/net/bnx2x.h |3 -
2 files changed, 116 insertions(+), 100 del
[BNX2X]: Tx fixes - fix several bugs in start_xmit
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 12 +++-
drivers/net/bnx2x.h |3 +++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index d
[BNX2X]: workaround PCI queue overflow - limit traffic through an internal
queue to prevent overflow.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_in
[BNX2X]: MSI-X / INT#A errata - workaround for a HW bug when moving from MSI-X
to INT#A without a reboot
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/net/b
[BNX2X]: Spelling fixes
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 119 +++---
drivers/net/bnx2x.h |2 +-
2 files changed, 56 insertions(+), 65 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/b
it out just the bug fixes from this
> series and resubmit, thank you.
>
I will resubmit the bug fixes only.
Can I keep the spelling fixes in?
Thanks
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More major
amp;
reboot
Various things the shutdown scripts try to do will fail because of the
held RTNL lock. in the end the script dies and the machine does not
reboot.
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
it out just the bug fixes from this
> series and resubmit, thank you.
The only patch that adds new features is number 6.
If you are willing to accept the spelling corrections, even though
technically, they are not bugfixes, you can apply all the others and I
will resubmit patch 6 when the time is
[BNX2X]: fix spelling, some fashion policework, report PCI link
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 272 ++-
drivers/net/bnx2x.h |7 +-
2 files changed, 121 insertions(+), 158 deletions(-)
diff -
[BNX2X]: Fix FW client config and assert printing
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 308 +++---
drivers/net/bnx2x.h | 11 +-
2 files changed, 170 insertions(+), 149 deletions(-)
diff --git a/drive
[BNX2X]: rework slowpath and hw attentions
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 466 +++
drivers/net/bnx2x.h |3 -
drivers/net/bnx2x_fw_defs.h |7 +-
3 files changed, 294 insertions(+
[BNX2X]: Xmit rework, add TSO6 and CSUM_HW support
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c | 307 +++---
drivers/net/bnx2x.h | 18 +++
2 files changed, 208 insertions(+), 117 deletions(-)
diff --git a/drive
[BNX2X]: add to MAINTAINERS
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6680ec4..da69429 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -982,6 +982,12 @@ M:
[BNX2X]: update version to 1.42.2
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x.c b/drivers/net/bnx2x.c
index a213d67..fe96605 100644
--- a/drivers/net/bnx2x.c
+++ b/d
Xmit code, I hope that it is now clearer, this rework was
needed in order to add IPv6 CSUM and TSO.
7: update version to 1.42.2
8: add to MAINTAINERS
(So Michael stops getting complaints about my bugs)
Thanks
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev&qu
[BNX2X]: workaround for a PCI core bug
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h
index 04f93bf..dcaecc5 100644
ned-off-by: Lee Schermerhorn <[EMAIL PROTECTED]>
Acked-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 5bafb30..b9d7f5b 100644
--- a/drivers/net/Kco
I will resend it in a moment.
Thanks,
Eliezer
On Wed, 2007-12-05 at 05:44 -0800, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Wed, 05 Dec 2007 15:40:15 +0200
>
> > Dave,
> >
> > Lee Schermerhorn sent this patch while yo
Dave,
Lee Schermerhorn sent this patch while you were away,
please apply.
Thanks,
Eliezer
Forwarded Message
From: Lee Schermerhorn <[EMAIL PROTECTED]>
To: Andrew Morton <[EMAIL PROTECTED]>, netdev@vger.kernel.org,
linux-kernel <[EMAIL PROTECTED]>
Subject: PA
selected manually
> or by building another module that automatically selects it.
>
> Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2
> and others. This seems to fix it.
>
> Signed-off-by: Lee Schermerhorn <[EMAIL PROTECTED]>
You are right.
My mi
o this will only happen
early next week.
Thanks,
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
* Based on code from Michael Chan's bnx2 driver
*/
#ifndef BNX2X_H
#define BNX2X_H
/* error/debug prints */
#define DRV_MODULE_NAME "bnx2x"
#define PFX DRV_MODULE_NAME ": "
/* for
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
*/
#ifndef BNX2X_INIT_H
#define BNX2X_INIT_H
#define COMMON 0x1
#define PORT0 0x2
#define PORT1 0x4
#define INIT_EMULATION
allowed us to replace the mdelays with msleeps.
ftp link
ftp://[EMAIL PROTECTED]/0001-add-bnx2x-driver-for-BCM57710.patch
gzipped
ftp://[EMAIL PROTECTED]/0001-add-bnx2x-driver-for-BCM57710.patch.gz
I will also post individual files for review as replies to this post.
Thanks,
Eliezer
-
To
posting individual files for comments.
---
/* bnx2x_fw_defs.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Fr
On Fri, 2007-11-02 at 16:35 -0700, Max Asbock wrote:
> I built the newest bnx2x code against the net-2.6 kernel and ran a
> number of stress tests with netperf and pktgen. I did not encounter
> any
> errors.
>
> Max
>
>
Thanks,
Eliezer
-
To unsubscribe from
On Thu, 2007-11-01 at 02:56 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Thu, 01 Nov 2007 11:56:17 +0200
>
> > posting individual files for comments.
> >
> > ---
> > #ifndef __BNX2X_NEW_INIT_H__
> > #define
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
*/
#ifndef EVEREST_INIT_FUNCTIONS_H
#define EVEREST_INIT_FUNCTIONS_H
#define COMMON 0x1
#define PORT0 0x2
#define PORT1 0x4
#
posting individual files for comments.
---
/* bnx2x_fw_defs.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Fr
Software Foundation.
*
* Written by: Eliezer Tamir <[EMAIL PROTECTED]>
* Based on code from Michael Chan's bnx2 driver
*/
#ifndef BNX2X_H
#define BNX2X_H
/* error/debug prints */
#define DRV_MODULE_NAME "bnx2x"
#define PFX DRV_MODULE_NAME ": "
/* for
On Thu, 2007-11-01 at 02:28 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Thu, 01 Nov 2007 11:28:25 +0200
>
> > Here is the version with added register comments.
> > Please consider applying.
>
> The 2.6.24 merge w
this
email)
Thanks,
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(Sorry It took so long to answer, I've had to go over a lot of stuff to
make sure I'm giving you accurate answers.)
On Mon, 2007-10-29 at 01:39 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Sun, 28 Oct 2007 22:21:14 +0200
>
for review)
Thanks
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
;poll() which is >= budget, which is illegal.
>
> We had to fix a similar bug in the tg3 and bnx2 drivers, the same
> logic probably just propagated itself into bnx2x.
I think that this will fix the bug.
This is a diff against 0.40.10a.
I hope to get a new version out soon, once we
On Mon, 2007-10-15 at 12:38 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Mon, 15 Oct 2007 17:27:29 +0200
>
> > Unfortunately, the firmware code is different for LE and BE machines.
> > We had issues with the BE firmware that
On Mon, 2007-10-15 at 18:05 +0200, Andi Kleen wrote:
> > This is not a driver issue.
> > Unfortunately, the firmware code is different for LE and BE machines.
> > We had issues with the BE firmware that appear to be resolved.
> > Hopefully, the next version will have both.
>
> If the firmware is b
On Fri, 2007-10-12 at 15:03 -0700, David Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Fri, 12 Oct 2007 16:47:28 +0200
>
> > "Eliezer Tamir" <[EMAIL PROTECTED]> writes:
> >
> >
> > > * For now depend on x86 or x86_64, wil
e can maintain them
better manually. (I'm asking what is the upper bound to the number of
header files you would consider reasonable for this driver.)
Thanks
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
On Wed, 2007-10-10 at 18:54 -0700, Stephen Hemminger wrote:
> Please fix these...
>
Thanks,
All that code is going to be rewritten, as per Dave's request,
but I will make sure to test the new code with sparse.
Eliezer
-
To unsubscribe from this list: send the line "unsubs
in parenthesis
#21196: FILE: drivers/net/bnx2x_init.h:138:
+#define INIT_INTERNAL0_MEM_WR(block_bar, block, reg, \
+ part, hw, value, off, len) \
Not sure, I think this one is too, but I'm going to rewrite bnx2x_init.h anyway,
this code is going away.
...
Than
Eliezer Tamir wrote:
The full patch is available at:
[EMAIL PROTECTED]://ftp1.broadcom.com/0001-BNX2X-0.40.10a-net-2.6.24.patch
Just when I thought I have beaten the line beast.
(or maybe it's just too much work and not enough sleep.)
the right links are of course:
ftp://[EMAIL PROT
On Mon, 2007-10-08 at 21:29 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Tue, 09 Oct 2007 06:13:23 +0200
>
> > Due to the size of the patch I can not post it to the list.
>
> Understood
>
> > Here is an FTP link.
David Miller wrote:
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:15:17 +0200
Add bnx2x to Kconfig and Makefile
In a patch submission, the tree should build on every step along the
way in applying your patches, with any given configuration.
Here, the us
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> On Mon, 08 Oct 2007 20:34:41 +0200
> "Eliezer" <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote:
> >
> > >
> > > Looks good. Some m
PROTECTED]/0006-add-bnx2x_init_values.h.txt
ftp://[EMAIL PROTECTED]/0008-add-bnx2x_asm.h.txt
I want to thank Michael Chan and Matti Aarnio for helping me with resolving the
email problem.
Thanks
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
es coming from the outside are a problem, but using the cvs version
as an anchor I can track them using git.
Again, I'm open to suggestions and if someone can think of an elegant
way of doing it, I will gladly use it.
thanks
Eliezer
-
To unsubscribe from this list: send the line "uns
bnx2x_init.h - code that does chip init
From 8ef995a3102800d70b677aefb6e769c0d36e178c Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:17 +0200
Subject: [PATCH 5/8] add bnx2x_init.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
bnx2x.h - main .h file
From c32bf79956add229de2e4b81a848fad0e503d3d0 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:14 +0200
Subject: [PATCH 3/8] add bnx2x.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bn
oding
style requirements.
Known issues/TODO.
* Move slowpath event handling from tasklet to workqueue context. This
will allow replacing the busy waits in the link management code with sleeps.
Please consider applying to 2.6.24
Thanks
Eliezer
-
To unsubscribe from this list: send the
Add bnx2x to Kconfig and Makefile
From 94bf385550356534e6dd41ce61879608a63ed972 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:48:10 +0200
Subject: [PATCH 1/8] add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL
bnx2x_self_test.h - machine generated self test, plus the code that
reports HW/FW/BC asserts
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_self_test.h | 1387
+
1 files changed, 1387 insertions(+), 0 deletions(-)
diff -
bnx2x_init.h - code that does chip init
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x_init.h | 555
++
1 files changed, 555 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init
bnx2x.h - main .h file
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.h | 997
+++
1 files changed, 997 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h
new file mode 100644
Add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |9 +
drivers/net/Makefile |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9c635a2..1d44a5e 100644
event handling from tasklet to workqueue context. This
will allow replacing the busy waits in the link management code with sleeps.
Please consider applying to 2.6.24
Thanks
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0,
It does look like your Thunderbird 2.0 did wrap long text lines when you
included the texts into the posts.
Sorry about that, will fix and resubmit shortly.
Thanks
Eliezer
bnx2x_self_test.h
This file contains a self-test derived from HW specs, and the code that
prints HW/FW/BC assert codes.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x_self_test.h | 1387
++
bnx2x_init.h - Various bits of init code.
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x_init.h | 555
++
1 files changed, 555 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bn
bnx2x.h - main .h file
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>>
---
drivers/net/bnx2x.h | 997
+++
1 files changed, 997 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x.h b/drivers/net
Add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |9 +
drivers/net/Makefile |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 467532c..fbb69ac 100644
will allow replacing the busy waits in the link management code with sleeps.
Please consider applying to 2.6.24
Thanks
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.
e
each in a slightly different manner.
Eliezer
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Michal,
Thanks for going over the code.
My responses are inline.
Eliezer
Michael Buesch wrote:
On Wednesday 01 August 2007 10:31:17 Michael Chan wrote:
+typedef struct {
+ u8 reserved[64];
+} license_key_t;
No typedef.
What is a "license key" used for, anyway?
This will
73 matches
Mail list logo
