[PATCH] ip6_tunnel: disable dst caching if tunnel is dual-stack

. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 931c38f6ff4a..8aea23d15ddd 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @

[PATCH net v2 1/3] ipv4: Set skb->protocol properly for local output

ug where GSO packets sent through a sit tunnel are dropped when xfrm is involved. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- v2: place the assignment before the netfilter hook net/ipv4/ip_output.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_ou

[PATCH net v2 3/3] Revert: "ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"

tunnel. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 0a4759b..d76674e 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -1181,7 +1181,6 @@ int ip6

[PATCH net v2 2/3] ipv6: Set skb->protocol properly for local output

ug where GSO packets sent through an ipip6 tunnel are dropped when xfrm is involved. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- v2: place the assignment before the netfilter hook net/ipv6/output_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/output_core.

[PATCH net 1/2] Set skb->protocol properly before calling dst_output()

GSO packets sent through a sit or ipip6 tunnel are dropped when xfrm is involved. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- net/ipv4/ip_output.c | 4 +++- net/ipv6/output_core.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.

[PATCH net 2/2] Revert: "ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"

tunnel. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 0a4759b..d76674e 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -1181,7 +1181,6 @@ int ip6

Re: Large performance regression with 6in4 tunnel (sit)

Hi Stephen, On 2016/11/27 10:02, Stephen Rothwell wrote: > Hi Eli, > > On Sun, 27 Nov 2016 11:54:41 +1100 Stephen Rothwell > wrote: >> On Fri, 25 Nov 2016 14:05:04 +0800 Eli Cooper wrote: >>> I think this is similar to the bug I fixed in commit ae148b085876 &

Re: Large performance regression with 6in4 tunnel (sit)

Hi Stephen, On 2016/11/25 10:45, Stephen Rothwell wrote: > Hi Eli, > > On Fri, 25 Nov 2016 10:18:12 +0800 Eli Cooper wrote: >> Sounds like TSO/GSO packets are not properly segmented and therefore >> dropped. >> >> Could you first try turning off segme

[PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

Tested-by: Eli Cooper Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- net/ipv6/sit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index b1cdf80..a05dceb 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -972,6 +972,7 @@ static netdev_tx_t ipip6_tu

Re: Large performance regression with 6in4 tunnel (sit)

Hi Stephen, On 2016/11/25 9:09, Stephen Rothwell wrote: > Hi all, > > This is a typical user error report i.e. a net well specified one :-) > > I am using a 6in4 tunnel from my Linux server at home (since my ISP > does not provide native IPv6) to another hosted Linus server (that has > native IPv6

[PATCH net v3 2/2] ip6_udp_tunnel: remove unused IPCB related codes

, otherwise IPCB(skb)->opt might need to be cleared for IPv4 packets, as shown in 5146d1f1511 ("tunnel: Clear IPCB(skb)->opt before dst_link_failure called"). Signed-off-by: Eli Cooper --- net/ipv6/ip6_udp_tunnel.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv6/ip6_ud

[PATCH net v3 1/2] ip6_tunnel: Clear IP6CB in ip6tunnel_xmit()

which affects ip6_tunnel, ip6_udp_tunnel and ip6_gre. Currently none of these tunnels set IP6CB(skb)->flags, otherwise it needs to be done earlier. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- v3: moves to ip6tunnel_xmit() and clears IP6CB unconditionally v2: clears the whole IP6CB a

Re: [PATCH v2] ip6_tunnel: Clear IP6CB in ip6_tnl_xmit() after encapsulation

On 2016/10/28 10:17, Tom Herbert wrote: > On Thu, Oct 27, 2016 at 6:52 PM, Eli Cooper wrote: >> > skb->cb may contain data from previous layers. In the observed scenario, >> > the garbage data were misinterpreted as IP6CB(skb)->frag_max_size, so >> > that small

[PATCH v2] ip6_tunnel: Clear IP6CB in ip6_tnl_xmit() after encapsulation

der is installed. Signed-off-by: Eli Cooper --- v2: clears the whole IP6CB altogether and does it after encapsulation net/ipv6/ip6_tunnel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 202d16a..1487e17 100644 --- a/net/ipv6/ip6_tunnel.c +++

[PATCH] ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()

mpt to call gso_segment() for IPv4, which results in the packets being dropped. Fixes: b8921ca83eed ("ip4ip6: Support for GSO/GRO") Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c

[PATCH] ip6_tunnel: Clear IP6CB(skb)->frag_max_size in ip4ip6_tnl_xmit()

ax_size. In the observed scenario, the garbage data made the max fragment size so so small that packets sent through the tunnel are mistakenly fragmented. This patch clears IP6CB(skb)->frag_max_size for ipip6 tunnels. Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 1 + 1 file changed,

Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

Hello, On 2016/9/1 4:56, David Miller wrote: > From: Eli Cooper > Date: Fri, 26 Aug 2016 23:52:29 +0800 > >> @@ -1174,6 +1174,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device >> *dev) >> encap_limit = t->parms.encap_limit; >> >&

Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

Hello, On 2016/8/29 1:18, Guillaume Nault wrote: > On Sun, Aug 28, 2016 at 11:34:06AM +0800, Eli Cooper wrote: >> According to RFC 1885 2.2(c), the source address of ICMPv6 >> errors in response to forwarded packets should be set to the >> unicast address of the forwarding

[PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

t is NOT enforced as claimed without this patch). Signed-off-by: Eli Cooper --- v2: changed to a switch statement net/ipv6/icmp.c | 12 1 file changed, 12 insertions(+) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index bd59c34..edb50b6 100644 --- a/net/ipv6/icmp.c +++ b/net/i

[PATCH] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

t is NOT enforced as claimed without this patch). Signed-off-by: Eli Cooper --- net/ipv6/icmp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index bd59c34..0e52f3b 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -397,6 +397,7 @@ static vo

Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

Hi, On 2016/8/27 3:49, Shmulik Ladkani wrote: > However new users of 'ip6_tnl_xmit' (e.g. __gre6_xmit callers) may still > have their 'fl6->flowi6_proto' not armed. > > Maybe the right fix is assigning 'fl6->flowi6_proto = proto', either at > start of 'ip6_tnl_xmit' or just prior the ip6_route_out

[PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

owi6_proto back. Cc: sta...@vger.kernel.org Fixes: 8eb30be0352d ("ipv6: Create ip6_tnl_xmit") Signed-off-by: Eli Cooper --- net/ipv6/ip6_tunnel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 2050217..5c57797 100644 --- a/net/ipv