Re: [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

2019-06-10 Thread Eli Britstein
On 6/11/2019 3:52 AM, Cong Wang wrote: > On Wed, Jun 5, 2019 at 10:37 PM Eli Britstein wrote: >> >> On 6/6/2019 4:42 AM, Cong Wang wrote: >>> On Tue, Jun 4, 2019 at 11:19 AM Eli Britstein wrote: >>>> On 6/4/2019 8:55 PM, Cong Wang wrote: >>>>>

Re: [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

2019-06-08 Thread Eli Britstein
On 6/7/2019 9:20 PM, Davide Caratti wrote: > On Wed, 2019-06-05 at 18:42 -0700, Cong Wang wrote: >> On Tue, Jun 4, 2019 at 11:19 AM Eli Britstein wrote: > hello Cong and Eli, > > and thanks for all the thoughts. > >>> On 6/4/2019 8:55 PM, Cong Wang wrote: >>&

Re: [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

2019-06-05 Thread Eli Britstein
On 6/6/2019 4:42 AM, Cong Wang wrote: > On Tue, Jun 4, 2019 at 11:19 AM Eli Britstein wrote: >> >> On 6/4/2019 8:55 PM, Cong Wang wrote: >>> On Sat, Jun 1, 2019 at 9:22 PM Eli Britstein wrote: >>>> I think that's because QinQ, or VLAN is not an en

Re: [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

2019-06-04 Thread Eli Britstein
On 6/4/2019 8:55 PM, Cong Wang wrote: > On Sat, Jun 1, 2019 at 9:22 PM Eli Britstein wrote: >> I think that's because QinQ, or VLAN is not an encapsulation. There is >> no outer/inner packets, and if you want to mangle fields in the packet >> you can do it and the resu

Re: [PATCH net v3 1/3] net/sched: act_csum: pull all VLAN headers before checksumming

2019-06-01 Thread Eli Britstein
On 6/1/2019 1:50 AM, Cong Wang wrote: > On Fri, May 31, 2019 at 3:01 PM Davide Caratti wrote: >> Please note: this loop was here also before this patch (the 'goto again;' >> line is only patch context). It has been introduced with commit >> 2ecba2d1e45b ("net: sched: act_csum: Fix csum calc for t

Re: [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

2019-06-01 Thread Eli Britstein
On 6/1/2019 1:29 AM, Cong Wang wrote: > On Fri, May 31, 2019 at 3:01 PM Davide Caratti wrote: >> On Fri, 2019-05-31 at 11:42 -0700, Cong Wang wrote: >>> On Fri, May 31, 2019 at 10:26 AM Davide Caratti wrote: 'act_csum' was recently fixed to mangle the IPv4/IPv6 header if a packet havin

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-03 Thread Eli Britstein
Reviewed-by: Eli Britstein On 3/3/2019 5:20 PM, Roi Dayan wrote: > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> Remove redundant assignment to tun_entropy->enabled. >> >> Addesses-Coverity-ID: 1477328 ("Unused value") >> Fixes: 97417f6182f8 (

[PATCH net-next 1/1] net: sched: act_csum: Fix csum calc for tagged packets

2019-02-26 Thread Eli Britstein
cases. Fixes: d8b9605d2697 ("net: sched: fix skb->protocol use in case of accelerated vlan path") Signed-off-by: Eli Britstein Signed-off-by: Jiri Pirko --- net/sched/act_csum.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/net/sche

[PATCH net-next 1/1] flow_offload: Fix flow action infrastructure

2019-02-10 Thread Eli Britstein
h the last one. Fix it. Fixes: e3ab786b42535 ("flow_offload: add flow action infrastructure") Fixes: 738678817573c ("drivers: net: use flow action infrastructure") Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- include/net/flow_offload.h | 2 +- 1 file changed, 1 ins

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-08 Thread Eli Britstein
On 2/8/2019 9:59 AM, Simon Horman wrote: > On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: >> From: Gregory Rose >> Date: Mon, 4 Feb 2019 11:41:29 -0800 >> >>> On 2/3/2019 1:12 AM, Eli Britstein wrote: >>>> Declare ovs key struct

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-06 Thread Eli Britstein
On 2/5/2019 10:23 PM, Ben Pfaff wrote: > On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote: >> On 2/5/2019 4:02 AM, Eli Britstein wrote: >>> On 2/4/2019 10:07 PM, David Miller wrote: >>>> From: Yi-Hung Wei >>>> Date: Mon, 4 Feb 2019 10:47:1

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-05 Thread Eli Britstein
On 2/4/2019 10:07 PM, David Miller wrote: > From: Yi-Hung Wei > Date: Mon, 4 Feb 2019 10:47:18 -0800 > >> For example, to see how 'struct ovs_key_ipv6' is defined, now we need >> to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR >> and OVS_KEY_FIELD defined. I think it makes

[PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-03 Thread Eli Britstein
nal change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- include/uapi/linux/openvswitch.h | 102 ++- 1 file changed, 69 insertions(+), 33 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h index dbe0cbe4f1b7..dc

Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-31 Thread Eli Britstein
ping for the using patch, i put below the v1 of it. here is v2: https://patchwork.ozlabs.org/patch/1023406/ On 1/27/2019 8:37 AM, Eli Britstein wrote: > > On 1/27/2019 1:04 AM, David Miller wrote: >> From: Eli Britstein >> Date: Thu, 24 Jan 2019 11:46:47 +0200 >

Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-26 Thread Eli Britstein
On 1/27/2019 1:04 AM, David Miller wrote: > From: Eli Britstein > Date: Thu, 24 Jan 2019 11:46:47 +0200 > >> Declare ovs key structures using macros to enable retrieving fields >> information, with no functional change. >> >> Signed-off-by: Eli Britstein >

[PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-24 Thread Eli Britstein
Declare ovs key structures using macros to enable retrieving fields information, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- include/uapi/linux/openvswitch.h | 102 ++- 1 file changed, 69 insertions(+), 33 deletions