Re: [PATCH net] ehea: fix operation state report

2016-11-03 Thread Douglas Miller
ruct net_device *dev) netif_info(port, ifup, dev, "enabling port\n"); + netif_carrier_off(dev); + ret = ehea_up(dev); if (!ret) { port_napi_enable(port); Signed-off-by: Douglas Miller

[PATCH 1/1] Update maintainer for EHEA driver.

2016-07-18 Thread Douglas Miller
cardo Signed-off-by: Douglas Miller --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d74837..e9cefe2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4477,7 +4477,7 @@ S:Orphan F: fs/efs/ EHEA (IBM pSeries eHEA 1

[PATCH V2 1/1] be2net: Don't leak iomapped memory on removal.

2016-03-04 Thread Douglas Miller
unmap if required. Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors") Signed-off-by: Douglas Miller --- drivers/net/ethernet/emulex/benet/be.h |1 + drivers/net/ethernet/emulex/benet/be_main.c |4 2 files changed, 5 insertions(+), 0 deletions(-) d

[PATCH V2 0/1] be2net: Don't leak iomapped memory on removal.

2016-03-04 Thread Douglas Miller
unmap if required. Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors") Signed-off-by: Douglas Miller

[PATCH 0/1] be2net: Don't leak iomapped memory on removal.

2016-03-03 Thread Douglas Miller
unmap if required. Signed-off-by: Douglas Miller

[PATCH 1/1] be2net: Don't leak iomapped memory on removal.

2016-03-03 Thread Douglas Miller
unmap if required. Signed-off-by: Douglas Miller --- drivers/net/ethernet/emulex/benet/be.h |1 + drivers/net/ethernet/emulex/benet/be_main.c |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/b

[PATCH 0/1] Fix bug where remove of device fails to free all resources.

2016-03-01 Thread Douglas Miller
t flag in be_unmap_pci_bars() to unmap if required. Signed-off-by: Douglas Miller

[PATCH 1/1] Fix bug where remove of device fails to free all resources.

2016-03-01 Thread Douglas Miller
unmap if required. Signed-off-by: Douglas Miller --- drivers/net/ethernet/emulex/benet/be.h |1 + drivers/net/ethernet/emulex/benet/be_main.c |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/b

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-13 Thread Douglas Miller
any delay between runs of ethtool -t ... offline. Thanks Siva, Doug On 08/13/2015 03:40 AM, Siva Reddy (Siva) Kallam wrote: On 8/12/2015 6:02 PM, Douglas Miller wrote: Oh, I had missed the extra "if" condition on tg3_test_link(). So "external_lb" is not a true superse

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-12 Thread Douglas Miller
el Chan wrote: On Tue, 2015-08-11 at 14:24 -0500, Douglas Miller wrote: Yes, the "wrap plugs" are the loopback cables/plugs. It is my understanding that the "offline" tests do not require anything to be plugged into the ports, as they do not in any way touch the "extern

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-11 Thread Douglas Miller
ng the loopback tests again). I believe this call is to switch from "internal loopback" to "normal", in order to leverage the wrap plugs and perform the external loopback tests. But this call is not made for "offline" and I am wondering if that leaves the port in a state wh

Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-11 Thread Douglas Miller
(Sorry if you got several duplicates, am trying to work through rejected messages due to supposed HTML content) The following behavior is being observed when running "ethtool -t offline" on ports on the Broadcom BCM5719 adapter (tg3 driver). The ports have wrap plugs on them, although I'm not