Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-27 Thread Doug Ledford
ew cycles > > before removing it. > > > > If you completely replace it with something that works the same, why > > keep the old > > one around at all? > > Agree. Thanks! > > > > Unless you don't trust your new code? :) > > > We do :) I don't -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated

2019-09-27 Thread Doug Ledford
> Unless you don't trust your new code? :) I have yet to see, in over 20 years of kernel experience, a new driver replace an old driver and not initially be more buggy and troublesome than the old driver. It takes time and real world usage for the final issues to get sorted out. During

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-22 Thread Doug Ledford
On Wed, 2019-08-21 at 17:02 +0300, Leon Romanovsky wrote: > On Tue, Aug 20, 2019 at 01:54:59PM -0400, Doug Ledford wrote: > > On Mon, 2019-08-19 at 14:36 +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Hi, > > > > > >

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-20 Thread Doug Ledford
space flow table default miss action support > net/mlx5: Create bypass and loopback flow steering namespaces for > RDMA > RX > RDMA/mlx5: RDMA_RX flow type support for user applications I have no objection to this series. -- Doug Ledford GPG KeyID: B826A3330E572FDD F

Re: [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15

2019-08-20 Thread Doug Ledford
. > > Thanks, > Saeed. Series looks fine to me. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/1] net: rds: add service level support in rds-info

2019-08-20 Thread Doug Ledford
o match up with. Are there any versions of rds-tools that actually use the kernel provided headers? Are there any other users of uapi/linux/rds.h besides rds-tools? Once the kernel and rds-tools package are in sync, rds-tools needs to be modified to use the kernel header and proper ABI mainten

Re: [PATCH net-next 0/5] net/rds: Fixes from internal Oracle repo

2019-08-14 Thread Doug Ledford
rtions(+), 3 deletions(-) > That first patch looks like a total bogon to me, but the remaining four look fine. -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH net-next 1/5] RDS: Re-add pf/sol access via sysctl

2019-08-14 Thread Doug Ledford
ted by IANA on Feb 27 and May 20, 2009. And you *still* have software that needs this? The only software that has ever used RDS was Oracle software. I would have expected you guys to update your source code to do the right thing long before now. In fact, I would expect you were ready to retir

Re: [PATCH rdma-next 0/4] Add XRQ and SRQ support to DEVX interface

2019-08-13 Thread Doug Ledford
On Tue, 2019-08-13 at 10:06 +, Leon Romanovsky wrote: > On Mon, Aug 12, 2019 at 11:43:58AM -0400, Doug Ledford wrote: > > On Thu, 2019-08-08 at 10:11 +, Leon Romanovsky wrote: > > > On Thu, Aug 08, 2019 at 11:43:54AM +0300, Leon Romanovsky wrote: > > &

Re: [PATCH rdma-next 0/4] Add XRQ and SRQ support to DEVX interface

2019-08-12 Thread Doug Ledford
> Sorry for typo in cover letter, there is no SRQ here. Series looks fine to me. Are you planning on the first two via mlx5- next and the remainder via RDMA tree? -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signatur

Re: [PATCH v3 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-21 Thread Doug Ledford
) > Hi Michal, In patch 2 and 3 both, you still have quite a few casts to (u8 __iomem *). Why not just define the struct elements as u8 __iomem * instead of void __iomem * and avoid all the casts? -- Doug Ledford GPG KeyID: B826A3330E572FDD Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH net-next v4 2/2] ipoib: show VF broadcast address

2019-06-18 Thread Doug Ledford
broadcast address in use by each to make sure they are the same and not that they shouldn't be able to see each other because they are on different P_Keys and therefore different broadcast multicast groups. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B

Re: [PATCH rdma-next v1 0/4] Expose ENCAP mode to mlx5_ib

2019-06-17 Thread Doug Ledford
gt; 82b11f071936 net/mlx5: Expose eswitch encap mode > 98fdbea55037 net/mlx5: Declare more strictly devlink encap mode > > > RDMA/mlx5: Consider eswitch encap mode > > RDMA/mlx5: Enable decap and packet reformat on FDB > > Doug, Jason > > Can you please take t

Re: [PATCH 1/2] ipoib: correcly show a VF hardware address

2019-06-17 Thread Doug Ledford
st copy an address without modifing ifla_vf_mac > v2->v3: update the changelog > v3->v4: update the changelog: add a link to the patch for iproute2 > > Signed-off-by: Denis Kirjanov I assume you want this to go as a series through netdev, so you can add my: Acked-by: Doug Ledford

Re: [PATCH 2/2] ipoib: show VF broadcast address

2019-06-15 Thread Doug Ledford
On Sat, 2019-06-15 at 11:49 +0300, Denis Kirjanov wrote: > On 6/14/19, Doug Ledford wrote: > > On Fri, 2019-06-14 at 15:32 +0200, Denis Kirjanov wrote: > > > in IPoIB case we can't see a VF broadcast address for but > > > can see for PF > > > >

Re: [PATCH 2/2] ipoib: show VF broadcast address

2019-06-14 Thread Doug Ledford
f_rate) || > @@ -1753,6 +1757,7 @@ static const struct nla_policy > ifla_info_policy[IFLA_INFO_MAX+1] = { > > static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = { > [IFLA_VF_MAC] = { .len = sizeof(struct ifla_vf_mac) > }, > + [IFLA_VF_BRO

Re: [PATCH net-next v2 1/2] ipoib: correcly show a VF hardware address

2019-06-13 Thread Doug Ledford
r_len); > > return 0; > } I'm ok with the patch, but your commit message does not match what the patch does at all. You need to correct the commit message. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: linux-next: manual merge of the net-next tree with the rdma tree

2019-02-27 Thread Doug Ledford
ex conflicts. > Thanks Stephen, we'll add it to the (largish this release) list of conflicts to bring to Linus' attention. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH rdma-next 0/7] Enrich DEVX support

2018-12-04 Thread Doug Ledford
On Tue, 2018-12-04 at 12:15 -0700, Jason Gunthorpe wrote: > On Tue, Dec 4, 2018 at 12:02 PM Doug Ledford wrote: > > On Mon, 2018-11-26 at 08:28 +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > From Yishai, > > > -

Re: [PATCH rdma-next 0/7] Enrich DEVX support

2018-12-04 Thread Doug Ledford
/dl-for-next branch. Because it pulled in the mlx5-next tree (which was significant because the patch we wanted was at the tip and a whole slew of other patches were before it), the changeset for this patch looks much bigger. And it had the merge conflict you mentioned. You might want to double che

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-03 Thread Doug Ledford
will appreciate suggestions, inputs and review. > > 1. git grep "nid == -1" > 2. git grep "node == -1" > 3. git grep "nid = -1" > 4. git grep "node = -1" > > drivers/infiniband/hw/hfi1/affinity.c | 3 ++- > drivers/infiniband

Re: [PATCH mlx5-next 1/7] net/mlx5: Update mlx5_ifc with DEVX UCTX capabilities bits

2018-12-03 Thread Doug Ledford
gt; }; > > enum mlx5_flow_destination_type { > @@ -9276,7 +9286,9 @@ struct mlx5_ifc_umem_bits { > struct mlx5_ifc_uctx_bits { > u8 modify_field_select[0x40]; > > - u8 reserved_at_40[0x1c0]; > + u8 cap[0x20]; > + > + u8 re

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Doug Ledford
On Tue, 2018-11-06 at 22:02 +, Jason Gunthorpe wrote: > On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > > From: Yishai Hadas > > > > > > Adapt XRC SRQ to the latest HW

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Doug Ledford
etter readability. > > Thanks This looks fine. Let me know when it's in the mlx5-next tree to pull. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH rdma-next] IB/mlx5: Add support for extended atomic operations

2018-10-17 Thread Doug Ledford
-by: Guy Levi > Signed-off-by: Leon Romanovsky Thanks, applied to for-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH rdma-next v1 0/4] Scatter to CQE

2018-10-17 Thread Doug Ledford
On Tue, 2018-10-16 at 22:00 +0300, Leon Romanovsky wrote: > On Tue, Oct 16, 2018 at 02:39:01PM -0400, Doug Ledford wrote: > > On Tue, 2018-10-09 at 12:05 +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Changelog v0->v1: > > >

Re: [PATCH rdma-next v1 0/4] Scatter to CQE

2018-10-16 Thread Doug Ledford
gt; 5 files changed, 79 insertions(+), 22 deletions(-) > > -- > 2.14.4 > Hi Leon, This series looks fine. Let me know when the net/mlx5 portion has been committed. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH rdma-next 0/4] mlx5 vport loopback

2018-09-21 Thread Doug Ledford
> .../net/ethernet/mellanox/mlx5/core/en_common.c| 2 +- > include/linux/mlx5/mlx5_ifc.h | 4 +- > include/uapi/rdma/mlx5-abi.h | 2 + > 6 files changed, 138 insertions(+), 43 deletions(-) > > -- > 2.14.4 > Thanks, fir

Re: [PATCH rdma-next 0/4] mlx5 vport loopback

2018-09-21 Thread Doug Ledford
On Sat, 2018-09-22 at 00:40 +0300, Leon Romanovsky wrote: > On Fri, Sep 21, 2018 at 04:05:53PM -0400, Doug Ledford wrote: > > On Fri, 2018-09-21 at 22:33 +0300, Leon Romanovsky wrote: > > > Hope it makes it clear now. > > > > Clear enough. Between yours and Jason&#

Re: [PATCH rdma-next 0/4] mlx5 vport loopback

2018-09-21 Thread Doug Ledford
Let me know a tag when it's ready to merge. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH rdma-next 0/4] mlx5 vport loopback

2018-09-21 Thread Doug Ledford
h the mlx5 tree and get picked up by Dave and us, and then we take the rest? This is unclear to me... -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v4 0/3] IB/ipoib: Use dev_port to disambiguate port numbers

2018-09-13 Thread Doug Ledford
ng the wrong variable is too noisy, then we might want to revert it or modify it to only print out once per specific executable instead of once per run of each executable. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v4 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

2018-09-13 Thread Doug Ledford
gt; udev in particular does not use dev_id at all since 2014, because "why > > would we keep using dev_id if it is not the right thing to use?". > > > > > > > > Do we know there is no userspace doing this? > > > > > > > Not

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

2018-09-07 Thread Doug Ledford
On Fri, 2018-09-07 at 20:28 +0300, Leon Romanovsky wrote: > On Fri, Sep 07, 2018 at 01:14:37PM -0400, Doug Ledford wrote: > > On Thu, 2018-09-06 at 16:03 +0300, Leon Romanovsky wrote: > > > On Thu, Sep 06, 2018 at 10:04:33AM +0300, Arseny Maslennikov wrote: > > > >

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

2018-09-07 Thread Doug Ledford
e? > > > > > > > Netdev code relies on macros around a *static* function 'netdev_show', > > which is defined in net/core/net-sysfs.c; it is not listed in any header > > files, and the macros aren't as well. This all leads me to believe it > > was n

Re: [PATCH v4 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

2018-09-07 Thread Doug Ledford
ction is done as part of ipoib_add_port() so the port itself isn't live yet. Things like udev shouldn't be scanning it until after we've finished bringing it up and added it to the system, so any race here is unimportant IMO. > > static struct net_device *ipoib_a

Re: [PATCH v2 1/2] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-31 Thread Doug Ledford
On Fri, 2018-08-31 at 11:57 +0300, Arseny Maslennikov wrote: > On Thu, Aug 30, 2018 at 04:17:58PM -0400, Doug Ledford wrote: > > On Thu, 2018-08-30 at 21:22 +0300, Arseny Maslennikov wrote: > > > Some InfiniBand network devices have multiple ports on the same PCI > > >

Re: [PATCH v2 1/2] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-30 Thread Doug Ledford
e the new item to make us compliant with the new docs, and deprecate the old sysfs item, but we can't just yank the old item. Existing tools/scripts might (probably) rely on it (existing tools already special case IPoIB interfaces and we'll need to make sure they don't special

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-06-01 Thread Doug Ledford
On Fri, 2018-06-01 at 11:45 -0400, David Miller wrote: > From: Doug Ledford > Date: Fri, 01 Jun 2018 11:08:24 -0400 > > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > >> From: Saeed Mahameed > >> Date: Wed, 30 May 2018 10:59:48 -0700 > >>

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-06-01 Thread Doug Ledford
On Fri, 2018-06-01 at 19:21 +0300, Leon Romanovsky wrote: > On Fri, Jun 01, 2018 at 11:45:58AM -0400, David Miller wrote: > > From: Doug Ledford > > Date: Fri, 01 Jun 2018 11:08:24 -0400 > > > > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > > &g

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-06-01 Thread Doug Ledford
you to ack the original patch series, not apply it, and when acks from both the net and rdma side have been received, then we will get a pull request of just that series. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-31 Thread Doug Ledford
| 8 ++ > include/linux/mlx5/mlx5_ifc.h| 3 ++- > include/linux/mlx5/mlx5_ifc_fpga.h | 16 +++ > 4 files changed, 53 insertions(+), 2 deletions(-) > For the RDMA community, series ack: Acked-by: Doug Ledford -- Doug Ledford GPG Key

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-22 Thread Doug Ledford
capture the two different merge commit messages one > > by one. > > > > Is this basically how you want to handle things moving forward? > > > > Thanks Dave ! > Basically yes, we want to avoid sending netdev related patches to rdma, > and vice versa. > Unlik

Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Doug Ledford
On Tue, 2018-05-15 at 15:28 -0500, Steve Wise wrote: > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Doug Ledford > > Sent: Tuesday, May 15, 2018 2:53 PM > > To: David Ahern ; Steve Wise >

Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Doug Ledford
On Tue, 2018-05-15 at 14:01 -0600, David Ahern wrote: > On 5/15/18 2:00 PM, Doug Ledford wrote: > > I just sent an incremental fix to the list under separate cover. You > > can squash that fix into Steve's patch and it should resolve the issue. > > Or Steve can r

Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Doug Ledford
quash that fix into Steve's patch and it should resolve the issue. Or Steve can respin the set. Either way. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Doug Ledford
2 */ > > + RDMA_NLDEV_ATTR_DRIVER_S64, /* s64 */ > > + RDMA_NLDEV_ATTR_DRIVER_U64, /* u64 */ > > and again here. This chunk, however, is a problem. We'll need to fix that in the kernel and in this patch too. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Doug Ledford
/* s64 */ > > + RDMA_NLDEV_ATTR_DRIVER_U64, /* u64 */ > > and again here. > > > > > /* > > * Provides logical name and index of netdevice which is > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Doug Ledford
On Tue, 2018-05-15 at 19:59 +0300, Leon Romanovsky wrote: > On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > > On Mon, May 0

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Doug Ledford
n the form of > > [print_type], value> tuples, where the key is a string and the value can > > > be any supported driver attribute. The print_type attribute, if present, > > > > ditto > > I'll fix these. Fix it if you want, but don't do it beca

Re: [pull request][for-next 0/6] Mellanox, mlx5 updates 2018-05-07

2018-05-15 Thread Doug Ledford
> > see tag log below. > > > > Please pull and let me know if there's any problem. > > Looks good, pulled into net-next. > > Thanks. Thanks, pulled into rdma-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B

Re: [PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

2018-05-09 Thread Doug Ledford
On Thu, 2018-05-03 at 21:37 +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Delete non-existent @mellanox.com addresses from MAINTAINERS file. > > Signed-off-by: Leon Romanovsky Thanks, applied to for-rc. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fin

Re: [PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

2018-05-03 Thread Doug Ledford
On 5/3/2018 5:11 PM, Or Gerlitz wrote: > On Thu, May 3, 2018 at 9:37 PM, LR wrote: > >> MELLANOX MLX5 core VPI driver >> M: Saeed Mahameed >> -M: Matan Barak > > Goodbye Matan! > > You were a long time developer, maintainer, hacker and a very deeply thinking, > pleasant, nice and ope

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

2018-04-27 Thread Doug Ledford
> > I will make further investigations about other error handler after > > ip_local_out. > > If I am wrong, please correct me. > > > > Any reply is appreciated. > > > > Zhu Yanjun > > On 2018/4/20 13:46, Yanjun Zhu wrote: > > > > &g

Re: [PATCH for-rc] uapi: Fix SPDX tags for files referring to the 'OpenIB.org' license

2018-04-23 Thread Doug Ledford
license that matches the BSD-2-Clause > > SPX. There is no 'three clause' version of the OpenIB.org > > license. > > > > Signed-off-by: Jason Gunthorpe > > Acked-by: David S. Miller > Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E57

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

2018-04-19 Thread Doug Ledford
t; @@ -1141,7 +1143,8 @@ static enum resp_states duplicate_request(struct rxe_qp > *qp, > if (rc) { > pr_err("Failed resending result. This flow is > not handled - skb ignored\n"); > rxe_

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-20 Thread Doug Ledford
On 3/16/2018 12:18 PM, David Ahern wrote: > On 3/13/18 1:58 PM, Doug Ledford wrote: >> On Tue, 2018-03-13 at 13:45 -0700, David Ahern wrote: >>> On 3/13/18 1:32 AM, Leon Romanovsky wrote: >>>> On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: >>>

Re: linux-next: manual merge of the net-next tree with the rdma-fixes tree

2018-03-15 Thread Doug Ledford
up(struct mlx5_ib_dev *dev); > -int mlx5_ib_stage_umr_res_init(struct mlx5_ib_dev *dev); > -void mlx5_ib_stage_umr_res_cleanup(struct mlx5_ib_dev *dev); > +int mlx5_ib_stage_post_ib_reg_umr_init(struct mlx5_ib_dev *dev); > int mlx5_ib_stage_class_attr_init(struct mlx5_ib_dev *dev); > void __

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-13 Thread Doug Ledford
has become the standard drop box for low level kernel network configuring tools. The RDMA subsystem may not be IP networking, but it is still networking, so it seemed an appropriate fit. > I do not need the overhead of > sometimes I sync the rdma header file and sometimes I don'

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-13 Thread Doug Ledford
On Mon, 2018-03-12 at 21:43 -0400, Doug Ledford wrote: > On Mon, 2018-03-12 at 21:43 +, Saeed Mahameed wrote: > > On Thu, 2018-03-08 at 14:14 -0500, Doug Ledford wrote: > > > On 3/8/2018 1:04 PM, David Miller wrote: > > > > From: Saeed Mahameed > > >

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-12 Thread Doug Ledford
On Mon, 2018-03-12 at 21:43 +, Saeed Mahameed wrote: > On Thu, 2018-03-08 at 14:14 -0500, Doug Ledford wrote: > > On 3/8/2018 1:04 PM, David Miller wrote: > > > From: Saeed Mahameed > > > Date: Wed, 7 Mar 2018 17:26:03 -0800 > > > > > > >

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-08 Thread Doug Ledford
On 3/8/2018 2:38 PM, Randy Dunlap wrote: > On 03/08/2018 11:14 AM, Doug Ledford wrote: >> On 3/8/2018 1:04 PM, David Miller wrote: >>> From: Saeed Mahameed >>> Date: Wed, 7 Mar 2018 17:26:03 -0800 >>> >>>> Hi Dave and Doug, >>>> >

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-08 Thread Doug Ledford
On 3/8/2018 1:04 PM, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 7 Mar 2018 17:26:03 -0800 > >> Hi Dave and Doug, >> >> This series includes shared code updates (IPSec part2) for mlx5 core >> driver for both netdev and rdma subsystems. This series should be pulled >> to both trees

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

2018-03-07 Thread Doug Ledford
On Wed, 2018-03-07 at 15:41 -0500, Doug Ledford wrote: > On Wed, 2018-03-07 at 15:31 -0500, David Miller wrote: > > From: Saeed Mahameed > > Date: Tue, 6 Mar 2018 22:35:03 -0800 > > > > > This series includes shared code updates for mlx5 core driver for both &g

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

2018-03-07 Thread Doug Ledford
parse fixes patch > > - Updated commit message of "net/mlx5: Add has_tag to mlx5_flow_act" > > - Add const to static mlx5_flow_cmd structs where needed. > > Pulled, thanks Saeed. Thanks, pulled here as well. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerp

Re: [for-next V2 12/13] {net,IB}/mlx5: Add flow steering helpers

2018-03-07 Thread Doug Ledford
ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + */ > + Nit: I would prefer a license identifier line followed by just the copyright tag, not the full boiler plate. -- Doug Ledford GPG KeyID: B826A3330E572FDD

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

2018-03-07 Thread Doug Ledford
t; > - Add const to static mlx5_flow_cmd structs where needed. > > Thanks, > Saeed. FWIW, the IB portions are fine with me (they're all pretty simple). Acked-by: Doug Ledford -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274

Re: [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23

2018-02-28 Thread Doug Ledford
itch, I would > > like to get Doug's or Jason's approval before pulling it in. > > > > The series doesn't cause any conflict with the latest mlx5 net fixes > > series. > > With Doug's ACK, I've pulled this into net-next. > > Thanks. Series pu

Re: [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23

2018-02-27 Thread Doug Ledford
/net/ethernet/mellanox/mlx5/core/mlx5_core.h| 7 +- > include/linux/mlx5/driver.h | 6 + > include/linux/mlx5/eswitch.h | 58 > 15 files changed, 796 insertions(+), 147 deletions(-) > create mode 100644 drivers/infiniband/hw/mlx5/ib_rep.c > create mode 100644 drivers/infiniband/hw/mlx5/ib_rep.h > create mode 100644 include/linux/mlx5/eswitch.h -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-22 Thread Doug Ledford
et fixes > > series. > > > > Please pull and let me know if there's any issue, > > Looks good to me, pulled into net-next, thanks. Thanks, pulled into rdma-next. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: This is a digitally signed message part

Re: [PATCH v3] RDS: IB: Fix null pointer issue

2018-02-05 Thread Doug Ledford
id_priv->id.event_handler > > Signed-off-by: Guanglei Li > Signed-off-by: Honglei Wang > Reviewed-by: Junxiao Bi > Reviewed-by: Yanjun Zhu > Reviewed-by: Leon Romanovsky > Acked-by: Santosh Shilimkar RDS patches normally go through Dave's tree, so for

Re: [pull request][for-next V3 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2018-01-05 Thread Doug Ledford
On Fri, 2018-01-05 at 12:26 -0700, Jason Gunthorpe wrote: > On Fri, Jan 05, 2018 at 02:07:34PM -0500, Doug Ledford wrote: > > > > > V2->V3: > > > > - Fixed compilation warning, reported by Dave. > > > > > > > > Please pull and let me kno

Re: [pull request][for-next V3 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2018-01-05 Thread Doug Ledford
o @rc4. > > > > V2->V3: > > - Fixed compilation warning, reported by Dave. > > > > Please pull and let me know if there's any problem. > > Looks good, pulled, thank you. Hi Jason, Unless I missed something, you haven't pulled this for for-n

Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11,Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-18 Thread Doug Ledford
On Mon, 2017-10-16 at 05:45 +0100, David Miller wrote: > > Once I hear that Dave is OK with the net changes, I'm ready to pull > > (if > > I need to). > > They look fine and I've pulled this into net-next. Thanks, pulled here as well. -- Doug Ledford G

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

2017-10-18 Thread Doug Ledford
Bhumika Goyal Acked-by: Doug Ledford -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-14 Thread Doug Ledford
driver to submit after this but still in this devel cycle. > Please pull and let me know if there's any problem. Once I hear that Dave is OK with the net changes, I'm ready to pull (if I need to). -- Doug Ledford GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
Toukan > Cc: netdev@vger.kernel.org > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-al

Re: [pull request][for-next 0/9] Mellanox, mlx5 updates 2017-10-06

2017-10-09 Thread Doug Ledford
On Fri, 2017-10-06 at 16:37 -0700, Saeed Mahameed wrote: > The following changes since commit > e19b205be43d11bff638cad4487008c48d21c103: > > Linux 4.14-rc2 (2017-09-24 16:38:56 -0700) Thanks for keeping the base at rc2 like I requested. Pulled. -- Doug Ledford

Re: [PATCH v12 0/8] Replace PCI pool by DMA pool API

2017-08-22 Thread Doug Ledford
nch (mthca, mlx4, and mlx5 patches). Thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [PATCH v10 00/15] Replace PCI pool by DMA pool API

2017-07-09 Thread Doug Ledford
mvsas/mv_init.c | 6 +- > drivers/scsi/mvsas/mv_sas.c | 6 +- > drivers/scsi/pmcraid.c| 10 +-- > drivers/scsi/pmcraid.h| 2 +- > include/linux/mlx5/driver.h | 2 +- > include/linux/pci.h | 9 --- > 35 files changed, 269 insertions(+), 278 deletions(-) > -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Re: [pull request][for-next 0/6] Mellanox mlx5 updates 2017-05-23

2017-06-14 Thread Doug Ledford
your latest net-next as of today as the easiest way to resolve that issue.  Now I can merge my -rc branch in and it won't cause any extra noise in the merge.  It seems to be a fairly regular pattern that I'm going to have to hold my pull request to Linus until after your tree is

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-09 Thread Doug Ledford
someplace else. This is a valid concern. > This is especially true for mlx nics as there are many raw packet > bypass mechanisms available to userspace. Right.  The question becomes: Does the firmware filter outgoing raw ETH QPs such that a nefarious user could not send a crafted RoCE packet that the bump on the wire would intercept and accept? -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [PATCH net-next 0/3] mlx4 drivers: version update

2017-06-09 Thread Doug Ledford
u want to handle this differently or want > me to change something. > > Thanks. You've got it, I'll skip it, it's all good. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-02 Thread Doug Ledford
posed to look at? net-next -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [pull request][for-next 0/6] Mellanox mlx5 updates 2017-05-23

2017-06-01 Thread Doug Ledford
do.  But is the question of a possible revert settled?  Because once I pull, a revert means I have to pull all the way up to the revert as well... -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-17 Thread Doug Ledford
l before it has had time to fully sit and gel, acceptable. But this is where we kind of need a judgment from on high, and why I Cc:ed Linus on this thread. Any input on this issue Linus? > I have additional proposal for link groups, resource creation area. I will > take that up after this discu

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-17 Thread Doug Ledford
On Tue, 2017-05-16 at 15:28 -0400, Doug Ledford wrote: > I hadn't realized EXPERIMENTAL was gone.  Which is too bad, because > that's entirely appropriate in this case, and would have had the > desired side effect of keeping it out of any non-cutting edge distros > and warn

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 14:52 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 14:03:22 -0400 > > > On Tue, 2017-05-16 at 13:36 -0400, David Miller wrote: > >> From: Doug Ledford > >> Date: Tue, 16 May 2017 13:20:44 -0400 > >> 

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 13:36 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 13:20:44 -0400 > > > Anyway, we're just talking out what happened, when what we really > need > > to focus on is moving forward.  Again, your thoughts on marking SM

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 12:49 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 12:42:43 -0400 > > > On Tue, 2017-05-16 at 12:29 -0400, David Miller wrote: > >> From: Doug Ledford > >> Date: Tue, 16 May 2017 11:57:04 -0400 > >

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 12:41 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 12:36:01 -0400 > > > On Tue, 2017-05-16 at 18:30 +0200, Christoph Hellwig wrote: > >> On Tue, May 16, 2017 at 12:29:23PM -0400, David Miller wrote: > >> >  >

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
On Tue, 2017-05-16 at 12:29 -0400, David Miller wrote: > From: Doug Ledford > Date: Tue, 16 May 2017 11:57:04 -0400 > > > Regardless though, I'm rather purturbed about this entire thing. >  If > > you are right that because this got into 4.11, it's now a done &

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
27;ve even had things like a 12 patch series that buried three netdev@ appropriate patches at different points in the series and told the submitter to move all of the netdev@ related patches to the front and submit them to netdev@ so they can be reviewed as a group before I would move on to the othe

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-16 Thread Doug Ledford
s a reasonable driver that can continue to work with future planned RDMA subsystem updates and across various link layers, we remove the EXPERIMENTAL marker and freeze the API for user space. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [RFC iproute2 0/8] RDMA tool

2017-05-04 Thread Doug Ledford
stuff. If you look into the iproute2 package, it becomes clear that the name iproute2 is historical and not really accurate any more.  It contains things like the bridge control software, tc for controlling send queues, and many things network related but not routing related.  The rdma tool is a

Re: net/smc and the RDMA core

2017-05-02 Thread Doug Ledford
reasonable fashion. >> * Since functionality that is similar what the SMC driver provides already >> exists in user space (rsockets), why has this functionality been >> reimplemented as a kernel driver (SMC)? >> >> Bart. >> > > Regards, Ursula > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Doug Ledford GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read

2017-05-01 Thread Doug Ledford
e previous MAD_IFC implementation populated this counter, but it > was > removed during the migration to PPCNT for error counters (32-bit > only). > > Signed-off-by: Tim Wright Thanks, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-26 Thread Doug Ledford
On Wed, 2017-04-26 at 22:11 +0800, Honggang LI wrote: > On Wed, Apr 26, 2017 at 09:50:38AM -0400, Doug Ledford wrote: > > > > On Wed, 2017-04-26 at 09:48 -0400, Doug Ledford wrote: > > > > > > On Wed, 2017-04-26 at 21:33 +0800, Honggang LI wrote: > > >

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-26 Thread Doug Ledford
On Wed, 2017-04-26 at 09:48 -0400, Doug Ledford wrote: > On Wed, 2017-04-26 at 21:33 +0800, Honggang LI wrote: > > > > Yes, it is during the process of removing the final slave. The > > reproducer looks like this: > > > > ping remote_ip_over_bonding_interface

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-26 Thread Doug Ledford
er = (struct ipoib_header *) skb_push(skb, sizeof > > > > *header); > > > > --- > > > > > > > > Paolo > > > > -- > > > > To unsubscribe from this list: send the line "unsubscribe > > > > linux- > > > >

  1   2   3   >