Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask

as not good enough. I missed that pci_dma_supported returns 1 on success and pci_set_dma_mask returns 0 on success. The original patch needs to have the ! removed as Geliang Tang points out. Acked-by: Don Fry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported

ertion(+), 1 deletion(-) > Acked-by: Don Fry > diff --git a/drivers/net/ethernet/amd/pcnet32.c > b/drivers/net/ethernet/amd/pcnet32.c > index bc8b04f..e2afabf 100644 > --- a/drivers/net/ethernet/amd/pcnet32.c > +++ b/drivers/net/ethernet/amd/pcnet32.c > @@ -1500,7 +1500,7

[PATCH 2.6.24] pcnet32: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Acked-by: Don Fry <[EMAIL PROTECTED]> --- Originally sent by Joe Dec 14, 2007 Tested by Don on amd_64 --- linux-2.6.24-git13/drivers/net/orig.pcnet32.c 2008-02-04 10:05:48.0 -0800 +++ linux-2.6.24-git18/drivers/net/pcnet

[PATCH 2.6.24] pcnet32: use NET_IP_ALIGN instead of 2

Change hard coded 2 to NET_IP_ALIGN. Added new #define with comments. Tested amd_64 Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.24-git13/drivers/net/joe.pcnet32.c2008-02-04 10:59:08.0 -0800 +++ linux-2.6.24-git18/drivers/net/pcnet32.c2008-02-08

Re: [PATCH 5/7]: [NET]: Fix drivers to handle napi_disable() disabling interrupts.

Tested pcnet32 on x86_64 box and see no problems with the change. The code is only exercised if doing loopback testing, or changing the ring size during a receive storm. Acked-by: Don Fry <[EMAIL PROTECTED]> --- [NET]: Fix drivers to handle napi_disable() disabling interrupts. When we a

[PATCH] pcnet32: remove private net_device_stats structure

Remove the statistics from the private structure. Use the net_device_stats in netn_device structure. Following Jeff Garzik's massive cleanup Sep 01. pcnet32 was not "low-hanging fruit". Tested x86_64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.

Re: [PATCH] pcnet32: fix non-napi packet reception

>In general, we're hoping to remove as many CONFIG_FOO_NAPI as possible, >pushing everybody towards using NAPI. > >Any objection to heading in this direction with pcnet32? > >Jeff I have no objections myself. It has been slowly moving that direction. First with the napi implementation, de

[PATCH] pcnet32: remove compile warnings in non-napi mode

Remove compile warning when in non-napi mode. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.23-git7/drivers/net/napi.pcnet32.c2007-10-17 15:56:15.0 -0700 +++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 16:00:44.0 -0700 @@ -442,7

[PATCH] pcnet32: fix non-napi packet reception

Recent changes to the driver for the new napi API broke the reception of packets when in non-napi mode. The initialization of napi.weight was removed for the non-napi case leaving the value zero. Tested NAPI and non-NAPI on x86_64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- ---

[PATCH] pcnet32: add suspend and resume capability

Add suspend and resume capability to the driver. Tested both to ram and to disk on x86_64 platform. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc3/drivers/net/pcnet32.c.orig 2007-08-14 13:52:24.0 -0700 +++ linux-2.6.23-rc3/drivers/net/pcnet32.c 2007-08-14

[PATCH] pcnet32: add suspend and resume capability

Add suspend and resume capability to the driver. Tested both to ram and to disk on x86_64 platform. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc3/drivers/net/pcnet32.c.orig 2007-08-14 13:52:24.0 -0700 +++ linux-2.6.23-rc3/drivers/net/pcnet32.c 2007-08-14

Re: Strange soft lockup detected message (looks like spin_lock bug in pcnet32)

All instances of obtaining the lock in pcnet32 are done as spin_lock_irqsave except the interrupt handler itself. The interrupt mask needs to be saved everywhere else, but the interrupt handler is known not to need to save the flags. If the lock is held and the same CPU tries to get the lock agai

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

On Wed, Mar 07, 2007 at 12:15:26PM -0800, Michael K. Edwards wrote: > cacheability of the allocated block. Maybe it doesn't. The alpha > version of pci_alloc_consistent, on the other hand, does interesting > things to make the memory visible to PCI. Don, what arches did you > have in mind when y

[PATCH 2/2] pcnet32: change to use netdev_priv

use netdev_priv() instead of dev->priv Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.21-rc2/drivers/net/one.pcnet32.c 2007-03-06 10:48:37.0 -0800 +++ linux-2.6.21-rc2/drivers/net/pcnet32.c 2

[PATCH 1/2] pcnet32: only allocate init_block dma consistent

platforms, which need to have locks in cached memory Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> Acked-by: Don Fry <[EMAIL PROTECTED]> --- drivers/net/pcnet32.c | 77 ++--- 1 files changed, 34 insertions(+), 43 deletions(-)

Re: [PATCH] pcnet32: only allocate init_block dma consistent

The change to use netdev_priv can only be done After moving the init block out of the private structure. It will break the driver if done first, which is why they were sent together. I will separate the changes and resend them. On Tue, Mar 06, 2007 at 06:13:14AM -0500, Jeff Garzik wrote: >

[PATCH] pcnet32: only allocate init_block dma consistent

platforms, which need to have locks in cached memory Also use netdev_priv() instead of dev->priv Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> Acked-by: Don Fry <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index 36f9d98..8498c

[PATCH ] pcnet32: Fix PCnet32 performance bug on non-coherent architecutres

z CPU this patch increases network bandwidth by about 12%. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Acked-by: Don Fry <[EMAIL PROTECTED]> diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index 36f9d98..4d94ba7 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.

Re: [PATCH 0/5 addendum] NetXen

On Thu, Nov 30, 2006 at 07:15:50PM -0500, Jeff Garzik wrote: > Don Fry wrote: > >The NetXen patches fix many problems in the current #upstream version of > >the driver. It has warts and probably lots of bugs still, but it is > >better than what is queued for mainline i

[PATCH 0/5 addendum] NetXen

The NetXen patches fix many problems in the current #upstream version of the driver. It has warts and probably lots of bugs still, but it is better than what is queued for mainline inclusion at this time. Please apply to 2.6.20. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list

[PATCH 5/5] NetXen: Fix cast error

Fix for pointer casting error. Signed-off-by: Don Fry <[EMAIL PROTECTED]> diff -Nupr netdev-2.6/drivers/net/netxen.four/netxen_nic_hw.c netdev-2.6/drivers/net/netxen/netxen_nic_hw.c --- netdev-2.6/drivers/net/netxen.four/netxen_nic_hw.c 2006-11-30 10:06:24.0 -0800 +++ netd

[PATCH 3/5] NetXen: 64-bit memory fixes and driver cleanup

NetXen: 1G/10G Ethernet Driver updates - These fixes take care of driver on machines with >4G memory - Driver cleanup Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> diff -Nupr netdev-2.6/drivers/net/netxen.two/netxe

[PATCH 1/5] NetXen: Fixed /sys mapping between device and driver

port->netdev = netdev; @@ -1043,7 +1044,7 @@ static int netxen_nic_poll(struct net_de netxen_nic_enable_int(adapter); } - return (done ? 0 : 1); + return !done; } #ifdef CONFIG_NET_POLL_CONTROLLER -- Don Fry [EMAIL PROTECTED] - To unsubscrib

[PATCH 0/5] NetXen: 1G/10G Ethernet Driver updates

a 32-bit one and using the address. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] pcnet32: move/create receive and transmit routines

Move the receive routine and create the transmit routine. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.magicTue Sep 12 10:25:20 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 11:37:43 2006 @@ -299,7

[PATCH 5/5] pcnet32: NAPI implementation

others. Signed-off-by: Len Sorensen <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/orig.Kconfig Wed Jun 28 10:38:45 2006 +++ linux-2.6.17-git13/drivers/net/Kconfig Wed Jun 28 15:36:25 2006 @@ -1300,6 +1300,23 @@ config PCNET3

[PATCH 4/5] pcnet32: break receive routine into two pieces.

Breaking the receive frame processing into two routines for greater clarity. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.move Tue Sep 12 11:37:43 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 14:21:1

[PATCH 2/5] pcnet32: magic number cleanup

Change some magic numbers to clearer names. A few whitespace changes. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.rap Tue Sep 12 10:09:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 10:25:09 2006 @@

[PATCH 1/5] pcnet32: remove unnecessary save/restore register accesses.

Delete unnecessary save/restore of rap in interrupt handler and statistics. tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.orig Fri Sep 8 14:02:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 10:09:1

[PATCH 0/5] pcnet32: NAPI implementation (one more try)

unnecessary save/restore register accesses. [PATCH 2/5] pcnet32: magic number cleanup [PATCH 3/5] pcnet32: move/create receive and transmit routines [PATCH 4/5] pcnet32: break receive routine into two pieces. [PATCH 5/5] pcnet32: NAPI implementation -- Don Fry [EMAIL PROTECTED] - To unsubscribe

[PATCH] pcnet32: Magic number cleanup

Initial magic number cleanup. Delete one unnecessary read and write. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.napi Fri Sep 8 14:04:47 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Fri Sep 8 14:05:09 2006 @@

[PATCH 2/3] pcnet32: NAPI implementation

others. Signed-off-by: Len Sorensen <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/orig.Kconfig Wed Jun 28 10:38:45 2006 +++ linux-2.6.17-git13/drivers/net/Kconfig Wed Jun 28 15:36:25 2006 @@ -1300,6 +1300,23 @@ config PCNET3

[PATCH 1/3] pcnet32: reorganize interrupt, tx, and rx processing

Reorganize code to facilitate NAPI changes. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.orig Fri Sep 8 14:02:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Mon Sep 11 09:07:13 2006 @@ -299,7 +299,6 @@ stat

[PATCH 0/3] pcnet32: reorg, NAPI, and cleanup

it is safer to leave the locking as it is. The requested mmiowb calls were added. Please appply to 2.6.19. 1/3 Code reorganization to facilitate NAPI. 2/3 NAPI implementation. 3/3 Magic number cleanup. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe

[PATCH 2/2] pcnet32: Magic number cleanup

Initial magic number cleanup. Delete one unnecessary read and write. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.napi Fri Sep 8 13:19:53 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Fri Sep 8 13:57:13 2006 @@

[PATCH 1/2] pcnet32: NAPI implementation

others. Signed-off-by: Len Sorensen <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/orig.Kconfig Wed Jun 28 10:38:45 2006 +++ linux-2.6.17-git13/drivers/net/Kconfig Wed Jun 28 15:36:25 2006 @@ -1300,6 +1300,23 @@ config PCNET3

[PATCH 0/2] pcnet32: NAPI support

interrupt handler from deadlocking, and since I would probably forget sometime, it is safer to leave the locking as it is. The requested mmiowb calls were added. Please appply to 2.6.19. 1/2 NAPI implementation. 2/2 Magic number cleanup. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this

Re: [PATCH] pcnet32: fix user visible typo

Alexey, Your patch is fine. I had not looked at the if which would prevent zero cards from even printing. On Mon, Aug 28, 2006 at 04:51:42PM -0700, Don Fry wrote: > The cause of #6428 has already been fixed in v1.32 of the pcnet32 > driver. To be correct, the printk sho

Re: [PATCH] pcnet32: fix user visible typo

_found, cards_found > 1 ? "s" : ""); > > return (pcnet32_have_pci + cards_found) ? 0 : -ENODEV; > } > > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majord

Re: [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver

It looks like you have not run the source throught Lindent as previously requested. Before you submit the code again, please use the Lindent script. I can get the code to ping between two cards. Will be doing more testing tomorrow. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list

[PATCH] pcnet32: break in 2.6.18-rc1 identified

to 2.6.18. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc3-git1/drivers/net/orig.pcnet32.cTue Aug 1 14:47:07 2006 +++ linux-2.6.18-rc3-git1/drivers/net/pcnet32.c Thu Aug 3 08:36:26 2006 @@ -202,6 +202,8 @@ static int homepna[MAX_UNITS]; #define CSR15 15 #

Re: [PATCH] pcnet32: break in 2.6.18-rc1 identified (corrected)

On Wed, Aug 09, 2006 at 12:01:34AM -0400, Jeff Garzik wrote: > Don Fry wrote: > >I noticed this morning that I had the polarity wrong in my patch > >yesterday for older chips in the pcnet32_suspend routine. Here is the > >correct patch to test. > > > >>A chan

[PATCH] pcnet32: break in 2.6.18-rc1 identified (corrected)

ion >= PCNET32_79C970A) { + /* Print the link status and start the watchdog */ + pcnet32_check_media(dev, 1); + mod_timer(&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT); + } i = 0; while (i++ < 100) -- Don Fry [EMAIL PROTE

[PATCH] pcnet32: break in 2.6.18-rc1 identified

a(dev, 1); - mod_timer(&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT); + if (lp->chip_version >= PCNET32_79C970A) { + /* Print the link status and start the watchdog */ + pcnet32_check_media(dev, 1); + mod_timer(&(lp->watchdog_timer), PCNET

Re: Simultanious transmits seems to cause hang on pcnet32

, but I can't see > anything in the transmit code that looks like that could happen. > > -- > Len Sorensen > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at

Re: [PATCH 8/9] pcnet32: NAPI implementation.

On Fri, Jun 30, 2006 at 12:24:38AM +0200, Francois Romieu wrote: > Nit below. > > Don Fry <[EMAIL PROTECTED]> : > [...] > > --- linux-2.6.17-git13/drivers/net/purge.pcnet32.c Thu Jun 29 13:28:24 2006 > > +++ linux-2.6.17-git13/drivers/net/pcnet32.c

[PATCH 7/9] pcnet32: Cleanup rx buffers after loopback test.

More cleanup to pcnet32_loopback_test to release receive buffers if device is not up. Created common routine to free rx buffers. Tested ia32 and ppc64 Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/mcast.pcnet32.c Wed Jun 28 15:16:58 2006 +++ linux-

[PATCH 8/9] pcnet32: NAPI implementation.

others. Signed-off-by: Len Sorensen <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/orig.Kconfig Wed Jun 28 10:38:45 2006 +++ linux-2.6.17-git13/drivers/net/Kconfig Wed Jun 28 15:36:25 2006 @@ -1300,6 +1300,23 @@ config PCNET3

[PATCH 9/9] pcnet32: Magic number cleanup.

Initial magic number cleanup. Delete one unnecessary read and write. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/napi.pcnet32.c Thu Jun 29 13:25:50 2006 +++ linux-2.6.17-git13/drivers/net/pcnet32.cThu Jun 29 13:30:4

[PATCH 5/9] pcnet32: Handle memory allocation failures cleanly when resizing tx/rx rings

Fix pcnet32_set_ringparam to handle memory allocation errors without leaving the adapter in an inoperative state and null pointers waiting to be dereferenced. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/calloc.pcnet32.c Wed

[PATCH 6/9] pcnet32: Suspend the chip rather than restart when changing multicast/promisc

Suspend the chip if possible rather than stop and discard all tx and rx frames, when changing the mcast list or entering/leaving promiscuous mode. Created common pcnet32_suspend routine. Tested ia32 and ppc64 Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drive

[PATCH 1/9] pcnet32: Fix Section mismatch error

Fix Section mismatch error. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/orig.pcnet32.c Wed Jun 28 10:38:46 2006 +++ linux-2.6.17-git13/drivers/net/pcnet32.cWed Jun 28 11:03:38 2006 @@ -277,7 +277,6 @@ struct pcnet32_p

[PATCH 0/9] pcnet32: NAPI support

memory allocation failures cleanly when resizing tx/rx rings 6/9 Suspend the chip rather than restart when changing multicast/promisc 7/9 Cleanup rx buffers after loopback test. 8/9 NAPI implementation. 9/9 Magic number cleanup. -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the

[PATCH 3/9] pcnet32: Fix off-by-one in get_ringparam

Fix off-by-one in pcnet32_get_ringparam Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/device.pcnet32.c Wed Jun 28 11:12:22 2006 +++ linux-2.6.17-git13/drivers/net/pcnet32.cWed Jun 28 11:16:15 2006 @@ -515,10 +515,10 @@ static void pcnet32_get_rin

[PATCH 2/9] pcnet32: Use PCI_DEVICE macro

Jon Mason wrote on Thu, 12 Jan 2006 17:07:49 -0600: This patch adds the PCI_DEVICE macro to the pcnet32 driver. This has been tested on my opteron with my "trident" adapter. Don Fry modified it slightly and tested on ia32 and ppc64. Signed-off-by: Jon Mason <[EMAIL PROTECTED]&g

[PATCH 4/9] pcnet32: Use kcalloc instead of kmalloc and memset

On 2006-03-08 Eric Sesterhenn wrote: converts drivers/net to kzalloc usage. Don Fry modified it to use netif_msg_drv. Tested ia32 and ppc64. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-git13/drivers/net/g

Re: [RFT PATCH] pcnet32: NAPI support

On Wed, Jun 28, 2006 at 10:40:10AM -0400, Lennart Sorensen wrote: > On Fri, Jun 23, 2006 at 02:32:12PM -0700, Don Fry wrote: > > This set of changes combines the work done by Len Sorensen and myself to > > add compile time support for NAPI for the pcnet32 driver. I have tested >

[RFT PATCH] pcnet32: NAPI support

of the many magic numbers in the driver is not yet done. If no-one encounters any problems when testing this, I will break up the several changes, into proper patches and submit them next week. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17/drivers/net/orig.Kconfig 2

[RFT] pcnet32 NAPI changes

This patch is a collection of changes to pcnet32 which does the following: - Fix section mismatch warning. - fix set_ringparam to correctly handle memory allocation failures - fix off-by-one in get_ringparam. - cleanup at end of loopback_test when not up. - Add NAPI to driver, fixing set_ringpara

Re: [PATCH] pcnet32 driver NAPI support

One other problem I ran into. I applied the patch but it will not compile because rl_active is never defined. I have worked around it but ... -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Re: [PATCH] pcnet32 driver NAPI support

On Wed, Jun 07, 2006 at 03:34:56PM -0400, Lennart Sorensen wrote: > On Wed, Jun 07, 2006 at 11:20:40AM -0700, Don Fry wrote: > > > Some areas of concern that you may have addressed already, I have not > > scanned your changes yet, are what happens if the ring size is changed &g

Re: [PATCH] pcnet32 driver NAPI support

ti-step process, and has been the source of problems in the past. Even on UP systems. > > Signed-off-by: Len Sorensen <[EMAIL PROTECTED]> > > Len Sorensen -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2.6.17-rc5] pcnet32: remove incorrect pcnet32_free_ring

. Please apply to 2.6.17. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.17-rc5/drivers/net/orig.pcnet32.c 2006-05-25 15:59:12.0 -0700 +++ linux-2.6.17-rc5/drivers/net/pcnet32.c 2006-05-25 16:09:40.0 -0700 @@ -1774,8 +1774,6 @@ static int pcnet32_open(struct net

Re: [PATCH] pcnet32.c: modify RX ring size through module parameter

> insertion via module parameter 'rx_log_size'. This is needed in some > cases where too small the rx ring > size will cause RX errors upon remote installation via pcnet32 NIC card. > > Signed-off-by: Wen Hsin Chang <[EMAIL PROTECTED]> -- Don Fry [EMAIL PROTECT

[PATCH 2.6.16-git1] pcnet32: support boards with multiple phys

Seewer also tested and improved the patch. ethtool for pcnet32 already supports multiple phys. See also bugzilla bug 4219. Please apply to 2.6.16 Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.16-git1/drivers/net/pcnet32.c.origMon Mar 20 13:53:17 2006 +++ linux-2.6.1

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

course). If I understand correctly, your suggestion is to always have Autoneg selected (options = 0) but the hardware is set by default to use 100Full Fiber. Is that a correct understanding? -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

har pcnet32_gstrings_test[ }; #define PCNET32_TEST_LEN (sizeof(pcnet32_gstrings_test) / ETH_GSTRING_LEN) -#define PCNET32_NUM_REGS 168 +#define PCNET32_NUM_REGS 136 #define MAX_UNITS 8/* More are supported, limit only on options */ static int options[MAX_UNITS]; @@ -265,6 +265,8 @@ static

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

card was just seen but not used, what did the registers of the card contain? ethtool has been enhanced to support the pcnet32 better (at least for me). > > Regards, > Philippe Seewer -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

I am removing linux-kernel from the mailing list, as this thread is more appropriate to netdev, and there is a lot more traffic on linux-kernel. On Fri, Feb 17, 2006 at 09:12:52PM +0100, Seewer Philippe wrote: > > Don Fry wrote: > > Philippe, > > > > On a purely mechani

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

use it's only necessary to override the options once. > > Tested and works. > > Patch applies to 2.6.16-rc3 > Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: pcnet32 devices with incorrect trident vendor ID

e vendor file. This > was with 2.6.9-ish, I don't have the box around any more to confirm > with something more recent. > > Bill -- Don Fry [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] is_valid_ether_addr() returns true for FF:FF:FF:FF:FF:FF

addr(addr); > > + return !is_broadcast_ether_addr(addr) && > > + !is_multicast_ether_addr(addr) && > > + !is_zero_ether_addr(addr); > > } > > > > why not > return !(addr[0] & 1) && !is_zero_ether_addr(

[RFT] pcnet32: support for boards with multiple phys

ings_test[ }; #define PCNET32_TEST_LEN (sizeof(pcnet32_gstrings_test) / ETH_GSTRING_LEN) -#define PCNET32_NUM_REGS 168 +#define PCNET32_NUM_REGS 136 #define MAX_UNITS 8/* More are supported, limit only on options */ static int options[MAX_UNITS]; @@ -265,6 +265,8 @@ static int homepna[MAX_UNITS];