Re: [PATCH v1] Bluetooth: Set missing suspend task bits

2020-12-21 Thread Dmitry Osipenko
04.12.2020 06:14, Howard Chung пишет: > From: Abhishek Pandit-Subedi > > When suspending, mark SUSPEND_SCAN_ENABLE and SUSPEND_SCAN_DISABLE tasks > correctly when either classic or le scanning is modified. > > Signed-off-by: Abhishek Pandit-Subedi > Signed-off-by: Howard Chung > Reviewed-by: A

Re: [PATCH v1] Bluetooth: Set missing suspend task bits

2020-12-21 Thread Dmitry Osipenko
21.12.2020 20:58, Abhishek Pandit-Subedi пишет: > Hi Dmitry, > > https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=295fa2a5647b13681594bb1bcc76c74619035218 > should fix this issue. > > Your issue seems the same as the one I encountered -- the > SUSPEND_DISABL

Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Dmitry Osipenko
20.11.2020 12:52, matthias@kernel.org пишет: > From: Matthias Brugger > > Apart from a firmware binary the chip needs a config file used by the > FW. Add the config files to modinfo so that they can be read by > userspace. > > Signed-off-by: Matthias Brugger > > --- > > Changes in v2: > I

[PATCH v3 3/3] brcmfmac: set F2 SDIO block size to 128 bytes for BCM4329

2020-08-30 Thread Dmitry Osipenko
the downstream BCMDHD driver. The comment in the BCMDHD driver says that 128B improves throughput and turns out that it works for the brcmfmac as well. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 1 file changed, 4 insertions(+) diff

[PATCH v3 0/3] Fixes and improvements for brcmfmac driver

2020-08-30 Thread Dmitry Osipenko
h. v2: - Added "drop chip id from debug messages" as was requested by Arend Van Spriel in the review comment to v1 of the "increase F2 watermark" patch. - Added patches that remove unnecessary "fallthrough" comments and change F2 SDIO bloc

[PATCH v3 2/3] brcmfmac: drop chip id from debug messages

2020-08-30 Thread Dmitry Osipenko
d van Spriel Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

[PATCH v3 1/3] brcmfmac: increase F2 watermark for BCM4329

2020-08-30 Thread Dmitry Osipenko
at is already used for the BCM4339 chip, hence let's re-use it for BCM4329. Reviewed-by: Arend van Spriel Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmf

Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Dmitry Osipenko
27.08.2020 09:23, Gustavo A. R. Silva пишет: > Hi, > > There is a patch that address this, already: > > https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ > > Thanks Okay, then my patch is unnecessary. Thank you!

Re: [PATCH v2 1/4] brcmfmac: increase F2 watermark for BCM4329

2020-08-26 Thread Dmitry Osipenko
27.08.2020 09:04, Dmitry Osipenko пишет: > This patch fixes SDHCI CRC errors during of RX throughput testing on > BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the > checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark > value is borrowed from downs

[PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Dmitry Osipenko
There is no need to insert the "fallthrough" comment if there is nothing in-between of case switches. Hence let's remove the unnecessary comments in order to make code cleaner a tad. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2

[PATCH v2 1/4] brcmfmac: increase F2 watermark for BCM4329

2020-08-26 Thread Dmitry Osipenko
at is already used for the BCM4339 chip, hence let's re-use it for BCM4329. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/ne

[PATCH v2 0/4] Fixes and improvements for brcmfmac driver

2020-08-26 Thread Dmitry Osipenko
drop chip id from debug messages" as was requested by Arend Van Spriel in the review comment to v1 of the "increase F2 watermark" patch. - Added patches that remove unnecessary "fallthrough" comments and change F2 SDIO block size to 128 bytes for BCM

[PATCH v2 3/4] brcmfmac: drop chip id from debug messages

2020-08-26 Thread Dmitry Osipenko
d van Spriel Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

[PATCH v2 4/4] brcmfmac: set F2 SDIO block size to 128 bytes for BCM4329

2020-08-26 Thread Dmitry Osipenko
the downstream BCMDHD driver. The comment in the BCMDHD driver says that 128B improves throughput and turns out that it works for the brcmfmac as well. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329

2020-08-24 Thread Dmitry Osipenko
24.08.2020 11:28, Arend Van Spriel пишет: > > > On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: >> This patch fixes SDHCI CRC errors during of RX throughput testing on >> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the >> checksum problem is observed

[PATCH v1] brcmfmac: increase F2 watermark for BCM4329

2020-08-23 Thread Dmitry Osipenko
d for the BCM4339 chip, hence let's re-use it for BCM4329. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom