r\n");
The sentence structure here seems awkward. I would probably just get rid of
this error and this one later in the function.
dev_err(dev, "Failed to isolate FW level string\n");
Instead just check and report if adapter->fw_version == NULL
. Nunes do Rosario
Applied.
Please do not put empty lines between Fixes: and Signed-off-by: and other
tags, all tags are equal and are placed together in an uninterrupted
sequences of consequetive lines.
Thank you.
--
Desnes Augusto Nunes do Rosário
---
dev_err(dev, "Could not map VPD buffer\n");
kfree(adapter->vpd->buff);
return -ENOMEM;
--
Desnes Augusto Nunes do Rosário
--
Linux Developer - IBM / Brazil
M.Sc. in Electrical and Computer Engineering - UFRN
(11) 9595-30-900
desn...@br.ibm.com
kfree(adapter->vpd->buff);
return -ENOMEM;
--
Desnes Augusto Nunes do Rosário
--
Linux Developer - IBM / Brazil
M.Sc. in Electrical and Computer Engineering - UFRN
(11) 9595-30-900
desn...@br.ibm.com
On 11/10/2017 12:54 PM, Nathan Fontenot wrote:
On 11/10/2017 08:41 AM, Desnes Augusto Nunes do Rosário wrote:
On 11/09/2017 06:31 PM, Nathan Fontenot wrote:
On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote:
This patch implements and enables VDP support for the ibmvnic driver
ndication acl_change_indication;
struct ibmvnic_acl_query acl_query;
struct ibmvnic_generic_crq acl_query_rsp;
@@ -937,6 +950,12 @@ struct ibmvnic_error_buff {
__be32 error_id;
};
+struct ibmvnic_vpd {
+ unsigned char *buff;
+ dma_addr_t dma_addr;
+ u64 len
