[PATCH] [NETNS]: Namespace leak in pneigh_lookup.

release_net is missed on the error path in pneigh_lookup. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neighbour.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 7bb6a9a..174e29e 100644 --- a/ne

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: > Denis V. Lunev wrote: > > On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: > >> Denis V. Lunev wrote: > >>> Default ARP parameters should be findable regardless of the context. > >>&

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: > Denis V. Lunev wrote: > > Default ARP parameters should be findable regardless of the context. > > Required to make inetdev_event working. > > > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > &g

[PATCH 1/17 net-2.6.26] [IPV4]: Remove ifa != NULL check.

This is a callback registered to inet address notifier chain. The check is useless as: - ifa is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/net/via-velocity.c | 22 ++ 1 files chang

[PATCH 3/17 net-2.6.26] [NETFILTER]: Consolidate masq_inet_event and masq_device_event.

They do exactly the same job. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/net/ipv4/netfilter/ipt_MASQUERADE.c b/net/ipv4/netfilter/ipt_MASQUERADE.c index d

[PATCH 2/17 net-2.6.26] [IPV4]: Remove check for ifa->ifa_dev != NULL.

This is a callback registered to inet address notifier chain. The check is useless as: - ifa->ifa_dev is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/atm/clip.c |4 1 files changed, 0 inserti

[PATCH 15/17 net-2.6.26] [NETNS]: Enable all routing manipulation via netlink inside namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 5f67eba..79e2e8a 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2702,9 +

[PATCH 5/17 net-2.6.26] [NETNS]: Register neighbour table parameters in the correct namespace.

neigh_sysctl_register should register sysctl entries inside correct namespace to avoid naming conflict. Typical example is a loopback. Entries for it present in all namespaces. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neigh

[PATCH 16/17 net-2.6.26] [NETNS]: Enable IPv4 address manipulations inside namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index f7e78b7..aa23d10 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -446,9

[PATCH 17/17 net-2.6.26] [NETNS]: Process inet_select_addr inside a namespace.

The context is available from a network device passed in. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index aa23d10..033670d 100644 --- a/ne

[PATCH 4/17 net-2.6.26] [NETNS]: Disable inetaddr notifiers in namespaces other than initial.

ip_fib_init is kept enabled. It is already namespace-aware. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c |3 +++ drivers/net/via-velocity.c |3 +++ drivers/s390/net/qeth_main.c|3 +++ net/sctp/protocol.c |3

[PATCH 8/17 net-2.6.26] [NETNS]: Enable inetdev_event notifier.

After all these preparations it is time to enable main IPv4 device initialization routine inside namespace. It is safe do this now. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/ne

[PATCH 7/17 net-2.6.26] [NETNS]: Disable multicaststing configuration inside non-initial namespace.

Do not calls hooks from device notifiers and disallow configuration from ioctl/netlink layer. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/igmp.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/net/ipv4/ig

[PATCH 14/17 net-2.6.26] [NETNS]: Process devinet ioctl in the correct namespace.

Add namespace parameter to devinet_ioctl and locate device inside it for state changes. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/linux/inetdevice.h |2 +- net/ipv4/af_inet.c |7 --- net/ipv4/devinet.c |6 +++--- net/ipv4/ipco

[PATCH 9/17 net-2.6.26] [NETNS]: DST cleanup routines should be called inside namespace.

Device inside the namespace can be started and downed. So, active routing cache should be cleaned up on device stop. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/dst.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/core/dst.c b/net/core

[PATCH 11/17 net-2.6.26] [IPV4]: rt_cache_get_next should take rt_genid into account.

In the other case /proc/net/rt_cache will look inconsistent in respect to genid. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> --- net/ipv4/route.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff

[PATCH 13/17 net-2.6.26] [NETNS]: Register /proc/net/rt_cache for each namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index c11e6bf..5f67eba 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -545,7

[PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neighbour.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/core/neighbour.c b/ne

[PATCH 12/17 net-2.6.26] [NETNS]: Process /proc/net/rt_cache inside a namespace.

Show routing cache for a particular namespace only. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 67df872..c11e6bf 100644 --- a/net/ipv4/r

[PATCH 10/17 net-2.6.26] [NETNS]: Process ip_rt_redirect in the correct namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 525787b..44708ab 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1132,10 +1132,12 @

[PATCH 0/17] Finish IPv4 infrastructure namespacing.

This set finally allows to manipulate with network devices inside a namespace and allows to configure them [via netlink]. 'route' is not yet supported (but prepared to) as it requires a socket. Additionally, better routing cache support is added. Signed-off-by: Denis V. Lunev <[EM

Re: Network namespace and tc?

Hello, Stephen! Namespaces are not fully implemented yet :) Right now we we have only basic infrastructure in the mainstream and, currently, we can't even run TCP in different namespace :( We hope this will be changed very soon. These marks (net != &init_net) are used to - mark places we need to

Re: [PATCH] [IPV4]: Remove warning in node_set_parent.

ugly :), but Acked-by: Denis V. Lunev <[EMAIL PROTECTED]> On Mon, 2008-02-11 at 11:48 -0800, Stephen Hemminger wrote: > On Mon, 11 Feb 2008 11:47:17 +0300 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > > > net/ipv4/fib_trie.c: In function 'node_set_par

[PATCH] [IPV4]: Remove warning in node_set_parent.

net/ipv4/fib_trie.c: In function 'node_set_parent': net/ipv4/fib_trie.c:184: warning: assignment makes integer from pointer without a cast Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_trie.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-)

[PATCH] [IPV6]: dst_entry leak in ip4ip6_err.

The result of the ip_route_output is not assigned to skb. This means that - it is leaked - possible OOPS below dereferrencing skb->dst - no ICMP message for this case Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv6/ip6_tunnel.c |1 + 1 files changed, 1 inserti

[PATCH] [IGMP]: Optimize kfree_skb in igmp_rcv.

Merge error paths inside igmp_rcv. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/igmp.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index fe2e6cd..d3f34a7 100644 --- a/net/ipv4/igmp.c +++ b/ne

Re: [PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

This has been added by the Daniel Lezcano <[EMAIL PROTECTED]> in the commit d4fa26ff44e31c2636a985e3092e2cd55d8045de. It looks to me a preparatory staff for IPv6 namespacing. I think this is not needed in 2.6.25 but will be required in 2.6.26 very soon. Regards, Den On Fri, 2008-02-08 a

RE: cgroup: limit network bandwidth

Hello, Andrea! I have occasionally seen your patch on LWN (missed one in netdev@) and have two words about. May be this is not too late. I have missed my entire mailbox yesterday and have not followed the discussion. Pls forgive me. Rate-limiting message receive is nothing good at all. First, if

Re: [PATCH 0/17] Finish IPv4 infrastructure namespacing

David Miller wrote: > What part of "no new features" did you not understand? OOPS, again :( sorry, I miss that thread -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.htm

[PATCH 17/17] [NETNS]: Process inet_select_addr inside a namespace.

The context is available from a network device passed in. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index aa23d10..d06a4e6 100644 --- a/ne

[PATCH 15/17] [NETNS]: Enable all routing manipulation via netlink inside namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 8a31e33..92ff622 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2672,9 +

[PATCH 14/17] [NETNS]: Process devinet ioctl in the correct namespace.

Add namespace parameter to devinet_ioctl and locate device inside it for a state changes. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/linux/inetdevice.h |2 +- net/ipv4/af_inet.c |7 --- net/ipv4/devinet.c |6 +++--- net/ipv4/ipco

[PATCH 16/17] [NETNS]: Enable IPv4 address manipulations inside namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index f7e78b7..aa23d10 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -446,9

[PATCH 13/17] [NETNS]: Register /proc/net/rt_cache for each namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index cc002d8..84da794 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -545,7

[PATCH 12/17] [NETNS]: Process /proc/net/rt_cache inside a namespace.

Show routing cache for a particular namespace only. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index b03de57..cc002d8 100644 --- a/net/ipv4/r

[PATCH 7/17] [NETNS]: Disable multicaststing configuration inside namespace.

Do not calls hooks from device notifiers and disallow configuration from ioctl/netlink layer. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/igmp.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/net/ipv4/ig

[PATCH 11/17] [IPV4]: rt_cache_get_next should take rt_genid into account.

In the other case /proc/net/rt_cache will look inconsistent in respect to genid. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Alexey Kuznetsov <[EMAIL PROTECTED]> --- net/ipv4/route.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff

[PATCH 10/17] [NETNS]: Process ip_rt_redirect in the correct namespace.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 8842ecb..8a31e33 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1132,10 +1132,12 @

[PATCH 8/17] [NETNS]: Enable inetdev_event notifier.

After all these preparations it is time to enable main IPv4 device initialization routine inside namespace. It is safe do this now. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/ne

[PATCH 9/17] [NETNS]: DST cleanup routines should be called inside namespace.

Device inside the namespace can be started and downed. So, active routing cache should be cleaned up on device stop. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/dst.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/core/dst.c b/net/core

[PATCH 4/17] [NETNS]: Disable address notifiers in namespaces other than initial.

ip_fib_init is keeped enabled. It is already namespace-aware. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c |3 +++ drivers/net/via-velocity.c |3 +++ drivers/s390/net/qeth_main.c|3 +++ net/sctp/protocol.c |3

[PATCH 6/17] [NETNS]: Default arp parameters lookup.

Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neighbour.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/core/neighbour.c b/ne

[PATCH 5/17] [NETNS]: Register neighbour parameters of the net device in the correct namespace.

neigh_sysctl_register should register sysctl entries inside correct namespace to avoid naming conflict. Typical example is a loopback. Entries for it present in all namespaces. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neigh

[PATCH 3/17] [IPV4]: Consolidate masq_inet_event and masq_device_event.

They do exactly the same job. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/net/ipv4/netfilter/ipt_MASQUERADE.c b/net/ipv4/netfilter/ipt_MASQUERADE.c index d

[PATCH 1/17] [IPV4]: Remove ifa != NULL check.

This is a callback registered to inet address notifiers chains. The check is useless as: - ifa is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/net/via-velocity.c | 22 ++ 1 files c

[PATCH 2/17] [IPV4]: Remove check for ifa->ifa_dev != NULL.

This is a callback registered to inet address notifiers chains. The check is useless as: - ifa->ifa_dev is always != NULL - similar checks are abscent in all other notifiers. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/atm/clip.c |4 1 files changed, 0 inserti

[PATCH 0/17] Finish IPv4 infrastructure namespacing

r this set :) Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [IPV4]: Fix compiler error with CONFIG_PROC_FS=n

Johann Felix Soden wrote: > From: Johann Felix Soden <[EMAIL PROTECTED]> > > Handle CONFIG_PROC_FS=n in net/ipv4/fib_frontend.c because: > > net/ipv4/fib_frontend.c: In function 'fib_net_init': > net/ipv4/fib_frontend.c:1032: error: implicit declaration of function > 'fib_proc_init' > net/ipv4/f

[PATCH] [IPV4]: Formatting fix for /proc/net/fib_trie.

The line in the /proc/net/fib_trie for route with TOS specified - has extra \n at the end - does not have a space after route scope like below. |-- 1.1.1.1 /32 universe UNICASTtos =1 Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_trie.c |3

[PATCH 6/6] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace.

path. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |2 +- net/ipv4/fib_frontend.c |2 +- net/ipv4/fib_semantics.c |6 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index c

[PATCH 4/6] [IPV4]: fib_sync_down rework.

fib_sync_down can be called with an address and with a device. In reality it is called either with address OR with a device. The codepath inside is completely different, so lets separate it into two calls for these two cases. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- inclu

[PATCH 5/6] [NETNS]: Add a namespace mark to fib_info.

This is required to make fib_info lookups namespace aware. In the other case initial namespace devices are marked as dead in the local routing table during other namespace stop. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |1 + net/ipv4/fib_seman

[PATCH 3/6] [NETNS]: Process interface address manipulation routines in the namespace.

The namespace is available when required except rtm_to_ifaddr. Add namespace argument to it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/dev

[PATCH 1/6] [IPV4]: Fix memory leak on error path during FIB initialization.

net->ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem has been introduced by the following commit. commit c8050bf6d84785a7edd2e81591e8f833231477e8 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Jan 10 03:28:24 2008 -0800 Signed-off-by: Denis V. Lune

[PATCH 2/6] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

Remove error code assignment inside brackets on failure. The code looks better if the error is assigned before condition check. Also, the compiler treats this better. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 21 - 1 files chan

[PATCH 0/6] preparations to enable netdevice notifiers inside a namespace (resend)

Here are some preparations and cleanups to enable network device/inet address notifiers inside a namespace. This set of patches has been originally sent last Friday. One cleanup patch from the original series is dropped as wrong, thanks to Daniel Lezcano. -- To unsubscribe from this list: send the

[PATCH 3/3] [RAW]: Wrong content of the /proc/net/raw6.

ed the problem. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/raw.h |3 ++- net/ipv4/raw.c|8 net/ipv6/raw.c|2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/net/raw.h b/include/net/raw.h index c7ea7a2..1828f81

[PATCH 1/3] [RAW]: Family check in the /proc/net/raw[6] is extra.

Different hashtables are used for IPv6 and IPv4 raw sockets, so no need to check the socket family in the iterator over hashtables. Clean this out. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/raw.h |4 +--- net/ipv4/raw.c| 12 net/ipv6/raw.c

[PATCH 2/3] [RAW]: Cleanup IPv4 raw_seq_show.

There is no need to use 128 bytes on the stack at all. Clean the code in the IPv6 style. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/raw.c | 24 +++- 1 files changed, 7 insertions(+), 17 deletions(-) diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c

[PATCH 0/3] [RAW]: proc output cleanups.

due to it. This series of patches fixes original problem and slightly cleanups the code around. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

[PATCH] Debugfs compile fix.

Debugfs is not compiled without CONFIG_SYSFS in net-2.6 tree. Move kobject_create_and_add under appropriate ifdef. The fix looks correct from a first glance, but may be the dependency should be added into the Kconfig. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- fs/debugfs/i

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

Daniel Lezcano wrote: > Denis V. Lunev wrote: >> Daniel Lezcano wrote: >>> Denis V. Lunev wrote: >>>> I could hardly imagine why sombady needs to assign 0.0.0.0 as an >>>> interface >>>> address or interface destination address. The kernel will

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

Daniel Lezcano wrote: > Denis V. Lunev wrote: >> I could hardly imagine why sombady needs to assign 0.0.0.0 as an >> interface >> address or interface destination address. The kernel will behave in a >> strage >> way in several places if this is possible, as ifa_

[PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 9da4c68..e55c85e 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -534,7 +534,13 @@ static

[PATCH 4/7 net-2.6.25] [NETNS]: Process interface address manipulation routines in the namespace.

The namespace is available when required except rtm_to_ifaddr. Add namespace argument to it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/dev

[PATCH 5/7 net-2.6.25] [IPV4]: fib_sync_down rework.

fib_sync_down can be called with an address and with a device. In reality it is called either with address OR with a device. The codepath inside is completely different, so lets separate it into two calls for these two cases. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- inclu

[PATCH 7/7 net-2.6.25] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace.

path. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |2 +- net/ipv4/fib_frontend.c |2 +- net/ipv4/fib_semantics.c |6 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index c

[PATCH 6/7 net-2.6.25] [NETNS]: Add a namespace mark to fib_info.

This is required to make fib_info lookups namespace aware. In the other case initial namespace devices are marked as dead in the local routing table during other namespace stop. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |1 + net/ipv4/fib_seman

[PATCH 1/7 net-2.6.25] [IPV4]: Fix memory leak on error path during FIB initialization.

net->ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem has been introduced by the following commit. commit c8050bf6d84785a7edd2e81591e8f833231477e8 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Jan 10 03:28:24 2008 -0800 Signed-off-by: Denis V. Lune

[PATCH 2/7 net-2.6.25] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

Remove error code assignment inside brackets on failure. The code looks better if the error is assigned before condition check. Also, the compiler treats this better. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 21 - 1 files chan

[PATCH 11/12 net-2.6.25] [NETNS]: Routing cache virtualization.

-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |2 +- net/ipv4/icmp.c |2 +- net/ipv4/route.c| 21 - 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/include/net/route.h b/include/net/route.h index 1985d82..4eabf00 100644

[PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

All needed API is done, the namespace is available when required from the device on the DST entry from the incoming packet. So, just replace init_net with proper namespace. Other protocols will follow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/icmp.c

[PATCH 10/12 net-2.6.25] [NETNS]: Correct namespace for connect-time routing.

ip_route_connect and ip_route_newports are a part of routing API presented to the socket layer. The namespace is available inside them through a socket. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |8 +--- 1 files changed, 5 insertions(+), 3 del

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

Patrick McHardy wrote: > Denis V. Lunev wrote: >> init_net is used added as a parameter to a lot of old API calls, f.e. >> ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export >> init_net >> as EXPORT_SYMBOL to keep networking API consistent. > > &

[PATCH 9/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_key.

Needed to propagate it down to the ip_route_output_flow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/net/bonding/bond_main.c |2 +- include/net/route.h |2 +- net/atm/clip.c |2 +

[PATCH 7/12 net-2.6.25] [NETNS]: Add namespace parameter to __ip_route_output_key.

This is only required to propagate it down to the ip_route_output_slow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |4 ++-- net/ipv4/icmp.c |4 ++-- net/ipv4/route.c|7 --- net/ipv4/xfrm4_policy.c |2 +- 4 files chan

[PATCH 8/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_flow.

Needed to propagate it down to the __ip_route_output_key. Signed_off_by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |2 +- include/net/route.h |6 +++--- net/dccp/ipv4.c |2 +- net/ipv4/af_

[PATCH 3/12 net-2.6.25] [NETNS]: Add netns parameter to fib_select_default.

Currently fib_select_default calls fib_get_table() with the init_net. Prepare it to provide a correct namespace to lookup default route. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h|3 ++- net/ipv4/fib_frontend.c |5 +++-- net/ipv4/route.c

[PATCH 6/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_slow.

This function needs a net namespace to lookup devices, fib tables, etc. in, so pass it there. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 22 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/r

[PATCH 2/12 net-2.6.25] [IPV4]: Consolidate fib_select_default.

The difference in the implementation of the fib_select_default when CONFIG_IP_MULTIPLE_TABLES is (not) defined looks negligible. Consolidate it and place into fib_frontend.c. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h| 10 +- net/ipv4/fib_fron

[PATCH 4/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_dev_find.

in_dev_find() need a namespace to pass it to fib_get_table(), so add an argument. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/infiniband/core/cma.c |2 +- include/linux/inetdevice.h |2 +- net/ipv4/fib_fron

[PATCH 1/12 net-2.6.25] [IPV4]: Declarations cleanup in ip_fib.h.

Two small issues fixed: - fib_select_multipath is exported from fib_semantics.c rather than from fib_frontend.c. So, move the declaration below appropriate comment. - struct rt_entry declaration is not used. Drop it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip

[PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/net_namespace.c |2 +- 1

[PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path.

to work in initial namespace. ICMP replies now also use correct namespace. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

[PATCH 2/6 net-2.6.25] [NETNS] Add netns parameter to inetdev_by_index.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/linux/inetdevice.h |2 +- net/ipv4/devinet.c |6 +++--- net/ipv4/fib_semantics.c |2 +- net/ipv4/igmp.c|4 ++-- net/ipv4/ip_gre.c |3 ++- 5 files changed, 9 insertions(+), 8 del

[PATCH 6/6 net-2.6.25] [NETNS] Pass correct namespace in ip_rt_get_source.

ip_rt_get_source is the infamous place for which dst_ifdown kludges have been implemented. This means that rt->u.dst.dev can be safely dereferrenced obtain nd_net. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 1/6 net-2.6.25] [NETNS] Add netns parameter to fib_lookup.

Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |9 + net/ipv4/fib_frontend.c |4 ++-- net/ipv4/fib_rules.c |4 ++-- net/ipv4/fib_semantics.c |2 +- net/ipv4/route.c |6 +++--- 5 files changed, 13 insertions(+), 12 del

[PATCH 5/6 net-2.6.25] [NETNS] Pass correct namespace in ip_route_input_slow.

The packet on the input path always has a referrence to an input network device it is passed from. Extract network namespace from it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ne

[PATCH 4/6 net-2.6.25] [NETNS] Pass correct namespace in context fib_check_nh.

Correct network namespace is already used in fib_check_nh. Re-work its usage for better readability and pass into fib_lookup & inetdev_by_index. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_semantics.c | 12 ++-- 1 files changed, 6 insertions(+), 6

[PATCH 3/6 net-2.6.25] [NETNS] Pass correct namespace in fib_validate_source.

Correct network namespace is available inside fib_validate_source. It can be obtained from the device passed in. The device is not NULL as in_device is obtained from it just above. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/fib_frontend.c |6 -- 1 files chan

[PATCH 0/6 net-2.6.25] Provide correct namespace on IPv4 packet input path.

This patchset sequentially adds namespace parameter to fib_lookup and inetdev_by_index. After that it is possible to pass network namespace from input packet to routing engine. Output path is much more intrusive and will be sent separately. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>

[PATCH ] [NETNS 3/4 net-2.6.25] Consolidate kernel netlink socket destruction.

Create a specific helper for netlink kernel socket disposal. This just let the code look better and provides a ground for proper disposal inside a namespace. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Tested-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/connector

[PATCH] [NETNS 4/4 net-2.6.25] Namespace stop vs 'ip r l' race.

referrence for a socket, remove it from lookup tables and only after that change namespace and perform a last put. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Tested-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/core/rtnetlink.c | 15 ++- net/ipv4/fib_fronte

[PATCH] [NETNS 2/4 net-2.6.25] Memory leak on network namespace stop.

Network namespace allocates 2 kernel netlink sockets, fibnl & rtnl. These sockets should be disposed properly, i.e. by sock_release. Plain sock_put is not enough. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Tested-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/core/rtnet

[PATCH] [NETNS 1/4 net-2.6.25] Double free in netlink_release.

not used any more. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Tested-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/netlink/af_netlink.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c i

[PATCH 0/4 net-2.6.25] Proper netlink kernel sockets disposal.

ce stop netlink_sock_destruct BUG_TRAP(!atomic_read(&sk->sk_rmem_alloc)); is hit This set address all these issues. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Tested-by: Alexey Dobriayn <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsub

[PATCH 3/3 net-2.6.25] Process FIB rule action in the context of the namespace.

Save namespace context on the fib rule at the rule creation time and call routing lookup in the correct namespace. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/fib_rules.h |1 + net/core/fib_rules.c|2

[PATCH 1/3 net-2.6.25] Add netns to fib_rules_ops.

The backward link from FIB rules operations to the network namespace will allow to simplify the API a bit. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/fib_rules.h |1 + net/decnet/dn_rules.c |1 + net/ipv4

[PATCH 2/3 net-2.6.25] [NETNS] FIB rules API cleanup.

30032991 -12 fib_nl_delrule 568 553 -15 fib_nl_newrule 883 852 -31 Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Acked-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/fib_rules.h |

[PATCH 0/3 net-2.6.25] call FIB rule->action in the correct namespace

row less. Additionally, the patchset cleanups struct net from fib_rules_register/unregister to have network namespace context at the time of default rules creation. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev&quo

  1   2   3   >