Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

On Mon, Feb 13, 2017 at 7:12 AM, Christoph Hellwig wrote: > On Mon, Feb 13, 2017 at 06:42:56AM -0500, David Windsor wrote: >> I'm not sure this is a sound argument for not converting to >> refcount_t. > > It's an argument again the way how this patch was sent.

Re: [kernel-hardening] Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

On Mon, Feb 13, 2017 at 5:54 AM, Hans Liljestrand wrote: > On Sat, Feb 11, 2017 at 01:42:53AM -0500, David Windsor wrote: >> >> >> >>> Signed-off-by: David Windsor >>> --- >>> fs/nfsd/nfs4state.c | 6 +++--- >>> 1 file changed, 3 i

Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

On Mon, Feb 13, 2017 at 5:38 AM, Christoph Hellwig wrote: > On Sat, Feb 11, 2017 at 09:01:15AM -0500, David Windsor wrote: >> I'm not sure there's another way to accomplish what we need >> (initializing struct nfsd4_session objects with refcount=1) without >> also m

Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

On Sat, Feb 11, 2017 at 8:15 PM, Bruce Fields wrote: > On Sat, Feb 11, 2017 at 07:31:42AM -0500, Jeff Layton wrote: >> The basic idea here is that nfsv4 sessions have a "resting state" of 0. >> We want to keep them around, but if they go "dead" then we we'll tear >> them down if they aren't active

Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

On Sat, Feb 11, 2017 at 7:31 AM, Jeff Layton wrote: > On Sat, 2017-02-11 at 01:42 -0500, David Windsor wrote: >> >> >> > Signed-off-by: David Windsor >> > --- >> > fs/nfsd/nfs4state.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deleti

Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

> Signed-off-by: David Windsor > --- > fs/nfsd/nfs4state.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index a0dee8a..b0f3010 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs

[RFC][PATCH] nfsd: add +1 to reference counting scheme for struct nfsd4_session

ount_t API series. Thanks, David Windsor Signed-off-by: David Windsor --- fs/nfsd/nfs4state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index a0dee8a..b0f3010 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.

[PATCH v2 net] net: free ip_vs_dest structs when refcnt=0

ng dest_trash to hold dest with refcnt=1 will allow us to free ip_vs_dest structs when their refcnt=0, in ip_vs_dest_put_and_free(). Signed-off-by: David Windsor --- include/net/ip_vs.h| 2 +- net/netfilter/ipvs/ip_vs_ctl.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-)

[PATCH net] net: free ip_vs_dest structs when refcnt=0

ng dest_trash to hold dest with refcnt=1 will allow us to free ip_vs_dest structs when their refcnt=0, in ip_vs_dest_put_and_free(). Signed-off-by: David Windsor --- include/net/ip_vs.h| 2 +- net/netfilter/ipvs/ip_vs_ctl.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)

Re: Reference counting struct inet_peer

On Tue, Jan 24, 2017 at 2:38 AM, Julian Anastasov wrote: > > Hello, > > On Mon, 23 Jan 2017, David Windsor wrote: > >> Hi, >> >> I'm working on a patchset that adds overflow protection to kernel >> reference counters, as part of the K

Reference counting struct inet_peer

p://lxr.free-electrons.com/source/include/net/ip_vs.h#L1424 static inline void ip_vs_dest_put_and_free(struct ip_vs_dest *dest) { if (atomic_dec_return(&dest->refcnt) < 0) kfree(dest); } Note that this example also appears in a garbage collector internal to net/. Thanks, David Windsor