> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, March 11, 2021 9:20 PM
> To: David Thompson
> Cc: netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Liming
> Sun ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next v4] Add Mellanox BlueField Gigab
> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, March 11, 2021 8:57 PM
> To: David Thompson
> Cc: netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Liming
> Sun ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next v4] Add Mellanox BlueField Gigab
relevant pointers as NULL, not 0
b) Change mlxbf_gige_get_mac_rx_filter() to return void,
as this function's return status is not used by caller
c) Fixed type definition of "buff" in mlxbf_gige_get_regs()
Signed-off-by: David Thompson
Signed-off-by: Asmaa Mnebhi
Revie
einit()
to initialize relevant pointers as NULL, not 0
b) Change mlxbf_gige_get_mac_rx_filter() to return void,
as this function's return status is not used by caller
c) Fixed type definition of "buff" in mlxbf_gige_get_regs()
Signed-off-by: David Thompson
Signed-off-by: Asmaa Mnebh
> > +config MLXBF_GIGE
> > + tristate "Mellanox Technologies BlueField Gigabit Ethernet support"
> > + depends on (ARM64 || COMPILE_TEST) && ACPI && INET
>
> Why do you depend on INET? :S
>
When I wrote the Kconfig definition I was thinking that "INET" is an
obvious functional dependency for
_get_mac_rx_filter() to return void,
as this function's return status is not used by caller
c) Fixed type definition of "buff" in mlxbf_gige_get_regs()
Signed-off-by: David Thompson
Signed-off-by: Asmaa Mnebhi
Reviewed-by: Jiri Pirko
Reported-by: kernel test robot
> -Original Message-
> From: David Thompson
> Sent: Wednesday, July 29, 2020 2:29 PM
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net; k...@kernel.org; Jiri Pirko ;
> David Thompson ; Asmaa Mnebhi
>
> Subject: [PATCH net-next] Add Mellanox BlueField
for ARM64, ARM32, X86_64
- Tested ARM64 build on FastModels & Palladium
Signed-off-by: David Thompson
Signed-off-by: Asmaa Mnebhi
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/Kconfig |1 +
drivers/net/ethernet/mellanox/Makefile |1 +
drivers/n
