Lv Yunlong wrote:
> In the case RXRPC_PACKET_TYPE_DATA of rxrpc_input_packet, if
> skb_unshare(skb,..) failed, it will free the skb and return NULL.
> But if skb_unshare() return NULL, the freed skb will be used by
> rxrpc_eaten_skb(skb,..).
That's not precisely the case:
void rxrpc_eat
ported-by: kernel test robot
> Signed-off-by: Vadim Fedorenko
Looks reasonable.
Acked-by: David Howells
eported-by: kernel test robot
Signed-off-by: Vadim Fedorenko
Signed-off-by: David Howells
Reviewed-by: Xin Long
cc: a...@dev.mellanox.co.il
cc: Jakub Kicinski
---
net/rxrpc/Kconfig |1 +
1 file changed, 1 insertion(+)
diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index d706bb408365..08
eported-by: kernel test robot
Suggested-by: Vadim Fedorenko
Signed-off-by: David Howells
cc: Xin Long
cc: a...@dev.mellanox.co.il
cc: Jakub Kicinski
---
net/rxrpc/Kconfig |1 +
1 file changed, 1 insertion(+)
diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index d706bb408365..0885b22e5c0e 10
Xin Long wrote:
> Subject: [PATCH net-next] rxrpc: use udp tunnel APIs instead of open code in
> rxrpc_open_socket
>
> Signed-off-by: Xin Long
You can add "Acked-by: David Howells " if you want.
David
Xin Long wrote:
> > If you could arrange for a random port to be assigned in such a case (and
> > indicated back to the caller), that would be awesome. Possibly I just don't
> > need to actually use bind in this case.
> >
> The patch is attached (based on this patch):
Initial testing seems to s
Xin Long wrote:
> BTW: do you have any testing for this?
If you're using a distro like a recent-ish Fedora or, I think, Debian, you
should be able to install a kafs-client package. If that works, start the
afs.mount service with systemctl and then look in /afs. You should see
directories corre
nable()
> where it increases both UDP and UDPv6 encap_needed_key and sets
> up->encap_enabled.
>
> v4->v5:
> - add the missing '#include ', as David Howells
> noticed.
>
> Acked-and-tested-by: David Howells
> Signed-off-by: Xin Long
Looks good.
David
Xin Long wrote:
> BTW, I'm also thinking to use udp_sock_create(), the only problem I can
> see is it may not do bind() in rxrpc_open_socket(), is that true? or we
> can actually bind to some address when a local address is not supplied?
If a local address isn't explicitly bound to the AF_RXRPC
syzbot+3d1c772efafd3c38d...@syzkaller.appspotmail.com
Signed-off-by: David Howells
cc: Hillf Danton
---
net/rxrpc/call_object.c |2 --
1 file changed, 2 deletions(-)
diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c
index c845594b663f..4eb91d958a48 100644
--- a/net/rxrpc/call
Xin Long wrote:
> I saw the state of this patchset is still new, should I repost it?
It needs a fix in patch 2 (see my response to that patch).
Thanks,
David
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
7ef09ba11b33e371c9a8510c1f56e40aa0862c65
Hillf Danton wrote:
> --- a/net/rxrpc/call_object.c
> +++ b/net/rxrpc/call_object.c
> @@ -549,6 +549,7 @@ void rxrpc_release_call(struct rxrpc_soc
> if (call->security)
> call->security->free_call_crypto(call);
>
> + cancel_work_sync(&call->processor);
> rxrpc_clea
work out the fix.
Reported-by: syzbot+df400f2f24a1677cd...@syzkaller.appspotmail.com
Reported-by: Vadim Fedorenko
Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
Signed-off-by: David Howells
Acked-by: Vadim Fedorenko
---
fs/afs/main.c|6 +++---
net/rxrpc/
Vadim Fedorenko wrote:
> You missed the call to dst_release(sk->sk_rx_dst) in
> rxrpc_sock_destructor. Without it we are still leaking the dst.
Hmmm... I no longer get the messages appearing with this patch. I'll have
another look.
David
work out the fix.
Reported-by: syzbot+df400f2f24a1677cd...@syzkaller.appspotmail.com
Reported-by: Vadim Fedorenko
Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
Signed-off-by: David Howells
---
fs/afs/main.c|6 +++---
net/rxrpc/af_rxrpc.c |6 +++---
2 fil
gt;] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
[<637076d4>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 9ebeddef58c4 ("rxrpc: rxrpc_peer needs to hold a ref on the rxrpc_local
record")
Signed-off-by: Takeshi Misawa
Reported-and-tested-by: syzbot+305326672
net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -16,6 +16,7 @@
#include
#include
#include
+#include
#include
#include "ar-internal.h"
With that, it seems to work still:
Acked-and-tested-by: David Howells
David
Jakub Kicinski wrote:
> On Tue, 12 Jan 2021 15:59:15 +0000 David Howells wrote:
> > From: Baptiste Lepers
> >
> > The call state may be changed at any time by the data-ready routine in
> > response to received packets, so if the call state is to be read and acted
() to read the state a few lines above the
unmarked read in rxrpc_input_data(), so use that value rather than
re-reading it.
Signed-off-by: Baptiste Lepers
Signed-off-by: David Howells
---
net/rxrpc/input.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/input.c
("rxrpc: Downgrade the BUG() for unsupported token type in
rxrpc_read()")
Reported-by: Tom Rix
Signed-off-by: David Howells
Reviewed-by: Tom Rix
---
net/rxrpc/key.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index 96
Baptiste Lepers wrote:
> The call state may be changed at any time by the data-ready routine in
> response to received packets, so if the call state is to be read and acted
> upon several times in a function, READ_ONCE() must be used unless the call
> state lock is held.
I'm going to add:
A
Tom Rix wrote:
> On 1/6/21 11:44 AM, David Howells wrote:
> > Tom Rix wrote:
> >
> >> These two loops iterate over the same data, i believe returning here is all
> >> that is needed.
> > But if the first loop is made to support a new type, but the second
Tom Rix wrote:
> These two loops iterate over the same data, i believe returning here is all
> that is needed.
But if the first loop is made to support a new type, but the second loop is
missed, it will then likely oops. Besides, the compiler should optimise both
paths together.
David
David Howells wrote:
> How about this?
> ...
> Fix the second loop so that it doesn't encode the size and type of an
> unsupported token, but rather just ignore it as does the first loop.
Actually, a better way is probably just to error out in this case. This
should
How about this?
David
---
commit 5d370a9db65a6fae82f09a009430ae40c564b0ef
Author: David Howells
Date: Wed Jan 6 16:21:40 2021 +
rxrpc: Fix handling of an unsupported token type in rxrpc_read()
Clang static analysis reports the following:
net/rxrpc/key.c:657:11
t...@redhat.com wrote:
> - switch (token->security_index) {
> - case RXRPC_SECURITY_RXKAD:
> ...
> - switch (token->security_index) {
> - case RXRPC_SECURITY_RXKAD:
These switches need to be kept. There's another security type on the way.
See:
htt
Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
Reviewed-by: David Howells
Ard Biesheuvel wrote:
> Apparently, it is permitted for gss_krb5_cts_crypt() to do a
> kmalloc(GFP_NOFS) in the context from where gss_krb5_aes_encrypt() is
> being invoked, and so I don't see why it wouldn't be possible to
> simply kmalloc() a scatterlist[] of the appropriate size, populate it
>
David Howells wrote:
> I wonder - would it make sense to reserve two arrays of scatterlist structs
> and a mutex per CPU sufficient to map up to 1MiB of pages with each array
> while the krb5 service is in use?
Actually, simply reserving a set per CPU is probably unnecessary. We c
I wonder - would it make sense to reserve two arrays of scatterlist structs
and a mutex per CPU sufficient to map up to 1MiB of pages with each array
while the krb5 service is in use?
That way sunrpc could, say, grab the mutex, map the input and output buffers,
do the entire crypto op in one go an
Ard Biesheuvel wrote:
Ard Biesheuvel wrote:
> > > > I wonder if it would help if the input buffer and output buffer didn't
> > > > have to correspond exactly in usage - ie. the output buffer could be
> > > > used at a slower rate than the input to allow for buffering inside the
> > > > crypto a
Ard Biesheuvel wrote:
> > I wonder if it would help if the input buffer and output buffer didn't
> > have to correspond exactly in usage - ie. the output buffer could be used
> > at a slower rate than the input to allow for buffering inside the crypto
> > algorithm.
> >
>
> I don't follow - how
Ard Biesheuvel wrote:
> > Yeah - the problem with that is that for sunrpc, we might be dealing with
> > 1MB
> > plus bits of non-contiguous pages, requiring >8K of scatterlist elements
> > (admittedly, we can chain them, but we may have to do one or more large
> > allocations).
> >
> > > However
Herbert Xu wrote:
> > Herbert recently made some changes for MSG_MORE support in the AF_ALG
> > code, which permits a skcipher encryption to be split into several
> > invocations of the skcipher layer without the need for this complexity
> > on the side of the caller. Maybe there is a way to reus
Ard Biesheuvel wrote:
> The tricky thing with CTS is that you have to ensure that the final
> full and partial blocks are presented to the crypto driver as one
> chunk, or it won't be able to perform the ciphertext stealing. This
> might be the reason for the current approach. If the sunrpc code
Bruce Fields wrote:
> OK, I guess I don't understand the question. I haven't thought about
> this code in at least a decade. What's an auxilary cipher? Is this a
> question about why we're implementing something, or how we're
> implementing it?
That's what the Linux sunrpc implementation call
Bruce Fields wrote:
> > Reading up on CTS, I'm guessing the reason it's like this is that CTS is the
> > same as the non-CTS, except for the last two blocks, but the non-CTS one is
> > more efficient.
>
> CTS is cipher-text stealing, isn't it? I think it was Kevin Coffman
> that did that, and I
Hi Chuck, Bruce,
Why is gss_krb5_crypto.c using an auxiliary cipher? For reference, the
gss_krb5_aes_encrypt() code looks like the attached.
>From what I can tell, in AES mode, the difference between the main cipher and
the auxiliary cipher is that the latter is "cbc(aes)" whereas the former is
Herbert Xu wrote:
> Couldn't you just change the output sg to include the offset?
That depends on whether the caller has passed it elsewhere for some other
parallel purpose, but I think I'm going to have to go down that road and
restore it afterwards.
David
Btw, would it be feasible to make it so that an extra parameter can be added
to the cipher buffer-supplying functions, e.g.:
skcipher_request_set_crypt(req, input, ciphertext_sg, esize, iv);
such that we can pass in an offset into the output sg as well?
David
Vladimir Oltean wrote:
> The last user of the RTNL brother of dev_getfirstbyhwtype (the latter
> being synchronized under RCU) has been deleted in commit b4db2b35fc44
> ("afs: Use core kernel UUID generation").
>
> Cc: Arnd Bergmann
> Cc: David Howells
> Cc
Herbert Xu wrote:
> > Here's my first cut at a generic Kerberos crypto library in the kernel so
> > that I can share code between rxrpc and sunrpc (and cifs?).
>
> I can't find the bit where you are actually sharing this code with
> sunrpc, am I missing something?
I haven't done that yet. Sorr
Joe Perches wrote:
> It seems no other follow-on patch in the series uses this nameless union.
There will be a follow on series. Either this:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk
or this:
https://git.kernel.org/pub/scm/lin
Ask the security class how much header and trailer space to allow for when
allocating a packet, given how much data is remaining.
This will allow the rxgk security class to stick both a trailer in as well
as a header as appropriate in the future.
Signed-off-by: David Howells
---
net/rxrpc/ar
to just add the displacement to the next offset.
Signed-off-by: David Howells
---
net/rxrpc/rxkad.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index f3182edfcbae..e5b4bbdd0f34 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@
Organise the security information in the rxrpc_connection struct to use a
union to allow for different data for different security classes.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h | 11 ---
net/rxrpc/rxkad.c | 40
2
encrypt-and-checksum function that is used in a number of circumstances.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |5 +
net/rxrpc/insecure.c|6 ++
net/rxrpc/rxkad.c | 24 +---
net/rxrpc/sendmsg.c |6 ++
4 files changed, 14
Merge the ->prime_packet_security() into the ->init_connection_security()
hook as they're always called together.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |2 --
net/rxrpc/conn_client.c |6 --
net/rxrpc/conn_event.c |4
net/rxrpc/insecure.
Fix an example of an rxrpc key name in a comment.
Signed-off-by: David Howells
---
net/rxrpc/key.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index 7e6d19263ce3..9631aa8543b5 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
Allow a security class to give more information on an rxrpc_s-type key when
it is viewed in /proc/keys. This will allow the upcoming RxGK security
class to show the enctype name here.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |3 +++
net/rxrpc/server_key.c |4
2
When parsing a payload for an rxrpc-type key, ignore any tokens that are
not of a known type and don't give an error for them - unless there are no
tokens of a known type.
Signed-off-by: David Howells
---
net/rxrpc/key.c | 31 +--
1 file changed, 21 inser
Make the parsing of xdr-encoded payloads, as passed to add_key, more
coherent. Shuttling back and forth between various variables was a bit
hard to follow.
Signed-off-by: David Howells
---
net/rxrpc/key.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff
-off-by: David Howells
---
net/rxrpc/ar-internal.h | 11 +
net/rxrpc/rxkad.c | 47 +++
net/rxrpc/security.c|2 +-
net/rxrpc/server_key.c | 56 +++
4 files changed, 86 insertions(+), 30
Don't let someone reading a service-side rxrpc-type key get access to the
session key that was exchanged with the client. The server application
will, at some point, need to be able to read the information in the ticket,
but this probably shouldn't include the key material.
Signed-off
Split the server private key type (rxrpc_s) out into its own file rather
than mingling it with the authentication/client key type (rxrpc) since they
don't really bear any relation.
Signed-off-by: David Howells
---
net/rxrpc/Makefile |1
net/rxrpc/ar-internal.h |9 ++-
net/
ding types. Keys of this type have an extra bit in the
description:
":::"
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h | 11 +++---
net/rxrpc/call_accept.c | 14
net/rxrpc/conn_event.c |1 -
net/rxrpc/conn_object.c |1 -
net/rxrpc/co
higher layer) and go through the
tokens to find one that's supported.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |4 +++-
net/rxrpc/conn_event.c |3 ++-
net/rxrpc/insecure.c|3 ++-
net/rxrpc/rxkad.c |5 ++---
net/rxrpc/security.c|
When viewing an rxrpc-type key through /proc/keys, display a list of held
token types.
Signed-off-by: David Howells
---
net/rxrpc/key.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index fb4d2a2fca02
Remove the rxrpc rxk5 security class as it's now defunct and nothing uses
it anymore.
Signed-off-by: David Howells
---
include/keys/rxrpc-type.h | 55 -
net/rxrpc/key.c | 468 -
2 files changed, 523 deletions(-)
diff --git a/in
ls/linux-fs.git
rxrpc-next-20201123
and can also be found on the following branch:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next
David
---
David Howells (17):
keys: Provide the original description to the key preparser
rxrpc: Remove the rxk5
it's better to do that when
the key is loaded rather than deep in trying to process a response packet.
Signed-off-by: David Howells
cc: Jarkko Sakkinen
cc: keyri...@vger.kernel.org
---
include/linux/key-type.h |1 +
security/keys/key.c |2 ++
2 files changed, 3 insertions(+)
Chuck Lever wrote:
> Really? My understanding of the Linux kernel SUNRPC implementation is
> that it uses asynchronous, even for small data items. Maybe I'm using
> the terminology incorrectly.
Seems to be synchronous, at least in its use of skcipher:
grep -e skcipher *
gss_krb5_crypto.c:#inclu
Chuck Lever wrote:
> > There are three main interfaces to it:
> >
> > (*) I/O crypto: encrypt, decrypt, get_mic and verify_mic.
> >
> > These all do in-place crypto, using an sglist to define the buffer
> > with the data in it. Is it necessary to make it able to take separate
> > i
Would it be possible/practical to make the skcipher encrypt functions take an
offset into the scatterlist rather than always starting at the beginning?
David
---
net/rxrpc/ar-internal.h |1
net/rxrpc/key.c | 136 +++
net/rxrpc/rxgk.c| 25 +
net/rxrpc/rxgk_app.c| 135 +++
net/rxrpc/rxgk_common.h |2 +
net/rxrpc/security.c
inserted into the security-specific field in
the RX header, and we try and expand it to 32-bits to make it last longer.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |6 ++
net/rxrpc/conn_object.c |2 +
net/rxrpc/rxgk.c| 156
Implement the aes128-cts-hmac-sha1-96 and aes256-cts-hmac-sha1-96 enctypes
from rfc3962, using the rfc3961 kerberos 5 simplified crypto scheme.
Signed-off-by: David Howells
---
crypto/krb5/Makefile |3 +
crypto/krb5/internal.h|6 ++
crypto/krb5/main.c|2 +
crypto
Provide key derivation interface functions and a helper to implement the
PRF+ function from rfc4402.
Signed-off-by: David Howells
---
crypto/krb5/Makefile |1
crypto/krb5/kdf.c | 223 +
include/crypto/krb5.h | 29 ++
3 files
Implement the basic parts of the yfs-rxgk security class (security index 6)
to support GSSAPI-negotiated security.
Signed-off-by: David Howells
---
include/trace/events/rxrpc.h |4
net/rxrpc/Makefile |2
net/rxrpc/ar-internal.h | 12
net/rxrpc/rxgk.c
in:
tools.ietf.org/html/draft-wilkinson-afs3-rxgk-11
Signed-off-by: David Howells
---
net/rxrpc/Kconfig | 10 ++
net/rxrpc/Makefile |3 +
net/rxrpc/ar-internal.h |3 +
net/rxrpc/rxgk_common.h | 44
net/rxrpc/rxgk_kdf.c| 271
=6803
Signed-off-by: David Howells
---
crypto/krb5/Kconfig|3
crypto/krb5/Makefile |3
crypto/krb5/internal.h |6 +
crypto/krb5/main.c |2
crypto/krb5/rfc6803_camellia.c | 249
crypto/krb5
KEN_CELL_MAX = 64;
struct ktc_setTokenData {
afs_int32 flags;
string cell;
token_opaque tokens;
};
The parser for the basic token struct is already present, as is the rxkad
token type. This adds a parser for the rxgk token type.
Signed-off-by: David Howells
---
Add the security index for the YFS variant of rxgk.
Signed-off-by: David Howells
---
fs/afs/misc.c | 13 +
include/uapi/linux/rxrpc.h | 17 +
2 files changed, 30 insertions(+)
diff --git a/fs/afs/misc.c b/fs/afs/misc.c
index 1d1a8debe472
Add the self-testing data from rfc8009 to test AES + HMAC-SHA2.
Signed-off-by: David Howells
---
crypto/krb5/selftest_data.c | 116 +++
1 file changed, 116 insertions(+)
diff --git a/crypto/krb5/selftest_data.c b/crypto/krb5/selftest_data.c
index
Implement the aes128-cts-hmac-sha256-128 and aes256-cts-hmac-sha384-192
enctypes from rfc8009, overriding the rfc3961 kerberos 5 simplified crypto
scheme.
Signed-off-by: David Howells
---
crypto/krb5/Kconfig|2
crypto/krb5/Makefile |3 -
crypto/krb5/internal.h |6
Implement self-testing infrastructure to test the pseudo-random function,
key derivation, encryption and checksumming.
Signed-off-by: David Howells
---
crypto/krb5/Kconfig |4
crypto/krb5/Makefile|4
crypto/krb5/internal.h | 48
crypto/krb5/main.c
Implement encryption and decryption functions for AES + HMAC-SHA2 as
described in rfc8009 sec 5.
Signed-off-by: David Howells
---
crypto/krb5/rfc8009_aes2.c | 205
1 file changed, 203 insertions(+), 2 deletions(-)
diff --git a/crypto/krb5
Implement the simplified crypto profile for Kerberos 5 rfc3961 with the
pseudo-random function, PRF(), from section 5.3 and the key derivation
function, DK() from section 5.1.
Signed-off-by: David Howells
---
crypto/krb5/Makefile |3
crypto/krb5/internal.h |6
Add functions that sign and verify a piece of an skbuff according to
rfc3961 sec 5.4, using Kc to generate a checksum and insert it into the MIC
field in the skbuff in the sign phase then checksum the data and compare it
to the MIC in the verify phase.
Signed-off-by: David Howells
---
crypto
Add functions that encrypt and decrypt a piece of an skbuff according to
rfc3961 sec 5.3, using Ki to checksum the data to be secured and Ke to
encrypt it during the encryption phase, then decrypting with Ke and
verifying the checksum with Ki in the decryption phase.
Signed-off-by: David Howells
Add some constants from the sunrpc headers.
Signed-off-by: David Howells
---
include/crypto/krb5.h | 39 +++
1 file changed, 39 insertions(+)
diff --git a/include/crypto/krb5.h b/include/crypto/krb5.h
index 2bd6cfe50b85..a7e4ab4e1348 100644
--- a/include
Provide core structures, an encoding-type registry and basic module and
config bits for a generic Kerberos crypto library.
Signed-off-by: David Howells
---
crypto/Kconfig |1 +
crypto/Makefile|1 +
crypto/krb5/Kconfig| 11 ++
crypto/krb5/Makefile |9
rpc patches that are a prerequisite for
this, but the crypto patches don't need it.
---
The patches can be found here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=crypto-krb5
David
---
David Howells (18):
crypto/krb5: Implement Kerberos crypto
#syz fix: afs: Fix cell removal
#syz fix: afs: Fix cell removal
Hi Herbert, Dave, Trond,
I've written basic gssapi-derived security support for AF_RXRPC:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk
I've borrowed some bits from net/sunrpc/auth_gss/ but there's a lot in there
that is quite specific to the su
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8
Signed-off-by: David Howells
cc: Hillf Danton
---
net/rxrpc/conn_client.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c
index 78c845a4f1ad..5d9adfd4c84f 100644
--- a/net/rxrpc/conn_client.c
+++ b/net/rxrpc/con
quot;rxrpc: Delay terminal ACK transmission on a client call")
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |1 +
net/rxrpc/conn_client.c |3 +++
net/rxrpc/conn_event.c |6 +++---
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/rxrpc/ar-internal.h
/dhowells/linux-fs.git
rxrpc-next-20201015
David
---
David Howells (2):
rxrpc: Fix bundle counting for exclusive connections
rxrpc: Fix loss of final ack on shutdown
net/rxrpc/ar-internal.h | 1 +
net/rxrpc/conn_client.c | 3 +++
net/rxrpc/conn_event.c | 6 +++---
3 files
Julia Lawall wrote:
> - call->completion = compl,
> + call->completion = compl;
Looks good. Do you want me to pick up the patch or send it yourself?
If the latter:
Acked-by: David Howells
David Miller wrote:
> I think the ".txt" at the end of the branch name is a mistake.
Sigh. That's the name of the file with the cover message in it (named for the
tag). I need to adjust my script yet more to check not only that the tag name
is in there, but that it also doesn't have any bits o
quest_key
mechanism")
Signed-off-by: David Howells
---
net/rxrpc/key.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index c668e4b7dbff..75e84ed4fa63 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
@@ -940,7 +940,7 @@ int rx
et.
Change the mode of operation for userspace rxrpc server sockets to work
like this too. Although this is a UAPI change, server sockets aren't
currently functional.
Fixes: 248f219cb8bc ("rxrpc: Rewrite the data and ack handling code")
Signed-off-by: David Howells
---
include/u
If someone calls setsockopt() twice to set a server key keyring, the first
keyring is leaked.
Fix it to return an error instead if the server key keyring is already set.
Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by
userspace and kernel both")
Signed-off
s should have separate call number
spaces")
Signed-off-by: David Howells
---
net/rxrpc/conn_event.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c
index 447f55ca6886..6e972b4823ef 100644
--- a/net/rxrpc/conn_even
ty index 5 keys (Kerberos 5)")
Signed-off-by: David Howells
---
net/rxrpc/key.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index 8f7d7a6187db..c668e4b7dbff 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
@@ -1107,7 +1107,8
kernel/git/dhowells/linux-fs.git
rxrpc-fixes-20201005.txt
and can also be found on the following branch:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes
David
---
David Howells (5):
rxrpc: Downgrade the BUG() for unsupported token type in
quot;)
Signed-off-by: Marc Dionne
Signed-off-by: David Howells
---
net/rxrpc/key.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index 94c3df392651..8f7d7a6187db 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
@@ -1072,7 +1
1 - 100 of 1054 matches
Mail list logo
