> > This patch should resolve a problem that's troubled support for
> > some RNDIS peripherals. It seems to have boiled down to using a
> > variable to establish transfer size limits before it was assigned,
> > which caused those devices to fallback to a default "jumbogram"
> > mode we don't suppo
On Sunday 24 February 2008, Sam Ravnborg wrote:
> From a quick look this is wrong.
> smc_drv_probe is assined the .probe member so it is used during
> hotplug and thus should be __devinit.
> Likewise smc_probe is used by smc_drv_probe and thus smc_probe
> should be __devinit too.
Thing is, with o
__init
annotation or the annotation of smc_probe is wrong.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/net/smc91x.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/smc91x.c 2008-02-24 18:50:32.0 -0800
+++ b/drivers/net/smc91x.c
o a default "jumbogram"
mode we don't support. Fix by assigning it earlier for RNDIS.
Signed-off-by: Jean-Christophe Dubois <[EMAIL PROTECTED]>
[ cleanups ]
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
This bugfix should be merged before 2.6.25-final.
. e.g. bit set or cleared.
It's basically what the previous wait_phy_ready() did, but this
version is generalized to support the handshaking needed to
enter and exit low power mode.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
Signed-off-by: Claudio Lanconelli <[EMAIL PROTECTED
Minor bugfixes to the enc28j60 driver ... wrong section marking,
indentation, and bogus use of spi_bus_type. There's still major
overuse of printk; essentially every place it's used should switch
to dev_*() messaging primitives.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
A
Prevent oops on enc28j60 packet RX: make sure buffers are aligned.
Not all architectures support unaligned accesses in kernel space.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
Acked-by: Claudio Lanconelli <[EMAIL PROTECTED]>
---
Seems the enc28j60 patches didn't get picke
void __exit plusb_exit(void)
{
- usb_deregister(&plusb_driver);
+ usb_deregister(&plusb_driver);
}
module_exit(plusb_exit);
MODULE_AUTHOR("David Brownell");
-MODULE_DESCRIPTION("Prolific PL-2301/2302 USB Host to Host Link Driver");
+MODULE_DESCRIPTION("Prolific PL
On Thursday 14 February 2008, tony_gibbs wrote:
> I have tried to make the changes I have been working on and testing with
> your help into a patch as attached.
>
> Please let me know what you think of it.
It arrived line wrapped, and turned on debug options that
should stay off by default ... it
On Monday 11 February 2008, Claudio Lanconelli wrote:
> I have tried your latest patch. Only after the following change it
> works fine (no more rx errors during ifconfig up).
Hmm, what chip rev do you have? Different errata and all.
ISTR mine is rev4; so, not the most current, but not the
oldest
On Thursday 07 February 2008, Claudio Lanconelli wrote:
> David Brownell wrote:
> > How long did that take? I did about four dozen
> >
> > ifconfig eth1 up
> > sleep 3
> > ifconfig eth1 down
> >
> > cycles ... it worked fine. The "s
. e.g. bit set or cleared.
It's basically what the previous wait_phy_ready() did, but this
version is generalized to support the handshaking needed to
enter and exit low power mode.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/net/e
On Thursday 07 February 2008, Claudio Lanconelli wrote:
> Sorry,
> let me repeat what I said in previous mail.
> I propose you to add set_lowpower(true) in the enc28j60_probe()
As the current patch does...
> and in the enc28j60_net_close() after enc28j60_hw_disable().
> Probably we don't need
s that power usage by a factor of around 100.
This version provides a generic routine to poll a register until
its masked value equals some value ... e.g. bit set or cleared.
It's basically what the previous wait_phy_ready() did, but this
version is generalized to support the handshaking needed
Minor bugfixes to the enc28j60 driver ... wrong section marking and
indentation, and bogus use of spi_bus_type. (Setting the bus type
of a driver is a SPI framework responsibility.)
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
Bonus patch.
drivers/net/enc28j60.c |5 ++---
1
On Wednesday 06 February 2008, Claudio Lanconelli wrote:
> Good idea, but with your patch applied, after some ifconfig down -
> ifconfig up cycle, the
> enc28j60 is left in an unknown state and it doesn' Rx/Tx anything.
How long did that take? I did about four dozen
ifconfig eth1 up
> > Keep enc28j60 chips in low-power mode when they're not in use.
> > At typically 120 mA, these chips run hot even when idle. Low
> > power mode cuts that power usage by a factor of around 100.
>
> Good idea, but with your patch applied, after some ifconfig down -
> ifconfig up cycle, the
> enc
=== CUT HERE
Prevent oops on enc28j60 packet RX: make sure buffers are aligned.
Not all architectures support unaligned accesses in kernel space.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/net/enc28j60.c |3 ++-
1 files changed, 2 insertions(+), 1 deletio
From: David Brownell <[EMAIL PROTECTED]>
Prevent unaligned packet oops on enc28j60 packet RX.
Keep enc28j60 chips in low-power mode when they're not in use.
At typically 120 mA, these chips run hot even when idle. Low
power mode cuts that power usage by a factor of around 100.
Si
On Sunday 27 January 2008, Jussi Kivilinna wrote:
> Add RNDIS physical medium checking into generic_rndis_bind() and also make
> rndis_host to be only bind on every medium except wireless.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <
On Sunday 27 January 2008, Jussi Kivilinna wrote:
>
> I'm not very familiar with posting patches (as some might have noticed)
> so I have some questions.. if you don't mind. Now that you have acked
> most of the patches, is it ok for me to add your 'Acked-by' to those
> patches?
On those patches
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> ---
>
> drivers/net/usb/asix.c |3
> drivers/net/usb/cdc_ether.c|3
> drivers/net/usb/cdc_subset.c |3
> drivers/net/usb/dm960
On Friday 25 January 2008, Jussi Kivilinna wrote:
> Callback to signal link state changes from minidriver to
> 'subminidrivers'.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> ---
>
On Friday 25 January 2008, Jussi Kivilinna wrote:
> + if(flags & FLAG_RNDIS_PHYM_WIRELESS &&
> + *phym != RNDIS_PHYSICAL_MEDIUM_WIRELESS_LAN) {
> + dev_err(&intf->dev, "driver requires wireless physical "
> + "medium, b
IS_CONFIG_PARAMETER right after rndis_host has
> initialized hardware with RNDIS_INIT.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
... though I'm not sure I'd coin a term like "subminidriver". ;)
On Friday 25 January 2008, Jussi Kivilinna wrote:
> Hello,
>
> Here is the third try on wireless RNDIS patchset.
>
> Patches 1-9 are from second patchset (with name change rndis_wext ->
> rndis_wlan
> in comments where needed):
> 1. Fix sparse warning: returning void valued expression
> 2. [cd
On Friday 25 January 2008, Jussi Kivilinna wrote:
> On Thu, 2008-01-24 at 17:19 -0800, David Brownell wrote:
> > > 13. [rndis_host] blacklist known wireless RNDIS devices
> >
> > That will be a headache over time though ... can't you just
> > let the probe succe
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> When bind fails after device was initialized, shutdown device properly
> by sending RNDIS_MSG_HALT.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Hello,
>
> This is second try on wireless RNDIS patchset started by Bjorge Dijkstra.
> Since
> Bjorge has disappeared, I claim maintainership of rndis_wext and this patchset
> until he returns.
>
> This patchset adds support for various 802.1
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Blacklist known wireless RNDIS devices that will be handled by
> rndis_wext module.
This seems destined to become a headache. Wouldn't it be better
to let the probe progress far enough to detect that it's actually
a WLAN device, and then back
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Split up rndis_host.c into rndis_host.h and rndis_base.c. This is done so
> that rndis_wext can reuse common parts with rndis_host.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Function pointer is for rndis minidrivers that need to do work on device right
> after RNDIS_INIT. For example setting device specific configuration parameters
> with OID_GEN_RNDIS_CONFIG_PARAMETER.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PR
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Add a private data pointer to usbnet for rndis_wext module to use.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> ---
>
> drivers/net/usb/usbnet.h
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Export rndis_host functions and also rename rndis_bind() to
> generic_rndis_bind() for modules using rndis_host as base.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]&
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> Use wlan device name for RNDIS wireless devices.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> -
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> RNDIS packet filter flags are not exactly the same as CDC flags
> so we cannot reuse them.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> rndis_command requires the caller to pass in a buffer of at least 1KB.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David Br
s for all RNDIS style devices
> when they are missing.
>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> ---
>
> drivers/net/usb/cdc_ether.c | 10
On Saturday 19 January 2008, Jussi Kivilinna wrote:
> From: Bjorge Dijkstra <[EMAIL PROTECTED]>
>
> rndis_unbind and usbnet_cdc_unbind don't return anything.
>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
> Signed-off-by: Jussi Kivilinna <[EMAIL
On Tuesday 08 January 2008, Johannes Berg wrote:
>
> > I see that the rndis_wext.c Kconfig won't kick in unless the
> > 802.11 stuff is available ... what additional dependencies
> > does that imply for a fatter rndis_host module?
>
> No extra modules are currently required for just plain wext [1
#x27;s actually a sane way to split that stuff
into its own module, too...)
- Dave
> - Jussi Kivilinna
>
> On Sat, 2007-12-22 at 17:17 -0800, David Brownell wrote:
> > > From: Bjorge Dijkstra <[EMAIL PROTECTED]>
> > > Subject: [PATCH 6/8] [PATCH] Split up rndis_host.c
On Wednesday 02 January 2008, Alan Stern wrote:
> BTW, I don't recall ever seeing Tony's patch announced on
> linux-usb or linux-usb-devel. Did I simply miss it?
I think he didn't post it. I got some questions from him at
one point, which I answered, but as I recall he decided for
some re
> From: Bjorge Dijkstra <[EMAIL PROTECTED]>
> Subject: [PATCH 0/8] RFC: Wireless Extensions for rndis_host
> Date: Sat, 22 Dec 2007 22:51:26 +0100
>
> Hello all,
>
> I have here a patchset that needs some review.
> This patchset adds wireless extensions for rndis_host to
> enable support for RNDIS
gt;
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
... though it'd be a bit nicer IMO to see this before patch #7,
and just have one (or two) patches that only add in
> From: Bjorge Dijkstra <[EMAIL PROTECTED]>
> Subject: [PATCH 7/8] Add Wireless Extensions to rndis_host
> Date: Sat, 22 Dec 2007 22:51:33 +0100
>
> The bulk of this patch is the addition of a new file that
> implements the wireless extensions for RNDIS devices.
> The rest are some smaller changes
> From: Bjorge Dijkstra <[EMAIL PROTECTED]>
> Subject: [PATCH 6/8] [PATCH] Split up rndis_host.c
> Date: Sat, 22 Dec 2007 22:51:32 +0100
>
> Split up rndis_host.c into rndis_host.h and rndis_base.c and
> change Makefile accordingly. This is done so we can add extra
> source files to the rndis_host
> Date: Sat, 22 Dec 2007 22:51:31 +0100
>
> From: Jussi Kivilinna <[EMAIL PROTECTED]>
>
> RNDIS packet filter flags are not exactly the same as CDC flags
> so we cannot reuse them.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dij
ind fails.
> Date: Sat, 22 Dec 2007 22:51:30 +0100
>
> From: Jussi Kivilinna <[EMAIL PROTECTED]>
>
> When bind fails after device was initialized, shutdown device properly
> by sending RNDIS_MSG_HALT.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
>
nbind
> Date: Sat, 22 Dec 2007 22:51:29 +0100
>
> From: Jussi Kivilinna <[EMAIL PROTECTED]>
>
> rndis_command requires the caller to pass in a buffer of at least 1KB.
>
> Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]>
> Signed-off-by: Bjorge Dijkst
f-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
Note what this tells us about how little Microsoft cares about
the interoperability specs they claim to conform to. Having
those descriptors is *NOT* optional in their (incomplete and
in adequate) RN
Dec 2007 22:51:27 +0100
>
> rndis_unbind and usbnet_cdc_unbind don't return anything.
>
> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
> ---
> drivers/net/usb/rndis_host.c |2 +-
> 1 files changed, 1 insertions(+),
On Wednesday 07 November 2007, Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > But on the other hand, it seems that only the ASIX code will work
> > > > right; the DM9601 and MCS7830 Kconfig is different/wrong.
> > &g
> > But on the other hand, it seems that only the ASIX code will work
> > right; the DM9601 and MCS7830 Kconfig is different/wrong.
>
> I'm not seeing the problem.
>
> Which configuration will be handled wrongly?
Notice how only the ASIX kconfig depended on NET_ETHERNET...
since MII depends on N
On Friday 02 November 2007, Adrian Bunk wrote:
> <-- snip -->
>
>
> This patch fixes the following compile error with CONFIG_MII=m,
> CONFIG_USB_USBNET=y, CONFIG_USB_USBNET_MII=n:
This is the patch I liked better, if there was going to be
one going upstream without additional test from me ...
On Wednesday 07 November 2007, David Miller wrote:
> David, I hate to say this and point you out like this, but you are a
> real cancer for bug fixes to USB things in the kernel,
You didn't hate it enough to find a way to deal with your issue
that doesn't involve namecalling or other flamage, I'll
On Friday 02 November 2007, Adrian Bunk wrote:
> This approach has two disadvantages:
> - it's complicated
No more so than the problem itself.
> - the MII stuff is an implementation detail, and we shouldn't bother
> the user with it (especially since we can do better)
That's a Kconfig policy
= CUT HERE
Simplify handling of the MII-dependent usbnet based adapters: stick
to forward dependencies, and explicitly handle the core dependency.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/net/usb/Kconfig | 23 ---
drivers/net/usb/usbnet.c |
On Thursday 01 November 2007, Adrian Bunk wrote:
> All this USB_USBNET_MII trickery is simply not worth it considering how
> few code it saves.
Depends on what systems you're talking about. Forcing unused
code into the kernel is not free, especially if that's made into
a design policy and applie
On Thursday 01 November 2007, Randy Dunlap wrote:
> The MII functions aren't available unless NET_ETHERNET=y.
> Howver, the MII functions aren't always needed...
>
> David, any ideas on this one?
It's been several years since I looked at this. It
used to behave just fine.
Something must have ch
> From [EMAIL PROTECTED] Tue Oct 23 10:51:00 2007
> Date: Tue, 23 Oct 2007 21:40:18 +0400
> From: Valentine Barshak <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Cc: netdev@vger.kernel.org
> Subject: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer
> allocations.
>
> On syst
On Monday 13 August 2007, Jeff Garzik wrote:
> Oliver Neukum wrote:
> > Hi,
> >
> > this implements support for USB autosuspend in the asix USB ethernet
> > driver.
> >
> > Regards
> > Oliver
> > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
>
> David, does this look OK to you
On Friday 06 July 2007, jing xiang wrote:
> Hi,
>
> This patch is for cdc subset to support Mavell vendor/product ID.
>
> Jing Xiang
>
> Signed-off-by: Jing Xiang<[EMAIL PROTECTED]>
Acked-by: David Brownell <[EMAIL PROTECTED]>
>
> diff -uNpr linux-2.6.2
ve values as success in both checks.
>
> Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]>
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
... though I'd adjust comments to say "non-negative" rather
than "positive". Most folks won't say that zero is
On Monday 02 July 2007, Peter Korsgaard wrote:
> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to only
> accept 0 as success in both c
Remove an "sparse" warning about a shadowed variable name.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/net/usb/cdc_ether.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
--- g26.orig/drivers/net/usb/cdc_ether.c2007-07-01 11:40:37.
> > > > @@ -3610,15 +3610,14 @@
> > > > USB CDC ETHERNET DRIVER
> > > > P: Greg Kroah-Hartman
> >
> > I think that may refer to the old cdc ethernet driver
> > though ... Greg? The new one, in the usbnet framework,
> > is a very different beast...
>
> Yeah, this is the cdc_acm driver that i
kernel.org
> > W: http://pegasus2.sourceforge.net/
> > S: Maintained
> >
> > @@ -3717,8 +3715,7 @@
> > USB RTL8150 DRIVER
> > P: Petko Manolov
> > M: [EMAIL PROTECTED]
> > -L: [EMAIL PROTECTED]
> > -L: [EMAIL PROTECTED]
> > +L: net
On Thursday 08 February 2007 1:01 am, Zhu Yi wrote:
> A generic requirement for dynamic power management is the hardware
> resource should not be touched when you put it in a low power state.
That is in no way a "generic" requirement. It might apply specifically
to one ipw2100 low power state ..
On Tuesday 16 January 2007 1:13 am, Nate Diller wrote:
> On 1/15/07, David Brownell <[EMAIL PROTECTED]> wrote:
> > What's needed is an async, non-sleeeping, interface ... with I/O
> > overlap. That's antithetical to using read()/write() calls, so
> > your pro
On Monday 15 January 2007 8:25 pm, Nate Diller wrote:
> I don't think we should be waiting on sync I/O
> at the *top* of the call stack, like with wait_on_sync_kiocb(), I'd
> say the best place to wait is at the *bottom*, down in the I/O
> scheduler.
Erm ... *what* I/O scheduler? These I/O requ
On Monday 15 January 2007 5:54 pm, Nate Diller wrote:
> This removes the aio implementation from the usb gadget file system.
NAK. I see a deep mis-understanding here.
> Aside
> from making very creative (!) use of the aio retry path, it can't be of any
> use performance-wise
Other than the
On Monday 15 January 2007 5:54 pm, Nate Diller wrote:
> --- a/drivers/usb/gadget/inode.c 2007-01-12 14:42:29.0 -0800
> +++ b/drivers/usb/gadget/inode.c 2007-01-12 14:25:34.0 -0800
> @@ -559,35 +559,32 @@ static int ep_aio_cancel(struct kiocb *i
> return value;
> }
>
On Wednesday 20 December 2006 11:08 pm, Stephen Hemminger wrote:
> David Brownell wrote:
> > Hmm, this reminds me of a thread from last summer, following up on
> > some PM discussions at OLS. Thread "Runtime power management for
> > network interfaces", at the end
Hmm, this reminds me of a thread from last summer, following up on
some PM discussions at OLS. Thread "Runtime power management for
network interfaces", at the end of July.
> 2) Network device infrastructure should make it easier for devices:
> bring interface down on suspend and bring it up
On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote:
> It seems to lack the "select MII" at the USB_RTL8150 option that was in
> Randy's first patch?
I was just addressing the usbnet issues ... that driver doesn't
use the usbnet framework.
- Dave
-
To unsubscribe from this list: send the li
On Tuesday 31 October 2006 5:23 pm, Adrian Bunk wrote:
> select MII if USB_NET_AX8817X!=n || USB_NET_MCS7830!=n
Thing is, I'm seeing that get morphed inside Kconfig to "select MII" in
some cases ... the "if x != n" gets ignored, MII can't be deselected.
That looks to me like a Kconfig de
NET=y and USBNET_MII=n); I think
I've noticed that same problem in other situations too. So the result can
mean kernels being bloated by stuff that's needlessly enabled ... better
than wrongly being disabled, but contributing to bloat.
Signed-off-by: David Brownell <[EMAIL PROTECTED
> > ...
> > depends on MII if MII != n
> >
> > except that Kconfig doesn't comprehend conditionals like that.
>
> You can express this in Kconfig:
> depends MII || MII=n
Except that:
Warning! Found recursive dependency: USB_USBNET USB_NET_AX8817X MII USB_USBNET
I
> > +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE)
> > +#define HAVE_MII
> >...
>
> This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage
> (as already described earlier in this thread)?
Well, "alluded to" not described. Fixable by the equivalent of
config USB_USBNET
On Saturday 28 October 2006 2:13 pm, Christoph Hellwig wrote:
>
> I still don't quite like the approach. What about simply putting
> the mii using functions into usbnet-mii.c and let makefile doing
> all the work? This would require a second set of ethtool ops,
> but I'd actually consider that a
drivers follow the standard convention
("select MII") given Randy's patch #1 of 2.
- Dave
-
The usbnet infrastructure must not reference MII symbols unless they're
provided in the kernel being built. This extends also to the ethtool
hooks that referen
On Wednesday 25 October 2006 10:05 pm, Randy.Dunlap wrote:
> >
> > ... MII should still depend on ETHERNET, right?
> > Just not limited to 10/100 Ethernet.
>
> There is no such config symbol. NET_ETHERNET means 10/100 ethernet.
> Gigabit ethernet doesn't use the ETHERNET symbol (and doesn't use
On Wednesday 25 October 2006 4:58 pm, Randy Dunlap wrote:
> On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
>
> > Instead, "usbnet.c" should #ifdef the relevant ethtool hooks
> > according to CONFIG_MII ... since it's completely legit to
> > use
On Wednesday 25 October 2006 4:59 pm, Randy Dunlap wrote:
> On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
>
> > The other parts are right, this isn't.
> >
> > Instead, "usbnet.c" should #ifdef the relevant ethtool hooks
> > according to
> @@ -94,6 +95,7 @@ config USB_RTL8150
>
> config USB_USBNET
> tristate "Multi-purpose USB Networking Framework"
> + select MII
> ---help---
> This driver supports several kinds of network links over USB,
> with "minidrivers" built around a common network driver c
On Sunday 15 October 2006 6:10 pm, Andrew Morton wrote:
> - A printk if something went bad
Where "bad" would I hope exclude cases where the device
doesn't support MWI ... that is, the "go faster if you can"
advice from the driver, where it isn't an error to run into
the common case of _this_ impl
> > If the drivers doesn't care and if it makes no difference to performance
> > then just delete the call to pci_set_mwi().
> >
> > But if MWI _does_ make a difference to performance then we should tell
> > someone that it isn't working rather than silently misbehaving?
To repeat: it's not "mis
ow the criteria by which "if(ptr)" is judged a waste of effort in all
callers, but that more extensive PCI configspace logic was not...
- Dave
CUT HERE
Remove bogus annotation of pci_set_mwi() as __must_check. It's completely
reasonable for drivers to not care about the retur
> > Most drivers should be able to say "enable MWI if possible, but
> > don't worry if it's not possible". Only a few controllers need
> > additional setup to make MWI actually work ... if they couldn't
> > do that setup, that'd be worth a warning before they backed off
> > to run in a non-MWI mod
(From Alan Cox:)
> The underlying bug is that someone marked pci_set_mwi must-check, that's
> wrong for most of the drivers that use it. If you remove the must check
> annotation from it then the problem and a thousand other spurious
> warnings go away.
Yes, there seems to be abuse of this new "mu
> But the only effect of returning EINVAL is a printk (for this particular
> driver):
>
> /* PCI Memory-Write-Invalidate cycle support is optional (uncommon) */
> retval = pci_set_mwi(pdev);
> if (!retval)
> ehci_dbg(ehci, "MWI active\n");
Erm, I've lost con
On Monday 31 July 2006 9:17 am, Stephen Hemminger wrote:
> On Tue, 25 Jul 2006 11:59:52 -0400 (EDT)
> Alan Stern <[EMAIL PROTECTED]> wrote:
>
> > During a Power Management session at the Ottawa Linux Symposium, it was
> > generally agreed that network interface drivers ought to automatically
> > s
On Tuesday 25 July 2006 8:59 am, Alan Stern wrote:
> During a Power Management session at the Ottawa Linux Symposium, it was
> generally agreed that network interface drivers ought to automatically
> suspend their devices (if possible) whenever:
>
> (1) The interface is ifconfig'ed down, or
>
On Saturday 03 June 2006 3:25 pm, Oliver Neukum wrote:
> Am Samstag, 3. Juni 2006 21:35 schrieb Daniel Drake:
> > Oliver Neukum wrote:
> > > +static int read_mac_addr(struct zd_chip *chip, u8 *mac_addr)
> > > +{
> > > + static const zd_addr_t addr[2] = { CR_MAC_ADDR_P1, CR_MAC_ADDR_P2 };
> > > + re
94 matches
Mail list logo
