On 4/19/21 10:52 AM, Kasper Dupont wrote:
> On 19/04/21 10.10, David Ahern wrote:
>> On 4/19/21 9:44 AM, Kasper Dupont wrote:
>>>
>>> Is there any update regarding this change?
>>>
>>> I noticed this regression when it was used in a DoS attack on on
On 4/19/21 9:44 AM, Kasper Dupont wrote:
> On 17/03/21 15.53, Thadeu Lima de Souza Cascardo wrote:
>> IFF_POINTOPOINT interfaces use NUD_NOARP entries for IPv6. It's possible to
>> fill up the neighbour table with enough entries that it will overflow for
>> valid connections after that.
>>
>> This
On 4/16/21 2:16 AM, Xuan Zhuo wrote:
> In page_to_skb(), if we have enough tailroom to save skb_shared_info, we
> can use build_skb to create skb directly. No need to alloc for
> additional space. And it can save a 'frags slot', which is very friendly
> to GRO.
>
> Here, if the payload of the rece
On 4/15/21 8:57 PM, Bala Sajja wrote:
>please find the ip link show output(for ifindex) and ping and
> its corresponding perf fib events output. OIF seems MGMT(ifindex 5)
> always, not enslaved interfaces ?
that is the reason it does not work.
On 4/17/21 8:49 PM, Tony Ambardar wrote:
> The 'ip' utility hardcodes the assumption of being a 2-char command, where
> any follow-on characters are passed as an argument:
>
> $ ./ip-full help
> Object "-full" is unknown, try "ip help".
>
> This confusing behaviour isn't seen with 'tc' for ex
ib_nexthops.sh | 15 +++
> 1 file changed, 15 insertions(+)
>
Reviewed-by: David Ahern
-off-by: Ido Schimmel
> Reviewed-by: Petr Machata
> ---
> net/ipv4/nexthop.c | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
Reviewed-by: David Ahern
Any reason not to put this in -net with a Fixes tag?
[ cc author of 648700f76b03b7e8149d13cc2bdb3355035258a9 ]
On 4/16/21 3:58 PM, Keyu Man wrote:
> Hi,
>
>
>
> My name is Keyu Man. We are a group of researchers from University
> of California, Riverside. Zhiyun Qian is my advisor. We found the code
> in processing IPv4/IPv6 fragments will p
On 4/15/21 12:15 AM, Bala Sajja wrote:
> When interfaces are not part of VRF and below ip address config is
> done on these interfaces, ping with -I (interface) option, we see
> packets transmitting out of the right interfaces.
>
> ip addr add 2.2.2.100 peer 1.1.1.100/32 dev enp0s3
> ip addr ad
[ cc Ben ]
On 4/15/21 9:51 AM, Rob Dover wrote:
> Hi there,
>
> I'm working on an application that's programming IPSec connections via XFRM
> on VRFs. I'm seeing some strange behaviour in cases where there is an
> enslaved interface on the VRF - was wondering if anyone has seen something
> lik
On 4/15/21 9:03 AM, Lorenzo Bianconi wrote:
>> On 4/15/21 8:05 AM, Daniel Borkmann wrote:
>
> [...]
&stats);
>>>
>>> Given we stop counting drops with the netif_receive_skb_list(), we
>>> should then
>>> also remove drops from trace_xdp_cpumap_kthread(), imho, as otherwise it
>>> is rather
>>
On 4/15/21 8:05 AM, Daniel Borkmann wrote:
> On 4/13/21 6:22 PM, Lorenzo Bianconi wrote:
>> Rely on netif_receive_skb_list routine to send skbs converted from
>> xdp_frames in cpu_map_kthread_run in order to improve i-cache usage.
>> The proposed patch has been tested running xdp_redirect_cpu bpf s
On 4/14/21 12:33 AM, Pavel Balaev wrote:
>>
>> This should work the same for IPv6.
> I wanted to add IPv6 support after IPv4 will be approved,
> anyway no problem, will add IPv6 in next version
>> And please add test cases under tools/testing/selftests/net.
> This feature cannot be tested whithin
+), 6 deletions(-)
>
Acked-by: David Ahern
Thanks, Nicolas.
On 4/13/21 4:55 AM, Balaev Pavel wrote:
> Ability for a user to assign seed value to multipath route hashes.
> Now kernel uses random seed value to prevent hash-flooding DoS attacks;
> however, it disables some use cases, f.e:
>
> +---++--+++
> | |-eth0---| FW
On 4/5/21 7:33 PM, Chunmei Xu wrote:
> since id is unique for nexthop, it is heavy to dump all nexthops.
> use existing delete_nexthop to support flush by id
>
> Signed-off-by: Chunmei Xu
> ---
> ip/ipnexthop.c | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
appl
net.c | 3 ++-
> net/ipv6/addrconf.c | 32 ++--
> 4 files changed, 31 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern
Since this is a single patch set, just put this good cover letter
content as the message in the patch.
On 4/7/21 12:03 PM, Andrea Mayer wrote:
> diff --git a/include/uapi/linux/seg6_local.h b/include/uapi/linux/seg6_local.h
> index 3b39ef1dbb46..ae5e3fd12b73 100644
> --- a/include/uapi/linux/seg6_local.h
> +++ b/include/uapi/linux/seg6_local.h
> @@ -27,6 +27,7 @@ enum {
> SEG6_LOCAL_OIF,
>
On 3/31/21 10:03 PM, Chunmei Xu wrote:
> since id is unique for nexthop, it is heavy to dump all nexthops.
> use existing delete_nexthop to support flush by id
>
> Signed-off-by: Chunmei Xu
> ---
> ip/ipnexthop.c | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
th
On 3/31/21 8:34 PM, Hoang Le wrote:
> To avoid code duplication, tipc should be converted to use the helper
> functions for working with libmnl in lib/mnl_utils.c
>
> Acked-by: Jon Maloy
> Signed-off-by: Hoang Le
> ---
> tipc/bearer.c| 38 ++
> tipc/cmdl.c | 2 -
> tipc/
; case for UDP_GRO
>
> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
> Signed-off-by: Norman Maurer
> ---
> net/ipv4/udp.c | 4
> 1 file changed, 4 insertions(+)
>
Reviewed-by: David Ahern
On 3/31/21 9:49 PM, Stephen Hemminger wrote:
> @@ -5681,14 +5682,29 @@ static int inet6_set_iftoken(struct inet6_dev *idev,
> struct in6_addr *token)
>
> ASSERT_RTNL();
>
> - if (!token)
> + if (!token) {
You forgot to add a message here.
> return -EINVAL;
> -
On 3/31/21 7:10 AM, Norman Maurer wrote:
> Friendly ping…
>
> As this missing change was most likely an oversight in the original commit I
> do think it should go into 5.12 and subsequently stable as well. That’s also
> the reason why I didn’t send a v2 and changed the commit message / subject
On 3/31/21 5:53 AM, Ido Schimmel wrote:
>> @@ -124,6 +125,9 @@ static int flush_nexthop(struct nlmsghdr *nlh, void *arg)
>> if (tb[NHA_ID])
>> id = rta_getattr_u32(tb[NHA_ID]);
>>
>> +if (filter.id && filter.id != id)
>> +return 0;
>> +
>> if (id && !delete_
On 3/30/21 7:05 AM, Ido Schimmel wrote:
> Looks like a bug. 'flush' does not really make sense with 'id', but
> 'list id' works, so I think 'flush id' should also work.
right, neither were intended. If you know the id, you don't need the
generic list / flush option.
>
> Can you send a patch?
Ag
On 3/26/21 6:50 AM, Simon Horman wrote:
> From: Baowen Zheng
>
> Allow a policer action to enforce a rate-limit based on packets-per-second,
> configurable using a packet-per-second rate and burst parameters.
>
> e.g.
> # $TC actions add action police pkts_rate 1000 pkts_burst 200 index 1
> #
On 3/26/21 9:05 AM, Cooper Ry Lees wrote:
> From: Cooper Lees
>
> - Open Routing is using ID 99 for it's installed routes
> - https://github.com/facebook/openr
> - Kernel has accepted 99 in `rtnetlink.h`
>
> Signed-of-by: Cooper Lees
> ---
> etc/iproute2/rt_protos | 1 +
> 1 file changed, 1 in
ned-off-by: Xiongfeng Wang
> ---
> net/ipv6/ip6_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern
g prototype for
> l3mdev_master_upper_ifindex_by_index(). Prototype was for
> l3mdev_master_upper_ifindex_by_index_rcu() instead
>
> Reported-by: Hulk Robot
> Signed-off-by: Xiongfeng Wang
> ---
> net/l3mdev/l3mdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: David Ahern
sit.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: David Ahern
_grp_entry::mpath was renamed to ::hthr as
> well.
>
> UAPI artifacts were obviously left intact.
>
> Suggested-by: David Ahern
> Signed-off-by: Petr Machata
> ---
> include/net/nexthop.h | 4 ++--
> net/ipv4/nexthop.c| 56 +++++--
> 2 files changed, 30 insertions(+), 30 deletions(-)
>
Thanks for the followup.
Reviewed-by: David Ahern
Signed-off-by: Yejune Deng
> ---
> net/ipv4/route.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern
On 3/23/21 10:39 AM, Ron Bonica wrote:
> Hi Folks,
>
>
>
> The rationale for RFC 8335 can be found in Section 5.0 of that document.
> Currently, ICMP ECHO and ECHO RESPONSE messages can be used to determine
> the liveness of some interfaces. However, they cannot determine the
> liveness of:
>
On 3/24/21 7:56 PM, Hoang Le wrote:
> Add support extack in tipc to dump the netlink extack error messages
> (i.e -EINVAL) sent from kernel.
>
> Acked-by: Jon Maloy
> Signed-off-by: Hoang Le
> ---
> tipc/msg.c | 29 ++---
> 1 file changed, 22 insertions(+), 7 deletions(-
On 3/22/21 11:02 AM, Matteo Croce wrote:
> From: Matteo Croce
>
> This series enables recycling of the buffers allocated with the page_pool API.
> The first two patches are just prerequisite to save space in a struct and
> avoid recycling pages allocated with other API.
> Patch 2 was based on a p
subject line should have net-next as the target branch
On 3/23/21 4:20 AM, Yejune Deng wrote:
> Put if and else if together, and remove unnecessary judgments, because
> it's caller can make sure it is true. And add likely() in
> ipv4_confirm_neigh().
>
> Signed-off-by: Yejune Deng
> ---
> net/
On 3/22/21 3:29 AM, Eelco Chaudron wrote:
>
>
> On 20 Mar 2021, at 4:42, David Ahern wrote:
>
>> On 3/19/21 3:47 PM, Lorenzo Bianconi wrote:
>>> diff --git a/include/net/xdp.h b/include/net/xdp.h
>>> index 19cd6642e087..e47d9e8da547 100644
>>> --- a/
On 3/19/21 10:57 AM, Sabrina Dubroca wrote:
> This patch adds support for setting and displaying the Traffic Flow
> Confidentiality attribute for an XFRM state, which allows padding ESP
> packets to a specified length.
>
> Signed-off-by: Sabrina Dubroca
> ---
> ip/ipxfrm.c| 8
>
On 3/20/21 6:20 PM, Riccardo Paolo Bestetti wrote:
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index 50a73178d63a..734c0332b54b 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -717,6 +717,7 @@ static int raw_bind(struct sock *sk, struct sockaddr
> *uaddr, int addr_len)
> {
>
On 3/19/21 10:24 PM, David Ahern wrote:
> At the end of the day, what is the value of this feature vs the other
> ICMP probing set?
Merging the conversations about both of these RFCs since my comments and
questions are the same for both.
What is the motivation for adding support for thes
On 3/20/21 10:01 AM, Andreas Roeseler wrote:
> On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote:
>> On 3/17/21 9:19 PM, David Miller wrote:
>>> From: Andreas Roeseler
>>> Date: Wed, 17 Mar 2021 22:11:47 -0500
>>>
>>>> On Mon, 2021-03-15 at 04:
On 3/19/21 6:53 PM, Willem de Bruijn wrote:
> On Fri, Mar 19, 2021 at 7:54 PM David Ahern wrote:
>>
>> On 3/19/21 10:11 AM, Ishaan Gandhi wrote:
>>> Thank you. Would it be better to do instead:
>>>
>>> + if_index = skb->skb_iif;
>>>
>
On 3/19/21 3:47 PM, Lorenzo Bianconi wrote:
> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index 19cd6642e087..e47d9e8da547 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -75,6 +75,10 @@ struct xdp_buff {
> struct xdp_txq_info *txq;
> u32 frame_sz:31; /* frame s
On 3/19/21 10:11 AM, Ishaan Gandhi wrote:
> Thank you. Would it be better to do instead:
>
> + if_index = skb->skb_iif;
>
> or
>
> + if_index = ip_version == 4 ? inet_iif(skb) : skb->skb_iif;
>
If the packet comes in via an interface assigned to a VRF, skb_iif is
most likely the VRF in
On 3/17/21 6:54 AM, Petr Machata wrote:
> Support for resilient next-hop groups was recently accepted to Linux
> kernel[1]. Resilient next-hop groups add a layer of indirection between the
> SKB hash and the next hop. Thus the hash is used to reference a hash table
> bucket, which is then used to r
On 3/17/21 4:19 PM, ishaangandhi wrote:
> +void icmp_identify_arrival_interface(struct sk_buff *skb, struct net *net,
> int room,
> + char *icmph, int ip_version)
> +{
> + unsigned int ext_len, orig_len, word_aligned_orig_len, offset,
> extra_space_needed,
> +
On 3/17/21 9:19 PM, David Miller wrote:
> From: Andreas Roeseler
> Date: Wed, 17 Mar 2021 22:11:47 -0500
>
>> On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote:
>> Is there something that I'm not understanding about compiling kernel
>> components modularly? How do I avoid this error?
>
On 3/17/21 12:53 PM, Thadeu Lima de Souza Cascardo wrote:
> During forced garbage collection, neighbours with more than a reference are
> not removed. It's possible to DoS the neighbour table by using ARP spoofing
> in such a way that there is always a timer pending for all neighbours,
> preventing
On 3/17/21 9:07 AM, Anish Udupa wrote:
> Ran checkpatch and found these warnings. Fixed some of them in this patch.
> a) Added a space before '='.
> b) Removed the space before the tab.
>
> Signed-off-by: Anish Udupa H
> ---
> net/ipv4/route.c | 8
> 1 file changed, 4 insertions(+), 4 d
On 3/15/21 1:22 PM, Tim Rice wrote:
> Hey all,
>
> Sorry if this isn't the right place to report Iproute2 bugs. It was
> implied by README.devel as well as a couple of entries I saw in bugzilla.
>
> I use iproute2 batch mode to construct network namespaces. Example script:
>
> $ cat ~/bin/netn
On 3/15/21 11:10 AM, Greesha Mikhalkin wrote:
>> That's the way the source address selection works -- it takes the fib
>> lookup result and finds the best source address match for it.
>>
>> Try adding 'src a.b.c.d' to the leaked route. e.g.,
>> ip ro add 172.16.1.0/24 dev red vrf blue src 172.1
On 3/15/21 7:10 AM, Petr Machata wrote:
> Could this be merged, please?
done
On 3/12/21 10:23 AM, Petr Machata wrote:
> From: Petr Machata
>
> From: Ido Schimmel
All of the patches have the above. If Ido is the author and you are
sending, AIUI you add your Signed-off-by below his.
>
> Next patches are going to add a 'resilient' nexthop group type, so allow
> users to
Signed-off-by: Petr Machata
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 517
> 1 file changed, 517 insertions(+)
>
Reviewed-by: David Ahern
with more test cases.
>
> Signed-off-by: Ido Schimmel
> Reviewed-by: Petr Machata
> Signed-off-by: Petr Machata
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 30 ++---
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern
> Tests passed: 1
> Tests failed: 0
>
> # ./fib_nexthops.sh -t ipv6_torture
>
> IPv6 runtime torture
>
> TEST: IPv6 torture test [ OK ]
>
> Tests passed: 1
> Tests failed: 0
>
> Signed-off-by: Ido Schimmel
> Reviewed-by: Petr Machata
> Signed-off-by: Petr Machata
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: David Ahern
On 3/11/21 7:22 PM, subas...@codeaurora.org wrote:
>
> We are seeing that the interface itself doesn't get the address assigned
> via RA when setting accept_ra_pinfo = 0.
>
> We would like to have the interface address assigned via SLAAC
> here while the route management would be handled via the
On 3/10/21 1:34 AM, Greesha Mikhalkin wrote:
> I see. When i do `ping -I vrf2` to address that was leaked from vrf1
> it selects source address that's set as local in vrf1 routing table.
> Is this expected behavior? I guess, forwarding packets from vrf1 to
> vrf2 local address won't help here.
>
On 3/10/21 8:02 AM, Petr Machata wrote:
> At this moment, there is only one type of next-hop group: an mpath group.
> Mpath groups implement the hash-threshold algorithm, described in RFC
> 2992[1].
>
> To select a next hop, hash-threshold algorithm first assigns a range of
> hashes to each next h
On 3/10/21 8:03 AM, Petr Machata wrote:
> Now that all the code is in place, stop rejecting requests to create
> resilient next-hop groups.
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
> net/ipv4/nexthop.c | 4
> 1 file changed, 4 deletions(-)
; Reviewed-by: Ido Schimmel
> ---
>
> Notes:
> v1 (changes since RFC):
> - u32 -> u16 for bucket counts / indices
>
> net/ipv4/nexthop.c | 45 +++--
> 1 file changed, 39 insertions(+), 6 deletions(-)
>
Reviewed-by: David Ahern
t; - u32 -> u16 for bucket counts / indices
>
> net/ipv4/nexthop.c | 110 -
> 1 file changed, 109 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
>
> Notes:
> v1 (changes since RFC):
> - u32 -> u16 for bucket counts / indices
>
Reviewed-by: David Ahern
; u16 for bucket counts / indices
>
> net/ipv4/nexthop.c | 150 +++--
> 1 file changed, 145 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern
> Reviewed-by: Petr Machata
> Signed-off-by: Petr Machata
> ---
>
> Notes:
> v1 (changes since RFC):
> - u32 -> u16 for bucket counts / indices
>
> include/net/nexthop.h | 2 ++
> net/ipv4/nexthop.c| 35 +++++++
> 2 files changed, 37 insertions(+)
>
Reviewed-by: David Ahern
| 34 ++++++
> 2 files changed, 36 insertions(+)
>
Reviewed-by: David Ahern
gt; Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
>
> Notes:
> v1 (changes since RFC):
> - u32 -> u16 for bucket counts / indices
>
Reviewed-by: David Ahern
Schimmel
> Reviewed-by: Petr Machata
> Signed-off-by: Petr Machata
> ---
>
> Notes:
> v1 (changes since RFC):
> - u32 -> u16 for bucket counts / indices
>
Reviewed-by: David Ahern
On 3/11/21 8:39 AM, Petr Machata wrote:
>
> David Ahern writes:
>
>>> diff --git a/include/net/nexthop.h b/include/net/nexthop.h
>>> index 7bc057aee40b..5062c2c08e2b 100644
>>> --- a/include/net/nexthop.h
>>> +++ b/include/net/nexthop.h
>>&g
On 3/11/21 8:45 AM, Petr Machata wrote:
>
> David Ahern writes:
>
>> On 3/10/21 8:02 AM, Petr Machata wrote:
>>> diff --git a/include/uapi/linux/nexthop.h b/include/uapi/linux/nexthop.h
>>> index 2d4a1e784cf0..8efebf3cb9c7 100644
>>> --- a/include/u
currently exposed to
> user space is the new next-hop group type, and that is currently bounced.
> There is therefore no way to actually access this code.
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
>
Thanks for the detailed documentation around exclusion expectations.
Reviewed-by: David Ahern
an updated comment, this looks fine:
Reviewed-by: David Ahern
>
> Notes:
> v1 (changes since RFC):
> - This patch is new
>
> include/net/nexthop.h | 7 ---
> net/ipv4/nexthop.c| 5 -
> 2 files changed, 8 insertions(+), 4 deletions(-)
This patch looks good:
Reviewed-by: David Ahern
>
> diff --git a/include/ne
hanged, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern
+
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern
On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote:
> Added new procfs flag to toggle the automatic addition of prefix
> routes on a per device basis. The new flag is accept_ra_prefix_route.
>
> A value of 0 for the flag maybe used in some forwarding scenarios
> when a userspace daemon is m
sed is to add a variant of nexthop_fib6_nh() to use
> rcu_dereference_bh_rtnl() for ipv6_route_seq_show().
>
...
>
> Fixes: f88d8ea67fbdb ("ipv6: Plumb support for nexthop object in a fib6_info")
> Reported-by: syzbot
> Signed-off-by: Wei Wang
> Cc: David Ahern
>
On 3/9/21 1:02 PM, Steven Rostedt wrote:
> On Tue, 9 Mar 2021 12:53:37 -0700
> David Ahern wrote:
>
>> Changing the order of the fields will impact any bpf programs expecting
>> the existing format
>
> I thought bpf programs were not API. And why are they not parsi
On 3/9/21 10:40 AM, Steven Rostedt wrote:
> The order of the fields is important. Don't worry about breaking API by
> fixing it. The parsing code uses this output to find where the binary data
> is.
Changing the order of the fields will impact any bpf programs expecting
the existing format.
On 3/9/21 10:32 AM, Wei Wang wrote:
> Thanks David and Ido.
> To clarify, David, you suggest we add a separate function instead of
> adding an extra parameter, right?
for this case I think it is the better way to go.
3 insertions(+)
>
Reviewed-by: David Ahern
[ cc Ido and Petr ]
On 3/8/21 12:21 PM, Wei Wang wrote:
> diff --git a/include/net/nexthop.h b/include/net/nexthop.h
> index 7bc057aee40b..48956b144689 100644
> --- a/include/net/nexthop.h
> +++ b/include/net/nexthop.h
> @@ -410,31 +410,39 @@ static inline struct fib_nh *fib_info_nh(struct
> fib_
On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
>> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>>>> index b1690149b6fa..cc1b6457fc93 100644
>>>>
On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>> index b1690149b6fa..cc1b6457fc93 100644
>> --- a/net/mpls/mpls_gso.c
>> +++ b/net/mpls/mpls_gso.c
>> @@ -27,7 +27,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff
>> *skb,
>>
>>
On 3/8/21 12:21 AM, ze wang wrote:
> mlxconfig tool from mft tools version 4.16.52 or higher to set number of SF.
>
> mlxconfig -d b3:00.0 PF_BAR2_ENABLE=0 PER_PF_NUM_SF=1 PF_SF_BAR_SIZE=8
> mlxconfig -d b3:00.0 PER_PF_NUM_SF=1 PF_TOTAL_SF=192 PF_SF_BAR_SIZE=8
> mlxconfig -d b3:00.1 PER_PF_NUM_
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote:
> Main goal is that 100.255.254.3 should be reachable from vrf2. But
> after this setup it doesn’t work. When i run `ping -I vrf2
> 100.255.254.3` it sends packets from source address that belongs to
> vlan1 enslaved by vrf1. I can see in tcpdump that ICM
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote:
> Hi. I need a help to understand why VRF leaking doesn’t work in my situation.
> I want to set up leaking between 2 VRFs, that are set up by following
> commands:
>
> # Setup bridge
> sudo ip link add bridge type bridge
>
> # Setup V
On 3/1/21 3:56 AM, Parav Pandit wrote:
> This series uses utils helper for socket operations, string
> processing and print error messages.
>
> Patch summary:
> Patch-1 uses utils library helper for string split and string search
> Patch-2 extends library for socket receive operation
> Patch-3 con
quivalent to me. Code wise:
Reviewed-by: David Ahern
The commit message needs more words about the change.
On 2/28/21 5:53 PM, Henry Shen wrote:
> When an IPv4 packet with a destination address of broadcast is received
> on an ingress interface, it will not be forwarded out of the egress
> interface if the ingress interface is not configured with bc_forwarding
> but the egress interface is. If both the
On 2/19/21 1:42 PM, Paolo Abeni wrote:
> The feature is supported by the kernel since 5.11-net-next,
> let's allow user-space to use it.
>
> Just parse and dump an additional, per endpoint, u16 attribute
>
> Signed-off-by: Paolo Abeni
> ---
> ip/ipmptcp.c| 16 ++--
> man/man
gt; + run_cmd "$IP link set dev lo down"
> + check_nexthop "id 2" "id 2 blackhole"
> + log_test $? 0 "Blackhole nexthop with loopback device down"
> +
> + run_cmd "$IP link set dev lo up"
> +
> #
> # groups
> #
>
Thanks for adding a test.
Reviewed-by: David Ahern
TDEV_UNREGISTER:
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGE:
> if (!(dev_get_flags(dev) & (IFF_RUNNING | IFF_LOWER_UP)))
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGEMTU:
> info_ext = ptr;
>
LGTM. I suggest submitting without the RFC.
Reviewed-by: David Ahern
On 2/22/21 9:32 AM, Kaustubh Pandey wrote:
> When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised.
>
> addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route ->
> fib6_nh_mtu_change
>
> As part of handling NETDEV_CHANGEMTU notification we land up on a
> condition where if rout
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF:
On 2/19/21 9:32 PM, Yejune Deng wrote:
> static const struct neigh_ops arp_direct_ops = {
> .family = AF_INET,
> .output = neigh_direct_output,
> @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh)
> memcpy(neigh->
On 2/17/21 9:06 AM, Муравьев Александр wrote:
> Hi
>
> A noob question that I haven't found an answer.
>
> Just wanted to clarify a piece of iproute2 code.
>
> ip/iplink.c:
>
>> 1058 addattr_l(&req.n, sizeof(req), IFLA_INFO_KIND, type,
>> 1059 strlen(type));
>
> also ip/ip
On 2/17/21 7:01 AM, Or Gerlitz wrote:
>>> @@ -1136,6 +1265,10 @@ static int nvme_tcp_try_send_cmd_pdu(struct
>>> nvme_tcp_request *req)
>>> else
>>> flags |= MSG_EOR;
>>>
>>> + if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) &&
>>> + blk_rq_nr_phys_segments(rq) && r
On 2/15/21 11:16 PM, Leon Romanovsky wrote:
> On Mon, Feb 15, 2021 at 06:56:26PM -0700, David Ahern wrote:
>> On 2/14/21 10:40 PM, Leon Romanovsky wrote:
>>> On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote:
>>>> what does iproute2-rc mean?
>&g
1 - 100 of 5537 matches
Mail list logo
