[KJ][Patch][update] remove dead code in bcm43xx_sysfs.c

2006-09-07 Thread Darren Jenkins\\
G'day people Coverity CID 1160 & 1161 These are probably fixed in some external tree, but in case they are not, here is a patch Compile tested with allyesconfig Remove some dead cose from bcm43xx_sysfs.c in 2.6.18-rc6 Signed-off-by: Darren Jenkins <[EMAIL PROTECTED]> --- drive

Re: [KJ][Patch] remove dead code in bcm43xx_sysfs.c

2006-09-07 Thread Darren Jenkins\\
Sorry people I have done it again! Both Coverity CID 1160 and 1161 are for the same file. I will whip up a combined patch Darren J. On Thu, 2006-09-07 at 17:27 +1000, Darren Jenkins\ wrote: > G'day people, > > Coverity CID 1161 > > This is probably fixed in some extern

[KJ][Patch] remove dead code in bcm43xx_sysfs.c

2006-09-07 Thread Darren Jenkins\\
G'day people, Coverity CID 1161 This is probably fixed in some external tree, but in case it isn't, here is a patch Compile tested with allyesconfig Remove some dead code from bcm43xx_sysfs.c in 2.6.18-rc6 Signed-off-by: Darren Jenkins <[EMAIL PROTECTED]> --- drivers/net/

Re: Fix memory allocation in com90xx.c

2006-03-28 Thread Darren Jenkins\\
On Tue, 2006-03-28 at 13:12 +0200, Andi Kleen wrote: >GFP_KERNEL); > > If it's too big for kzalloc then it's too big for kcalloc too. > > -Andi Thanks for that. I seem to have been rather confused about the difference between kzalloc, and kcalloc. Darren J. - To unsubsc

Fix memory allocation in com90xx.c

2006-03-27 Thread Darren Jenkins\\
ude/linux/slab.h:128: __you_cannot_kzalloc_that_much(); The patch below fixes the compilation with 'make allyesconfig'. Signed-off-by: Darren Jenkins <[EMAIL PROTECTED]> --- linux-2.6.16-git13/drivers/net/arcnet/com90xx.c.orig2006-03-28 01:44:44.0 +1100 +++ l

[KJ][Patch] fix array overflows in de4x5.c

2006-03-25 Thread Darren Jenkins\\
) + #define MOTO_SROM_BUG((lp->active >= DE4X5_MAX_PHY) || (((le32_to_cpu(get_unaligned(((s32 *)dev->dev_addr&0x00ff)==0x3e0008 as this seems to make sense, but as i am not sure that this bug happens when (lp->active < 8) I am reluctant to change this. Signed-o