Re: [PATCH] net/core/flow.c: compare data with memcmp

2007-01-01 Thread Daniel Marjamäki
for (i = 0; i < NUM_REP; i++) flow_key_compare(k1, k2); printf("compare2..\n"); for (i = 0; i < NUM_REP; i++) flow_key_compare2(k1, k2); printf((flow_key_compare(k1,k2)==(flow_key_compare2(k1,k2)?1:0))?"ok\n":"err

Re: [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Daniel Marjamäki
el_Marjamäki" <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 17:37:05 +0100 > From: Daniel Marjamäki > This has been tested by me. > Signed-off-by: Daniel Marjamäki <[EMAIL PROTECTED]> Please do not do this. memcmp() cannot assume the alignment of the source and destination buffe

[PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Daniel Marjamäki
From: Daniel Marjamäki This has been tested by me. Signed-off-by: Daniel Marjamäki <[EMAIL PROTECTED]> --- linux-2.6.20-rc2/net/core/flow.c2006-12-27 09:59:56.0 +0100 +++ linux/net/core/flow.c 2006-12-31 18:26:06.0 +0100 @@ -144,29 +144,16 @@ typedef u32 flow_com