Re: [4.9.13] use after free in ipv4_mtu

2017-05-03 Thread Daniel J Blueman
On 6 March 2017 at 21:45, Eric Dumazet wrote: > On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote: >> On 2 March 2017 at 21:28, Eric Dumazet wrote: >> > On Thu, 2017-03-02 at 05:08 -0800, Eric Dumazet wrote: >> > >> >> Thanks for the report ! &

Re: [4.9.13] use after free in ipv4_mtu

2017-03-07 Thread Daniel J Blueman
On 7 March 2017 at 00:20, Eric Dumazet wrote: > On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote: >> On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote: > >> > I do change the network queueing discipline and related at runtime [1] >> > which may be trigg

Re: [PATCH] 4.9.13 brcmfmac: fix use-after-free on resume

2017-03-06 Thread Daniel J Blueman
On 6 March 2017 at 21:00, Arend Van Spriel wrote: > + linux-wireless > > On 6-3-2017 8:14, Daniel J Blueman wrote: >> KASAN reported 'struct wireless_dev wdev' was read after being freed. >> Fix by freeing after the access. > > I would rather like to see the K

[PATCH] 4.9.13 brcmfmac: fix use-after-free on resume

2017-03-05 Thread Daniel J Blueman
KASAN reported 'struct wireless_dev wdev' was read after being freed. Fix by freeing after the access. Signed-off-by: Daniel J Blueman diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index de19c7c..aa0f470 10

[4.9.13] brcmf use-after-free on resume

2017-03-05 Thread Daniel J Blueman
c fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >8803fefebb00: fc fc fc fc fc fb fb fb fb fb fb fb fb fb fb fb ^ 8803fefebb80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb 8803fefebc00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb -- Daniel J Blueman

Re: [4.9.13] use after free in ipv4_mtu

2017-03-05 Thread Daniel J Blueman
cu_read_unlock(); >> >> header_len = tcp_established_options(sk, NULL, &opts, &md5) + >>sizeof(struct tcphdr); > > Normally TCP sockets sk_dst_cache can only be changed if the thread > doing the change owns the socket. > > I have not

[4.9.13] use after free in ipv4_mtu

2017-03-02 Thread Daniel J Blueman
nst struct dst_entry *dst, const int metric) -- Daniel J Blueman

Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-27 Thread Daniel J Blueman
On 17 February 2017 at 15:39, Florian Westphal wrote: > Daniel J Blueman wrote: > > [ CC nf-devel, pablo ] > >> When booting a VM in libvirt/KVM attached to a local bridge and KASAN >> enabled on 4.9.10, we see a stream of KASAN warnings about off-slab >> access [

Re: [4.9.10] ip_route_me_harder() reading off-slab

2017-02-17 Thread Daniel J Blueman
On 17 February 2017 at 13:36, Eric Dumazet wrote: > On Fri, 2017-02-17 at 12:36 +0800, Daniel J Blueman wrote: >> When booting a VM in libvirt/KVM attached to a local bridge and KASAN >> enabled on 4.9.10, we see a stream of KASAN warnings about off-slab >> access [1]. >&

[4.9.10] ip_route_me_harder() reading off-slab

2017-02-16 Thread Daniel J Blueman
fc fc fc fc fc fc fc fc fc fc fc [ 473.581151] ^ [ 473.581157] 8801e1eb2900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 473.581164] 8801e1eb2980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc -- Daniel J Blueman

[PATCH 2/2] ixgbe: Use core to device locality interface

2015-12-23 Thread Daniel J Blueman
essed Signed-off-by: Daniel J Blueman --- drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c index f3168bc..12c4ce1 100644 --- a/driver

[PATCH 1/2] PCI: Add mechanism to find topologically near cores

2015-12-23 Thread Daniel J Blueman
find cores with reasonable locality to a device; use the existing precendent of RECLAIM_DISTANCE (30), wrapping the offset. Signed-off-by: Daniel J Blueman --- drivers/pci/pci.c | 15 +++ include/linux/pci.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/pci/pci.c b

Re: [2.6.25-rc2, 2.6.24-rc8] page allocation failure...

2008-02-24 Thread Daniel J Blueman
On Tue, Feb 19, 2008 at 5:37 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Sun, 17 Feb 2008 13:20:59 + "Daniel J Blueman" <[EMAIL PROTECTED]> > wrote: > >> I'm still hitting this with e1000e on 2.6.25-rc2, 10 times a

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Daniel J Blueman
ring pending=451...451 report=451 done=451 Rx ring hw get=316 put=440 last=1023 -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sky2 hangs without any messages

2007-07-13 Thread Daniel J Blueman
On 12/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Thu, 12 Jul 2007 22:29:50 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 12/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > On Wed, 11 Jul 2007 23:55:29 +0100 > > &

Re: sky2 hangs without any messages

2007-07-12 Thread Daniel J Blueman
On 12/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 11 Jul 2007 23:55:29 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > > > > > > Please try again with post 2.6.22 git version (1.16)? > > > > Reproduced with 2.6.22 w/ sk

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Wed, 11 Jul 2007 22:39:49 +0100 > "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > > > On 11/07/07, Daniel J Blueman <[EMAIL PRO

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 11 Jul 2007 22:39:49 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > > > On 05/07/07, Stephen Hemminger <[EMAIL PR

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > Well, it didn't fix my test, but it made it better. The following seemed > > > to work longer... > > > > > > --

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 11 Jul 2007 11:15:20 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Well, it didn't fix my test, but it made it better

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
===== Daniel -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sky2 silicon bugs and workarounds...

2007-07-02 Thread Daniel J Blueman
On 02/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Mon, 2 Jul 2007 14:37:06 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > When the sky2 driver initialises, it sets the the ISR timer register > (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the ven

sky2 silicon bugs and workarounds...

2007-07-02 Thread Daniel J Blueman
er framework to detect the chip's PCI interface locking up and kick it in a smarter way perhaps... Daniel -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sky2 hangs without any messages

2007-07-02 Thread Daniel J Blueman
ducts/adapters/pcie_server/sk-9exx/software/linux/driver/install-8_31.tar.bz2 -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

sky2 stable in 2.6.12-rc1 (but still performance problem)...

2007-02-27 Thread Daniel J Blueman
perf UDP also, since this shows min, max, avg UDP packet latency IIRC. Thanks for your great work so far though! Dan -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

sky2: transmit timed out...

2007-01-15 Thread Daniel J Blueman
6 sky2 hardware hung? flushing -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sky2 driver causes kernel crash as of 2.6.18.1

2006-11-01 Thread Daniel J Blueman
fficiently? Thanks John Clark I've been using sky2 v1.9 (in eg linux-2.6.19-rc3) on two sky2 platforms, running 100s of gigabytes via NFSv4 and CIFS without problem. In earlier versions, I'd hit a race after a few GBs at high load; Stephen Hemminger has done a great job. -- Daniel J Blueman -

Re: [PATCH] sky2: 88E803X transmit lockup

2006-10-23 Thread Daniel J Blueman
chip is Marvell 88E803X (10/100 only) are affected. [snip] This patch works great - without it, I get only a few minutes of use from my home dir over NFS4 before the NIC stops transmitting. This is on a recent Yonah Sony VGN-SZ notebook w/ 88E8036 Marvel Sk-Y2. Thanks again Stephen! -- Daniel J

Re: sky2 v1.7 rx error...

2006-09-26 Thread Daniel J Blueman
On 26/09/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Tue, 26 Sep 2006 21:09:31 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > The server processor is a Pentium-M 1.7GHz (ondemand governor, from > 0.6GHz -> 1.7GHz). > > Gigabit path from se

Re: sky2 v1.7 rx error...

2006-09-26 Thread Daniel J Blueman
Dan On 26/09/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Tue, 26 Sep 2006 18:58:40 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > I got a this message with sky2 on 2.6.18 + the sky2 v1.7 patches - it > has different status bits set than before (0x977d9

Re: sky2 rx error problems...

2006-07-05 Thread Daniel J Blueman
to help. Many thanks, Daniel On 31/05/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Tue, 30 May 2006 22:08:12 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > To follow on from the previous 'sky2 rx error' problem reported, the > problem doesn&#x

sky2 rx error problems...

2006-05-30 Thread Daniel J Blueman
MSI support on my Intel ICH-7M chipset, but disabling MSI didn't help. kernel: sky2 lan0: rx error, status 0x977d977d length 0 Is there any debug information I can get to help or such? Voluntary preemption is enabled, UP, HZ=100 on 2.6.17-rc4 on i686. Dan -- Daniel J Blueman - To unsubscribe

Re: sky2 hw csum failure [was Re: sky2 large MTU problems]

2006-05-30 Thread Daniel J Blueman
On 25/05/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: Daniel J Blueman wrote: > On 25/05/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: > >> Daniel, is there an easy way to reproduce the checksum failure? > > In short, no. This was seen when packets may have bee

Re: sky2 hw csum failure [was Re: sky2 large MTU problems]

2006-05-25 Thread Daniel J Blueman
On 25/05/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: > On Wed, 24 May 2006 10:28:52 +0100 > "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > >>Having done some more stress testing with sky2 1.4 (in 2.6.17-rc4) and >>t

Re: sky2 hw csum failure [was Re: sky2 large MTU problems]

2006-05-25 Thread Daniel J Blueman
Hi Stephen, Thanks for your feedback. On 24/05/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > Having done some more stress testing with sky2 1.4 (in 2.6.17-rc4) and > the latest patch, I have found problems when str

sky2 large MTU problems...

2006-05-19 Thread Daniel J Blueman
from gmail hangs) Let me know if you need a more specific reproducer (eg a particular URL); I can test changes too. -- Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

RED qdisc not working...

2005-11-07 Thread Daniel J Blueman
eth0 parent 1:10 handle 10: red \ limit 4096kbit min 512kbit max 1024kbit avpkt 1000 \ burst 100 probability 0.02 bandwidth 1024kbit ___ Daniel J Blueman - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html