Re: [PATCH 1/1] net: macb: fix the RX queue reset in macb_rx()

2016-11-28 Thread Cyrille Pitchen
Hi David, Le 28/11/2016 à 02:25, David Miller a écrit : > From: Cyrille Pitchen > Date: Fri, 25 Nov 2016 09:49:32 +0100 > >> On macb only (not gem), when a RX queue corruption was detected from >> macb_rx(), the RX queue was reset: during this process the RX ring >

[PATCH net v2 1/1] net: macb: fix the RX queue reset in macb_rx()

2016-11-28 Thread Cyrille Pitchen
m macb_rx() and macb_init_rings(), we'd rather add the "bp->rx_tail = 0;" line inside macb_init_rx_ring() than add the very same line after each call of this function. Without this fix, the rx queue is not reset properly to recover from queue corruption and connection drop may occ

[PATCH 1/1] net: macb: fix the RX queue reset in macb_rx()

2016-11-25 Thread Cyrille Pitchen
m macb_rx() and macb_init_rings(), we'd rather add the "bp->rx_tail = 0;" line inside macb_init_rx_ring() than add the very same line after each call of this function. Without this fix, the rx queue is not reset properly to recover from queue corruption and connection drop may occ

4.4 stable request for net: macb: fix default configuration for GMAC on AT91

2016-06-23 Thread Cyrille Pitchen
Nicolas Ferre Signed-off-by: David S. Miller [cyrille.pitc...@atmel.com: backported to 4.4.y] Signed-off-by: Cyrille Pitchen --- drivers/net/ethernet/cadence/macb.c | 13 +++-- drivers/net/ethernet/cadence/macb.h | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH v2 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

2016-03-25 Thread Cyrille Pitchen
patch is a rework of an older patch proposed by Neil Armstrong: http://patchwork.ozlabs.org/patch/371525/ Signed-off-by: Cyrille Pitchen Acked-by: Neil Armstrong Acked-by: Nicolas Ferre --- ChangeLog v1 -> v2 - add Acked-by Neil Armstrong and Nicolas Ferre - use bool type instead of int

[PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR

2016-03-24 Thread Cyrille Pitchen
frames. The queue_readl() and queue_writel() helper macros are designed to access the relevant IRQ registers. [1] ISR: Interrupt Status Register IER: Interrupt Enable Register IDR: Interrupt Disable Register IMR: Interrupt Mask Register Signed-off-by: Cyrille Pitchen Fixes: bfbb92c44670 ("net:

[PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

2016-03-24 Thread Cyrille Pitchen
patch is a rework of an older patch proposed by Neil Armstrong: http://patchwork.ozlabs.org/patch/371525/ Signed-off-by: Cyrille Pitchen --- drivers/net/ethernet/cadence/macb.c | 59 ++--- 1 file changed, 49 insertions(+), 10 deletions(-) diff --git a/drivers/net

Re: macb: zynq: why is SG disabled?

2015-07-01 Thread Cyrille Pitchen
Le 01/07/2015 17:14, Nicolae Rosia a écrit : > Hello, > > After reading the GEM part of Zynq7000 Technical Reference Manual [0], I > think that SG should be supported. > Is there a reason why SG is disabled in macb for Zynq? > > Best regards, > Nicolae Rosia Hi Nicolae, when the scatter-gather