[PATCH 2.6.21-rc5] bnx2: fix buffer overrun in bnx2_nvram_write

2007-03-29 Thread Cureington, Tony
A buffer overrun issue exists in the bnx2_nvram_write function. This issue is exposed by calling ethtool to write to the eeprom as shown below. ethtool -E eth4 magic 0x669955AA offset 0x137 value 0xC4 The problem happens when align_buf is allocated only 2 bytes in the kmalloc call and later 4

Re: [RFC] selective ethtool diagnostic test method

2006-04-27 Thread Cureington, Tony
Ethtool Maintainers, WRT my RFC (http://www.spinics.net/lists/netdev/msg02806.html) regarding enhancing ethtool posted on 04/11/06, would such a patch be accepted by the maintainers of ethtool? I don't want to spend time on these changes just to have them rejected. I've not received any objections

[RFC] selective ethtool diagnostic test method

2006-04-11 Thread Cureington, Tony
I have searched the netdev archives and have not found any RFC like this. This proposal is to add selective diag/test modes to ethtool with minimal overhead/bloat. Please provide feedback on the proposal. This proposed selective test mode is being requested more and more from our Linux users, so