Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-23 Thread Cristian Ciocaltea
On Tue, Mar 23, 2021 at 12:38:10AM +0100, Andrew Lunn wrote: > > +static void owl_emac_set_multicast(struct net_device *netdev, int count) > > +{ > > + struct owl_emac_priv *priv = netdev_priv(netdev); > > + struct netdev_hw_addr *ha; > > + int index = 0; > > + > > + if (count <= 0) { > > +

Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-22 Thread Cristian Ciocaltea
Hi Florian, On Sun, Mar 21, 2021 at 08:30:07PM -0700, Florian Fainelli wrote: > Hi Christian, > > On 3/21/2021 4:29 PM, Cristian Ciocaltea wrote: > > Add new driver for the Ethernet MAC used on the Actions Semi Owl > > family of SoCs. > > > > Currently this ha

[PATCH v3 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC

2021-03-21 Thread Cristian Ciocaltea
Add entries for Actions Semi Owl Ethernet MAC binding and driver. Signed-off-by: Cristian Ciocaltea --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 14d1ef97c339..f9d147e27fb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1530,6 +1530,7 @@ F

[PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-21 Thread Cristian Ciocaltea
Add new driver for the Ethernet MAC used on the Actions Semi Owl family of SoCs. Currently this has been tested only on the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1

[PATCH v3 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding

2021-03-21 Thread Cristian Ciocaltea
Add devicetree binding for the Ethernet MAC present on the Actions Semi Owl family of SoCs. For the moment advertise only the support for the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- .../bindings/net/actions,owl-emac.yaml| 92 +++ 1 file

[PATCH v3 0/3] Add support for Actions Semi Owl Ethernet MAC

2021-03-21 Thread Cristian Ciocaltea
ed devm_add_action_or_reset() before clk_set_rate() in owl_emac_probe() * Other - Added SMII interface support: updated owl_emac_core_sw_reset(), added owl_emac_clk_set_rate(), updated description in the YAML binding - Changed OWL_EMAC_TX_TIMEOUT from 0.05*HZ to 2*HZ - Rebased patchset on v5.12-rc3 C

Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-16 Thread Cristian Ciocaltea
On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote: > From: Cristian Ciocaltea > Date: Mon, 15 Mar 2021 13:29:17 +0200 > > > + > > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | > > NETIF_MSG_LINK) > > +static int debug = -1

[PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-15 Thread Cristian Ciocaltea
Add new driver for the Ethernet MAC used on the Actions Semi Owl family of SoCs. Currently this has been tested only on the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1

[PATCH v2 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC

2021-03-15 Thread Cristian Ciocaltea
Add entries for Actions Semi Owl Ethernet MAC binding and driver. Signed-off-by: Cristian Ciocaltea --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 411df197e4a1..20b8e37ea34c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1530,6 +1530,7 @@ F

[PATCH v2 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding

2021-03-15 Thread Cristian Ciocaltea
Add devicetree binding for the Ethernet MAC present on the Actions Semi Owl family of SoCs. For the moment advertise only the support for the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- .../bindings/net/actions,owl-emac.yaml| 92 +++ 1 file

[PATCH v2 0/3] Add support for Actions Semi Owl Ethernet MAC

2021-03-15 Thread Cristian Ciocaltea
05*HZ to 2*HZ - Rebased patchset on v5.12-rc3 Cristian Ciocaltea (3): dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC .../bindings/net/actions,owl-emac.yaml

Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-14 Thread Cristian Ciocaltea
On Sun, Mar 14, 2021 at 05:36:32AM +0100, Andrew Lunn wrote: > > > > + if (phy->interface != PHY_INTERFACE_MODE_RMII) { > > > > + netdev_err(netdev, "unsupported phy mode: %s\n", > > > > + phy_modes(phy->interface)); > > > > + phy_disconnec

Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-13 Thread Cristian Ciocaltea
Hi Andrew, Thank you for the detailed review! On Sat, Mar 13, 2021 at 02:01:19AM +0100, Andrew Lunn wrote: > On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote: > > +static inline void owl_emac_reg_set(struct owl_emac_priv *priv, > > +

Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-11 Thread Cristian Ciocaltea
Hi Philipp, Thanks for your quick review! I will incorporate the indicated changes in the next patch revision. Kind regards, Cristi On Thu, Mar 11, 2021 at 07:43:36AM +0100, Philipp Zabel wrote: > Hi Cristian, > > On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote: &g

[PATCH 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding

2021-03-10 Thread Cristian Ciocaltea
Add devicetree binding for the Ethernet MAC present on the Actions Semi Owl family of SoCs. For the moment enable only the support for the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- .../bindings/net/actions,owl-emac.yaml| 91 +++ 1 file changed

[PATCH 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC

2021-03-10 Thread Cristian Ciocaltea
Add entries for Actions Semi Owl Ethernet MAC binding and driver. Signed-off-by: Cristian Ciocaltea --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5e372d606c5c..b6cd438083e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1530,6 +1530,7 @@ F

[PATCH 0/3] Add support for Actions Semi Owl Ethernet MAC

2021-03-10 Thread Cristian Ciocaltea
e provided separately. Thanks, Cristi Cristian Ciocaltea (3): dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC .../bindings/net/actions,owl-emac.yaml

[PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-10 Thread Cristian Ciocaltea
Add new driver for the Ethernet MAC used on the Actions Semi Owl family of SoCs. Currently this has been tested only on the Actions Semi S500 SoC variant. Signed-off-by: Cristian Ciocaltea --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1