On Thu, 4 Mar 2021 16:24:16 +0800
Jason Wang wrote:
> On 2021/3/3 4:29 下午, Cornelia Huck wrote:
> > On Wed, 3 Mar 2021 12:01:01 +0800
> > Jason Wang wrote:
> >
> >> On 2021/3/2 8:08 下午, Cornelia Huck wrote:
> >>> On Mon, 1 Mar 2
On Wed, 3 Mar 2021 12:01:01 +0800
Jason Wang wrote:
> On 2021/3/2 8:08 下午, Cornelia Huck wrote:
> > On Mon, 1 Mar 2021 11:51:08 +0800
> > Jason Wang wrote:
> >
> >> On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote:
> >>> On Fri, Feb 26, 2021 at 04:19
On Mon, 1 Mar 2021 11:51:08 +0800
Jason Wang wrote:
> On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote:
> > On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote:
> >> On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote:
> >>> Confused. What is wrong with the above? It never reads the
> >>> fie
On Thu, 25 Feb 2021 12:36:07 +0800
Jason Wang wrote:
> On 2021/2/24 7:12 下午, Cornelia Huck wrote:
> > On Wed, 24 Feb 2021 17:29:07 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 6:58 下午, Cornelia Huck wrote:
> >>> On Tue, 23 Feb 2021 18:31:07
On Wed, 24 Feb 2021 17:29:07 +0800
Jason Wang wrote:
> On 2021/2/23 6:58 下午, Cornelia Huck wrote:
> > On Tue, 23 Feb 2021 18:31:07 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 6:04 下午, Cornelia Huck wrote:
> >>> On Tue, 23 Feb 2
On Tue, 23 Feb 2021 18:31:07 +0800
Jason Wang wrote:
> On 2021/2/23 6:04 下午, Cornelia Huck wrote:
> > On Tue, 23 Feb 2021 17:46:20 +0800
> > Jason Wang wrote:
> >
> >> On 2021/2/23 下午5:25, Michael S. Tsirkin wrote:
> >>> On Mon, Feb 22,
On Tue, 23 Feb 2021 17:46:20 +0800
Jason Wang wrote:
> On 2021/2/23 下午5:25, Michael S. Tsirkin wrote:
> > On Mon, Feb 22, 2021 at 09:09:28AM -0800, Si-Wei Liu wrote:
> >>
> >> On 2/21/2021 8:14 PM, Jason Wang wrote:
> >>> On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
> Commit 452639a64ad8 ("
On Tue, 1 Sep 2020 16:50:03 +0800
Jason Wang wrote:
> On 2020/9/1 下午1:24, Kishon Vijay Abraham I wrote:
> > Hi,
> >
> > On 28/08/20 4:04 pm, Cornelia Huck wrote:
> >> On Thu, 9 Jul 2020 14:26:53 +0800
> >> Jason Wang wrote:
> >>
> >> [L
On Thu, 9 Jul 2020 14:26:53 +0800
Jason Wang wrote:
[Let me note right at the beginning that I first noted this while
listening to Kishon's talk at LPC on Wednesday. I might be very
confused about the background here, so let me apologize beforehand for
any confusion I might spread.]
> On 2020/7/
On Wed, 5 Aug 2020 09:45:00 -0400
"Michael S. Tsirkin" wrote:
> Speed and duplex config fields depend on VIRTIO_NET_F_SPEED_DUPLEX
> which being 63>31 depends on VIRTIO_F_VERSION_1.
>
> Accordingly, use LE accessors for these fields.
>
> Reported-by: Cornelia H
On Thu, 19 Apr 2018 08:30:49 +0300
"Michael S. Tsirkin" wrote:
> Programming vids (adding or removing them) still passes
> guest-endian values in the DMA buffer. That's wrong
> if guest is big-endian and when virtio 1 is enabled.
>
> Note: this is on top of a previous patch:
> virtio_net:
t_iucv_dev:
> + put_device(af_iucv_dev);
> out_driver:
> driver_unregister(&af_iucv_driver);
> out_iucv:
Reviewed-by: Cornelia Huck
On Wed, 28 Feb 2018 17:39:53 +0530
Arvind Yadav wrote:
> On Wednesday 28 February 2018 05:26 PM, Cornelia Huck wrote:
> > On Wed, 28 Feb 2018 17:14:55 +0530
> > Arvind Yadav wrote:
> >
> >> On Wednesday 28 February 2018 04:00 PM, Cornelia Huck wrote:
> >&
On Wed, 28 Feb 2018 17:14:55 +0530
Arvind Yadav wrote:
> On Wednesday 28 February 2018 04:00 PM, Cornelia Huck wrote:
> > On Wed, 28 Feb 2018 15:24:16 +0530
> > Arvind Yadav wrote:
> >
> >> Free memory, if afiucv_iucv_init is not successful and
> >> r
On Wed, 28 Feb 2018 15:24:16 +0530
Arvind Yadav wrote:
> Free memory, if afiucv_iucv_init is not successful and
> removing a IUCV driver.
>
> Signed-off-by: Arvind Yadav
> ---
> net/iucv/af_iucv.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/iucv/af_iucv.c
On Thu, 30 Mar 2017 17:31:37 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Mar 30, 2017 at 09:26:51AM +0200, Cornelia Huck wrote:
> > On Wed, 29 Mar 2017 23:48:54 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > With mergeable buffers we never us
On Wed, 29 Mar 2017 20:14:44 +0300
"Michael S. Tsirkin" wrote:
> Some drivers can't support all features in all configurations. At the
> moment we blindly set FEATURES_OK and later FAILED. Support this better
> by adding a callback drivers can use to do some early checks.
Looks reasonable. Do
On Wed, 29 Mar 2017 23:48:54 +0300
"Michael S. Tsirkin" wrote:
> With mergeable buffers we never use s/g for rx,
> so allow specifying context in that case.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/net/virtio_net.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deleti
On Wed, 29 Mar 2017 23:48:44 +0300
"Michael S. Tsirkin" wrote:
> We are going to add more parameters to find_vqs, let's wrap the call so
> we don't need to tweak all drivers every time.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/block/virtio_blk.c | 3 +--
> drivers/
On Thu, 8 Dec 2016 04:29:39 +0200
"Michael S. Tsirkin" wrote:
> By now, linux is mostly endian-clean. Enabling endian-ness
> checks for everyone produces about 200 new sparse warnings for me -
> less than 10% over the 2000 sparse warnings already there.
Out of curiousity: Where do most of those
igned-off-by: Mark Rutland
> Cc: Jason Wang
> Cc: Michael S. Tsirkin
> Cc: linux-ker...@vger.kernel.org
> Cc: virtualizat...@lists.linux-foundation.org
> ---
> tools/virtio/linux/uaccess.h | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck
nux-ker...@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: virtualizat...@lists.linux-foundation.org
> ---
> drivers/vhost/vringh.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck
ael S. Tsirkin
> Cc: linux-ker...@vger.kernel.org
> Cc: virtualizat...@lists.linux-foundation.org
> ---
> tools/virtio/linux/compiler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck
> kernels.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/net/virtio_net.c | 30 --
> 1 file changed, 20 insertions(+), 10 deletions(-)
Reviewed-by: Cornelia Huck
((skb = skb_array_consume(&q->skb_array)) != NULL)
> - kfree_skb(skb);
> + skb_array_cleanup(&q->skb_array);
> }
>
> static int macvtap_open(struct inode *inode, struct file *file)
Yes, that change fixes things for me.
Tested-by: Cornelia Huck
Thanks for the quick reply!
I'm hitting the following oops during shutdown (halt command in guest)
of a libvirt-managed qemu guest 100% of the time:
[ 108.920486] Unable to handle kernel pointer dereference in virtual kernel
address space
[ 108.920492] Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803
[ 108.920495
On Wed, 10 Feb 2016 14:08:43 +0100
Greg Kurz wrote:
> But you are right, there is a bug: we should rollback if vhost_init_used()
> fails. Something like below:
>
> err_used:
> vq->private_data = oldsock;
> vhost_net_enable_vq(n, vq);
> + vhost_adjust_vring_endian(vq);
Sho
On Wed, 10 Feb 2016 13:11:34 +0100
Greg Kurz wrote:
> On Wed, 10 Feb 2016 13:21:22 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Jan 13, 2016 at 06:09:41PM +0100, Greg Kurz wrote:
> > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> > > index ad2146a9ab2d..e02e06755ab7 100644
+-
> drivers/vhost/vhost.h |1 +
> 5 files changed, 20 insertions(+), 5 deletions(-)
Reviewed-by: Cornelia Huck
ch introduces helpers with explicit enable and disable semantics,
> for better clarity.
>
> No behaviour change.
>
> Signed-off-by: Greg Kurz
> ---
> drivers/vhost/vhost.c | 28 +++-
> 1 file changed, 19 insertions(+), 9 deletions(-)
Reviewed-by: Cornelia Huck
drivers/vhost/test.c |2 ++
> drivers/vhost/vhost.c | 12 +++-
> drivers/vhost/vhost.h |1 +
> 5 files changed, 19 insertions(+), 5 deletions(-)
Makes sense.
Reviewed-by: Cornelia Huck
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> ---
> arch/arm/kvm/Kconfig | 1 +
> arch/arm64/kvm/Kconfig | 1 +
> arch/powerpc/kvm/Kconfig | 1 +
> drivers/net/Kconfig | 1 +
> drivers/vhost/Kconfig| 1 +
> virt/kvm/Kconfig | 3 +++
> 6 files changed, 8 insertions(+)
Acked-by: Cornelia Huck
Caused-By : ?
> Handled-By : Cornelia Huck <[EMAIL PROTECTED]>
> Patch : http://lkml.org/lkml/2007/7/19/223
> Status : patch available
>
Multiple people posted this fix, and Andrew's already made it to git
(commit 275afcac9953ece0828972edeab9684cf
On Thu, 12 Jul 2007 10:59:53 -0700,
Yinghai Lu <[EMAIL PROTECTED]> wrote:
> @@ -1285,8 +1290,11 @@ int device_move(struct device *dev, struct device
> *new_parent)
> dev->parent = new_parent;
> if (old_parent)
> klist_remove(&dev->knode_parent);
> - if (new_parent)
>
On Thu, 12 Jul 2007 13:30:28 +0200,
Stefan Richter <[EMAIL PROTECTED]> wrote:
> So, since figuring the correct DMA device out is done by drivers
> themselves, they usually can figure out the correct NUMA node as well.
> The only precondition is that each DMA device has the correct NUMA node
> set.
On Thu, 12 Jul 2007 07:47:52 +0200,
Stefan Richter <[EMAIL PROTECTED]> wrote:
> The patch does nothing for all subsystems which do
>
> device_initialize(&dev);
> dev->parent = pd;
> device_add(&dev);
>
> Let's avoid to add infrastructure which does nothing, or only does
> somet
-by: Cornelia Huck <[EMAIL PROTECTED]>
---
drivers/s390/net/qeth_proc.c |2 --
1 files changed, 2 deletions(-)
--- linux.orig/drivers/s390/net/qeth_proc.c
+++ linux/drivers/s390/net/qeth_proc.c
@@ -37,7 +37,6 @@ qeth_procfile_seq_start(struct seq_file
struct device *dev
37 matches
Mail list logo
