amp;& new == NUD_STALE)
> + if (lladdr == neigh->ha && new == NUD_STALE &&
> + !(flags & NEIGH_UPDATE_F_ADMIN))
> new = old;
> }
> }
Reviewed-by: Chunhui He
ectness, we prefer to resolve lladdr,
when we can't get confirmation, even while remote packets try to set
NUD_STALE state.
Signed-off-by: Chunhui He
---
v2:
- change title from "net: neigh: disallow state transition DELAY->STALE in
neigh_update()"
- remove "NUD_C
Hi,
On Mon, 25 Jul 2016 14:20:29 +0900, YOSHIFUJI Hideaki/吉藤英明
wrote:
> Hi,
>
> Chunhui He wrote:
>> Hi,
>>
>> On Fri, 22 Jul 2016 10:20:01 +0300 (EEST), Julian Anastasov
>> wrote:
>>>
>>> Hello,
>>>
>>> On Thu, 21
Hello,
On Sat, 23 Jul 2016 22:09:43 +0300 (EEST), Julian Anastasov wrote:
>
> May be that is the problem: we receive such packet,
> ip_route_input_noref detects that we allow such packet
> from NEIGH_IP on this interface, tip is not RTN_LOCAL (no
> ARP reply from us), tip is RTN_UNICAST b
Hello, Julian.
My case is special, so I think the detail(provided below, if you are intresting)
is not very important. *It only trigers the real problem*.
The neigh system is to reduce ARP traffic, that is good. The problem is it fails
to handle some coner cases.
The coner case is (let's forget
On Sat, 23 Jul 2016 09:17:59 +0300 (EEST), Julian Anastasov wrote:
>
> In my case, the gateway refuses to send unicast packets to me, before it sees
> my ARP request. So it's critical to enter REACHABLE state by sending ARP
> request, but not by external confirmation.
>
>
> What kind of
Hi,
On Fri, 22 Jul 2016 10:20:01 +0300 (EEST), Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 21 Jul 2016, Chunhui He wrote:
>
>> If neigh entry was CONNECTED and address is not changed, and if new state is
>> STALE, entry state will not change. Because DELA
al confirmation.
This fixes neigh_update() not to change to STALE if old state is CONNECTED or
DELAY.
Signed-off-by: Chunhui He
---
net/core/neighbour.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 510cd62..29429eb 100644