Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible

2020-12-20 Thread Chuanhong Guo
existing > matching compatible strings. While it's not ideal to have the same > top-level SoC compatible and having another sub-node within that SoC's > DTS have the same compatible, given this would be break backwards > compatibility, cannot you stay with what is defined today? U-boot for MT7621 doesn't support device tree, and the kernel image is always packaged with dt. Do we need to maintain backward compatibility at all in this situation? -- Regards, Chuanhong Guo

[PATCH] mt76: mt7615: retry if mt7615_mcu_init returns -EAGAIN

2020-09-23 Thread Chuanhong Guo
times before giving up. Signed-off-by: Chuanhong Guo --- On my mt7622 board mt7615_load_patch always fails the first time and it then succeeded on the first retry added by this patch. "10 times" is an arbitarily picked value and it'll still leave a broken phy behind if all 10 retries

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-20 Thread Chuanhong Guo
belong to this switch at all and I think this approach should not be followed further by future code. The usage of mac5 should be explicitly defined as a dt property under mt753x node. -- Regards, Chuanhong Guo

Re: [RFC PATCH net-next] net: dsa: mt7530: fix roaming from DSA user ports

2020-05-11 Thread Chuanhong Guo
a new thread if you'd like to propose these fundamental behaviour changes, because this patch is already a result of previously proposed behaviour changes being rejected. -- Regards, Chuanhong Guo