Re: [stable] [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > I left it out on purpose because 2.6.22 doesn't support Yukon EX. OK, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: [stable] [PATCH 2/3] sky2: fix VLAN receive processing

2007-09-28 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > The length check for truncated frames was not correctly handling > the case where VLAN acceleration had already read the tag. > Also, the Yukon EX has some features that use high bit of status > as security tag. Did you leave out the GMR_FS_LEN chan

Re: [PATCH] bonding: Fix use after free in unregister path

2007-06-20 Thread Chris Wright
* Jeff Garzik ([EMAIL PROTECTED]) wrote: > Jay Vosburgh wrote: > > The following patch (based on a patch from Stephen Hemminger > ><[EMAIL PROTECTED]>) removes use after free conditions in > >the unregister path for the bonding master. Without this patch, an > >operation of the form "echo -bon

Re: [stable] "[IPV6]: Fix routing round-robin locking." breaks manual default route (bug 8349)

2007-06-05 Thread Chris Wright
* Simon Arlott ([EMAIL PROTECTED]) wrote: > Adding a ::/0 route doesn't work: > # ip -6 r a ::/0 via fe80::230:18ff:feb0:25c2 dev eth0 > # ping6 -c 1 2001:4b10:1005:0:205:b4ff:fe12:530 > connect: Network is unreachable > > A route assigned by addrconf works. > > Reverting this patch from 2.6.22-r

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: > On Wed, May 23, 2007 at 04:38:20PM -0700, Kok, Auke wrote: > > > > With that, please add my Acked-By... > > Sorry, I only read yours after Chris's message :) > > Chris, please add that Acked-By by Auke. Got it, thanks. -chris - To unsubscribe from this l

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-23 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: > On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote: > > > > I've posted that before and it's up to the stable team. I think that it's a > > seriously toolarge change unless Herbert posts his short version of the fix > > for 2.6.21.1. I would be OK

[patch 60/69] sky2: 88e8071 support not ready

2007-05-21 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. - From: Stephen Hemminger <[EMAIL PROTECTED]> The driver is not ready to support 88e8071 chip, it requires several more changes (not done yet). If this chip is present, system will hang on boot. Signed-o

[patch 61/69] skge: crash on shutdown/suspend

2007-05-21 Thread Chris Wright
own or suspend/resume. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- drivers/net/skge.c |9 + 1 file changed, 9 insertions(+) --- linux-2.6.21.1.orig/drivers/net/skge.c +++ linux-2.6.21.1/drivers/net/skge.c

[patch 59/69] sky2: allow 88E8056

2007-05-21 Thread Chris Wright
minger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- drivers/net/sky2.c |3 --- 1 file changed, 3 deletions(-) --- linux-2.6.21.1.orig/drivers/net/sky2.c +++ linux-2.6.21.1/drivers/net/sky2.c @@ -123,10 +123,7 @@ static const struct pci_device_id sky2_i

[patch 62/69] sky2: fix oops on shutdown

2007-05-21 Thread Chris Wright
utdown or suspend/resume. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 10 ++ 1 file changed, 10 insertions(+) --- linux-2.6.21.1.orig/drivers/net/sky2.c +++ linux-2.6.21.1/drivers/net/sky2.c

Re: [stable] [PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-16 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > We're not pushing this in, even the ipv6 working group is unsure > how this should be handled and one of the possibilities they might > choose matches how things currently are. Alright, I'll drop this one from the -stable radar, thanks. -chris - To unsub

Re: [stable] [PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-16 Thread Chris Wright
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > In article <[EMAIL PROTECTED]> (at Fri, 11 May 2007 09:22:43 -0700), Chris > Wright <[EMAIL PROTECTED]> says: > > * YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > > > The "fix" for emerging

Re: [stable] PROBLEM: SIS900 Driver change in Linux Kernel 2.6.21 causes kernel panic.

2007-05-16 Thread Chris Wright
* Dave Jones ([EMAIL PROTECTED]) wrote: > You need this.. > > http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=dc5a144991ba803bc8afded105c9db1dea0e57ab > > Which is queued for -stable afaik, but no sign of 2.6.21.2 yet. Greg/Chris? Yes, it is queued,

Re: [stable] [PATCH 3/6] sky2: allow 88E8056

2007-05-16 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > It looks like the problems of Gigabyte 88E8056 are unique to that chip > motherboard and maybe fixable by EEPROM update. So, drop the Gigabyte hunks in the original patch...ok, thanks. -chris - To unsubscribe from this list: send the line "unsubscri

Re: [stable] [PATCH 4/6] sky2: 88e8071 support not ready

2007-05-16 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > - { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x436B) }, /* 88E8071 */ > +// { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x436B) }, /* 88E8071 */ Where-o-where are the CodingStyle police? ;-) - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [stable] [PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread Chris Wright
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > Chris, I think it is okay, but > please wait for Dave's approval. Alright, will do. thanks, -chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [stable] [PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread Chris Wright
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > The "fix" for emerging security threats was overkill and it broke > basic semantic of IPv6 routing header processing. We should assume > RT0 (or even RT2, depends on configuration) as "unknown" RH type so > that we > - silently ignore the rou

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-10 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > Yep, this patch gets rid of my spinning thread. I can't find this patch > or any discussion on marc.info; is there a better netdev list archive? See the "linkwatch bustage in git-net" thread on netdev http://thread.gmane.org/gmane.linux.network/

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-25 Thread Chris Wright
* Chris Wright ([EMAIL PROTECTED]) wrote: > * Greg KH ([EMAIL PROTECTED]) wrote: > > fyi, here's the patch that I applied, perhaps 2.6.20 needed something > > else too? > > > @@ -809,7 +815,7 @@ static void nl_fib_input(struct sock *sk > > > > nl_

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-25 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: > fyi, here's the patch that I applied, perhaps 2.6.20 needed something > else too? > @@ -809,7 +815,7 @@ static void nl_fib_input(struct sock *sk > > nl_fib_lookup(frn, tb); > > - pid = nlh->nlmsg_pid; /*pid of sending process */ >

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-25 Thread Chris Wright
* Greg KH ([EMAIL PROTECTED]) wrote: > On Wed, Apr 25, 2007 at 01:15:12PM -0700, Linus Torvalds wrote: > > > > > > On Wed, 25 Apr 2007, Alexey Kuznetsov wrote: > > > > > > Reply to NETLINK_FIB_LOOKUP messages were misrouted back to kernel, > > > which resulted in infinite recursion and stack ove

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread Chris Wright
* Eric W. Biederman ([EMAIL PROTECTED]) wrote: > Is it truly critical to inline any of these instructions? I don't have any current measurements. But we'd been aiming at getting irq_{en,dis}able to a simple memory write to pda. But simplicity, maintenance, etc. win over trimming a couple cycles,

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > > Ugh, Chris, why is this patch against a copy of ipv6_sockglue.c > that doesn't have the NULL pointer fix applied? > > Nevermind, it's obvious, so I fixed it up by hand, but please > patch against current sources expecially when we're all aware > of ot

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > copy_to_user() will check it, actually, it will make sure that > optval + len doesn't wrap or overlap into kernel space. > > Actually, like sparc64 it BUG's on negative length so we have > to fix this :-) Yeah, I think it's arch dependent (x86_64 for ex

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 09 Mar 2007 10:13:28 +0900 (JST) > > > Bug noticed by Chris Wright <[EMAIL PROTECTED]>. > > > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTEC

Re: [PATCH 1/2] [IPV6]: Return correct result for sticky options.

2007-03-08 Thread Chris Wright
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: > We returned incorrect result with IPV6_RTHDRDSTOPTS, IPV6_RTHDR and > IPV6_DSTOPTS. This makes a lot more sense. I wondered about that, thanks. -chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

IPV6: make ipv6_getsockopt_sticky honor user's buffer size

2007-03-07 Thread Chris Wright
Make sure not to copy_to_user more than user's buffer can handle (we already checked the min, just use it) in ipv6_getsockopt_sticky. And while there, minor whitespace cleanup now that ipv6_getsockopt_sticky call can nicely fit on one line. Signed-off-by: Chris Wright <[EMAIL P

Re: [RFC] ARP notify option

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > This adds another inet device option to enable gratuitous ARP > when device is brought up or address change. This is handy for > clusters or virtualization. This looks good. I'll test with Xen. What about the source addr selection? thanks, -chris

Re: [patch 26/26] Xen-paravirt_ops: Add the Xen virtual network device driver.

2007-03-06 Thread Chris Wright
* Christoph Hellwig ([EMAIL PROTECTED]) wrote: > Actually the right way to do it is in userspace, as all clustering > solutions do. That's whay everyone told the Xen folks by the just > refuse to rip this junk out. I'm ripping it out. - To unsubscribe from this list: send the line "unsubscribe ne

Re: [RFC] Arp announce (for Xen)

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > + case NETDEV_CHANGEADDR: > + /* Send gratuitous ARP in case of address change or new device > */ > + if (IN_DEV_ARP_ANNOUNCE(in_dev)) Conceptually right on, but it looks like improper hijacking of arp_announce sysctl.

[patch 10/23] bcm43xx: Drain TX status before starting IRQs

2006-11-29 Thread Chris Wright
would immediately fire after enabling IRQs and would lead to an oops in the DMA TXstatus handling code. Cc: "John W. Linville" <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Larry Finger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright &l

Re: [patch 07/30] bcm43xx: Drain TX status before starting IRQs

2006-11-18 Thread Chris Wright
* Larry Finger ([EMAIL PROTECTED]) wrote: > The regression turns out to be a locking problem involving bcm43xx, > wpa_supplicant, and NetworkManager. The exact cause is unknown; however, > this patch is clearly not the problem. Please reinstate it for inclusion in > -stable. Thanks for the foll

Re: [patch 07/30] bcm43xx: Drain TX status before starting IRQs

2006-11-16 Thread Chris Wright
* Larry Finger ([EMAIL PROTECTED]) wrote: > We have a report of a regression between 2.6.19-rc3 and -rc5. As this patch > seems to be the only one that could cause the problem, please pull it from > -stable while we sort out the difficulty. Thanks a lot for the heads up Larry, dropping this one.

[patch 07/30] bcm43xx: Drain TX status before starting IRQs

2006-11-15 Thread Chris Wright
would immediately fire after enabling IRQs and would lead to an oops in the DMA TXstatus handling code. Cc: "John W. Linville" <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Larry Finger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright &l

Re: [PATCH] Fix verify_iovec() to not allow overflow of iov_len values

2006-08-29 Thread Chris Wright
* Sridhar Samudrala ([EMAIL PROTECTED]) wrote: > -int verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > +ssize_t verify_iovec(struct msghdr *m, struct iovec *iov, char *address, int > mode) > { > int size, err, ct; > + ssize_t tot_len = 0; > >

Re: [PATCH][SECURITY] secmark: nul-terminate secdata

2006-08-02 Thread Chris Wright
* James Morris ([EMAIL PROTECTED]) wrote: > cc'd Chris Wright, as this patch seems like a candidate for the stable > tree. Would be, but I thought secmark went in post 2.6.17. And I expect Dave will push this well before 2.6.18. thanks, -chris - To unsubscribe from this list: se

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > From: Chris Wright <[EMAIL PROTECTED]> > Date: Tue, 18 Jul 2006 00:00:32 -0700 > > > +#ifdef CONFIG_XEN_BALLOON > > +#include > > +#endif > > Let's put the ifdefs in xen/balloon.h not in the files >

[RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt <[EMAIL PROTECTED]> Signed-off-by: Christian Limpach <[EMAIL PROTECTED]> Signed-off-by: Chris Wr

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: > Chris Wright <[EMAIL PROTECTED]> wrote: > > > > + netdev->features= NETIF_F_IP_CSUM; > > Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter > would seem to be in fact easier for a virtual

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
* Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Tue, May 09, 2006 at 12:00:34AM -0700, Chris Wright wrote: > > The network device frontend driver allows the kernel to access network > > devices exported exported by a virtual machine containing a physical > > network devic

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > The stuff in /proc could easily just be added attributes to the class_device > kobject > of the net device (and then show up in sysfs). Agreed, it's on the todo list to drop proc support there. Thought that was marked in the patch. > > +#define G

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > > + info->irq = bind_evtchn_to_irqhandler( > > + info->evtchn, netif_int, SA_SAMPLE_RANDOM, > > netdev->name, > > This doesn't look like a real random entropy source. packets > arriving from another domain are easily timed. Heh, given t

[RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt <[EMAIL PROTECTED]> Signed-off-by: Christian Limpach <[EMAIL PROTECTED]> Signed-off-by: Chris Wr

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-20 Thread Chris Wright
* David S. Miller ([EMAIL PROTECTED]) wrote: > From: Chris Wright <[EMAIL PROTECTED]> > Date: Mon, 20 Mar 2006 13:36:36 -0800 > > > The point of Catherine's original patch was to make sure there's always > > a security identifier associated with AF_UNIX messag

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-20 Thread Chris Wright
* Andrew Morton ([EMAIL PROTECTED]) wrote: > Chris Wright <[EMAIL PROTECTED]> wrote: > > Catherine, the security_sid_to_context() is a raw SELinux function which > > crept into core code and should not have been there. The fallout fixes > > included conditionally export

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-20 Thread Chris Wright
* Chris Wright ([EMAIL PROTECTED]) wrote: > * Ingo Oeser ([EMAIL PROTECTED]) wrote: > > Hi Chris, > > > > Andrew Morton wrote: > > > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > > > > > > > -int scm_send(struct socke

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-20 Thread Chris Wright
* Ingo Oeser ([EMAIL PROTECTED]) wrote: > Hi Chris, > > Andrew Morton wrote: > > Ingo Oeser <[EMAIL PROTECTED]> wrote: > > > > > > -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie > > > *scm) > > > -{ > > > -struct task_struct *p = current; > > > -scm->

[PATCH 1/4] [REQSK] Dont reset rskq_defer_accept in reqsk_queue_alloc

2006-03-03 Thread Chris Wright
after bind, the fix is to remove the zeroing of rskq_defer_accept from reqsl_queue_alloc. Thanks to Alexandra N. Kossovsky <[EMAIL PROTECTED]> for reporting and testing the suggested fix. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[

[patch 04/39] [PATCH] [BRIDGE]: netfilter missing symbol has_bridge_parent

2006-02-27 Thread Chris Wright
with NETFILTER_DEBUG is enabled. This patch uses the already seeded realoutdev value to detect if a parent exists, and if so, the value of the parent. Signed-Off-By: Horms <[EMAIL PROTECTED]> Acked-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTE

Re: [stable] [PATCH] [BRIDGE]: netfilter missing symbol has_bridge_parent

2006-02-13 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > Horms patch was the best of the three fixes. Dave, already applied Harald's > version, so this patch converts that to the better one. Thanks, added Horms' patch to -stable. -chris - To unsubscribe from this list: send the line "unsubscribe netdev" i

[PATCH 19/23] [PATCH] bridge: netfilter races on device removal

2006-02-07 Thread Chris Wright
Hemminger <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- net/bridge/br_netfilter.c | 55 +++--- 1 files changed, 38 insertions(+), 17 deletions(-) Index: linux-2.6.15.3/net/bridge/br

Re: [stable] [PATCH 2.6.14.3] skge: handle out of memory on restart

2005-12-21 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > This is a backport of the patches posted for 2.6.15 to handle the cases > where the skge driver needs to reallocate receive buffers and fails. > This version is for 2.6.14 stable series only, the seven separate patches > sent yesterday for 2.6.15 do

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Chris Wright
* Trent Jaeger ([EMAIL PROTECTED]) wrote: > Patch with sock callback lock made unconditional. Previous send > (earlier today, 11/17) was not the latest patch -- please disregard > that patch. Little heavy on KERN_DEBUG printk's. Could you drop them (or perhaps use pr_debug instead)? thanks, -c