Re: Oops in filter add

2007-03-20 Thread Chris Madden
Patrick McHardy wrote: > > There was a small bug in my patch (broken return value on memory > allocation failure, not relevant for testing though). I'll push > the fixed patch to Dave once Chris confirms that it fixes the > problem he's seeing. > Looks like that may have done it. I ramped up th

Re: Oops in filter add

2007-03-20 Thread Chris Madden
jamal wrote: > On Mon, 2007-19-03 at 19:22 -0700, David Miller wrote: >> Can you just replace the above with dev->queue_lock and see if >> that makes your problem go away? THanks. >> > > It should; > i will stare at the code later and see if i can send a better patch, > maybe a read_lock(qdi

Re: Oops in filter add

2007-03-20 Thread Chris Madden
gt;ops->change(tp, cl, t->tcm_handle, tca, &fh); Simply reordering these seems to ameliorate the problem greatly. I don't know if this is a generic solution or something specific to the basic filter only. Chris Madden jamal wrote: > On Tue, 2007-20-03 at 08:29 +0100, Patrick McHa