Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-14 Thread Chen-Yu Tsai
On Thu, Apr 15, 2021 at 12:14 AM Ezequiel Garcia wrote: > > Hi Peter, Heiko, > > On Wed, 2021-04-14 at 13:15 +0200, Heiko Stübner wrote: > > Am Mittwoch, 14. April 2021, 13:03:25 CEST schrieb Peter Geis: > > > On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia > > > wrote: > > > > > > +static void

Re: [PATCH net-next 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback

2021-01-06 Thread Chen-Yu Tsai
ot;. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > Adjust the spacing and use an explicit "return 0" in the success path > to make the function easier to parse. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > Use the appropriate function instead of reimplementing it, > and update the error message to match the code. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered, > so there is no need to do it again here. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net-next 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

2021-01-06 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland wrote: > > This is a deinitialization function that always returned zero, and that > return value was always ignored. Have it return void instead. > > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net 2/4] net: stmmac: dwmac-sun8i: Balance internal PHY resource references

2021-01-04 Thread Chen-Yu Tsai
ver > removal callback. Also ensure the EPHY is powered down before removal. > > Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external > MDIOs") > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

2021-01-04 Thread Chen-Yu Tsai
: stmmac: Add dwmac-sun8i") > Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in > exit path") > Signed-off-by: Samuel Holland Reviewed-by: Chen-Yu Tsai

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Chen-Yu Tsai
On Wed, Dec 16, 2020 at 4:16 AM Christophe JAILLET wrote: > > Le 15/12/2020 à 20:35, Dan Carpenter a écrit : > > On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: > >> On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > >>> Le 15/12/2020 à 12:37, Maxime Ripard a écri

Re: [PATCH v4 13/13] ARM: dts: sunxi: Switch from phy to phy-handle

2019-07-29 Thread Chen-Yu Tsai
On Thu, Jun 27, 2019 at 11:32 PM Maxime Ripard wrote: > > The phy device tree property has been deprecated in favor of phy-handle, > let's replace it. > > Signed-off-by: Maxime Ripard This patch breaks Ethernet on all my dwmac-sunxi, i.e. old GMAC, boards, with the following error messages:

Re: [PATCH v2 11/11] ARM: dts: sunxi: Switch to the generic PHY properties

2019-06-11 Thread Chen-Yu Tsai
. > > Changes from v1: > - New patch > --- > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 6 +++--- Tested-by: Chen-Yu Tsai

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-19 Thread Chen-Yu Tsai
On Wed, Feb 20, 2019 at 5:09 AM David Summers wrote: > > On 19/02/2019 14:17, Rob Herring wrote: > > On Mon, Feb 18, 2019 at 4:28 PM Vasily Khoruzhick > > wrote: > >> On Mon, Feb 18, 2019 at 2:08 PM Stefan Wahren > >> wrote: > >>> Hi Vasily, > >> Hi Stefan, > >> > Vasily Khoruzhick hat a

Re: [PATCH 2/8] Bluetooth: hci_h5: Add support for reset GPIO

2019-01-18 Thread Chen-Yu Tsai
On Sat, Jan 19, 2019 at 1:02 AM Vasily Khoruzhick wrote: > > Some boards (e.g. Pine64 and Pinebook) wire a GPIO to reset pin of > RTL8723BS Pine64 / Pinebook don't have the enable pin. One could say that the enable pin and the reset pin you add here are actually the same thing. ChenYu > Signed-

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-15 Thread Chen-Yu Tsai
On Mon, May 14, 2018 at 1:03 AM, Maxime Ripard wrote: > 1;5201;0c > On Sun, May 13, 2018 at 12:37:49PM -0700, Chen-Yu Tsai wrote: >> On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard >> wrote: >> > On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote: >>

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 1:29 PM, Andrew Lunn wrote: > On Sun, May 13, 2018 at 01:11:08PM -0700, Chen-Yu Tsai wrote: >> On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: >> >> > Hi Chen-Yu >> >> > >> >> > Are these delays the MAC applies?

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 1:05 PM, Andrew Lunn wrote: >> > Hi Chen-Yu >> > >> > Are these delays the MAC applies? Not the PHY. It would be good to >> > make it clear here these are MAC imposed delays. >> >> Yes these are applied on the MAC side. Being described in the device >> tree bindings for the

Re: [PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
On Sun, May 13, 2018 at 12:49 PM, Andrew Lunn wrote: > On Mon, May 14, 2018 at 03:14:18AM +0800, Chen-Yu Tsai wrote: >> The clock delay chains found in the glue layer for dwmac-sun8i are only >> used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as >> MII

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-13 Thread Chen-Yu Tsai
On Wed, May 2, 2018 at 4:54 AM, Maxime Ripard wrote: > On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote: >> >> >> 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai 写到: >> >On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard >> > wrote: >> >>

[PATCH RESEND net-next v2 1/8] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-13 Thread Chen-Yu Tsai
chain section of the device tree binding to make it clear that the delay chains only apply to RGMII PHYs, and make it easier to add the R40-specific bits later. Signed-off-by: Chen-Yu Tsai Reviewed-by: Rob Herring Acked-by: Maxime Ripard --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt

[PATCH RESEND net-next v2 2/8] dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order

2018-05-13 Thread Chen-Yu Tsai
The A83T syscon compatible was appended to the syscon compatibles list, instead of inserted in to preserve the ordering. Move it to the proper place to keep the list sorted. Signed-off-by: Chen-Yu Tsai Reviewed-by: Rob Herring Acked-by: Maxime Ripard --- Documentation/devicetree/bindings/net

[PATCH RESEND net-next v2 5/8] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

2018-05-13 Thread Chen-Yu Tsai
d_update_bits(), but this is not done here to keep the patch simple. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 42 ++- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stm

[PATCH RESEND net-next v2 0/8] net: stmmac: dwmac-sun8i: Support R40

2018-05-13 Thread Chen-Yu Tsai
drivers to register custom syscon devices with their own regmap and locking. Please have a look. Regards ChenYu Chen-Yu Tsai (8): dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order dt-bindings:

[PATCH RESEND net-next v2 6/8] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from external device

2018-05-13 Thread Chen-Yu Tsai
p tied to it. We can then get the device from the existing syscon phandle, and retrieve the regmap with dev_get_regmap(). Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 50 ++- 1 file changed, 49 insertions(+), 1 deletion(-)

[PATCH RESEND net-next v2 8/8] net: stmmac: dwmac-sun8i: Add support for GMAC on Allwinner R40 SoC

2018-05-13 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds support for it using the framework laid out by previous patches to map the differences. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 17 + 1 file changed, 17

[PATCH RESEND net-next v2 4/8] dt-bindings: net: dwmac-sun8i: Add binding for GMAC on Allwinner R40 SoC

2018-05-13 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds the R40 specific bits to the dwmac-sun8i binding. Signed-off-by: Chen-Yu Tsai Reviewed-by: Rob Herring Acked-by: Maxime Ripard --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 3 +++ 1 file changed, 3 insertions(+) di

[PATCH RESEND net-next v2 3/8] dt-bindings: net: dwmac-sun8i: simplify description of syscon property

2018-05-13 Thread Chen-Yu Tsai
;syscon" device type is more of an implementation detail. There are many ways to access a register not in a device's address range, the syscon interface being the most generic and unrestricted one. Simplify the description so that it says what it is supposed to describe. Signed-off-by:

[PATCH RESEND net-next v2 7/8] net: stmmac: dwmac-sun8i: Support different ranges for TX/RX delay chains

2018-05-13 Thread Chen-Yu Tsai
is not supported or absent. Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 32 +-- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-02 Thread Chen-Yu Tsai
On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard wrote: > Hi, > > On Wed, May 02, 2018 at 12:12:27AM +0800, Chen-Yu Tsai wrote: >> From: Icenowy Zheng >> >> Allwinner A64 has a SRAM controller, and in the device tree currently >> we have a syscon node to enable EMA

Re: [PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

2018-05-01 Thread Chen-Yu Tsai
On Wed, May 2, 2018 at 12:12 AM, Chen-Yu Tsai wrote: > Hi everyone, > > This is v2 of my R40 Ethernet support series. > > Changes since v1: > > - Default to fetching regmap from device pointed to by syscon phandle, > and falling back to syscon API if tha

[PATCH net-next v2 11/15] ARM: dts: sun8i: r40: bananapi-m2-ultra: Sort device node dereferences

2018-05-01 Thread Chen-Yu Tsai
The device nodes dereference (&foo) usages should be sorted by the label names, barring any parsing order issues such as the #include statement for the PMIC's .dtsi file that must come after the PMIC. Move the mmc and ohci blocks in front of the PMIC's regulator blocks. Signed-o

[PATCH net-next v2 12/15] ARM: dts: sun8i: r40: Add device node and RGMII pinmux node for GMAC

2018-05-01 Thread Chen-Yu Tsai
GMAC is labeled "gmac_mdio". Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-r40.dtsi | 34 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi index 173dcc1652d2..bd97ca3dc2fa 10

[PATCH net-next v2 01/15] clk: sunxi-ng: r40: rewrite init code to a platform driver

2018-05-01 Thread Chen-Yu Tsai
Signed-off-by: Chen-Yu Tsai --- drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 39 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c index 933f2e68f42a..c3aa839a453d 100644 --- a/drivers

[PATCH net-next v2 04/15] dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order

2018-05-01 Thread Chen-Yu Tsai
The A83T syscon compatible was appended to the syscon compatibles list, instead of inserted in to preserve the ordering. Move it to the proper place to keep the list sorted. Signed-off-by: Chen-Yu Tsai Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 2

[PATCH net-next v2 10/15] net: stmmac: dwmac-sun8i: Add support for GMAC on Allwinner R40 SoC

2018-05-01 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds support for it using the framework laid out by previous patches to map the differences. Signed-off-by: Chen-Yu Tsai --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH net-next v2 09/15] net: stmmac: dwmac-sun8i: Support different ranges for TX/RX delay chains

2018-05-01 Thread Chen-Yu Tsai
is not supported or absent. Signed-off-by: Chen-Yu Tsai --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 32 +-- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

[PATCH net-next v2 06/15] dt-bindings: net: dwmac-sun8i: Add binding for GMAC on Allwinner R40 SoC

2018-05-01 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds the R40 specific bits to the dwmac-sun8i binding. Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dwmac-su

[PATCH net-next v2 00/15] ARM: sun8i: r40: Add Ethernet support

2018-05-01 Thread Chen-Yu Tsai
i M2 Ultra. Patches 14 and 15 are for the A64. They convert the existing syscon device to an SRAM controller device that exports a regmap. The needed driver changes are in patch 14, and the device tree changes are in patch 15. Please have a look. Regards ChenYu Chen-Yu Tsai (11): dt-bindings:

[PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-01 Thread Chen-Yu Tsai
, and let EMAC driver to acquire its EMAC clock regmap. Signed-off-by: Icenowy Zheng Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

[PATCH net-next v2 02/15] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-05-01 Thread Chen-Yu Tsai
Zheng Signed-off-by: Chen-Yu Tsai --- drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 33 1 file changed, 33 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c index c3aa839a453d..65ba6455feb7 100644 --- a/drivers/clk/sunxi-n

[PATCH net-next v2 03/15] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-05-01 Thread Chen-Yu Tsai
chain section of the device tree binding to make it clear that the delay chains only apply to RGMII PHYs, and make it easier to add the R40-specific bits later. Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH net-next v2 08/15] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from external device

2018-05-01 Thread Chen-Yu Tsai
p tied to it. We can then get the device from the existing syscon phandle, and retrieve the regmap with dev_get_regmap(). Signed-off-by: Chen-Yu Tsai --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 50 ++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH net-next v2 05/15] dt-bindings: net: dwmac-sun8i: simplify description of syscon property

2018-05-01 Thread Chen-Yu Tsai
;syscon" device type is more of an implementation detail. There are many ways to access a register not in a device's address range, the syscon interface being the most generic and unrestricted one. Simplify the description so that it says what it is supposed to describe. Si

[PATCH net-next v2 13/15] ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller

2018-05-01 Thread Chen-Yu Tsai
The Bananapi M2 Ultra has a Realtek RTL8211E RGMII PHY tied to the GMAC. The PMIC's DC1SW output provides power for the PHY, while the ALDO2 output provides I/O voltages on both sides. Signed-off-by: Chen-Yu Tsai --- .../boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 30 +++ 1

[PATCH net-next v2 07/15] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

2018-05-01 Thread Chen-Yu Tsai
d_update_bits(), but this is not done here to keep the patch simple. Signed-off-by: Chen-Yu Tsai --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 42 ++- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/

[PATCH net-next v2 14/15] soc: sunxi: export a regmap for EMAC clock reg on A64

2018-05-01 Thread Chen-Yu Tsai
accessible and drop regmap name] Signed-off-by: Chen-Yu Tsai --- drivers/soc/sunxi/sunxi_sram.c | 57 -- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 882be5ed7e84..eec7fc6e9f66

Re: [linux-sunxi] Re: [PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

2018-04-28 Thread Chen-Yu Tsai
Hi Rob, On Tue, Apr 17, 2018 at 7:17 AM, Icenowy Zheng wrote: > > > 于 2018年4月17日 GMT+08:00 上午2:47:45, Rob Herring 写到: >>On Wed, Apr 11, 2018 at 10:16:37PM +0800, Icenowy Zheng wrote: >>> On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i >>is >>> in another device's memory spac

Re: [linux-sunxi] Re: [PATCH 3/5] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from device

2018-04-17 Thread Chen-Yu Tsai
On Tue, Apr 17, 2018 at 7:52 PM, Maxime Ripard wrote: > On Mon, Apr 16, 2018 at 10:51:55PM +0800, Chen-Yu Tsai wrote: >> On Mon, Apr 16, 2018 at 10:31 PM, Maxime Ripard >> wrote: >> > On Thu, Apr 12, 2018 at 11:23:30PM +0800, Chen-Yu Tsai wrote: >> >> On Th

Re: [linux-sunxi] Re: [PATCH 3/5] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from device

2018-04-16 Thread Chen-Yu Tsai
On Mon, Apr 16, 2018 at 10:31 PM, Maxime Ripard wrote: > On Thu, Apr 12, 2018 at 11:23:30PM +0800, Chen-Yu Tsai wrote: >> On Thu, Apr 12, 2018 at 11:11 PM, Icenowy Zheng wrote: >> > 于 2018年4月12日 GMT+08:00 下午10:56:28, Maxime Ripard >> > 写到: >> >>On Wed, Ap

Re: [linux-sunxi] Re: [PATCH 3/5] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from device

2018-04-12 Thread Chen-Yu Tsai
On Thu, Apr 12, 2018 at 11:11 PM, Icenowy Zheng wrote: > > > 于 2018年4月12日 GMT+08:00 下午10:56:28, Maxime Ripard > 写到: >>On Wed, Apr 11, 2018 at 10:16:39PM +0800, Icenowy Zheng wrote: >>> From: Chen-Yu Tsai >>> >>> On the Allwinner R40 SoC, the &q

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-04 Thread Chen-Yu Tsai
On Wed, Apr 4, 2018 at 2:45 PM, Icenowy Zheng wrote: > 在 2018-04-03二的 11:50 +0200,Maxime Ripard写道: >> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >> > On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: >> > > On Mon, Mar 19,

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Chen-Yu Tsai
On Tue, Apr 3, 2018 at 5:54 PM, Icenowy Zheng wrote: > > > 于 2018年4月3日 GMT+08:00 下午5:53:08, Chen-Yu Tsai 写到: >>On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard >> wrote: >>> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >>>> On Tue, Mar

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Chen-Yu Tsai
On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard wrote: > On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >> On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: >> > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard >> > wrote: >> > > O

Re: [PATCH net-next 03/12] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-03-30 Thread Chen-Yu Tsai
On Sun, Mar 18, 2018 at 5:21 PM, Sergei Shtylyov wrote: > Hello! > > > On 3/17/2018 12:28 PM, Chen-Yu Tsai wrote: > >> The clock delay chains found in the glue layer for dwmac-sun8i are only >> used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-03-20 Thread Chen-Yu Tsai
On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard wrote: > On Sat, Mar 17, 2018 at 05:28:47PM +0800, Chen-Yu Tsai wrote: >> From: Icenowy Zheng >> >> There's a GMAC configuration register, which exists on A64/A83T/H3/H5 in >> the syscon part, in the CCU of R40 SoC.

[PATCH net-next 01/12] clk: sunxi-ng: r40: rewrite init code to a platform driver

2018-03-17 Thread Chen-Yu Tsai
Signed-off-by: Chen-Yu Tsai --- drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 39 ++-- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c index 933f2e68f42a..c3aa839a453d 100644 --- a

[PATCH net-next 10/12] ARM: dts: sun8i: r40: bananapi-m2-ultra: Sort device node dereferences

2018-03-17 Thread Chen-Yu Tsai
The device nodes dereference (&foo) usages should be sorted by the label names, barring any parsing order issues such as the #include statement for the PMIC's .dtsi file that must come after the PMIC. Move the mmc and ohci blocks in front of the PMIC's regulator blocks. Signed-o

[PATCH net-next 09/12] net: stmmac: dwmac-sun8i: Add support for GMAC on Allwinner R40 SoC

2018-03-17 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds support for it using the framework laid out by previous patches to map the differences. Signed-off-by: Chen-Yu Tsai --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-03-17 Thread Chen-Yu Tsai
Zheng Signed-off-by: Chen-Yu Tsai --- drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c index c3aa839a453d..54c7a6106206 100644 --- a/drivers/clk/sun

[PATCH net-next 04/12] dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical order

2018-03-17 Thread Chen-Yu Tsai
The A83T syscon compatible was appended to the syscon compatibles list, instead of inserted in to preserve the ordering. Move it to the proper place to keep the list sorted. Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 2 +- 1 file changed, 1

[PATCH net-next 08/12] net: stmmac: dwmac-sun8i: Support different ranges for TX/RX delay chains

2018-03-17 Thread Chen-Yu Tsai
is not supported or absent. Signed-off-by: Chen-Yu Tsai --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 32 --- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac

[PATCH net-next 06/12] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

2018-03-17 Thread Chen-Yu Tsai
d_update_bits(), but this is not done here to keep the patch simple. Signed-off-by: Chen-Yu Tsai --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 42 +-- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/

[PATCH net-next 05/12] dt-bindings: net: dwmac-sun8i: Add binding for GMAC on Allwinner R40 SoC

2018-03-17 Thread Chen-Yu Tsai
d RX delay chain, and no TX delay chain. This patch adds the R40 specific bits to the dwmac-sun8i binding. Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dwmac-su

[PATCH net-next 07/12] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from CCU device

2018-03-17 Thread Chen-Yu Tsai
registers. Instead, for these types of setups, we let the CCU register a proper device and a regmap tied to it. We can then get the device from the phandle, and retrieve the regmap with dev_get_regmap(). Signed-off-by: Chen-Yu Tsai --- drivers/net/ethernet/stmicro/stmmac/dwmac-su

[PATCH net-next 11/12] ARM: dts: sun8i: r40: Add device node and RGMII pinmux node for GMAC

2018-03-17 Thread Chen-Yu Tsai
GMAC is labeled "gmac_mdio". Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-r40.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi index 173dcc1652d2..bd97ca3dc2fa 10

[PATCH net-next 12/12] ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller

2018-03-17 Thread Chen-Yu Tsai
The Bananapi M2 Ultra has a Realtek RTL8211E RGMII PHY tied to the GMAC. The PMIC's DC1SW output provides power for the PHY, while the ALDO2 output provides I/O voltages on both sides. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts

[PATCH net-next 00/12] ARM: sun8i: r40: Add Ethernet support

2018-03-17 Thread Chen-Yu Tsai
ode pinmux setting for the R40. Patch 12 enables Ethernet on the Bananapi M2 Ultra. Please have a look. Regards ChenYu Chen-Yu Tsai (10): dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions dt-bindings: net: dwmac-sun8i: Sort syscon compatibles by alphabetical

[PATCH net-next 03/12] dt-bindings: net: dwmac-sun8i: Clean up clock delay chain descriptions

2018-03-17 Thread Chen-Yu Tsai
chain section of the device tree binding to make it clear that the delay chains only apply to RGMII PHYs, and make it easier to add the R40-specific bits later. Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Chen-Yu Tsai
On Wed, Nov 29, 2017 at 11:46 PM, Andrew Lunn wrote: > Hi ChenYu > >> It worked at one point. During some previous iteration, they lit up as >> they were supposed to. > > For a released version of the kernel? Or during development work? If > they did work, but broken, it would be good to know whi

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Chen-Yu Tsai
On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect "allwinner,leds-activ

Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes

2017-09-08 Thread Chen-Yu Tsai
On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe wrote: > On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote: >> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote: >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts >> > b/arch/arm64/boot/dts/allwinner/

Re: [PATCH 0/4] net: stmmac: revert the EMAC bindings

2017-08-27 Thread Chen-Yu Tsai
> arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 8 --- I think this particular change is in -next, not v4.13-rc. Otherwise, whole series is Acked-by: Chen-Yu Tsai > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 7 -- > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-24 Thread Chen-Yu Tsai
On Fri, Aug 25, 2017 at 11:05 AM, Florian Fainelli wrote: > > > On 08/24/2017 07:54 PM, Chen-Yu Tsai wrote: >> On Fri, Aug 25, 2017 at 3:59 AM, Florian Fainelli >> wrote: >>> On 08/24/2017 01:21 AM, Corentin Labbe wrote: >>>> On Wed, Aug 23, 2017 a

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-24 Thread Chen-Yu Tsai
On Fri, Aug 25, 2017 at 3:59 AM, Florian Fainelli wrote: > On 08/24/2017 01:21 AM, Corentin Labbe wrote: >> On Wed, Aug 23, 2017 at 09:31:53AM -0700, Florian Fainelli wrote: >>> On 08/23/2017 12:49 AM, Maxime Ripard wrote: Hi Florian, On Tue, Aug 22, 2017 at 11:35:01AM -0700, Floria

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-22 Thread Chen-Yu Tsai
On Mon, Aug 21, 2017 at 10:23 PM, Andrew Lunn wrote: >> All muxes are mostly always represented the same way afaik, or do you >> want to simply introduce a new compatible / property? > > + mdio-mux { > + compatible = "allwinner,sun8i-h3-mdio-switch"; > + mdio-pa

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-21 Thread Chen-Yu Tsai
On Sun, Aug 20, 2017 at 10:25 PM, Andrew Lunn wrote: >> I think we cannot use mdio-mux-mmioreg since the register for doing >> the switch is in middle of the "System Control" and shared with >> other functions. This is why we use a sycon/regmap for selecting >> the MDIO. > > You could add a mdio-

Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac

2017-08-18 Thread Chen-Yu Tsai
On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe wrote: > In case of a MDIO switch, the registered MDIO node should be > the parent of the PHY. Otherwise of_phy_connect will fail. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 12 ++-- >

Re: [PATCH v3 2/4] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-08-18 Thread Chen-Yu Tsai
Y, so it is modified to a boolean soc_has_internal_phy. > > Signed-off-by: Corentin Labbe Acked-by: Chen-Yu Tsai

Re: [PATCH v3 4/4] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-08-18 Thread Chen-Yu Tsai
On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe wrote: > This patch add documentation about the MDIO switch used on sun8i-h3-emac > for integrated PHY. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt| 112 > +++-- > 1 file changed, 1

Re: [PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY

2017-08-11 Thread Chen-Yu Tsai
On Fri, Aug 11, 2017 at 4:19 PM, Corentin Labbe wrote: > On Fri, Aug 11, 2017 at 04:11:13PM +0800, Chen-Yu Tsai wrote: >> On Fri, Aug 11, 2017 at 4:05 PM, Corentin Labbe >> wrote: >> > On Fri, Aug 11, 2017 at 10:42:51AM +0800, Chen-Yu Tsai wrote: >> >> Hi, &

Re: [PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY

2017-08-11 Thread Chen-Yu Tsai
On Fri, Aug 11, 2017 at 4:05 PM, Corentin Labbe wrote: > On Fri, Aug 11, 2017 at 10:42:51AM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Thu, Aug 10, 2017 at 4:51 PM, Corentin Labbe >> wrote: >> > This patch add the new phy-is-integrated property to the internal

Re: [PATCH 2/3] ARM: sun8i: sunxi-h3-h5: add phy-is-integrated property to internal PHY

2017-08-10 Thread Chen-Yu Tsai
Hi, On Thu, Aug 10, 2017 at 4:51 PM, Corentin Labbe wrote: > This patch add the new phy-is-integrated property to the internal PHY > node. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/sunx

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Chen-Yu Tsai
On Thu, Aug 10, 2017 at 8:20 AM, Andrew Lunn wrote: > On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: >> On August 9, 2017 5:10:30 AM PDT, David Wu wrote: >> >Add the documentation for internal phy. A boolean property >> >indicates that a internal phy will be used. >> > >> >Sign

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Chen-Yu Tsai
Hi David, On Wed, Aug 9, 2017 at 5:38 PM, David.Wu wrote: > Hello Corentin, Chen-Yu > > > 在 2017/8/9 16:45, Corentin Labbe 写道: >> >> On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: >>> >>> On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli &

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-03 Thread Chen-Yu Tsai
On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli wrote: > On 08/01/2017 11:21 PM, David Wu wrote: >> To make internal phy work, need to configure the phy_clock, >> phy cru_reset and related registers. >> >> Signed-off-by: David Wu >> --- >> .../devicetree/bindings/net/rockchip-dwmac.txt | 6

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-01 Thread Chen-Yu Tsai
Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > 在 2017/7/28 0:54, Florian Fainelli 写道: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver (that is, before of_phy_conn

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-31 Thread Chen-Yu Tsai
On Sat, Jul 29, 2017 at 2:48 PM, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: >> On 07/28/2017 07:44 AM, Corentin Labbe wrote: >> > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: >> I've probably asked this before: Does the internal P

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Chen-Yu Tsai
On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe wrote: > Hello > > The current way to find if the phy is internal is to compare DT phy-mode > and emac_variant/internal_phy. > But it will negate a possible future SoC where an external PHY use the > same phy mode than the internal one. > > This patc

Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible

2017-07-28 Thread Chen-Yu Tsai
On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe wrote: > The current way to find if the phy is internal is to compare DT phy-mode > and emac_variant/internal_phy. > But it will negate a possible future SoC where an external PHY use the > same phy mode than the internal one. > > This patch adds a n

Re: [PATCH 2/3] ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible

2017-07-28 Thread Chen-Yu Tsai
On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe wrote: > This patch adds the sun8i-h3-ephy compatible to the internal PHY. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 3 ++- To avoid repeating the past, this patch, if approved, will be merged through the sunxi

Re: [linux-sunxi] Re: [PATCH 6/6] net: stmmac: revert "support future possible different internal phy mode"

2017-07-06 Thread Chen-Yu Tsai
Hi Corentin, On Thu, Jul 6, 2017 at 5:45 PM, David Miller wrote: > From: Corentin Labbe > Date: Thu, 6 Jul 2017 10:51:47 +0200 > >> On Sun, Jul 02, 2017 at 02:31:59PM +0200, Corentin Labbe wrote: >>> Since internal phy-mode is reserved for non-xMII protocol we cannot use >>> it with dwmac-sun8i

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
gt;>> On 27/06/17 09:21, Corentin Labbe wrote: >>>> On Tue, Jun 27, 2017 at 04:11:21PM +0800, Chen-Yu Tsai wrote: >>>>> On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe >>>>> wrote: >>>>>> On Mon, Jun 26, 2017 at 01:18:23AM +0100, A

Re: [linux-sunxi] Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 6:17 PM, Icenowy Zheng wrote: > > > 于 2017年6月27日 GMT+08:00 下午6:11:47, Chen-Yu Tsai 写到: >>On Tue, Jun 27, 2017 at 5:41 PM, Maxime Ripard >> wrote: >>> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >>>> Hi, >&g

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 5:41 PM, Maxime Ripard wrote: > On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andre Przywara wrote: >> Hi, >> >> (CC:ing some people from that Rockchip dmwac series) >> >> On 27/06/17 09:21, Corentin Labbe wrote: >> > On Tue, Jun

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Chen-Yu Tsai
On Tue, Jun 27, 2017 at 4:05 PM, Corentin Labbe wrote: > On Mon, Jun 26, 2017 at 01:18:23AM +0100, André Przywara wrote: >> On 31/05/17 08:18, Corentin Labbe wrote: >> > The dwmac-sun8i is a heavy hacked version of stmmac hardware by >> > allwinner. >> > In fact the only common part is the descrip

Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-05-01 Thread Chen-Yu Tsai
On Mon, May 1, 2017 at 10:01 PM, Andrew Lunn wrote: > On Mon, May 01, 2017 at 02:45:00PM +0200, Corentin Labbe wrote: >> Hello >> >> This patch series add the driver for dwmac-sun8i which handle the Ethernet >> MAC >> present on Allwinner H3/H5/A83T/A64 SoCs. >> >> This driver is the continuation

Re: [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-04-24 Thread Chen-Yu Tsai
On Mon, Apr 24, 2017 at 8:24 PM, Corentin Labbe wrote: > On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote: >> On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: >> > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit >> > connections. It is very similar to

Re: Linux kernel commit breaks IPMI on iface downing

2016-08-02 Thread Chen-Yu Tsai
Hi, On Wed, Sep 9, 2015 at 9:33 AM, Harish Patil wrote: > >>On Fri, 2015-09-04 at 09:55 +0200, Sébastien Bocahu wrote: >>> Hi, >>> >>> Any chance this behaviour gets fixed, with either a new firmware or a >>> workaround in the kernel ? >>> >> >>As I said earlier, when we call bnx2_shutdown_chip()

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-07-29 Thread Chen-Yu Tsai
On Sat, Jul 30, 2016 at 1:25 AM, Maxime Ripard wrote: > On Thu, Jul 28, 2016 at 04:57:34PM +0200, LABBE Corentin wrote: >> > > +static int sun8i_mdio_write(struct mii_bus *bus, int phy_addr, int >> > > phy_reg, >> > > + u16 data) >> > > +{ >> > > + struct net_device *ndev = bu

Re: [PATCH 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-06-13 Thread Chen-Yu Tsai
Hi Rob, On Thu, Jun 9, 2016 at 3:11 AM, Rob Herring wrote: > On Mon, Jun 06, 2016 at 08:10:54PM +0200, Corentin LABBE wrote: >> Le 06/06/2016 16:14, Rob Herring a écrit : >> > On Fri, Jun 03, 2016 at 11:56:28AM +0200, LABBE Corentin wrote: >> >> This patch adds documentation for Device-Tree bindi

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-05 Thread Chen-Yu Tsai
On Mon, Jun 6, 2016 at 6:32 AM, André Przywara wrote: > On 03/06/16 10:56, LABBE Corentin wrote: > > Hi, > > first: thanks for posting this and the time and work that you spent on > it. With the respective DT nodes this works for me on the Pine64 and > turns this board eventually into something us

  1   2   >