(u64_stats_fetch_retry(&priv->rx[ring].statss,
> + } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
> start));
> }
> }
> --
> 2.20.1
Thanks!
Reviewed-by: Catherine Sullivan
desc_cnt and data_cnt should always be equal. In the case of a dropped
packet desc_cnt was still getting updated (correctly), data_cnt
was not. To eliminate this bug and prevent it from recurring this
patch combines them into one ring level cnt.
Signed-off-by: Catherine Sullivan
Reviewed-by
u64_stats_fetch_begin needs to initialize start.
Signed-off-by: Catherine Sullivan
Reported-by: kbuild test robot
---
drivers/net/ethernet/google/gve/gve_ethtool.c | 6 --
drivers/net/ethernet/google/gve/gve_main.c| 6 --
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git
Done in v4, thanks!
On Sat, Jun 29, 2019 at 11:28 AM Jakub Kicinski
wrote:
>
> On Fri, 28 Jun 2019 16:07:29 -0700, Catherine Sullivan wrote:
> > This patch series adds the gve driver which will support the
> > Compute Engine Virtual NIC that will be available in the futu
On Fri, Jun 28, 2019 at 7:44 PM Florian Fainelli wrote:
>
>
>
> On 6/26/2019 11:52 AM, Catherine Sullivan wrote:
>
> [snip]
>
> > +static void
> > +gve_get_ethtool_stats(struct net_device *netdev,
> > + struct ethtool_stats *stats, u64
ed-by: kbuild test robot
Reported-by: Julia Lawall
Catherine Sullivan (4):
gve: Add basic driver framework for Compute Engine Virtual NIC
gve: Add transmit and receive support
gve: Add workqueue and reset support
gve: Add ethtool support
.../networking/device_drivers/google/gve.rst |
Add support for the workqueue to handle management interrupts and
support for resets.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 11 +
drivers
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
drivers/net/ethernet/google/gve/Makefile | 2 +-
drivers/net/ethernet/google/gve/gve.h | 4 +
drivers/net/ethernet/google/gve
Add support for passing traffic.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 30 +
drivers/net/ethernet/google/gve/Makefile | 2
Add a driver framework for the Compute Engine Virtual NIC that will be
available in the future.
At this point the only functionality is loading the driver.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi
tch 4:
- Remove unneeded memsets in ethtool stats
Catherine Sullivan (4):
gve: Add basic driver framework for Compute Engine Virtual NIC
gve: Add transmit and receive support
gve: Add workqueue and reset support
gve: Add ethtool support
.../networking/device_drivers/google/gve.rst |
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
drivers/net/ethernet/google/gve/Makefile | 2 +-
drivers/net/ethernet/google/gve/gve.h | 4 +
drivers/net/ethernet/google/gve
Add a driver framework for the Compute Engine Virtual NIC that will be
available in the future.
At this point the only functionality is loading the driver.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi
Add support for passing traffic.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 30 +
drivers/net/ethernet/google/gve/Makefile | 2
Add support for the workqueue to handle management interrupts and
support for resets.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 11 +
drivers
On Fri, Jun 28, 2019 at 1:06 PM Andrew Lunn wrote:
>
> On Fri, Jun 28, 2019 at 11:46:15AM -0700, Jakub Kicinski wrote:
> > On Fri, 28 Jun 2019 10:52:27 -0700, Catherine Sullivan wrote:
> > > > > +if NET_VENDOR_GOOGLE
> > > > > +
> > > > >
On Fri, Jun 28, 2019 at 11:11 AM Stephen Hemminger
wrote:
>
> On Fri, 28 Jun 2019 10:56:33 -0700
> Catherine Sullivan wrote:
>
> > +static void
> > +gve_get_ethtool_stats(struct net_device *netdev,
> > + struct ethtool_stats *stats, u64 *data)
&g
Add a driver framework for the Compute Engine Virtual NIC that will be
available in the future.
At this point the only functionality is loading the driver.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi
Add support for passing traffic.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 30 +
drivers/net/ethernet/google/gve/Makefile | 2
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
drivers/net/ethernet/google/gve/Makefile | 2 +-
drivers/net/ethernet/google/gve/gve.h | 4 +
drivers/net/ethernet/google/gve
Add support for the workqueue to handle management interrupts and
support for resets.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 11 +
drivers
Patch 2:
- Use be16_to_cpu in the RX Seq No define
- Remove unneeded ndo_change_mtu
- Patch 3:
- No Changes
- Patch 4:
- Instead of checking netif_carrier_ok in ethtool stats, just make sure
the rings have valid pointers.
Catherine Sullivan (4):
gve: Add basic driver framework for Co
On Wed, Jun 26, 2019 at 12:35 PM Andrew Lunn wrote:
>
> On Wed, Jun 26, 2019 at 11:52:48AM -0700, Catherine Sullivan wrote:
> > Add a driver framework for the Compute Engine Virtual NIC that will be
> > available in the future.
> >
> > +static int
On Wed, Jun 26, 2019 at 4:08 PM Jakub Kicinski
wrote:
>
> On Wed, 26 Jun 2019 11:52:48 -0700, Catherine Sullivan wrote:
> > Add a driver framework for the Compute Engine Virtual NIC that will be
> > available in the future.
> >
> > At this point the only funct
On Wed, Jun 26, 2019 at 12:42 PM Andrew Lunn wrote:
>
> > +static int gve_change_mtu(struct net_device *dev, int new_mtu)
> > +{
> > + dev->mtu = new_mtu;
> > + return 0;
> > +}
>
> The default implementation does this.
>
> Also, i think your mtu has a limit of PAGE size. So you should se
On Wed, Jun 26, 2019 at 12:49 PM David Miller wrote:
>
> From: Catherine Sullivan
> Date: Wed, 26 Jun 2019 11:52:49 -0700
>
> > +#ifdef __LITTLE_ENDIAN
> > +#define GVE_SEQNO(x) __force u16)x) >> 8) & 0x7)
> > +#else
> > +#define GVE
On Wed, Jun 26, 2019 at 12:48 PM Andrew Lunn wrote:
>
> > +static int gve_get_sset_count(struct net_device *netdev, int sset)
> > +{
> > + struct gve_priv *priv = netdev_priv(netdev);
> > +
> > + if (!netif_carrier_ok(netdev))
> > + return 0;
>
> That is pretty unusual. What go
Add support for passing traffic.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 30 +
drivers/net/ethernet/google/gve/Makefile | 2
Add a driver framework for the Compute Engine Virtual NIC that will be
available in the future.
At this point the only functionality is loading the driver.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi
This patch series adds the gve driver which will support the
Compute Engine Virtual NIC that will be available in the future.
Catherine Sullivan (4):
gve: Add basic driver framework for Compute Engine Virtual NIC
gve: Add transmit and receive support
gve: Add workqueue and reset support
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
drivers/net/ethernet/google/gve/Makefile | 2 +-
drivers/net/ethernet/google/gve/gve.h | 4 +
drivers/net/ethernet/google/gve
Add support for the workqueue to handle management interrupts and
support for resets.
Signed-off-by: Catherine Sullivan
Signed-off-by: Sagi Shahar
Signed-off-by: Jon Olson
Acked-by: Willem de Bruijn
Reviewed-by: Luigi Rizzo
---
.../networking/device_drivers/google/gve.rst | 11 +
drivers
32 matches
Mail list logo
