Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-29 Thread Captain Wiggum
return -EINVAL; - skb_orphan(skb); fq = fq_find(net, fhdr->identification, user, hdr, skb->dev ? skb->dev->ifindex : 0); On Mon, Apr 29, 2019 at 10:57 AM Captain Wiggum wrote: > > I have run the 4.9 patch set on the full TAHI te

Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-29 Thread Captain Wiggum
I have run the 4.9 patch set on the full TAHI test sweet. Similar to 4.14, it does fix all the IPv6 frag header issues. But the "change MTU" mesg routing is still broken. Overall, it fixes what it was intended to fix, so I suggest it move toward release. Thanks Peter! --John Masinter On Fri, Apr

Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-29 Thread Captain Wiggum
My $.02 I do not see 4.4 used much in my circles. We do not use it anywhere at McAfee. On Fri, Apr 26, 2019 at 3:27 PM Peter Oskolkov wrote: > > On Fri, Apr 26, 2019 at 8:41 AM Peter Oskolkov wrote: > > > > This is a backport of a 5.1rc patchset: > > https://patchwork.ozlabs.org/cover/1029418/

Re: [PATCH 4.14 stable 0/5] net: ip6 defrag: backport fixes

2019-04-27 Thread Captain Wiggum
Hi Peter, The TAHI test has completed its run on this patch for the 4.14 kernel. The results are mixed. First let me review your 4.19 patch for clarification. The patch you did for 4.19 fixed two issues intentionally, and fixed one more unintentionally. The rbtrees and the IP6 header fragments sm

Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-26 Thread Captain Wiggum
Thanks Peter! I have your patch for 4.14 running now. Then I'll run this patch for 4.9. I'll report the results by Monday. --John Masinter On Fri, Apr 26, 2019 at 9:41 AM Peter Oskolkov wrote: > > This is a backport of a 5.1rc patchset: > https://patchwork.ozlabs.org/cover/1029418/ > > Which wa

Re: [PATCH 4.14 stable v2 1/5] ipv6: frags: fix a lockdep false positive

2019-04-26 Thread Captain Wiggum
Sorry for the late reply. I am starting the TAHI test on the 4.14 v2 patch today and reply with results before Mon morning. The test is long running so we let it run overnight. On Tue, Apr 23, 2019 at 11:48 AM Peter Oskolkov wrote: > > From: Eric Dumazet > > [ Upstream commit 415787d7799f4fccbe8

Re: [PATCH 4.19 stable 0/3] net: ip6 defrag: backport fixes

2019-04-17 Thread Captain Wiggum
o the fix for 4.14, and then 4.9. --John Masinter On Sun, Apr 14, 2019 at 12:28 PM Captain Wiggum wrote: > > Hi All, > > I apologize for the delay, my lab was reserved for some other uses. > But we am going to run the full TAHI IPv6 test suite against this patch > on Tue, an

Re: [PATCH 4.19 stable 0/3] net: ip6 defrag: backport fixes

2019-04-14 Thread Captain Wiggum
Hi All, I apologize for the delay, my lab was reserved for some other uses. But we am going to run the full TAHI IPv6 test suite against this patch on Tue, and I will reply with the results. Thanks Peter and Google team for the patch! --John Masinter On Mon, Apr 8, 2019 at 6:10 PM Peter Oskolko

Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

2019-04-08 Thread Captain Wiggum
t; > On Mon, Apr 08, 2019 at 08:49:52AM -0600, Captain Wiggum wrote: > > >Hi Sasha, > > > > > >This patch cannot be applied to upstream, the code is significantly > > >different. > > >Therefore, this un-do patch would not be seen in the upstrea

Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

2019-04-08 Thread Captain Wiggum
On Mon, Apr 8, 2019 at 7:50 AM Captain Wiggum wrote: > > > > Hi Sasha, > > > > This patch cannot be applied to upstream, the code is significantly > > different. > > Therefore, this un-do patch would not be seen in the upstream git log. > > It was solved

Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

2019-04-08 Thread Captain Wiggum
is not fit for IPv6 deployments. --John Masinter On Sat, Apr 6, 2019 at 8:15 AM Sasha Levin wrote: > > On Fri, Apr 05, 2019 at 10:22:51AM -0600, Captain Wiggum wrote: > >I know it affects 4.9, 4.14, 4.19. > >I have not tested the older LTS kernels. > >But any LTS kernel that

Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

2019-04-05 Thread Captain Wiggum
Kroah-Hartman wrote: > > On Thu, Apr 04, 2019 at 06:18:30PM -0600, Captain Wiggum wrote: > > Hi Greg, > > > > A previous bad patch breaks 18 test cases for IPv6 fragment headers. > > This has already been un-done in upstream, but not in any of the LTS. > > Ho

[PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu

2019-04-04 Thread Captain Wiggum
Hi Greg, A previous bad patch breaks 18 test cases for IPv6 fragment headers. This has already been un-done in upstream, but not in any of the LTS. However two upstream patches are first needed to cover a DoS vulnerability. For background, there are two mail threads in [netdev] on this subject: 1

Re: Please merge IPv6 fix for drop fragment smaller than MTU

2019-04-01 Thread Captain Wiggum
Thank you for the feedback and the specific commits needed! On Mon, Apr 1, 2019 at 3:48 PM Florian Westphal wrote: > > Captain Wiggum wrote: > > An error was introduced in 4.9.134 (and the other LTS branches also). > > This causes 18 test cases from the TAHI IPv6 test suite to

IPv6 unexpectedly changes MTU on wrong interface

2019-04-01 Thread Captain Wiggum
This bug exists in the LTS kernels, but has been fixed in mainline. My problem is I have no idea what to search for in git find the commit(s). Hopefully someone recognizes this issue and can give some tips to find it. Summary: Three TAHI IPv6 test cases fail on this: Two interface test: first inte

Please merge IPv6 fix for drop fragment smaller than MTU

2019-04-01 Thread Captain Wiggum
Hi Greg, An error was introduced in 4.9.134 (and the other LTS branches also). This causes 18 test cases from the TAHI IPv6 test suite to fail. I added you to the mail thread about this subject a month back. It has been fixed in upstream for some time now, but not in the LTS branches. Please merge

Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

2019-03-11 Thread Captain Wiggum
gt; On 03/11/2019 09:12 PM, Captain Wiggum wrote: > > Hi All, > > > > To summarize this thread, we test for IPv6 Ready Logo using Self-test > > Tools (TAHI Project) here: > > https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols > > > > 4.9.1

Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

2019-03-11 Thread Captain Wiggum
[a8444b1ccb20339774af58e40ad42296074fb484] ipv6: defrag: drop non-last frags smaller than min mtu $ git bisect bad 74fb484 is the first bad commit On Mon, Mar 11, 2019 at 10:12 PM Captain Wiggum wrote: > > Hi All, > > To summarize this thread, we test for IPv6 Ready Logo usi

Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

2019-03-11 Thread Captain Wiggum
Hi All, To summarize this thread, we test for IPv6 Ready Logo using Self-test Tools (TAHI Project) here: https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols 4.9.133 and previous passed 100%. Beginning with 4.9.134 it fails 18 tests related to IPv6 fragment headers. I have done a git

Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9

2019-03-06 Thread Captain Wiggum
gt; On 03/06/2019 02:28 PM, David Miller wrote: > > From: Captain Wiggum > > Date: Wed, 6 Mar 2019 15:26:43 -0700 > > > >> We are using the TAHI Self-test tools from IPv6 Ready Logo Program: > >> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols

TAHI testing fails for IPv6 Fragments in Kernel 4.9

2019-03-06 Thread Captain Wiggum
We are using the TAHI Self-test tools from IPv6 Ready Logo Program: https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols The test passed up to 4.9.133, then fails ever since. The are about 20 failing test cases regarding IPv6 fragments, where the kernel is issuing an ICMPv6 parameter